Fix: leak of event attributes on copy failure

Reported-by: Coverity Scan (1243042 Resource leak)
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
index 947c35db7cda8c92bd44bbe55fcc40513ed26698..d8ea2c1a5b2640af24864c6d12d6c91c8dd78001 100644 (file)
--- a/src/bin/lttng-sessiond/main.c
+++ b/src/bin/lttng-sessiond/main.c
@@ -3683,6 +3683,9 @@ error_add_context:
                if (!ev) {
                        DBG("Failed to copy event: %s",
                                        cmd_ctx->lsm->u.enable.event.name);
                if (!ev) {
                        DBG("Failed to copy event: %s",
                                        cmd_ctx->lsm->u.enable.event.name);

+                       free(filter_expression);
+                       free(bytecode);
+                       free(exclusion);

                        ret = LTTNG_ERR_NOMEM;
                        goto error;
                }
                        ret = LTTNG_ERR_NOMEM;
                        goto error;
                }


@@ -3692,6 +3695,9 @@ error_add_context:
                        /* Expect a userspace probe description. */
                        ret = receive_userspace_probe(cmd_ctx, sock, sock_error, ev);
                        if (ret) {
                        /* Expect a userspace probe description. */
                        ret = receive_userspace_probe(cmd_ctx, sock, sock_error, ev);
                        if (ret) {

+                               free(filter_expression);
+                               free(bytecode);
+                               free(exclusion);

                                lttng_event_destroy(ev);
                                goto error;
                        }
                                lttng_event_destroy(ev);
                                goto error;
                        }