actions: improve logging in lttng_action_create_from_buffer
authorSimon Marchi <simon.marchi@efficios.com>
Fri, 29 Nov 2019 21:48:16 +0000 (16:48 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Fri, 17 Apr 2020 20:37:06 +0000 (16:37 -0400)
Small improvements in the logging messages.  Use "Create from buffer"
instead of "Deserializing", since that's the term used in the function
names.

Change-Id: I7e688df766602cfb73bc40d87d224591c0f29534
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/common/actions/action.c

index 6894036cb779d09ced9c5acee4dacf9a2e99d876..4cad01b743189ff5318fa9e388ed2bd1d82f933a 100644 (file)
 #include <common/error.h>
 #include <assert.h>
 
+static const char *lttng_action_type_string(enum lttng_action_type action_type)
+{
+       switch (action_type) {
+       case LTTNG_ACTION_TYPE_UNKNOWN:
+               return "UNKNOWN";
+       case LTTNG_ACTION_TYPE_NOTIFY:
+               return "NOTIFY";
+       default:
+               return "???";
+       }
+}
+
 enum lttng_action_type lttng_action_get_type(struct lttng_action *action)
 {
        return action ? action->type : LTTNG_ACTION_TYPE_UNKNOWN;
@@ -106,12 +118,18 @@ ssize_t lttng_action_create_from_buffer(const struct lttng_buffer_view *view,
 
        action_comm = (const struct lttng_action_comm *) view->data;
 
-       DBG("Deserializing action from buffer");
+       DBG("Create action from buffer: action-type=%s",
+                       lttng_action_type_string(action_comm->action_type));
+
        switch (action_comm->action_type) {
        case LTTNG_ACTION_TYPE_NOTIFY:
                create_from_buffer_cb = lttng_action_notify_create_from_buffer;
                break;
        default:
+               ERR("Failed to create action from buffer, unhandled action type: action-type=%u (%s)",
+                               action_comm->action_type,
+                               lttng_action_type_string(
+                                               action_comm->action_type));
                consumed_len = -1;
                goto end;
        }
This page took 0.037545 seconds and 4 git commands to generate.