Fix: sessiond: fix possible buffer overflow warning
authorSimon Marchi <simon.marchi@efficios.com>
Wed, 10 Nov 2021 13:39:22 +0000 (08:39 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 17 Nov 2021 18:48:47 +0000 (13:48 -0500)
commit9c7134c044b76258a69abd8e6541d8c95f5acb99
tree0dd33b621cc60c9bb9d8ae0f289a04aafdcab5ff
parente59345cc9499a4ca7e5bb66579e50af7dc841425
Fix: sessiond: fix possible buffer overflow warning

When compiling with clang-14 on Ubuntu 20.04, I get:

      CC       lttng-syscall.lo
    /home/smarchi/src/lttng-tools/src/bin/lttng-sessiond/lttng-syscall.c:70:13: error: 'fscanf' may overflow; destination buffer in argument 4 has size 255, but the corresponding specifier may require size 256 [-Werror,-Wfortify-source]
                                    &index, name, &bitness) == 3) {
                                            ^

I think the compiler is right, we read a string when length up to 255 in
a buffer of size 255.  We need one more byte for the NULL terminator,
fix that.

Change-Id: I6b2eec401af3ef6230dd4b6c8559032de9b54584
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/bin/lttng-sessiond/lttng-syscall.c
This page took 0.025545 seconds and 4 git commands to generate.