consumerd: clean-up: stream attribute accessed without locking stream
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 28 Oct 2019 18:52:44 +0000 (14:52 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 28 Oct 2019 21:03:19 +0000 (17:03 -0400)
commit8e1ef46e89a86865736a62d2def88f70acb0be55
tree6eb096acb386496ddc4c0717b1c5a54c54b97bb2
parent93d0d1f7ded46987ea752b6fcfe81e3281fc533c
consumerd: clean-up: stream attribute accessed without locking stream

consumer_metadata_cache_flushed makes use of the metadata stream's
ust_metadata_pushed attribute without locking while it is updated by
commit_one_metadata_packet() which holds the metadata stream lock.

This is marked as a clean-up since the attribute appears to always be
accessed while the metadata cache lock is held. However this is a
_channel_ attribute and the stream and channel lifetimes do not match,
making the locking assumptions conceptually dubious.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/common/consumer/consumer-metadata-cache.c
This page took 0.032541 seconds and 4 git commands to generate.