userspace-probe: Print error for unsupported instrumentation mode
authorFrancis Deslauriers <francis.deslauriers@efficios.com>
Sat, 24 Nov 2018 00:03:21 +0000 (19:03 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 10 Dec 2018 19:59:50 +0000 (14:59 -0500)
commit36aa2f64f75a08a3f933197d5d464e6a31e865f7
tree5d7f5d7c3b71f73bf202860abbc242214a6b3138
parent89293443580129dbe50f3a65f92f9bfc5ea7a12f
userspace-probe: Print error for unsupported instrumentation mode

This patch adds an error message printed when the user tries to place an
userspace-probe using unsupported probe location descriptions.
Hopefully, this will help users understand why their command failed.

Here are examples of unsupported uses of an address location:
* "elf:/path/to/binary:0x400430"
* "elf:/path/to/binary:4194364"

Here are examples of unsupported uses of offset from symbol location:
* "elf:/path/to/binary:my_symbol+0x323"
* "elf:/path/to/binary:my_symbol+43"

I expect users to try using the address locations and offset from symbol
locations for ELF instrumentation location because those methods are
available with the --probe option used to instrument the kernel.

Supporting those location descriptions in the future would require
the validation that the address or the offset from a symbol is indeed at
the boundary of an instruction.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/bin/lttng/commands/enable_events.c
This page took 0.045488 seconds and 4 git commands to generate.