Fix: consumers don't honor protocol on rotate pending relay command
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 20 Aug 2018 21:32:46 +0000 (17:32 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 20 Aug 2018 21:34:45 +0000 (17:34 -0400)
commit19990ed538f86bf0f32193a378c3faf36ce4f467
tree9bd58b748a3ed235cf0c7aa807c7d13a7c5f84b5
parent4bd5b4af0f6c1f1ebc3a85696d0a09a7d24ad59c
Fix: consumers don't honor protocol on rotate pending relay command

The payload of a command should not be sent to the sessiond if
its execution failed. The sessiond reports an error as soon as
the return code of the command is returned and will never consume
the payload, resulting in a protocol error down the line.

Moreover, the ust-consumer's implementation doesn't check for
errors as it stores the return value of
lttng_consumer_rotate_pending_relay() to an unsigned variable and
checks for negative values.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/common/kernel-consumer/kernel-consumer.c
src/common/ust-consumer/ust-consumer.c
This page took 0.024926 seconds and 4 git commands to generate.