X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=tests%2Futils%2Futils.sh;h=e463e4fe34476eb347a370a19c827dce7b68eb98;hp=2752b0f7a76c84eec8ad2f70db5c9340c7162022;hb=HEAD;hpb=bade86436a3004fc696c5dc4d17607f63653b933

diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh
index 2752b0f7a..0e8ec54dd 100644
--- a/tests/utils/utils.sh
+++ b/tests/utils/utils.sh
@@ -148,7 +148,7 @@ function lttng_pgrep ()
 
 	while IFS= read -r pid ; do
 		# /proc/pid/cmdline is null separated.
-		if full_command_no_argument=$(cut -d '' -f 1 2>/dev/null < /proc/"$pid"/cmdline); then
+		if full_command_no_argument=$( (tr '\0' '\n' < /proc/"$pid"/cmdline) 2>/dev/null | head -n1); then
 			command_basename=$(basename "$full_command_no_argument")
 			if grep -q "$pattern" <<< "$command_basename"; then
 				echo "$pid"
@@ -204,11 +204,115 @@ function validate_kernel_version ()
 #  $2 = include special characters; 1 = yes, 0 = no; defaults to yes
 function randstring()
 {
+	local len="${1:-16}"
+
 	[ "$2" == "0" ] && CHAR="[:alnum:]" || CHAR="[:graph:]"
-	cat /dev/urandom 2>/dev/null | tr -cd "$CHAR" 2>/dev/null | head -c ${1:-16} 2>/dev/null
+	# /dev/urandom isn't guaranteed to generate valid multi-byte characters.
+	# Specifying the C locale eliminates the "Illegal byte sequence" error
+	# that 'tr' outputs in such cases.
+	LC_CTYPE=C tr -cd "$CHAR" < /dev/urandom 2>/dev/null | head -c "$len" 2>/dev/null
 	echo
 }
 
+# Return a space-separated string of online CPU IDs, based on
+# /sys/devices/system/cpu/online, or from 0 to nproc - 1 otherwise.
+function get_online_cpus()
+{
+	local cpus=()
+	local range_re
+	if [ -f /sys/devices/system/cpu/online ]; then
+		range_re='([0-9]+)-([0-9]+)'
+		while read -r range ; do
+			if [[ "${range}" =~ ${range_re} ]] ; then
+				mapfile -t -O "${#cpus[*]}" cpus <<< $(seq "${BASH_REMATCH[1]}" "${BASH_REMATCH[2]}")
+			else
+				cpus+=("${range}")
+			fi
+		done < <(tr ',' $'\n' < /sys/devices/system/cpu/online)
+	else
+		read -r -a cpus <<< $(seq 0 $(( $(conf_proc_count) - 1 )) )
+	fi
+	echo "${cpus[*]}"
+}
+
+# Helpers for get_possible_cpus.
+function get_possible_cpus_count_from_sysfs_possible_mask()
+{
+	local max_possible_cpu_id
+
+	# The Awk script extracts the highest CPU id from the possible CPU
+	# mask. Assuming a numerical order, a field separator '-' and a record
+	# separator ','. The last value parsed is the highest id.
+	if [ -f /sys/devices/system/cpu/possible ]; then
+		max_possible_cpu_id=$(awk -F '-' 'BEGIN { RS = ","} { last = $NF } END { printf("%d\n", last) }' \
+				      /sys/devices/system/cpu/possible)
+		echo "$((max_possible_cpu_id+1))"
+	else
+		echo "0"
+	fi
+}
+
+# This is a fallback if the possible CPU mask is not available. This will not
+# take into account unplugged CPUs.
+function get_max_cpus_count_from_sysfs_cpu_directories()
+{
+	local max_possible_cpu_id=0
+	local current_cpu_id
+
+	for i in /sys/devices/system/cpu/cpu[0-9]*; do
+		current_cpu_id="${i#/sys/devices/system/cpu/cpu}"
+		if [ "$current_cpu_id" -gt "$max_possible_cpu_id" ]; then
+			max_possible_cpu_id="$current_cpu_id"
+		fi
+	done
+
+	echo "$((max_possible_cpu_id+1))"
+}
+
+# Return the number of possible CPUs.
+function get_possible_cpus_count()
+{
+	local possible_cpus_count
+	possible_cpus_count=$(get_possible_cpus_count_from_sysfs_possible_mask)
+
+	if [ "$possible_cpus_count" -eq "0" ]; then
+		local configured_cpus_count
+		configured_cpus_count=$(getconf _NPROCESSORS_CONF)
+		possible_cpus_count=$(get_max_cpus_count_from_sysfs_cpu_directories)
+		possible_cpus_count=$((configured_cpus_count > possible_cpus_count \
+							     ? configured_cpus_count \
+							     : possible_cpus_count))
+	fi
+
+	echo "$possible_cpus_count"
+}
+
+# Return the list of exposed CPU.
+#
+# NOTE! Use it like so:
+#
+# IFS=" " read -r -a VARIABLE <<< "$(get_exposed_cpus_list)"
+function get_exposed_cpus_list()
+{
+	local list=()
+
+	for i in /sys/devices/system/cpu/cpu[0-9]*; do
+		list+=("${i#/sys/devices/system/cpu/cpu}")
+	done
+
+	echo "${list[@]}"
+}
+
+# Return any available CPU found. Do not make assumption about the returned
+# value, e.g. that it could be 0.
+function get_any_available_cpu()
+{
+	for cpu in $(get_online_cpus); do
+		echo "${cpu}"
+		break;
+	done
+}
+
 # Return the number of _configured_ CPUs.
 function conf_proc_count()
 {
@@ -219,6 +323,41 @@ function conf_proc_count()
 	echo
 }
 
+# Usage:
+# check_skip_kernel_test [NB_TESTS] [SKIP_MESSAGE]
+# Return 0 if LTTNG_TOOLS_DISABLE_KERNEL_TESTS was set or the current user is not a root user
+# If NB_TESTS is set, call skip() to skip number of tests.
+# If NB_TESTS is empty, just output a reason with diag.
+# An optional message can be added.
+
+function check_skip_kernel_test ()
+{
+	local num_tests="$1"
+	local skip_message="$2"
+
+	# Check for skip test kernel flag
+	if [ "$LTTNG_TOOLS_DISABLE_KERNEL_TESTS" == "1" ]; then
+		if ! test -z "$num_tests"; then
+			skip 0 "LTTNG_TOOLS_DISABLE_KERNEL_TESTS was set.${skip_message+ }${skip_message}" "$num_tests"
+		else
+			diag "LTTNG_TOOLS_DISABLE_KERNEL_TESTS was set.${skip_message+ }${skip_message}"
+		fi
+		return 0
+	fi
+
+	# Check if we are running as root
+	if [ "$(id -u)" != "0" ]; then
+		if ! test -z "$num_tests"; then
+			skip 0 "Root access is needed for kernel testing.${skip_message+ }${skip_message}" "$num_tests"
+		else
+			diag "Root access is needed for kernel testing.${skip_message+ }${skip_message}"
+		fi
+		return 0
+	fi
+
+	return 1
+}
+
 # Check if base lttng-modules are present.
 # Bail out on failure
 function validate_lttng_modules_present ()
@@ -529,7 +668,7 @@ function start_lttng_relayd_opt()
 	if [ -z $(lttng_pgrep "$RELAYD_MATCH") ]; then
 		# shellcheck disable=SC2086
 		$DIR/../src/bin/lttng-relayd/$RELAYD_BIN $process_mode $opt 1> $OUTPUT_DEST 2> $ERROR_OUTPUT_DEST
-		#$DIR/../src/bin/lttng-relayd/$RELAYD_BIN $opt -vvv >>/tmp/relayd.log 2>&1 &
+		#$DIR/../src/bin/lttng-relayd/$RELAYD_BIN $process_mode $opt -vvv >>/tmp/relayd.log 2>&1 &
 		if [ $? -eq 1 ]; then
 			if [ $withtap -eq "1" ]; then
 				fail "Start lttng-relayd (process mode: $process_mode opt: $opt)"
@@ -571,8 +710,9 @@ function stop_lttng_relayd_opt()
 
 
 	# Multiply time by 2 to simplify integer arithmetic
+	# Multiply time by 5 to adjust for sleeping every 0.1s
 	if [ -n "$timeout_s" ]; then
-		dtimeleft_s=$((timeout_s * 2))
+		dtimeleft_s=$((timeout_s * 2 * 5))
 	fi
 
 
@@ -607,7 +747,7 @@ function stop_lttng_relayd_opt()
 				fi
 				dtimeleft_s=$((dtimeleft_s - 1))
 			fi
-			sleep 0.5
+			sleep 0.1
 		done
 		if [ "$withtap" -eq "1" ]; then
 			if [ "$retval" -eq "0" ]; then
@@ -731,8 +871,9 @@ function stop_lttng_sessiond_opt()
 	fi
 
 	# Multiply time by 2 to simplify integer arithmetic
+	# Multiply time by 5 to adjust for sleeping every 0.1s
 	if [ -n "$timeout_s" ]; then
-		dtimeleft_s=$((timeout_s * 2))
+		dtimeleft_s=$((timeout_s * 2 * 5))
 	fi
 
 	if [ -n "$TEST_NO_SESSIOND" ] && [ "$TEST_NO_SESSIOND" == "1" ]; then
@@ -777,7 +918,7 @@ function stop_lttng_sessiond_opt()
 				fi
 				dtimeleft_s=$((dtimeleft_s - 1))
 			fi
-			sleep 0.5
+			sleep 0.1
 		done
 		out=1
 		while [ -n "$out" ]; do
@@ -789,7 +930,7 @@ function stop_lttng_sessiond_opt()
 				fi
 				dtimeleft_s=$((dtimeleft_s - 1))
 			fi
-			sleep 0.5
+			sleep 0.1
 		done
 
 		if [ "$withtap" -eq "1" ]; then
@@ -899,8 +1040,9 @@ function stop_lttng_consumerd_opt()
 	fi
 
 	# Multiply time by 2 to simplify integer arithmetic
+	# Multiply time by 5 to adjust for sleeping every 0.1s
 	if [ -n "$timeout_s" ]; then
-		dtimeleft_s=$((timeout_s * 2))
+		dtimeleft_s=$((timeout_s * 2 * 5))
 	fi
 
 	pids="$(lttng_pgrep "$CONSUMERD_MATCH")"
@@ -945,7 +1087,7 @@ function stop_lttng_consumerd_opt()
 				fi
 				dtimeleft_s=$((dtimeleft_s - 1))
 			fi
-			sleep 0.5
+			sleep 0.1
 		done
 		if [ "$withtap" -eq "1" ]; then
 			if [ "$retval" -eq "0" ]; then
@@ -1431,9 +1573,14 @@ function enable_ust_lttng_event_loglevel()
 	local sess_name="$1"
 	local event_name="$2"
 	local loglevel="$3"
+	local channel_name="$4"
+	local chan=()
+	if [ -n "${channel_name}" ] ; then
+		chan=('-c' "${channel_name}")
+	fi
 
 	_run_lttng_cmd "$OUTPUT_DEST" "$ERROR_OUTPUT_DEST" \
-		enable-event "$event_name" -s $sess_name -u --loglevel $loglevel
+		enable-event "${chan[@]}" "$event_name" -s "${sess_name}" -u --loglevel="${loglevel}"
 	ok $? "Enable event $event_name with loglevel $loglevel"
 }
 
@@ -1442,9 +1589,14 @@ function enable_ust_lttng_event_loglevel_only()
 	local sess_name="$1"
 	local event_name="$2"
 	local loglevel="$3"
+	local channel_name="$4"
+	local chan=()
+	if [ -n "${channel_name}" ] ; then
+		chan=('-c' "${channel_name}")
+	fi
 
 	_run_lttng_cmd "$OUTPUT_DEST" "$ERROR_OUTPUT_DEST" \
-		enable-event "$event_name" -s $sess_name -u --loglevel-only $loglevel
+		enable-event "${chan[@]}" "$event_name" -s "${sess_name}" -u --loglevel-only "${loglevel}"
 	ok $? "Enable event $event_name with loglevel-only $loglevel"
 }
 
@@ -1574,9 +1726,10 @@ function destroy_lttng_session ()
 	local withtap=$1
 	local expected_to_fail=$2
 	local sess_name=$3
+	shift 3
 
 	_run_lttng_cmd "$OUTPUT_DEST" "$ERROR_OUTPUT_DEST" \
-		destroy $sess_name
+		destroy $sess_name $@
 	ret=$?
 	if [[ $expected_to_fail -eq "1" ]]; then
 		test "$ret" -ne "0"
@@ -1881,7 +2034,7 @@ function wait_live_trace_ready ()
 	diag "Waiting for live trace at url: $url"
 	while [ $zero_client_match -eq 0 ]; do
 		zero_client_match=$($BABELTRACE_BIN -i lttng-live $url | grep "0 client(s) connected" | wc -l)
-		sleep 0.5
+		sleep 0.1
 	done
 	pass "Waiting for live trace at url: $url"
 }
@@ -1894,7 +2047,7 @@ function wait_live_viewer_connect ()
 	diag "Waiting for live viewers on url: $url"
 	while [ $one_client_match -eq 0 ]; do
 		one_client_match=$($BABELTRACE_BIN -i lttng-live $url | grep "1 client(s) connected" | wc -l)
-		sleep 0.5
+		sleep 0.1
 	done
 	pass "Waiting for live viewers on url: $url"
 }
@@ -1907,216 +2060,220 @@ function bail_out_if_no_babeltrace()
 	fi
 }
 
-function validate_metadata_event ()
+# Check that the trace metadata contains '$expected' event ids matching '$event_name'.
+function validate_metadata_event()
 {
 	local event_name=$1
-	local nr_event_id=$2
+	local expected=$2
 	local trace_path=$3
 
-	local metadata_file=$(find $trace_path -name "metadata")
-	local metadata_path=$(dirname $metadata_file)
+	local metadata_file
+	local metadata_path
+	local count
+
+	metadata_file=$(find "$trace_path" -name "metadata")
+	metadata_path=$(dirname "$metadata_file")
 
 	bail_out_if_no_babeltrace
 
-	local count=$($BABELTRACE_BIN --output-format=ctf-metadata $metadata_path | grep $event_name | wc -l)
-
-	if [ "$count" -ne "$nr_event_id" ]; then
-		fail "Metadata match with the metadata of $nr_event_id event(s) named $event_name"
-		diag "$count matching event names found in metadata"
-	else
-		pass "Metadata match with the metadata of $nr_event_id event(s) named $event_name"
-	fi
+	count=$($BABELTRACE_BIN --output-format=ctf-metadata "$metadata_path" | grep -c "$event_name")
 
+	test "$count" -eq "$expected"
+	ok $? "Found $count / $expected metadata event id matching '$event_name'"
 }
 
-function trace_matches ()
+# Check that the trace contains '$expected' events matching '$event_name', other
+# events not matching '$event_name' can be present.
+function trace_matches()
 {
 	local event_name=$1
-	local nr_iter=$2
+	local expected=$2
 	local trace_path=$3
 
+	local count
+	local total
+
 	bail_out_if_no_babeltrace
 
-	local count=$($BABELTRACE_BIN $trace_path | grep $event_name | wc -l)
+	count=$($BABELTRACE_BIN "$trace_path" | grep -c "$event_name")
+	total=$($BABELTRACE_BIN "$trace_path" | wc -l)
 
-	if [ "$count" -ne "$nr_iter" ]; then
-		fail "Trace match"
-		diag "$count matching events found in trace"
-	else
-		pass "Trace match"
-	fi
+	test "$count" -eq "$expected"
+
+	ok $? "Found $count / $expected events matching '$event_name' out of $total events"
 }
 
+# Check that the trace contains '$expected' events matching '$event_name' and no
+# other events.
 function trace_match_only()
 {
 	local event_name=$1
-	local nr_iter=$2
+	local expected=$2
 	local trace_path=$3
 
+	local count
+	local total
+
 	bail_out_if_no_babeltrace
-	#which "$BABELTRACE_BIN" >/dev/null
-	#skip $? -ne 0 "\"$BABELTRACE_BIN\" binary not found. Skipping trace comparison"
 
-	local count=$($BABELTRACE_BIN $trace_path | grep $event_name | wc -l)
-	local total=$($BABELTRACE_BIN $trace_path | wc -l)
+	count=$($BABELTRACE_BIN "$trace_path" | grep -c "$event_name")
+	total=$($BABELTRACE_BIN "$trace_path" | wc -l)
 
-	if [ "$nr_iter" -eq "$count" ] && [ "$total" -eq "$nr_iter" ]; then
-		pass "Trace match with $total event $event_name"
-	else
-		fail "Trace match"
-		diag "$total event(s) found, expecting $nr_iter of event $event_name and only found $count"
-	fi
+	test "$expected" -eq "$count" && test "$total" -eq "$expected"
+
+	ok $? "Found $count / $expected events matching '$event_name' amongst $total events"
 }
 
-function validate_trace
+# Check that the trace contains at least 1 event matching each name in the
+# comma separated list '$event_names'.
+function validate_trace()
 {
-	local event_name=$1
+	local event_names=$1
 	local trace_path=$2
 
+	local count
+
 	bail_out_if_no_babeltrace
 
 	OLDIFS=$IFS
 	IFS=","
-	for i in $event_name; do
-		traced=$($BABELTRACE_BIN $trace_path 2>/dev/null | grep $i | wc -l)
-		if [ "$traced" -ne 0 ]; then
-			pass "Validate trace for event $i, $traced events"
-		else
-			fail "Validate trace for event $i"
-			diag "Found $traced occurrences of $i"
-		fi
+	for event_name in $event_names; do
+		# trace_path is unquoted since callers make use of globbing
+		count=$($BABELTRACE_BIN $trace_path | grep -c "$event_name")
+		test "$count" -gt 0
+		ok $? "Found $count events matching '$event_name'"
 	done
-	ret=$?
 	IFS=$OLDIFS
-	return $ret
 }
 
-function validate_trace_count
+# Check that the trace contains at least 1 event matching each name in the
+# comma separated list '$event_names' and a total of '$expected' events.
+function validate_trace_count()
 {
-	local event_name=$1
+	local event_names=$1
 	local trace_path=$2
-	local expected_count=$3
+	local expected=$3
+
+	local count
+	local total=0
 
 	bail_out_if_no_babeltrace
 
-	cnt=0
 	OLDIFS=$IFS
 	IFS=","
-	for i in $event_name; do
-		traced=$($BABELTRACE_BIN $trace_path 2>/dev/null | grep $i | wc -l)
-		if [ "$traced" -ne 0 ]; then
-			pass "Validate trace for event $i, $traced events"
-		else
-			fail "Validate trace for event $i"
-			diag "Found $traced occurrences of $i"
-		fi
-		cnt=$(($cnt + $traced))
+	for event_name in $event_names; do
+		count=$($BABELTRACE_BIN "$trace_path" | grep -c "$event_name")
+		test "$count" -gt 0
+		ok $? "Found '$count' events matching '$event_name'"
+		total=$(( total + count ))
 	done
 	IFS=$OLDIFS
-	test $cnt -eq $expected_count
-	ok $? "Read a total of $cnt events, expected $expected_count"
+	test $total -eq "$expected"
+	ok $? "Found $total events, expected $expected events"
 }
 
-function validate_trace_count_range_incl_min_excl_max
+# Check that the trace contains at least '$expected_min' event matching each
+# name in the comma separated list '$event_names' and a total at least
+# '$expected_min' and less than '$expected_max' events.
+function validate_trace_count_range_incl_min_excl_max()
 {
-	local event_name=$1
+	local event_names=$1
 	local trace_path=$2
 	local expected_min=$3
 	local expected_max=$4
 
+	local count
+	local total=0
+
 	bail_out_if_no_babeltrace
 
-	cnt=0
 	OLDIFS=$IFS
 	IFS=","
-	for i in $event_name; do
-		traced=$($BABELTRACE_BIN $trace_path 2>/dev/null | grep $i | wc -l)
-		if [ "$traced" -ge $expected_min ]; then
-			pass "Validate trace for event $i, $traced events"
-		else
-			fail "Validate trace for event $i"
-			diag "Found $traced occurrences of $i"
-		fi
-		cnt=$(($cnt + $traced))
+	for event_name in $event_names; do
+		count=$($BABELTRACE_BIN "$trace_path" | grep -c "$event_name")
+		test "$count" -ge "$expected_min"
+		ok $? "Found $count events matching '$event_name', expected at least $expected_min"
+		total=$(( total + count ))
 	done
 	IFS=$OLDIFS
-	test $cnt -lt $expected_max
-	ok $? "Read a total of $cnt events, expected between [$expected_min, $expected_max["
+	test $total -ge "$expected_min" && test $total -lt "$expected_max"
+	ok $? "Found a total of $total events, expected at least $expected_min and less than $expected_max"
 }
 
-function trace_first_line
+function trace_first_line()
 {
 	local trace_path=$1
 
-	$BABELTRACE_BIN $trace_path 2>/dev/null | head -n 1
+	$BABELTRACE_BIN "$trace_path" | head -n 1
 }
 
+# Check that the trace contains at least 1 event matching the grep extended
+# regexp '$event_exp'.
 function validate_trace_exp()
 {
 	local event_exp=$1
 	local trace_path=$2
 
+	local count
+
 	bail_out_if_no_babeltrace
 
-	traced=$($BABELTRACE_BIN $trace_path 2>/dev/null | grep --extended-regexp ${event_exp} | wc -l)
-	if [ "$traced" -ne 0 ]; then
-		pass "Validate trace for expression '${event_exp}', $traced events"
-	else
-		fail "Validate trace for expression '${event_exp}'"
-		diag "Found $traced occurrences of '${event_exp}'"
-	fi
-	ret=$?
-	return $ret
+	# event_exp is unquoted since it contains multiple grep arguments
+	count=$($BABELTRACE_BIN "$trace_path" | grep -c --extended-regexp $event_exp)
+	test "$count" -gt 0
+	ok $? "Found $count events matching expression '$event_exp'"
 }
 
+# Check that the trace contains at least 1 event matching the grep extended
+# regexp '$event_exp' and zero event not matching it.
 function validate_trace_only_exp()
 {
 	local event_exp=$1
 	local trace_path=$2
 
+	local count
+	local total
+
 	bail_out_if_no_babeltrace
 
-	local count=$($BABELTRACE_BIN $trace_path | grep --extended-regexp ${event_exp} | wc -l)
-	local total=$($BABELTRACE_BIN $trace_path | wc -l)
+	# event_exp is unquoted since it contains multiple grep arguments
+	count=$($BABELTRACE_BIN "$trace_path" | grep -c --extended-regexp $event_exp)
+	total=$($BABELTRACE_BIN "$trace_path" | wc -l)
 
-	if [ "$count" -ne 0 ] && [ "$total" -eq "$count" ]; then
-		pass "Trace match with $total for expression '${event_exp}'"
-	else
-		fail "Trace match"
-		diag "$total syscall event(s) found, only syscalls matching expression '${event_exp}' ($count occurrences) are expected"
-	fi
-	ret=$?
-	return $ret
+	test  "$count" -gt 0 && test "$total" -eq "$count"
+	ok $? "Found $count events matching expression '$event_exp' amongst $total events"
 }
 
+# Check that the trace is valid and contains 0 event.
 function validate_trace_empty()
 {
 	local trace_path=$1
 
+	local ret
+	local count
+
 	bail_out_if_no_babeltrace
 
-	events=$($BABELTRACE_BIN $trace_path 2>/dev/null)
+	events=$($BABELTRACE_BIN "$trace_path")
 	ret=$?
 	if [ $ret -ne 0 ]; then
 		fail "Failed to parse trace"
 		return $ret
 	fi
 
-	traced=$(echo -n "$events" | wc -l)
-	if [ "$traced" -eq 0 ]; then
-		pass "Validate empty trace"
-	else
-		fail "Validate empty trace"
-		diag "Found $traced events in trace"
-	fi
-	ret=$?
-	return $ret
+	count=$(echo -n "$events" | wc -l)
+	test "$count" -eq 0
+	ok $? "Validate trace is empty, found $count events"
 }
 
 function validate_directory_empty ()
 {
 	local trace_path="$1"
 
+	local files
+	local ret
+	local nb_files
+
 	# Do not double quote `$trace_path` below as we want wildcards to be
 	# expanded.
 	files="$(ls -A $trace_path)"
@@ -2127,7 +2284,8 @@ function validate_directory_empty ()
 	fi
 
 	nb_files="$(echo -n "$files" | wc -l)"
-	ok $nb_files "Directory \"$trace_path\" is empty"
+	test "$nb_files" -eq 0
+	ok $? "Directory \"$trace_path\" is empty"
 }
 
 function validate_trace_session_ust_empty()
@@ -2265,9 +2423,9 @@ function lttng_enable_rotation_size ()
 	ret=$?
 	if [[ $expected_to_fail -eq "1" ]]; then
 		test "$ret" -ne "0"
-		ok $? "Expected fail on rotate session $sess_name"
+		ok $? "Expected to fail to set a periodic rotation of session $sess_name" "every " $size " bytes"
 	else
-		ok $ret "Rotate session $sess_name"
+		ok $ret "Set a scheduled rotation of session $sess_name" "every " $size " bytes"
 	fi
 }
 
@@ -2366,8 +2524,8 @@ function lttng_remove_trigger_ok()
 
 function list_triggers_matches_ok ()
 {
-	local tmp_stdout=$(mktemp --tmpdir -t "tmp.${FUNCNAME[0]}_stdout.XXXXXX")
-	local tmp_stderr=$(mktemp --tmpdir -t "tmp.${FUNCNAME[0]}_stderr.XXXXXX")
+	local tmp_stdout=$(mktemp -t "tmp.${FUNCNAME[0]}_stdout.XXXXXX")
+	local tmp_stderr=$(mktemp -t "tmp.${FUNCNAME[0]}_stderr.XXXXXX")
 
 	local test_name="$1"
 	local expected_stdout_file="$2"
@@ -2396,9 +2554,9 @@ function list_triggers_matches_mi_ok ()
 	local test_name="$1"
 	local expected_stdout_file="$2"
 
-	tmp_stdout_raw=$(mktemp --tmpdir -t "tmp.${FUNCNAME[0]}_stdout.XXXXXX")
-	tmp_stdout=$(mktemp --tmpdir -t "tmp.${FUNCNAME[0]}_stdout.XXXXXX")
-	tmp_stderr=$(mktemp --tmpdir -t "tmp.${FUNCNAME[0]}_stderr.XXXXXX")
+	tmp_stdout_raw=$(mktemp -t "tmp.${FUNCNAME[0]}_stdout.XXXXXX")
+	tmp_stdout=$(mktemp -t "tmp.${FUNCNAME[0]}_stdout.XXXXXX")
+	tmp_stderr=$(mktemp -t "tmp.${FUNCNAME[0]}_stderr.XXXXXX")
 
 	diag "$TESTDIR/../src/bin/lttng/$LTTNG_BIN --mi xml list-triggers"