X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=tests%2Funit%2Ftest_log_level_rule.cpp;h=d2895c811bc5331e23d00bcea68805fe7d82827c;hp=be60e82c78ed0f989ebeef87e114ffe0f741e3fb;hb=HEAD;hpb=17d3ad998a3f3fc753c04c58d7e234e22558ca9e

diff --git a/tests/unit/test_log_level_rule.cpp b/tests/unit/test_log_level_rule.cpp
index be60e82c7..209253267 100644
--- a/tests/unit/test_log_level_rule.cpp
+++ b/tests/unit/test_log_level_rule.cpp
@@ -7,18 +7,18 @@
  *
  */
 
-#include <inttypes.h>
-#include <stdio.h>
-#include <string.h>
-#include <unistd.h>
-
-#include <tap/tap.h>
-
 #include <common/payload-view.hpp>
 #include <common/payload.hpp>
+
 #include <lttng/log-level-rule-internal.hpp>
 #include <lttng/log-level-rule.h>
 
+#include <inttypes.h>
+#include <stdio.h>
+#include <string.h>
+#include <tap/tap.h>
+#include <unistd.h>
+
 /* For error.h. */
 int lttng_opt_quiet = 1;
 int lttng_opt_verbose;
@@ -26,33 +26,43 @@ int lttng_opt_mi;
 
 #define NUM_TESTS 29
 
-static void test_log_level_rule_error(void)
+static void test_log_level_rule_error()
 {
 	int level = 9000;
-	struct lttng_log_level_rule *exactly =
-			lttng_log_level_rule_exactly_create(level);
+	struct lttng_log_level_rule *exactly = lttng_log_level_rule_exactly_create(level);
 	struct lttng_log_level_rule *at_least_as_severe =
-			lttng_log_level_rule_at_least_as_severe_as_create(
-					level);
-
-	ok(lttng_log_level_rule_get_type(NULL) == LTTNG_LOG_LEVEL_RULE_TYPE_UNKNOWN, "Get type on invalid pointer");
-
-	ok(lttng_log_level_rule_exactly_get_level(NULL, NULL) == LTTNG_LOG_LEVEL_RULE_STATUS_INVALID, "lttng_log_level_rule_exactly_get_level (NULL, NULL) returns invalid");
-	ok(lttng_log_level_rule_exactly_get_level(exactly, NULL) == LTTNG_LOG_LEVEL_RULE_STATUS_INVALID, "lttng_log_level_rule_exactly_get_level (valid, NULL) returns invalid");
-	ok(lttng_log_level_rule_exactly_get_level(NULL, &level) == LTTNG_LOG_LEVEL_RULE_STATUS_INVALID, "lttng_log_level_rule_exactly_get_level (NULL, valid) returns invalid");
-
-	ok(lttng_log_level_rule_at_least_as_severe_as_get_level(NULL, NULL) == LTTNG_LOG_LEVEL_RULE_STATUS_INVALID, "lttng_log_level_rule_at_least_as_severe_as_get_level (NULL, NULL) returns invalid");
-	ok(lttng_log_level_rule_at_least_as_severe_as_get_level(exactly, NULL) == LTTNG_LOG_LEVEL_RULE_STATUS_INVALID, "lttng_log_level_rule_at_least_as_severe_as_get_level (valid, NULL) returns invalid");
-	ok(lttng_log_level_rule_at_least_as_severe_as_get_level(NULL, &level) == LTTNG_LOG_LEVEL_RULE_STATUS_INVALID, "lttng_log_level_rule_at_least_as_severe_as_get_level (NULL, valid) returns invalid");
+		lttng_log_level_rule_at_least_as_severe_as_create(level);
+
+	ok(lttng_log_level_rule_get_type(nullptr) == LTTNG_LOG_LEVEL_RULE_TYPE_UNKNOWN,
+	   "Get type on invalid pointer");
+
+	ok(lttng_log_level_rule_exactly_get_level(nullptr, nullptr) ==
+		   LTTNG_LOG_LEVEL_RULE_STATUS_INVALID,
+	   "lttng_log_level_rule_exactly_get_level (NULL, NULL) returns invalid");
+	ok(lttng_log_level_rule_exactly_get_level(exactly, nullptr) ==
+		   LTTNG_LOG_LEVEL_RULE_STATUS_INVALID,
+	   "lttng_log_level_rule_exactly_get_level (valid, NULL) returns invalid");
+	ok(lttng_log_level_rule_exactly_get_level(nullptr, &level) ==
+		   LTTNG_LOG_LEVEL_RULE_STATUS_INVALID,
+	   "lttng_log_level_rule_exactly_get_level (NULL, valid) returns invalid");
+
+	ok(lttng_log_level_rule_at_least_as_severe_as_get_level(nullptr, nullptr) ==
+		   LTTNG_LOG_LEVEL_RULE_STATUS_INVALID,
+	   "lttng_log_level_rule_at_least_as_severe_as_get_level (NULL, NULL) returns invalid");
+	ok(lttng_log_level_rule_at_least_as_severe_as_get_level(exactly, nullptr) ==
+		   LTTNG_LOG_LEVEL_RULE_STATUS_INVALID,
+	   "lttng_log_level_rule_at_least_as_severe_as_get_level (valid, NULL) returns invalid");
+	ok(lttng_log_level_rule_at_least_as_severe_as_get_level(nullptr, &level) ==
+		   LTTNG_LOG_LEVEL_RULE_STATUS_INVALID,
+	   "lttng_log_level_rule_at_least_as_severe_as_get_level (NULL, valid) returns invalid");
 
 	lttng_log_level_rule_destroy(exactly);
 	lttng_log_level_rule_destroy(at_least_as_severe);
 }
 
-static
-void test_log_level_rule_serialize_deserialize(const struct lttng_log_level_rule *rule)
+static void test_log_level_rule_serialize_deserialize(const struct lttng_log_level_rule *rule)
 {
-	struct lttng_log_level_rule *log_level_rule_from_buffer = NULL;
+	struct lttng_log_level_rule *log_level_rule_from_buffer = nullptr;
 	struct lttng_payload payload;
 
 	lttng_payload_init(&payload);
@@ -60,23 +70,20 @@ void test_log_level_rule_serialize_deserialize(const struct lttng_log_level_rule
 	ok(lttng_log_level_rule_serialize(rule, &payload) == 0, "Serializing.");
 
 	{
-		struct lttng_payload_view view =
-				lttng_payload_view_from_payload(
-						&payload, 0, -1);
+		struct lttng_payload_view view = lttng_payload_view_from_payload(&payload, 0, -1);
 
-		ok(lttng_log_level_rule_create_from_payload(
-				&view, &log_level_rule_from_buffer) > 0,
-				"Deserializing.");
+		ok(lttng_log_level_rule_create_from_payload(&view, &log_level_rule_from_buffer) > 0,
+		   "Deserializing.");
 	}
 
-	ok(lttng_log_level_rule_is_equal(rule, log_level_rule_from_buffer), "Serialized and from buffer are equal");
+	ok(lttng_log_level_rule_is_equal(rule, log_level_rule_from_buffer),
+	   "Serialized and from buffer are equal");
 
 	lttng_log_level_rule_destroy(log_level_rule_from_buffer);
 	lttng_payload_reset(&payload);
 }
 
-static
-void test_log_level_rule_is_equal_exactly(void)
+static void test_log_level_rule_is_equal_exactly()
 {
 	int level = 9000, no_eq_level = 420;
 	struct lttng_log_level_rule *a, *b, *different_level, *different_type;
@@ -95,8 +102,10 @@ void test_log_level_rule_is_equal_exactly(void)
 
 	ok(lttng_log_level_rule_is_equal(a, a), "Same object is equal");
 	ok(lttng_log_level_rule_is_equal(a, b), "Object a and b are equal");
-	ok(!lttng_log_level_rule_is_equal(a, different_level), " Object of different levels are not equal");
-	ok(!lttng_log_level_rule_is_equal(a, different_type), " Object of different types are not equal");
+	ok(!lttng_log_level_rule_is_equal(a, different_level),
+	   " Object of different levels are not equal");
+	ok(!lttng_log_level_rule_is_equal(a, different_type),
+	   " Object of different types are not equal");
 
 	lttng_log_level_rule_destroy(a);
 	lttng_log_level_rule_destroy(b);
@@ -104,8 +113,7 @@ void test_log_level_rule_is_equal_exactly(void)
 	lttng_log_level_rule_destroy(different_type);
 }
 
-static
-void test_log_level_rule_is_equal_at_least_as_severe_as(void)
+static void test_log_level_rule_is_equal_at_least_as_severe_as()
 {
 	int level = 9000, no_eq_level = 420;
 	struct lttng_log_level_rule *a, *b, *different_level, *different_type;
@@ -124,8 +132,10 @@ void test_log_level_rule_is_equal_at_least_as_severe_as(void)
 
 	ok(lttng_log_level_rule_is_equal(a, a), "Same object is equal");
 	ok(lttng_log_level_rule_is_equal(a, b), "Object a and b are equal");
-	ok(!lttng_log_level_rule_is_equal(a, different_level), " Object of different levels are not equal");
-	ok(!lttng_log_level_rule_is_equal(a, different_type), " Object of different types are not equal");
+	ok(!lttng_log_level_rule_is_equal(a, different_level),
+	   " Object of different levels are not equal");
+	ok(!lttng_log_level_rule_is_equal(a, different_type),
+	   " Object of different types are not equal");
 
 	lttng_log_level_rule_destroy(a);
 	lttng_log_level_rule_destroy(b);
@@ -133,19 +143,18 @@ void test_log_level_rule_is_equal_at_least_as_severe_as(void)
 	lttng_log_level_rule_destroy(different_type);
 }
 
-static void test_log_level_rule_exactly(void)
+static void test_log_level_rule_exactly()
 {
 	int level = 9000;
 	int _level;
-	struct lttng_log_level_rule *exactly = NULL;
+	struct lttng_log_level_rule *exactly = nullptr;
 	enum lttng_log_level_rule_status status;
 
 	exactly = lttng_log_level_rule_exactly_create(level);
 
 	ok(exactly, "Log level exactly allocated");
-	ok(lttng_log_level_rule_get_type(exactly) ==
-					LTTNG_LOG_LEVEL_RULE_TYPE_EXACTLY,
-			"Log level rule exactly type");
+	ok(lttng_log_level_rule_get_type(exactly) == LTTNG_LOG_LEVEL_RULE_TYPE_EXACTLY,
+	   "Log level rule exactly type");
 
 	status = lttng_log_level_rule_exactly_get_level(exactly, &_level);
 	ok(status == LTTNG_LOG_LEVEL_RULE_STATUS_OK, "Get the level");
@@ -156,21 +165,22 @@ static void test_log_level_rule_exactly(void)
 	lttng_log_level_rule_destroy(exactly);
 }
 
-static void test_log_level_rule_at_least_as_severe_as(void)
+static void test_log_level_rule_at_least_as_severe_as()
 {
 	int level = 9000;
 	int _level;
-	struct lttng_log_level_rule *at_least_as_severe_as = NULL;
+	struct lttng_log_level_rule *at_least_as_severe_as = nullptr;
 	enum lttng_log_level_rule_status status;
 
 	at_least_as_severe_as = lttng_log_level_rule_at_least_as_severe_as_create(level);
 
 	ok(at_least_as_severe_as, "Log level at_least_as_severe_as allocated");
 	ok(lttng_log_level_rule_get_type(at_least_as_severe_as) ==
-					LTTNG_LOG_LEVEL_RULE_TYPE_AT_LEAST_AS_SEVERE_AS,
-			"Log level rule at_least_as_severe_as type");
+		   LTTNG_LOG_LEVEL_RULE_TYPE_AT_LEAST_AS_SEVERE_AS,
+	   "Log level rule at_least_as_severe_as type");
 
-	status = lttng_log_level_rule_at_least_as_severe_as_get_level(at_least_as_severe_as, &_level);
+	status = lttng_log_level_rule_at_least_as_severe_as_get_level(at_least_as_severe_as,
+								      &_level);
 	ok(status == LTTNG_LOG_LEVEL_RULE_STATUS_OK, "Get the level");
 	ok(_level == level, "Level property is valid");
 
@@ -179,7 +189,7 @@ static void test_log_level_rule_at_least_as_severe_as(void)
 	lttng_log_level_rule_destroy(at_least_as_severe_as);
 }
 
-int main(void)
+int main()
 {
 	plan_tests(NUM_TESTS);
 	test_log_level_rule_exactly();