X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=tests%2Fregression%2Ftools%2Fnotification%2Fnotification.c;h=535a71fce7fd8b5cbda2fa9a4086866b4d372007;hp=f0149bc2f109db3c5b33167564117b6c498ef7fe;hb=f12eb9c1ceb619db54be0842323a32cda12651cd;hpb=9df6c82a8ea4064f9868028b9fc3412f45adbb0a

diff --git a/tests/regression/tools/notification/notification.c b/tests/regression/tools/notification/notification.c
index f0149bc2f..535a71fce 100644
--- a/tests/regression/tools/notification/notification.c
+++ b/tests/regression/tools/notification/notification.c
@@ -59,19 +59,35 @@ void wait_on_file(const char *path, bool file_exist)
 		ret = stat(path, &buf);
 		if (ret == -1 && errno == ENOENT) {
 			if (file_exist) {
-				(void) poll(NULL, 0, 10);	/* 10 ms delay */
-				continue;			/* retry */
+				/*
+				 * The file does not exist. wait a bit and
+				 * continue looping until it does.
+				 */
+				(void) poll(NULL, 0, 10);
+				continue;
 			}
-			break; /* File does not exist */
+
+			/*
+			 * File does not exist and the exit condition we want.
+			 * Break from the loop and return.
+			 */
+			break;
 		}
 		if (ret) {
 			perror("stat");
 			exit(EXIT_FAILURE);
 		}
-		break;	/* found */
+		/*
+		 * stat() returned 0, so the file exists. break now only if
+		 * that's the exit condition we want.
+		 */
+		if (file_exist) {
+			break;
+		}
 	}
 }
 
+static
 int write_pipe(const char *path, uint8_t data)
 {
 	int ret = 0;
@@ -103,6 +119,7 @@ end:
 	return ret;
 }
 
+static
 int stop_consumer(const char **argv)
 {
 	int ret = 0, i;
@@ -113,6 +130,7 @@ int stop_consumer(const char **argv)
 	return ret;
 }
 
+static
 int resume_consumer(const char **argv)
 {
 	int ret = 0, i;
@@ -123,7 +141,8 @@ int resume_consumer(const char **argv)
 	return ret;
 }
 
-int suspend_application()
+static
+int suspend_application(void)
 {
 	int ret;
 	struct stat buf;
@@ -151,6 +170,7 @@ error:
 
 }
 
+static
 int resume_application()
 {
 	int ret;
@@ -181,6 +201,7 @@ error:
 }
 
 
+static
 void test_triggers_buffer_usage_condition(const char *session_name,
 		const char *channel_name,
 		enum lttng_domain_type domain_type,
@@ -300,7 +321,7 @@ void test_triggers_buffer_usage_condition(const char *session_name,
 			assert("Logic error for test vector generation");
 		}
 
-		loop_ret = asprintf(&test_tuple_string, "session name %s, channel name  %s, threshold ratio %s, threshold byte %s, domain type %s",
+		loop_ret = asprintf(&test_tuple_string, "session name %s, channel name %s, threshold ratio %s, threshold byte %s, domain type %s",
 				session_name_set ? "set" : "unset",
 				channel_name_set ? "set" : "unset",
 				threshold_ratio_set ? "set" : "unset",
@@ -348,7 +369,7 @@ loop_end:
 			 * registered trigger fail.
 			 */
 			loop_ret = lttng_unregister_trigger(trigger);
-			ok(loop_ret == -LTTNG_ERR_TRIGGER_NOT_FOUND, "Unregister of a non-registerd  trigger fails as expected: %s", test_tuple_string);
+			ok(loop_ret == -LTTNG_ERR_TRIGGER_NOT_FOUND, "Unregister of a non-registered trigger fails as expected: %s", test_tuple_string);
 		} else {
 			ok(loop_ret == -LTTNG_ERR_INVALID_TRIGGER, "Trigger is invalid as expected and cannot be registered: %s", test_tuple_string);
 		}
@@ -374,6 +395,7 @@ void wait_data_pending(const char *session_name)
 	} while (ret != 0);
 }
 
+static
 void test_notification_channel(const char *session_name, const char *channel_name, const enum lttng_domain_type domain_type, const char **argv)
 {
 	int ret = 0;