X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=tests%2Fregression%2Ftools%2Fhealth%2Ftest_thread_stall;h=92cfb0135bfe16308f8e821cfb0649bffa85c59c;hp=dc9d850f45b1d7270b96cdbffe9098a71a2a58e6;hb=33c820d6c1f3b742a0028e0219b21e364baade78;hpb=03276eea085914fc02bd798dce8ac36d3007b1f2

diff --git a/tests/regression/tools/health/test_thread_stall b/tests/regression/tools/health/test_thread_stall
index dc9d850f4..92cfb0135 100755
--- a/tests/regression/tools/health/test_thread_stall
+++ b/tests/regression/tools/health/test_thread_stall
@@ -24,14 +24,14 @@ SESSION_NAME="health_thread_stall"
 EVENT_NAME="bogus"
 HEALTH_CHECK_BIN="health_check"
 SESSIOND_PRELOAD=".libs/libhealthstall.so"
+NUM_TESTS=12
 
 source $TESTDIR/utils/utils.sh
 
 print_test_banner "$TEST_DESC"
 
 if [ ! -f "$CURDIR/$SESSIOND_PRELOAD" ]; then
-	echo -e "libhealthstall.so not available for this test. Skipping."
-	exit 0
+	BAIL_OUT "libhealthstall.so not available for this test."
 fi
 
 function test_thread_stall
@@ -39,8 +39,7 @@ function test_thread_stall
 	test_thread_stall_name="$1"
 	test_thread_exit_code="$2"
 
-	echo ""
-	echo -e "=== Testing health failure with ${test_thread_stall_name}"
+	diag "Test health failure with ${test_thread_stall_name}"
 
 	# Activate testpoints
 	export LTTNG_TESTPOINT_ENABLE=1
@@ -59,8 +58,6 @@ function test_thread_stall
 	# Check initial health status
 	$CURDIR/$HEALTH_CHECK_BIN &> /dev/null
 
-	echo -n "Validating that ${test_thread_stall_name} is stalled... "
-
 	# Wait
 	sleep 25
 
@@ -70,17 +67,15 @@ function test_thread_stall
 	health_check_exit_code=$?
 
 	if [ $health_check_exit_code -eq $test_thread_exit_code ]; then
-		print_ok
+		pass "Validate that ${test_thread_stall_name} is stalled"
 	else
-		print_fail
-		echo -e "Health returned: $health_check_exit_code\n"
+		fail "Validate that ${test_thread_stall_name} is stalled"
+		diag "Health returned: $health_check_exit_code"
 
 		stop_lttng_sessiond
 		return 1
 	fi
 
-	echo -n "Validating that ${test_thread_stall_name} is no longer stalled... "
-
 	# Wait
 	sleep 40
 
@@ -90,11 +85,11 @@ function test_thread_stall
 	health_check_exit_code=$?
 
 	if [ $health_check_exit_code -eq 0 ]; then
-		print_ok
+		pass "Validate that ${test_thread_stall_name} is no longer stalled"
 		stop_lttng_sessiond
 	else
-		print_fail
-		echo -e "Health returned: $health_check_exit_code\n"
+		fail "Validate that ${test_thread_stall_name} is no longer stalled"
+		diag "Health returned: $health_check_exit_code\n"
 		stop_lttng_sessiond
 		return 1
 	fi
@@ -102,18 +97,20 @@ function test_thread_stall
 
 }
 
+plan_tests $NUM_TESTS
+
 THREAD=("LTTNG_THREAD_MANAGE_CLIENTS"
 	"LTTNG_THREAD_MANAGE_APPS"
 # This thread is a little bit tricky to stall,
 # need to send some commands and setup an app.
 #	"LTTNG_THREAD_REG_APPS"
-	"LTTNG_THREAD_MANAGE_KERNEL")
+)
 
 # Exit code value to indicate specific thread failure
 EXIT_CODE=(1
 	   2
 #	   4
-	   8)
+)
 
 THREAD_COUNT=${#THREAD[@]}
 i=0
@@ -126,3 +123,15 @@ while [ "$i" -lt "$THREAD_COUNT" ]; do
 
 	let "i++"
 done
+
+# The manage kernel thread is only spawned if we are root
+if [ "$(id -u)" == "0" ]; then
+	isroot=1
+else
+	isroot=0
+fi
+
+skip $isroot "Root access is needed. Skipping LTTNG_THREAD_MANAGE_KERNEL tests." "3" ||
+{
+	test_thread_stall "LTTNG_THREAD_MANAGE_KERNEL" "8"
+}