X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Flib%2Flttng-ctl%2Flttng-ctl.c;h=c9fb293be1ed74411d20238ec7f94663a613041e;hp=ef288726a23b1c97779097d4e0ce9bddbf00589c;hb=178191b3899f114001f000c2e7f46909969f9c6f;hpb=f73fabfda365d22e7dd180fb1614e37c446fbd9e

diff --git a/src/lib/lttng-ctl/lttng-ctl.c b/src/lib/lttng-ctl/lttng-ctl.c
index ef288726a..c9fb293be 100644
--- a/src/lib/lttng-ctl/lttng-ctl.c
+++ b/src/lib/lttng-ctl/lttng-ctl.c
@@ -34,17 +34,17 @@
 #include <common/uri.h>
 #include <lttng/lttng.h>
 
-#include "filter-ast.h"
-#include "filter-parser.h"
-#include "filter-bytecode.h"
-#include "memstream.h"
+#include "filter/filter-ast.h"
+#include "filter/filter-parser.h"
+#include "filter/filter-bytecode.h"
+#include "filter/memstream.h"
 
 #ifdef DEBUG
-const int print_xml = 1;
+static const int print_xml = 1;
 #define dbg_printf(fmt, args...)	\
 	printf("[debug liblttng-ctl] " fmt, ## args)
 #else
-const int print_xml = 0;
+static const int print_xml = 0;
 #define dbg_printf(fmt, args...)				\
 do {								\
 	/* do nothing but check printf format */		\
@@ -69,8 +69,6 @@ static int connected;
  * Those two variables are used by error.h to silent or control the verbosity of
  * error message. They are global to the library so application linking with it
  * are able to compile correctly and also control verbosity of the library.
- *
- * Note that it is *not* possible to silent ERR() and PERROR() macros.
  */
 int lttng_opt_quiet;
 int lttng_opt_verbose;
@@ -253,7 +251,7 @@ static int send_session_msg(struct lttcomm_session_msg *lsm)
 	int ret;
 
 	if (!connected) {
-		ret = -ENOTCONN;
+		ret = -LTTNG_ERR_NO_SESSIOND;
 		goto end;
 	}
 
@@ -261,6 +259,9 @@ static int send_session_msg(struct lttcomm_session_msg *lsm)
 
 	ret = lttcomm_send_creds_unix_sock(sessiond_socket, lsm,
 			sizeof(struct lttcomm_session_msg));
+	if (ret < 0) {
+		ret = -LTTNG_ERR_FATAL;
+	}
 
 end:
 	return ret;
@@ -277,7 +278,7 @@ static int send_session_varlen(void *data, size_t len)
 	int ret;
 
 	if (!connected) {
-		ret = -ENOTCONN;
+		ret = -LTTNG_ERR_NO_SESSIOND;
 		goto end;
 	}
 
@@ -287,6 +288,9 @@ static int send_session_varlen(void *data, size_t len)
 	}
 
 	ret = lttcomm_send_unix_sock(sessiond_socket, data, len);
+	if (ret < 0) {
+		ret = -LTTNG_ERR_FATAL;
+	}
 
 end:
 	return ret;
@@ -303,11 +307,14 @@ static int recv_data_sessiond(void *buf, size_t len)
 	int ret;
 
 	if (!connected) {
-		ret = -ENOTCONN;
+		ret = -LTTNG_ERR_NO_SESSIOND;
 		goto end;
 	}
 
 	ret = lttcomm_recv_unix_sock(sessiond_socket, buf, len);
+	if (ret < 0) {
+		ret = -LTTNG_ERR_FATAL;
+	}
 
 end:
 	return ret;
@@ -378,13 +385,13 @@ static int try_connect_sessiond(const char *sock_path)
 	ret = access(sock_path, F_OK);
 	if (ret < 0) {
 		/* Not alive */
-		return -1;
+		goto error;
 	}
 
 	ret = lttcomm_connect_unix_sock(sock_path);
 	if (ret < 0) {
 		/* Not alive */
-		return -1;
+		goto error;
 	}
 
 	ret = lttcomm_close_unix_sock(ret);
@@ -393,13 +400,17 @@ static int try_connect_sessiond(const char *sock_path)
 	}
 
 	return 0;
+
+error:
+	return -1;
 }
 
 /*
- * Set sessiond socket path by putting it in the global
- * sessiond_sock_path variable.
- * Returns 0 on success,
- * -ENOMEM on failure (the sessiond socket path is somehow too long)
+ * Set sessiond socket path by putting it in the global sessiond_sock_path
+ * variable.
+ *
+ * Returns 0 on success, negative value on failure (the sessiond socket path
+ * is somehow too long or ENOMEM).
  */
 static int set_session_daemon_path(void)
 {
@@ -437,11 +448,14 @@ static int set_session_daemon_path(void)
 		ret = snprintf(sessiond_sock_path, sizeof(sessiond_sock_path),
 				DEFAULT_HOME_CLIENT_UNIX_SOCK, getenv("HOME"));
 		if ((ret < 0) || (ret >= sizeof(sessiond_sock_path))) {
-			return -ENOMEM;
+			goto error;
 		}
 	}
 end:
 	return 0;
+
+error:
+	return -1;
 }
 
 /*
@@ -455,19 +469,22 @@ static int connect_sessiond(void)
 
 	ret = set_session_daemon_path();
 	if (ret < 0) {
-		return -1; /* set_session_daemon_path() returns -ENOMEM */
+		goto error;
 	}
 
 	/* Connect to the sesssion daemon */
 	ret = lttcomm_connect_unix_sock(sessiond_sock_path);
 	if (ret < 0) {
-		return ret;
+		goto error;
 	}
 
 	sessiond_socket = ret;
 	connected = 1;
 
 	return 0;
+
+error:
+	return -1;
 }
 
 /*
@@ -503,23 +520,27 @@ static int ask_sessiond_varlen(struct lttcomm_session_msg *lsm,
 
 	ret = connect_sessiond();
 	if (ret < 0) {
+		ret = -LTTNG_ERR_NO_SESSIOND;
 		goto end;
 	}
 
 	/* Send command to session daemon */
 	ret = send_session_msg(lsm);
 	if (ret < 0) {
+		/* Ret value is a valid lttng error code. */
 		goto end;
 	}
 	/* Send var len data */
 	ret = send_session_varlen(vardata, varlen);
 	if (ret < 0) {
+		/* Ret value is a valid lttng error code. */
 		goto end;
 	}
 
 	/* Get header from data transmission */
 	ret = recv_data_sessiond(&llm, sizeof(llm));
 	if (ret < 0) {
+		/* Ret value is a valid lttng error code. */
 		goto end;
 	}
 
@@ -553,7 +574,7 @@ static int ask_sessiond_varlen(struct lttcomm_session_msg *lsm,
 	 * this point, an error is returned and data is freed.
 	 */
 	if (buf == NULL) {
-		ret = -1;
+		ret = -LTTNG_ERR_INVALID;
 		free(data);
 		goto end;
 	}
@@ -583,11 +604,15 @@ static int ask_sessiond(struct lttcomm_session_msg *lsm, void **buf)
 struct lttng_handle *lttng_create_handle(const char *session_name,
 		struct lttng_domain *domain)
 {
-	struct lttng_handle *handle;
+	struct lttng_handle *handle = NULL;
+
+	if (domain == NULL) {
+		goto end;
+	}
 
 	handle = malloc(sizeof(struct lttng_handle));
 	if (handle == NULL) {
-		perror("malloc handle");
+		PERROR("malloc handle");
 		goto end;
 	}
 
@@ -621,6 +646,10 @@ int lttng_register_consumer(struct lttng_handle *handle,
 {
 	struct lttcomm_session_msg lsm;
 
+	if (handle == NULL || socket_path == NULL) {
+		return -LTTNG_ERR_INVALID;
+	}
+
 	lsm.cmd_type = LTTNG_REGISTER_CONSUMER;
 	copy_string(lsm.session.name, handle->session_name,
 			sizeof(lsm.session.name));
@@ -640,7 +669,7 @@ int lttng_start_tracing(const char *session_name)
 	struct lttcomm_session_msg lsm;
 
 	if (session_name == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_START_TRACE;
@@ -651,29 +680,79 @@ int lttng_start_tracing(const char *session_name)
 }
 
 /*
- *  Stop tracing for all traces of the session.
- *  Returns size of returned session payload data or a negative error code.
+ * Stop tracing for all traces of the session.
  */
-int lttng_stop_tracing(const char *session_name)
+static int _lttng_stop_tracing(const char *session_name, int wait)
 {
+	int ret, data_ret;
 	struct lttcomm_session_msg lsm;
 
 	if (session_name == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_STOP_TRACE;
 
 	copy_string(lsm.session.name, session_name, sizeof(lsm.session.name));
 
-	return ask_sessiond(&lsm, NULL);
+	ret = ask_sessiond(&lsm, NULL);
+	if (ret < 0 && ret != -LTTNG_ERR_TRACE_ALREADY_STOPPED) {
+		goto error;
+	}
+
+	if (!wait) {
+		goto end;
+	}
+
+	_MSG("Waiting for data availability");
+
+	/* Check for data availability */
+	do {
+		data_ret = lttng_data_pending(session_name);
+		if (data_ret < 0) {
+			/* Return the data available call error. */
+			ret = data_ret;
+			goto error;
+		}
+
+		/*
+		 * Data sleep time before retrying (in usec). Don't sleep if the call
+		 * returned value indicates availability.
+		 */
+		if (data_ret) {
+			usleep(DEFAULT_DATA_AVAILABILITY_WAIT_TIME);
+			_MSG(".");
+		}
+	} while (data_ret != 0);
+
+	MSG("");
+
+end:
+error:
+	return ret;
 }
 
 /*
- * Add context to event and/or channel.
- * If event_name is NULL, the context is applied to all events of the channel.
- * If channel_name is NULL, a lookup of the event's channel is done.
- * If both are NULL, the context is applied to all events of all channels.
+ * Stop tracing and wait for data availability.
+ */
+int lttng_stop_tracing(const char *session_name)
+{
+	return _lttng_stop_tracing(session_name, 1);
+}
+
+/*
+ * Stop tracing but _don't_ wait for data availability.
+ */
+int lttng_stop_tracing_no_wait(const char *session_name)
+{
+	return _lttng_stop_tracing(session_name, 0);
+}
+
+/*
+ * Add context to a channel.
+ *
+ * If the given channel is NULL, add the contexts to all channels.
+ * The event_name param is ignored.
  *
  * Returns the size of the returned payload data or a negative error code.
  */
@@ -685,7 +764,7 @@ int lttng_add_context(struct lttng_handle *handle,
 
 	/* Safety check. Both are mandatory */
 	if (handle == NULL || ctx == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	memset(&lsm, 0, sizeof(lsm));
@@ -695,9 +774,6 @@ int lttng_add_context(struct lttng_handle *handle,
 	/* Copy channel name */
 	copy_string(lsm.u.context.channel_name, channel_name,
 			sizeof(lsm.u.context.channel_name));
-	/* Copy event name */
-	copy_string(lsm.u.context.event_name, event_name,
-			sizeof(lsm.u.context.event_name));
 
 	copy_lttng_domain(&lsm.domain, &handle->domain);
 
@@ -721,7 +797,7 @@ int lttng_enable_event(struct lttng_handle *handle,
 	struct lttcomm_session_msg lsm;
 
 	if (handle == NULL || ev == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	memset(&lsm, 0, sizeof(lsm));
@@ -751,13 +827,13 @@ int lttng_enable_event(struct lttng_handle *handle,
 }
 
 /*
- * set filter for an event
+ * Set filter for an event
+ *
  * Return negative error value on error.
  * Return size of returned session payload data if OK.
  */
-
 int lttng_set_event_filter(struct lttng_handle *handle,
-		const char *event_name, const char *channel_name,
+		struct lttng_event *event, const char *channel_name,
 		const char *filter_expression)
 {
 	struct lttcomm_session_msg lsm;
@@ -767,7 +843,7 @@ int lttng_set_event_filter(struct lttng_handle *handle,
 
 	/* Safety check. */
 	if (handle == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	if (!filter_expression) {
@@ -782,24 +858,24 @@ int lttng_set_event_filter(struct lttng_handle *handle,
 			strlen(filter_expression), "r");
 	if (!fmem) {
 		fprintf(stderr, "Error opening memory as stream\n");
-		return -ENOMEM;
+		return -LTTNG_ERR_FILTER_NOMEM;
 	}
 	ctx = filter_parser_ctx_alloc(fmem);
 	if (!ctx) {
 		fprintf(stderr, "Error allocating parser\n");
-		ret = -ENOMEM;
+		ret = -LTTNG_ERR_FILTER_NOMEM;
 		goto alloc_error;
 	}
 	ret = filter_parser_ctx_append_ast(ctx);
 	if (ret) {
 		fprintf(stderr, "Parse error\n");
-		ret = -EINVAL;
+		ret = -LTTNG_ERR_FILTER_INVAL;
 		goto parse_error;
 	}
 	ret = filter_visitor_set_parent(ctx);
 	if (ret) {
 		fprintf(stderr, "Set parent error\n");
-		ret = -EINVAL;
+		ret = -LTTNG_ERR_FILTER_INVAL;
 		goto parse_error;
 	}
 	if (print_xml) {
@@ -807,7 +883,7 @@ int lttng_set_event_filter(struct lttng_handle *handle,
 		if (ret) {
 			fflush(stdout);
 			fprintf(stderr, "XML print error\n");
-			ret = -EINVAL;
+			ret = -LTTNG_ERR_FILTER_INVAL;
 			goto parse_error;
 		}
 	}
@@ -817,7 +893,7 @@ int lttng_set_event_filter(struct lttng_handle *handle,
 	ret = filter_visitor_ir_generate(ctx);
 	if (ret) {
 		fprintf(stderr, "Generate IR error\n");
-		ret = -EINVAL;
+		ret = -LTTNG_ERR_FILTER_INVAL;
 		goto parse_error;
 	}
 	dbg_printf("done\n");
@@ -826,7 +902,7 @@ int lttng_set_event_filter(struct lttng_handle *handle,
 	fflush(stdout);
 	ret = filter_visitor_ir_check_binary_op_nesting(ctx);
 	if (ret) {
-		ret = -EINVAL;
+		ret = -LTTNG_ERR_FILTER_INVAL;
 		goto parse_error;
 	}
 	dbg_printf("done\n");
@@ -836,7 +912,7 @@ int lttng_set_event_filter(struct lttng_handle *handle,
 	ret = filter_visitor_bytecode_generate(ctx);
 	if (ret) {
 		fprintf(stderr, "Generate bytecode error\n");
-		ret = -EINVAL;
+		ret = -LTTNG_ERR_FILTER_INVAL;
 		goto parse_error;
 	}
 	dbg_printf("done\n");
@@ -851,8 +927,10 @@ int lttng_set_event_filter(struct lttng_handle *handle,
 	copy_string(lsm.u.filter.channel_name, channel_name,
 			sizeof(lsm.u.filter.channel_name));
 	/* Copy event name */
-	copy_string(lsm.u.filter.event_name, event_name,
-			sizeof(lsm.u.filter.event_name));
+	if (event) {
+		memcpy(&lsm.u.enable.event, event, sizeof(lsm.u.enable.event));
+	}
+
 	lsm.u.filter.bytecode_len = sizeof(ctx->bytecode->b)
 			+ bytecode_get_len(&ctx->bytecode->b);
 
@@ -895,7 +973,7 @@ int lttng_disable_event(struct lttng_handle *handle, const char *name,
 	struct lttcomm_session_msg lsm;
 
 	if (handle == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	memset(&lsm, 0, sizeof(lsm));
@@ -936,7 +1014,7 @@ int lttng_enable_channel(struct lttng_handle *handle,
 	 * NULL arguments are forbidden. No default values.
 	 */
 	if (handle == NULL || chan == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	memset(&lsm, 0, sizeof(lsm));
@@ -963,7 +1041,7 @@ int lttng_disable_channel(struct lttng_handle *handle, const char *name)
 
 	/* Safety check. Both are mandatory */
 	if (handle == NULL || name == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	memset(&lsm, 0, sizeof(lsm));
@@ -994,7 +1072,7 @@ int lttng_list_tracepoints(struct lttng_handle *handle,
 	struct lttcomm_session_msg lsm;
 
 	if (handle == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_LIST_TRACEPOINTS;
@@ -1021,7 +1099,7 @@ int lttng_list_tracepoint_fields(struct lttng_handle *handle,
 	struct lttcomm_session_msg lsm;
 
 	if (handle == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_LIST_TRACEPOINT_FIELDS;
@@ -1056,7 +1134,7 @@ int lttng_create_session(const char *name, const char *url)
 	struct lttng_uri *uris = NULL;
 
 	if (name == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	memset(&lsm, 0, sizeof(lsm));
@@ -1067,7 +1145,7 @@ int lttng_create_session(const char *name, const char *url)
 	/* There should never be a data URL */
 	size = parse_str_urls_to_uri(url, NULL, &uris);
 	if (size < 0) {
-		return LTTNG_ERR_INVALID;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.u.uri.size = size;
@@ -1085,7 +1163,7 @@ int lttng_destroy_session(const char *session_name)
 	struct lttcomm_session_msg lsm;
 
 	if (session_name == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_DESTROY_SESSION;
@@ -1128,7 +1206,7 @@ int lttng_list_domains(const char *session_name,
 	struct lttcomm_session_msg lsm;
 
 	if (session_name == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_LIST_DOMAINS;
@@ -1156,7 +1234,7 @@ int lttng_list_channels(struct lttng_handle *handle,
 	struct lttcomm_session_msg lsm;
 
 	if (handle == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_LIST_CHANNELS;
@@ -1187,7 +1265,7 @@ int lttng_list_events(struct lttng_handle *handle,
 
 	/* Safety check. An handle and channel name are mandatory */
 	if (handle == NULL || channel_name == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_LIST_EVENTS;
@@ -1214,11 +1292,11 @@ int lttng_list_events(struct lttng_handle *handle,
 int lttng_set_tracing_group(const char *name)
 {
 	if (name == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	if (asprintf(&tracing_group, "%s", name) < 0) {
-		return -ENOMEM;
+		return -LTTNG_ERR_FATAL;
 	}
 
 	return 0;
@@ -1234,7 +1312,7 @@ int lttng_calibrate(struct lttng_handle *handle,
 
 	/* Safety check. NULL pointer are forbidden */
 	if (handle == NULL || calibrate == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_CALIBRATE;
@@ -1265,7 +1343,7 @@ void lttng_channel_set_default_attr(struct lttng_domain *domain,
 		attr->switch_timer_interval = DEFAULT_CHANNEL_SWITCH_TIMER;
 		attr->read_timer_interval = DEFAULT_CHANNEL_READ_TIMER;
 
-		attr->subbuf_size = DEFAULT_KERNEL_CHANNEL_SUBBUF_SIZE;
+		attr->subbuf_size = default_get_kernel_channel_subbuf_size();
 		attr->num_subbuf = DEFAULT_KERNEL_CHANNEL_SUBBUF_NUM;
 		attr->output = DEFAULT_KERNEL_CHANNEL_OUTPUT;
 		break;
@@ -1279,7 +1357,7 @@ void lttng_channel_set_default_attr(struct lttng_domain *domain,
 		attr->switch_timer_interval = DEFAULT_CHANNEL_SWITCH_TIMER;
 		attr->read_timer_interval = DEFAULT_CHANNEL_READ_TIMER;
 
-		attr->subbuf_size = DEFAULT_UST_CHANNEL_SUBBUF_SIZE;
+		attr->subbuf_size = default_get_ust_channel_subbuf_size();
 		attr->num_subbuf = DEFAULT_UST_CHANNEL_SUBBUF_NUM;
 		attr->output = DEFAULT_UST_CHANNEL_OUTPUT;
 		break;
@@ -1306,8 +1384,11 @@ int lttng_session_daemon_alive(void)
 	}
 
 	if (strlen(sessiond_sock_path) == 0) {
-		/* No socket path set. Weird error */
-		return -1;
+		/*
+		 * No socket path set. Weird error which means the constructor was not
+		 * called.
+		 */
+		assert(0);
 	}
 
 	ret = try_connect_sessiond(sessiond_sock_path);
@@ -1333,7 +1414,7 @@ int lttng_set_consumer_url(struct lttng_handle *handle,
 	struct lttng_uri *uris = NULL;
 
 	if (handle == NULL || (control_url == NULL && data_url == NULL)) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	memset(&lsm, 0, sizeof(lsm));
@@ -1346,7 +1427,7 @@ int lttng_set_consumer_url(struct lttng_handle *handle,
 
 	size = parse_str_urls_to_uri(control_url, data_url, &uris);
 	if (size < 0) {
-		return LTTNG_ERR_INVALID;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.u.uri.size = size;
@@ -1365,7 +1446,7 @@ int lttng_enable_consumer(struct lttng_handle *handle)
 	struct lttcomm_session_msg lsm;
 
 	if (handle == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_ENABLE_CONSUMER;
@@ -1387,7 +1468,7 @@ int lttng_disable_consumer(struct lttng_handle *handle)
 	struct lttcomm_session_msg lsm;
 
 	if (handle == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.cmd_type = LTTNG_DISABLE_CONSUMER;
@@ -1449,11 +1530,9 @@ static int set_health_socket_path(void)
 /*
  * Check session daemon health for a specific health component.
  *
- * Return 0 if health is OK or else 1 if BAD. A return value of -1 indicate
- * that the control library was not able to connect to the session daemon
- * health socket.
+ * Return 0 if health is OK or else 1 if BAD.
  *
- * Any other positive value is an lttcomm error which can be translate with
+ * Any other negative value is a lttng error code which can be translated with
  * lttng_strerror().
  */
 int lttng_health_check(enum lttng_health_component c)
@@ -1465,7 +1544,7 @@ int lttng_health_check(enum lttng_health_component c)
 	/* Connect to the sesssion daemon */
 	sock = lttcomm_connect_unix_sock(health_sock_path);
 	if (sock < 0) {
-		ret = -1;
+		ret = -LTTNG_ERR_NO_SESSIOND;
 		goto error;
 	}
 
@@ -1474,11 +1553,13 @@ int lttng_health_check(enum lttng_health_component c)
 
 	ret = lttcomm_send_unix_sock(sock, (void *)&msg, sizeof(msg));
 	if (ret < 0) {
+		ret = -LTTNG_ERR_FATAL;
 		goto close_error;
 	}
 
 	ret = lttcomm_recv_unix_sock(sock, (void *)&reply, sizeof(reply));
 	if (ret < 0) {
+		ret = -LTTNG_ERR_FATAL;
 		goto close_error;
 	}
 
@@ -1518,37 +1599,28 @@ int _lttng_create_session_ext(const char *name, const char *url,
 	struct lttng_uri *uris = NULL;
 
 	if (name == NULL || datetime == NULL) {
-		return -1;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	memset(&lsm, 0, sizeof(lsm));
 
 	lsm.cmd_type = LTTNG_CREATE_SESSION;
-	if (!strncmp(name, DEFAULT_SESSION_NAME, strlen(DEFAULT_SESSION_NAME))) {
-		ret = snprintf(lsm.session.name, sizeof(lsm.session.name), "%s-%s",
-				name, datetime);
-		if (ret < 0) {
-			PERROR("snprintf session name datetime");
-			return -1;
-		}
-	} else {
-		copy_string(lsm.session.name, name, sizeof(lsm.session.name));
-	}
+	copy_string(lsm.session.name, name, sizeof(lsm.session.name));
 
 	/* There should never be a data URL */
 	size = parse_str_urls_to_uri(url, NULL, &uris);
 	if (size < 0) {
-		return LTTNG_ERR_INVALID;
+		return -LTTNG_ERR_INVALID;
 	}
 
 	lsm.u.uri.size = size;
 
-	if (uris[0].dtype != LTTNG_DST_PATH && strlen(uris[0].subdir) == 0) {
+	if (size > 0 && uris[0].dtype != LTTNG_DST_PATH && strlen(uris[0].subdir) == 0) {
 		ret = snprintf(uris[0].subdir, sizeof(uris[0].subdir), "%s-%s", name,
 				datetime);
 		if (ret < 0) {
 			PERROR("snprintf uri subdir");
-			return -1;
+			return -LTTNG_ERR_FATAL;
 		}
 	}
 
@@ -1556,6 +1628,38 @@ int _lttng_create_session_ext(const char *name, const char *url,
 			NULL);
 }
 
+/*
+ * For a given session name, this call checks if the data is ready to be read
+ * or is still being extracted by the consumer(s) hence not ready to be used by
+ * any readers.
+ */
+int lttng_data_pending(const char *session_name)
+{
+	int ret;
+	struct lttcomm_session_msg lsm;
+
+	if (session_name == NULL) {
+		return -LTTNG_ERR_INVALID;
+	}
+
+	lsm.cmd_type = LTTNG_DATA_PENDING;
+
+	copy_string(lsm.session.name, session_name, sizeof(lsm.session.name));
+
+	ret = ask_sessiond(&lsm, NULL);
+
+	/*
+	 * The ask_sessiond function negate the return code if it's not LTTNG_OK so
+	 * getting -1 means that the reply ret_code was 1 thus meaning that the
+	 * data is available. Yes it is hackish but for now this is the only way.
+	 */
+	if (ret == -1) {
+		ret = 1;
+	}
+
+	return ret;
+}
+
 /*
  * lib constructor
  */
@@ -1566,3 +1670,11 @@ static void __attribute__((constructor)) init()
 	/* Set socket for health check */
 	(void) set_health_socket_path();
 }
+
+/*
+ * lib destructor
+ */
+static void __attribute__((destructor)) lttng_ctl_exit()
+{
+	free(tracing_group);
+}