X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Flib%2Flttng-ctl%2Ffilter%2Ffilter-visitor-generate-bytecode.c;h=0e778562f99ab606f7f988dd4a16673a9c666e81;hp=1ab98138e61e16f4120f3be7ae508b518dac65cc;hb=73e38068d5e19fd338f29e897598b15ab5ae743b;hpb=116d3c01872d62ee86bdbd0aea575b12fbc9c272

diff --git a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
index 1ab98138e..0e778562f 100644
--- a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
+++ b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c
@@ -295,6 +295,9 @@ int visit_node_load_expression_legacy(struct filter_parser_ctx *ctx,
 	}
 	ret = bytecode_push(&ctx->bytecode_reloc, symbol,
 				1, strlen(symbol) + 1);
+	if (ret) {
+		goto end;
+	}
 	ret = 1;	/* legacy */
 end:
 	free(insn);
@@ -319,6 +322,10 @@ int visit_node_load_expression(struct filter_parser_ctx *ctx,
 		return -EINVAL;
 	}
 
+	/*
+	 * TODO: if we remove legacy load for application contexts, we
+	 * need to update session bytecode parser as well.
+	 */
 	ret = visit_node_load_expression_legacy(ctx, exp, op);
 	if (ret < 0) {
 		return ret;