X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fcommon%2Fsessiond-comm%2Fsessiond-comm.c;fp=src%2Fcommon%2Fsessiond-comm%2Fsessiond-comm.c;h=aa24e82ddff31d80f6d0d15fe969aca8dc80f49e;hp=8a5ff1d3f10520efb26bef784dc7847fd7fba033;hb=e71aad1fa4b06a5f91ddceace42366f3d79bd77e;hpb=4c462e790c62ed5f6c5d61b3a182762fe02f7e9a

diff --git a/src/common/sessiond-comm/sessiond-comm.c b/src/common/sessiond-comm/sessiond-comm.c
index 8a5ff1d3f..aa24e82dd 100644
--- a/src/common/sessiond-comm/sessiond-comm.c
+++ b/src/common/sessiond-comm/sessiond-comm.c
@@ -24,7 +24,6 @@
 #include <string.h>
 #include <sys/stat.h>
 #include <sys/types.h>
-#include <sys/un.h>
 #include <unistd.h>
 #include <errno.h>
 
@@ -418,7 +417,7 @@ ssize_t lttcomm_recv_fds_unix_sock(int sock, int *fds, size_t nb_fd)
 	}
 	if (cmsg->cmsg_len != CMSG_LEN(sizeof_fds)) {
 		fprintf(stderr, "Error: Received %zu bytes of ancillary data, expected %zu\n",
-				cmsg->cmsg_len, CMSG_LEN(sizeof_fds));
+				(size_t) cmsg->cmsg_len, (size_t) CMSG_LEN(sizeof_fds));
 		ret = -1;
 		goto end;
 	}
@@ -436,12 +435,14 @@ end:
 ssize_t lttcomm_send_creds_unix_sock(int sock, void *buf, size_t len)
 {
 	struct msghdr msg;
-	struct cmsghdr *cmptr;
 	struct iovec iov[1];
 	ssize_t ret = -1;
-	struct ucred *creds;
-	size_t sizeof_cred = sizeof(struct ucred);
+#ifdef __linux__
+	struct cmsghdr *cmptr;
+	size_t sizeof_cred = sizeof(lttng_sock_cred);
 	char anc_buf[CMSG_SPACE(sizeof_cred)];
+	lttng_sock_cred *creds;
+#endif /* __linux__ */
 
 	memset(&msg, 0, sizeof(msg));
 
@@ -450,19 +451,21 @@ ssize_t lttcomm_send_creds_unix_sock(int sock, void *buf, size_t len)
 	msg.msg_iov = iov;
 	msg.msg_iovlen = 1;
 
+#ifdef __linux__
 	msg.msg_control = (caddr_t) anc_buf;
 	msg.msg_controllen = CMSG_LEN(sizeof_cred);
 
 	cmptr = CMSG_FIRSTHDR(&msg);
 	cmptr->cmsg_level = SOL_SOCKET;
-	cmptr->cmsg_type = SCM_CREDENTIALS;
+	cmptr->cmsg_type = LTTNG_SOCK_CREDS;
 	cmptr->cmsg_len = CMSG_LEN(sizeof_cred);
 
-	creds = (struct ucred *) CMSG_DATA(cmptr);
+	creds = (lttng_sock_cred*) CMSG_DATA(cmptr);
 
-	creds->uid = geteuid();
-	creds->gid = getegid();
-	creds->pid = getpid();
+	LTTNG_SOCK_SET_UID_CRED(creds, geteuid());
+	LTTNG_SOCK_SET_GID_CRED(creds, getegid());
+	LTTNG_SOCK_SET_PID_CRED(creds, getpid());
+#endif /* __linux__ */
 
 	ret = sendmsg(sock, &msg, 0);
 	if (ret < 0) {
@@ -478,14 +481,16 @@ ssize_t lttcomm_send_creds_unix_sock(int sock, void *buf, size_t len)
  * Returns the size of received data, or negative error value.
  */
 ssize_t lttcomm_recv_creds_unix_sock(int sock, void *buf, size_t len,
-		struct ucred *creds)
+		lttng_sock_cred *creds)
 {
 	struct msghdr msg;
-	struct cmsghdr *cmptr;
 	struct iovec iov[1];
 	ssize_t ret;
-	size_t sizeof_cred = sizeof(struct ucred);
+#ifdef __linux__
+	struct cmsghdr *cmptr;
+	size_t sizeof_cred = sizeof(lttng_sock_cred);
 	char anc_buf[CMSG_SPACE(sizeof_cred)];
+#endif	/* __linux__ */
 
 	memset(&msg, 0, sizeof(msg));
 
@@ -501,8 +506,10 @@ ssize_t lttcomm_recv_creds_unix_sock(int sock, void *buf, size_t len,
 	msg.msg_iov = iov;
 	msg.msg_iovlen = 1;
 
+#ifdef __linux__
 	msg.msg_control = anc_buf;
 	msg.msg_controllen = sizeof(anc_buf);
+#endif /* __linux__ */
 
 	ret = recvmsg(sock, &msg, 0);
 	if (ret < 0) {
@@ -510,6 +517,7 @@ ssize_t lttcomm_recv_creds_unix_sock(int sock, void *buf, size_t len,
 		goto end;
 	}
 
+#ifdef __linux__
 	if (msg.msg_flags & MSG_CTRUNC) {
 		fprintf(stderr, "Error: Control message truncated.\n");
 		ret = -1;
@@ -524,7 +532,7 @@ ssize_t lttcomm_recv_creds_unix_sock(int sock, void *buf, size_t len,
 	}
 
 	if (cmptr->cmsg_level != SOL_SOCKET ||
-			cmptr->cmsg_type != SCM_CREDENTIALS) {
+			cmptr->cmsg_type != LTTNG_SOCK_CREDS) {
 		fprintf(stderr, "Didn't received any credentials\n");
 		ret = -1;
 		goto end;
@@ -532,12 +540,24 @@ ssize_t lttcomm_recv_creds_unix_sock(int sock, void *buf, size_t len,
 
 	if (cmptr->cmsg_len != CMSG_LEN(sizeof_cred)) {
 		fprintf(stderr, "Error: Received %zu bytes of ancillary data, expected %zu\n",
-				cmptr->cmsg_len, CMSG_LEN(sizeof_cred));
+				(size_t) cmptr->cmsg_len, (size_t) CMSG_LEN(sizeof_cred));
 		ret = -1;
 		goto end;
 	}
 
 	memcpy(creds, CMSG_DATA(cmptr), sizeof_cred);
+#elif defined(__FreeBSD__)
+	{
+		int peer_ret;
+
+		peer_ret = getpeereid(sock, &creds->uid, &creds->gid);
+		if (peer_ret != 0) {
+			return peer_ret;
+		}
+	}
+#else
+#error "Please implement credential support for your OS."
+#endif	/* __linux__ */
 
 end:
 	return ret;
@@ -546,6 +566,7 @@ end:
 /*
  * Set socket option to use credentials passing.
  */
+#ifdef __linux__
 int lttcomm_setsockopt_creds_unix_sock(int sock)
 {
 	int ret, on = 1;
@@ -555,6 +576,13 @@ int lttcomm_setsockopt_creds_unix_sock(int sock)
 	if (ret < 0) {
 		PERROR("setsockopt creds unix sock");
 	}
-
 	return ret;
 }
+#elif defined(__FreeBSD__)
+int lttcomm_setsockopt_creds_unix_sock(int sock)
+{
+	return 0;
+}
+#else
+#error "Please implement credential support for your OS."
+#endif /* __linux__ */