X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fcommon%2Fcondition.c;h=6cebeb03f7bb9d35e651a9a110bb36f087cfd1fe;hp=60d32e6cc7816c461dd0f9a0bdee6340e3ea1e45;hb=6c2fe31927dd91be5a75702cd5399fd3aa04174f;hpb=e8360425c2fd0f8cfef1e678af5adfde7ae0a68e

diff --git a/src/common/condition.c b/src/common/condition.c
index 60d32e6cc..6cebeb03f 100644
--- a/src/common/condition.c
+++ b/src/common/condition.c
@@ -63,32 +63,29 @@ end:
 }
 
 LTTNG_HIDDEN
-ssize_t lttng_condition_serialize(const struct lttng_condition *condition,
-		char *buf)
+int lttng_condition_serialize(const struct lttng_condition *condition,
+		struct lttng_dynamic_buffer *buf)
 {
-	ssize_t ret, condition_size;
-	struct lttng_condition_comm condition_comm = {
-		.condition_type = (int8_t) (condition ?
-				condition->type : LTTNG_CONDITION_TYPE_UNKNOWN)
-	};
+	int ret;
+	struct lttng_condition_comm condition_comm = { 0 };
 
 	if (!condition) {
 		ret = -1;
 		goto end;
 	}
 
-	ret = sizeof(struct lttng_condition_comm);
-	if (buf) {
-		memcpy(buf, &condition_comm, ret);
-		buf += ret;
+	condition_comm.condition_type = (int8_t) condition->type;
+
+	ret = lttng_dynamic_buffer_append(buf, &condition_comm,
+			sizeof(condition_comm));
+	if (ret) {
+		goto end;
 	}
 
-	condition_size = condition->serialize(condition, buf);
-	if (condition_size < 0) {
-		ret = condition_size;
+	ret = condition->serialize(condition, buf);
+	if (ret) {
 		goto end;
 	}
-	ret += condition_size;
 end:
 	return ret;
 }
@@ -107,6 +104,11 @@ bool lttng_condition_is_equal(const struct lttng_condition *a,
 		goto end;
 	}
 
+	if (a == b) {
+		is_equal = true;
+		goto end;
+	}
+
 	is_equal = a->equal ? a->equal(a, b) : true;
 end:
 	return is_equal;