X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fcommands%2Fview.c;h=a2623fe49e0ccb66b4baecbf1f27552d22ffad43;hp=a13cb352510da0e3f2b60cc9a8c74f2b62f66870;hb=ce0b1d61919f37517a6212f7af2afe0fa1b1dcb0;hpb=8bf4946c164913124dc634eca8942c1f2c2fdd89 diff --git a/src/bin/lttng/commands/view.c b/src/bin/lttng/commands/view.c index a13cb3525..a2623fe49 100644 --- a/src/bin/lttng/commands/view.c +++ b/src/bin/lttng/commands/view.c @@ -1,18 +1,8 @@ /* - * Copyright (C) 2011 - David Goulet + * Copyright (C) 2011 David Goulet * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License, version 2 only, - * as published by the Free Software Foundation. + * SPDX-License-Identifier: GPL-2.0-only * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #define _LGPL_SOURCE @@ -24,12 +14,12 @@ #include #include +#include #include "../command.h" static char *opt_session_name; static char *opt_viewer; static char *opt_trace_path; -static const char *babeltrace_bin = CONFIG_BABELTRACE_BIN; #ifdef LTTNG_EMBED_HELP static const char help_msg[] = @@ -51,218 +41,9 @@ static struct poptOption long_options[] = { {0, 0, 0, 0, 0, 0, 0} }; -/* - * This is needed for each viewer since we are using execvp(). - */ -static const char *babeltrace_opts[] = { "babeltrace" }; - -/* - * Type is also use as the index in the viewers array. So please, make sure - * your enum value is in the right order in the array below. - */ -enum viewer_type { - VIEWER_BABELTRACE = 0, - VIEWER_USER_DEFINED = 1, -}; - -/* - * NOTE: "lttv" is a shell command and it's not working for exec() family - * functions so we might think of removing this wrapper or using bash. - */ -static const struct viewers { - const char *exec_name; - enum viewer_type type; -} viewers[] = { - { "babeltrace", VIEWER_BABELTRACE }, - { NULL, VIEWER_USER_DEFINED }, -}; - /* Is the session we are trying to view is in live mode. */ static int session_live_mode; -static const struct viewers *parse_options(void) -{ - if (opt_viewer == NULL) { - /* Default is babeltrace */ - return &(viewers[VIEWER_BABELTRACE]); - } - - /* - * This means that if -e, --viewers is used, we just override everything - * with it. For supported viewers like lttv, we could simply detect if "-t" - * is passed and if not, add the trace directory to it. - */ - return &(viewers[VIEWER_USER_DEFINED]); -} - -/* - * Alloc an array of string pointer from a simple string having all options - * seperated by spaces. Also adds the trace path to the arguments. - * - * The returning pointer is ready to be passed to execvp(). - */ -static char **alloc_argv_from_user_opts(char *opts, const char *trace_path) -{ - int i = 0, ignore_space = 0; - unsigned int num_opts = 1; - char **argv, *token = opts; - - /* Count number of arguments. */ - do { - if (*token == ' ') { - /* Use to ignore consecutive spaces */ - if (!ignore_space) { - num_opts++; - } - ignore_space = 1; - } else { - ignore_space = 0; - } - token++; - } while (*token != '\0'); - - /* Add two here for the NULL terminating element and trace path */ - argv = zmalloc(sizeof(char *) * (num_opts + 2)); - if (argv == NULL) { - goto error; - } - - token = strtok(opts, " "); - while (token != NULL) { - argv[i] = strdup(token); - if (argv[i] == NULL) { - goto error; - } - token = strtok(NULL, " "); - i++; - } - - argv[num_opts] = (char *) trace_path; - argv[num_opts + 1] = NULL; - - return argv; - -error: - if (argv) { - for (i = 0; i < num_opts + 2; i++) { - free(argv[i]); - } - free(argv); - } - - return NULL; -} - -/* - * Alloc an array of string pointer from an array of strings. It also adds - * the trace path to the argv. - * - * The returning pointer is ready to be passed to execvp(). - */ -static char **alloc_argv_from_local_opts(const char **opts, size_t opts_len, - const char *trace_path) -{ - char **argv; - size_t size, mem_len; - - /* Add one for the NULL terminating element. */ - mem_len = opts_len + 1; - if (session_live_mode) { - /* Add 3 option for the live mode being "-i lttng-live URL". */ - mem_len += 3; - } else { - /* Add option for the trace path. */ - mem_len += 1; - } - - size = sizeof(char *) * mem_len; - - /* Add two here for the trace_path and the NULL terminating element. */ - argv = zmalloc(size); - if (argv == NULL) { - goto error; - } - - memcpy(argv, opts, sizeof(char *) * opts_len); - - if (session_live_mode) { - argv[opts_len] = "-i"; - argv[opts_len + 1] = "lttng-live"; - argv[opts_len + 2] = (char *) trace_path; - argv[opts_len + 3] = NULL; - } else { - argv[opts_len] = (char *) trace_path; - argv[opts_len + 1] = NULL; - } - -error: - return argv; -} - -/* - * Spawn viewer with the trace directory path. - */ -static int spawn_viewer(const char *trace_path) -{ - int ret = 0; - struct stat status; - const char *viewer_bin = NULL; - const struct viewers *viewer; - char **argv = NULL; - - /* Check for --viewer options */ - viewer = parse_options(); - if (viewer == NULL) { - ret = CMD_ERROR; - goto error; - } - - switch (viewer->type) { - case VIEWER_BABELTRACE: - if (stat(babeltrace_bin, &status) == 0) { - viewer_bin = babeltrace_bin; - } else { - viewer_bin = viewer->exec_name; - } - argv = alloc_argv_from_local_opts(babeltrace_opts, - ARRAY_SIZE(babeltrace_opts), trace_path); - break; - case VIEWER_USER_DEFINED: - argv = alloc_argv_from_user_opts(opt_viewer, trace_path); - if (argv) { - viewer_bin = argv[0]; - } - break; - default: - viewer_bin = viewers[VIEWER_BABELTRACE].exec_name; - argv = alloc_argv_from_local_opts(babeltrace_opts, - ARRAY_SIZE(babeltrace_opts), trace_path); - break; - } - - if (argv == NULL || !viewer_bin) { - ret = CMD_FATAL; - goto error; - } - - DBG("Using %s viewer", viewer_bin); - - ret = execvp(viewer_bin, argv); - if (ret) { - if (errno == ENOENT) { - ERR("%s not found on the system", viewer_bin); - } else { - PERROR("exec: %s", viewer_bin); - } - ret = CMD_FATAL; - goto error; - } - -error: - free(argv); - return ret; -} - /* * Build the live path we need for the lttng live view. */ @@ -270,7 +51,7 @@ static char *build_live_path(char *session_name) { int ret; char *path = NULL; - char hostname[HOST_NAME_MAX]; + char hostname[LTTNG_HOST_NAME_MAX]; ret = gethostname(hostname, sizeof(hostname)); if (ret < 0) { @@ -386,7 +167,7 @@ static int view_trace(void) MSG("Trace directory: %s\n", trace_path); - ret = spawn_viewer(trace_path); + ret = spawn_viewer(trace_path, opt_viewer, session_live_mode); if (ret < 0) { /* Don't set ret so lttng can interpret the sessiond error. */ goto free_sessions;