X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fcommands%2Fview.c;h=1a9ad6c3a3868978467563b791cff34a133f6b35;hp=0dd1623ea1f7dd5db575a60e550a482d583f411c;hb=a85cae2bef6e4583072236c71770d4244ec5cf9d;hpb=ab5be9fa2eb5ba9600a82cd18fd3cfcbac69169a diff --git a/src/bin/lttng/commands/view.c b/src/bin/lttng/commands/view.c index 0dd1623ea..1a9ad6c3a 100644 --- a/src/bin/lttng/commands/view.c +++ b/src/bin/lttng/commands/view.c @@ -58,10 +58,6 @@ enum viewer_type { VIEWER_USER_DEFINED = 2, }; -/* - * NOTE: "lttv" is a shell command and it's not working for exec() family - * functions so we might think of removing this wrapper or using bash. - */ static const struct viewers { const char *exec_name; enum viewer_type type; @@ -81,11 +77,6 @@ static const struct viewers *parse_options(void) return &(viewers[VIEWER_BABELTRACE2]); } - /* - * This means that if -e, --viewers is used, we just override everything - * with it. For supported viewers like lttv, we could simply detect if "-t" - * is passed and if not, add the trace directory to it. - */ return &(viewers[VIEWER_USER_DEFINED]); } @@ -180,8 +171,8 @@ static char **alloc_argv_from_local_opts(const char **opts, size_t opts_len, memcpy(argv, opts, sizeof(char *) * opts_len); if (session_live_mode) { - argv[opts_len] = "-i"; - argv[opts_len + 1] = "lttng-live"; + argv[opts_len] = (char *) "-i"; + argv[opts_len + 1] = (char *) "lttng-live"; argv[opts_len + 2] = (char *) trace_path; argv[opts_len + 3] = NULL; } else {