X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fcommands%2Fcreate.c;h=08b12a46eee2b95e6093f738a97a5b0f01936551;hp=96bb184a7bd63a7c654604326ef50e13a23e3f3b;hb=04965770958ef684f0e40d948264dc3283b4bcdc;hpb=f73fabfda365d22e7dd180fb1614e37c446fbd9e diff --git a/src/bin/lttng/commands/create.c b/src/bin/lttng/commands/create.c index 96bb184a7..08b12a46e 100644 --- a/src/bin/lttng/commands/create.c +++ b/src/bin/lttng/commands/create.c @@ -271,13 +271,17 @@ static int create_session(void) PERROR("snprintf session name"); goto error; } - session_name = strdup(DEFAULT_SESSION_NAME); - if (session_name == NULL) { - PERROR("strdup session name"); - goto error; - } + session_name = session_name_date; DBG("Auto session name set to %s", session_name_date); } else { + if (strncmp(opt_session_name, DEFAULT_SESSION_NAME, + strlen(DEFAULT_SESSION_NAME)) == 0 && + strlen(opt_session_name) == strlen(DEFAULT_SESSION_NAME)) { + ERR("%s is a reserved keyword for default session(s)", + DEFAULT_SESSION_NAME); + ret = CMD_ERROR; + goto error; + } session_name = opt_session_name; ret = snprintf(session_name_date, sizeof(session_name_date), "%s-%s", session_name, datetime); @@ -345,11 +349,7 @@ static int create_session(void) goto error; } - if (opt_session_name == NULL) { - MSG("Session %s created.", session_name_date); - } else { - MSG("Session %s created.", session_name); - } + MSG("Session %s created.", session_name); MSG("Traces will be written in %s", print_str_url); if (opt_ctrl_url || opt_data_url) { @@ -372,11 +372,6 @@ static int create_session(void) } } - if (opt_session_name == NULL) { - free(session_name); - session_name = session_name_date; - } - /* Init lttng session config */ ret = config_init(session_name); if (ret < 0) { @@ -388,10 +383,6 @@ static int create_session(void) ret = CMD_SUCCESS; error: - if (opt_session_name == NULL && session_name != session_name_date) { - free(session_name); - } - if (alloc_url) { free(alloc_url); } @@ -399,6 +390,7 @@ error: if (traces_path) { free(traces_path); } + free(alloc_path); if (ret < 0) { ERR("%s", lttng_strerror(ret));