X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fcommands%2Fadd_trigger.c;h=b1ec6dd4780b11008a9583765b7ade979207e7d0;hp=af58d7b316d604cc3839780fdd22d758b79f64f4;hb=481c5310f698d32187c0f20bd0d1da3b8b696b06;hpb=665db06360d2bb830a47a2562ef0ebc28a1d75df

diff --git a/src/bin/lttng/commands/add_trigger.c b/src/bin/lttng/commands/add_trigger.c
index af58d7b31..b1ec6dd47 100644
--- a/src/bin/lttng/commands/add_trigger.c
+++ b/src/bin/lttng/commands/add_trigger.c
@@ -40,28 +40,19 @@ enum {
 	OPT_CONDITION,
 	OPT_ACTION,
 	OPT_ID,
-	OPT_USER_ID,
+	OPT_OWNER_UID,
 	OPT_RATE_POLICY,
 
-	OPT_ALL,
+	OPT_NAME,
 	OPT_FILTER,
-	OPT_EXCLUDE,
-	OPT_LOGLEVEL,
-	OPT_LOGLEVEL_ONLY,
-
-	OPT_USERSPACE,
-	OPT_KERNEL,
-	OPT_LOG4J,
-	OPT_JUL,
-	OPT_PYTHON,
-
-	OPT_FUNCTION,
-	OPT_PROBE,
-	OPT_USERSPACE_PROBE,
-	OPT_SYSCALL,
-	OPT_TRACEPOINT,
+	OPT_EXCLUDE_NAMES,
+	OPT_EVENT_NAME,
+	OPT_LOG_LEVEL,
+
+	OPT_DOMAIN,
+	OPT_TYPE,
+	OPT_LOCATION,
 
-	OPT_NAME,
 	OPT_MAX_SIZE,
 	OPT_DATA_URL,
 	OPT_CTRL_URL,
@@ -72,25 +63,15 @@ enum {
 };
 
 static const struct argpar_opt_descr event_rule_opt_descrs[] = {
-	{ OPT_ALL, 'a', "all", false },
 	{ OPT_FILTER, 'f', "filter", true },
-	{ OPT_EXCLUDE, 'x', "exclude", true },
-	{ OPT_LOGLEVEL, '\0', "loglevel", true },
-	{ OPT_LOGLEVEL_ONLY, '\0', "loglevel-only", true },
-
-	/* Domains */
-	{ OPT_USERSPACE, 'u', "userspace", false },
-	{ OPT_KERNEL, 'k', "kernel", false },
-	{ OPT_LOG4J, 'l', "log4j", false },
-	{ OPT_JUL, 'j', "jul", false },
-	{ OPT_PYTHON, 'p', "python", false },
-
-	/* Event rule types */
-	{ OPT_FUNCTION, '\0', "function", true },
-	{ OPT_PROBE, '\0', "probe", true },
-	{ OPT_USERSPACE_PROBE, '\0', "userspace-probe", true },
-	{ OPT_SYSCALL, '\0', "syscall" },
-	{ OPT_TRACEPOINT, '\0', "tracepoint" },
+	{ OPT_NAME, 'n', "name", true },
+	{ OPT_EXCLUDE_NAMES, 'x', "exclude-names", true },
+	{ OPT_LOG_LEVEL, 'l', "log-level", true },
+	{ OPT_EVENT_NAME, 'E', "event-name", true },
+
+	{ OPT_DOMAIN, 'd', "domain", true },
+	{ OPT_TYPE, 't', "type", true },
+	{ OPT_LOCATION, 'L', "location", true },
 
 	/* Capture descriptor */
 	{ OPT_CAPTURE, '\0', "capture", true },
@@ -99,36 +80,72 @@ static const struct argpar_opt_descr event_rule_opt_descrs[] = {
 };
 
 static
-bool assign_domain_type(enum lttng_domain_type *dest,
-		enum lttng_domain_type src)
+bool assign_domain_type(enum lttng_domain_type *dest, const char *arg)
 {
 	bool ret;
 
-	if (*dest == LTTNG_DOMAIN_NONE || *dest == src) {
-		*dest = src;
-		ret = true;
+	if (*dest != LTTNG_DOMAIN_NONE) {
+		ERR("More than one `--domain` was specified.");
+		goto error;
+	}
+
+	if (strcmp(arg, "kernel") == 0) {
+		*dest = LTTNG_DOMAIN_KERNEL;
+	} else if (strcmp(arg, "user") == 0 || strcmp(arg, "userspace") == 0) {
+		*dest = LTTNG_DOMAIN_UST;
+	} else if (strcmp(arg, "jul") == 0) {
+		*dest = LTTNG_DOMAIN_JUL;
+	} else if (strcmp(arg, "log4j") == 0) {
+		*dest = LTTNG_DOMAIN_LOG4J;
+	} else if (strcmp(arg, "python") == 0) {
+		*dest = LTTNG_DOMAIN_PYTHON;
 	} else {
-		ERR("Multiple domains specified.");
-		ret = false;
+		ERR("Invalid `--domain` value: %s", arg);
+		goto error;
 	}
 
+	ret = true;
+	goto end;
+
+error:
+	ret = false;
+
+end:
 	return ret;
 }
 
 static
-bool assign_event_rule_type(enum lttng_event_rule_type *dest,
-		enum lttng_event_rule_type src)
+bool assign_event_rule_type(enum lttng_event_rule_type *dest, const char *arg)
 {
 	bool ret;
 
-	if (*dest == LTTNG_EVENT_RULE_TYPE_UNKNOWN || *dest == src) {
-		*dest = src;
-		ret = true;
+	if (*dest != LTTNG_EVENT_RULE_TYPE_UNKNOWN) {
+		ERR("More than one `--type` was specified.");
+		goto error;
+	}
+
+	if (strcmp(arg, "tracepoint") == 0 || strcmp(arg, "logging") == 0) {
+		*dest = LTTNG_EVENT_RULE_TYPE_TRACEPOINT;
+	} else if (strcmp (arg, "kprobe") == 0 || strcmp(arg, "kernel-probe") == 0) {
+		*dest = LTTNG_EVENT_RULE_TYPE_KERNEL_PROBE;
+	} else if (strcmp (arg, "uprobe") == 0 || strcmp(arg, "userspace-probe") == 0) {
+		*dest = LTTNG_EVENT_RULE_TYPE_USERSPACE_PROBE;
+	} else if (strcmp (arg, "function") == 0) {
+		*dest = LTTNG_EVENT_RULE_TYPE_KERNEL_FUNCTION;
+	} else if (strcmp (arg, "syscall") == 0) {
+		*dest = LTTNG_EVENT_RULE_TYPE_SYSCALL;
 	} else {
-		ERR("Multiple event types specified.");
-		ret = false;
+		ERR("Invalid `--type` value: %s", arg);
+		goto error;
 	}
 
+	ret = true;
+	goto end;
+
+error:
+	ret = false;
+
+end:
 	return ret;
 }
 
@@ -165,45 +182,108 @@ int create_exclusion_list_and_validate(const char *event_name,
 		char ***exclusion_list);
 
 /*
- * Parse `str` as a log level in domain `domain_type`. Return -1 if the string
- * is not recognized as a valid log level.
+ * Parse `str` as a log level in domain `domain_type`.
+ *
+ * Return the log level in `*log_level`.  Return true in `*log_level_only` if
+ * the string specifies exactly this log level, false if it specifies at least
+ * this log level.
+ *
+ * Return true if the string was successfully parsed as a log level string.
  */
-static
-int parse_loglevel_string(const char *str, enum lttng_domain_type domain_type)
+static bool parse_log_level_string(const char *str,
+		enum lttng_domain_type domain_type,
+		int *log_level,
+		bool *log_level_only)
 {
+	bool ret;
+
 	switch (domain_type) {
 	case LTTNG_DOMAIN_UST:
 	{
-		enum lttng_loglevel loglevel;
-		const int ret = loglevel_name_to_value(str, &loglevel);
+		enum lttng_loglevel log_level_min, log_level_max;
+		if (!loglevel_parse_range_string(
+				    str, &log_level_min, &log_level_max)) {
+			goto error;
+		}
+
+		/* Only support VAL and VAL.. for now. */
+		if (log_level_min != log_level_max &&
+				log_level_max != LTTNG_LOGLEVEL_EMERG) {
+			goto error;
+		}
 
-		return ret == -1 ? ret : (int) loglevel;
+		*log_level = (int) log_level_min;
+		*log_level_only = log_level_min == log_level_max;
+		break;
 	}
 	case LTTNG_DOMAIN_LOG4J:
 	{
-		enum lttng_loglevel_log4j loglevel;
-		const int ret = loglevel_log4j_name_to_value(str, &loglevel);
+		enum lttng_loglevel_log4j log_level_min, log_level_max;
+		if (!loglevel_log4j_parse_range_string(
+				    str, &log_level_min, &log_level_max)) {
+			goto error;
+		}
+
+		/* Only support VAL and VAL.. for now. */
+		if (log_level_min != log_level_max &&
+				log_level_max != LTTNG_LOGLEVEL_LOG4J_FATAL) {
+			goto error;
+		}
 
-		return ret == -1 ? ret : (int) loglevel;
+		*log_level = (int) log_level_min;
+		*log_level_only = log_level_min == log_level_max;
+		break;
 	}
 	case LTTNG_DOMAIN_JUL:
 	{
-		enum lttng_loglevel_jul loglevel;
-		const int ret = loglevel_jul_name_to_value(str, &loglevel);
+		enum lttng_loglevel_jul log_level_min, log_level_max;
+		if (!loglevel_jul_parse_range_string(
+				    str, &log_level_min, &log_level_max)) {
+			goto error;
+		}
 
-		return ret == -1 ? ret : (int) loglevel;
+		/* Only support VAL and VAL.. for now. */
+		if (log_level_min != log_level_max &&
+				log_level_max != LTTNG_LOGLEVEL_JUL_SEVERE) {
+			goto error;
+		}
+
+		*log_level = (int) log_level_min;
+		*log_level_only = log_level_min == log_level_max;
+		break;
 	}
 	case LTTNG_DOMAIN_PYTHON:
 	{
-		enum lttng_loglevel_python loglevel;
-		const int ret = loglevel_python_name_to_value(str, &loglevel);
+		enum lttng_loglevel_python log_level_min, log_level_max;
+		if (!loglevel_python_parse_range_string(
+				    str, &log_level_min, &log_level_max)) {
+			goto error;
+		}
 
-		return ret == -1 ? ret : (int) loglevel;
+		/* Only support VAL and VAL.. for now. */
+		if (log_level_min != log_level_max &&
+				log_level_max !=
+						LTTNG_LOGLEVEL_PYTHON_CRITICAL) {
+			goto error;
+		}
+
+		*log_level = (int) log_level_min;
+		*log_level_only = log_level_min == log_level_max;
+		break;
 	}
 	default:
 		/* Invalid domain type. */
 		abort();
 	}
+
+	ret = true;
+	goto end;
+
+error:
+	ret = false;
+
+end:
+	return ret;
 }
 
 static int parse_kernel_probe_opts(const char *source,
@@ -542,25 +622,20 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 	struct filter_parser_ctx *parser_ctx = NULL;
 	struct lttng_log_level_rule *log_level_rule = NULL;
 
-	/* Was the -a/--all flag provided? */
-	bool all_events = false;
-
-	/* Tracepoint name (non-option argument). */
-	const char *tracepoint_name = NULL;
+	/* Tracepoint and syscall options. */
+	char *name = NULL;
+	char *exclude_names = NULL;
+	char **exclusion_list = NULL;
 
-	/* Holds the argument of --probe / --userspace-probe. */
-	char *source = NULL;
+	/* For userspace / kernel probe and function. */
+	char *location = NULL;
+	char *event_name = NULL;
 
 	/* Filter. */
 	char *filter = NULL;
 
-	/* Exclude. */
-	char *exclude = NULL;
-	char **exclusion_list = NULL;
-
 	/* Log level. */
-	char *loglevel_str = NULL;
-	bool loglevel_only = false;
+	char *log_level_str = NULL;
 
 	lttng_dynamic_pointer_array_init(&res.capture_descriptors,
 				destroy_event_expr);
@@ -593,107 +668,64 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 
 			switch (item_opt->descr->id) {
 			/* Domains. */
-			case OPT_USERSPACE:
-				if (!assign_domain_type(&domain_type, LTTNG_DOMAIN_UST)) {
-					goto error;
-				}
-
-				break;
-			case OPT_KERNEL:
-				if (!assign_domain_type(&domain_type, LTTNG_DOMAIN_KERNEL)) {
-					goto error;
-				}
-
-				break;
-			case OPT_LOG4J:
-				if (!assign_domain_type(&domain_type, LTTNG_DOMAIN_LOG4J)) {
-					goto error;
-				}
-
-				break;
-			case OPT_JUL:
-				if (!assign_domain_type(&domain_type, LTTNG_DOMAIN_JUL)) {
+			case OPT_DOMAIN:
+				if (!assign_domain_type(&domain_type,
+						item_opt->arg)) {
 					goto error;
 				}
 
 				break;
-			case OPT_PYTHON:
-				if (!assign_domain_type(&domain_type, LTTNG_DOMAIN_PYTHON)) {
-					goto error;
-				}
-
-				break;
-
-			/* Event rule types */
-			case OPT_FUNCTION:
+			case OPT_TYPE:
 				if (!assign_event_rule_type(&event_rule_type,
-						LTTNG_EVENT_RULE_TYPE_KERNEL_FUNCTION)) {
+						item_opt->arg)) {
 					goto error;
 				}
 
 				break;
-			case OPT_PROBE:
-				if (!assign_event_rule_type(&event_rule_type,
-						LTTNG_EVENT_RULE_TYPE_KERNEL_PROBE)) {
-					goto error;
-				}
-
-				if (!assign_string(&source, item_opt->arg, "source")) {
+			case OPT_LOCATION:
+				if (!assign_string(&location,
+						item_opt->arg,
+						"--location/-L")) {
 					goto error;
 				}
 
 				break;
-			case OPT_USERSPACE_PROBE:
-				if (!assign_event_rule_type(&event_rule_type,
-						LTTNG_EVENT_RULE_TYPE_USERSPACE_PROBE)) {
-					goto error;
-				}
-
-				if (!assign_string(&source, item_opt->arg, "source")) {
-						goto error;
-				}
-
-				break;
-			case OPT_SYSCALL:
-				if (!assign_event_rule_type(&event_rule_type,
-						LTTNG_EVENT_RULE_TYPE_SYSCALL)) {
+			case OPT_EVENT_NAME:
+				if (!assign_string(&event_name,
+						    item_opt->arg,
+						    "--event-name/-E")) {
 					goto error;
 				}
 
 				break;
-			case OPT_TRACEPOINT:
-				if (!assign_event_rule_type(&event_rule_type,
-						LTTNG_EVENT_RULE_TYPE_TRACEPOINT)) {
+			case OPT_FILTER:
+				if (!assign_string(&filter, item_opt->arg,
+						    "--filter/-f")) {
 					goto error;
 				}
 
 				break;
-			case OPT_ALL:
-				all_events = true;
-				break;
-			case OPT_FILTER:
-				if (!assign_string(&filter, item_opt->arg,
-						    "--filter/-f")) {
+			case OPT_NAME:
+				if (!assign_string(&name, item_opt->arg,
+						    "--name/-n")) {
 					goto error;
 				}
 
 				break;
-			case OPT_EXCLUDE:
-				if (!assign_string(&exclude, item_opt->arg,
-						    "--exclude/-x")) {
+			case OPT_EXCLUDE_NAMES:
+				if (!assign_string(&exclude_names,
+						    item_opt->arg,
+						    "--exclude-names/-x")) {
 					goto error;
 				}
 
 				break;
-			case OPT_LOGLEVEL:
-			case OPT_LOGLEVEL_ONLY:
-				if (!assign_string(&loglevel_str, item_opt->arg,
-						    "--loglevel/--loglevel-only")) {
+			case OPT_LOG_LEVEL:
+				if (!assign_string(&log_level_str,
+						    item_opt->arg, "--log-level/-l")) {
 					goto error;
 				}
 
-				loglevel_only = item_opt->descr->id ==
-						OPT_LOGLEVEL_ONLY;
 				break;
 			case OPT_CAPTURE:
 			{
@@ -742,17 +774,9 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 					(const struct argpar_item_non_opt *)
 							item;
 
-			/*
-			 * Don't accept two non-option arguments/tracepoint
-			 * names.
-			 */
-			if (tracepoint_name) {
-				ERR("Unexpected argument '%s'",
-						item_non_opt->arg);
-				goto error;
-			}
-
-			tracepoint_name = item_non_opt->arg;
+			/* Don't accept non-option arguments. */
+			ERR("Unexpected argument '%s'", item_non_opt->arg);
+			goto error;
 		}
 	}
 
@@ -761,44 +785,70 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 	}
 
 	/*
-	 * Option -a is applicable to event rules of type tracepoint and
-	 * syscall, and it is equivalent to using "*" as the tracepoint name.
+	 * Option --name is applicable to event rules of type tracepoint
+	 * and syscall.  For tracepoint and syscall rules, if --name is
+	 * omitted, it is implicitly "*".
 	 */
-	if (all_events) {
-		switch (event_rule_type) {
-		case LTTNG_EVENT_RULE_TYPE_TRACEPOINT:
-		case LTTNG_EVENT_RULE_TYPE_SYSCALL:
-			break;
-		default:
-			ERR("Can't use -a/--all with %s event rules.",
-					lttng_event_rule_type_str(event_rule_type));
-			goto error;
+	switch (event_rule_type) {
+	case LTTNG_EVENT_RULE_TYPE_TRACEPOINT:
+	case LTTNG_EVENT_RULE_TYPE_SYSCALL:
+		if (!name) {
+			name = strdup("*");
 		}
+		break;
 
-		if (tracepoint_name) {
-			ERR("Can't provide a tracepoint name with -a/--all.");
+	default:
+		if (name) {
+			ERR("Can't use --name with %s event rules.",
+					lttng_event_rule_type_str(
+							event_rule_type));
 			goto error;
 		}
 
-		/* In which case, it's equivalent to tracepoint name "*". */
-		tracepoint_name = "*";
+		if (exclude_names) {
+			ERR("Can't use --exclude-names/-x with %s event rules.",
+					lttng_event_rule_type_str(
+							event_rule_type));
+			goto error;
+		}
 	}
 
 	/*
-	 * A tracepoint name (or -a, for the event rule types that accept it)
-	 * is required.
+	 * Option --location is only applicable to (and mandatory for) event
+	 * rules of type {k,u}probe and function.
+	 *
+	 * Option --event-name is only applicable to event rules of type probe.
+	 * If omitted, it defaults to the location.
 	 */
-	if (!tracepoint_name) {
-		ERR("Need to provide either a tracepoint name or -a/--all.");
-		goto error;
-	}
+	switch (event_rule_type) {
+	case LTTNG_EVENT_RULE_TYPE_KERNEL_PROBE:
+	case LTTNG_EVENT_RULE_TYPE_USERSPACE_PROBE:
+	case LTTNG_EVENT_RULE_TYPE_KERNEL_FUNCTION:
+		if (!location) {
+			ERR("Event rule of type %s requires a --location.",
+			lttng_event_rule_type_str(event_rule_type));
+			goto error;
+		}
 
-	/*
-	 * We don't support multiple tracepoint names for now.
-	 */
-	if (strchr(tracepoint_name, ',')) {
-		ERR("Comma separated tracepoint names are not supported.");
-		goto error;
+		if (!event_name) {
+			event_name = strdup(location);
+		}
+
+		break;
+
+	default:
+		if (location) {
+			ERR("Can't use --location with %s event rules.",
+			lttng_event_rule_type_str(event_rule_type));
+			goto error;
+		}
+
+		if (event_name) {
+			ERR("Can't use --event-name with %s event rules.",
+					lttng_event_rule_type_str(
+							event_rule_type));
+			goto error;
+		}
 	}
 
 	/*
@@ -811,7 +861,7 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 
 	/* Need to specify a domain. */
 	if (domain_type == LTTNG_DOMAIN_NONE) {
-		ERR("Please specify a domain (--kernel/--userspace/--jul/--log4j/--python).");
+		ERR("Please specify a domain (--domain=(kernel,user,jul,log4j,python)).");
 		goto error;
 	}
 
@@ -852,24 +902,30 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 	}
 
 	/* If --exclude/-x was passed, split it into an exclusion list. */
-	if (exclude) {
+	if (exclude_names) {
 		if (domain_type != LTTNG_DOMAIN_UST) {
 			ERR("Event name exclusions are not yet implemented for %s event rules.",
 					get_domain_str(domain_type));
 			goto error;
 		}
 
-
-		if (create_exclusion_list_and_validate(tracepoint_name, exclude,
-				&exclusion_list) != 0) {
+		if (create_exclusion_list_and_validate(name,
+				    exclude_names, &exclusion_list) != 0) {
 			ERR("Failed to create exclusion list.");
 			goto error;
 		}
 	}
 
-	if (loglevel_str && event_rule_type != LTTNG_EVENT_RULE_TYPE_TRACEPOINT) {
-		ERR("Log levels are only applicable to tracepoint event rules.");
-		goto error;
+	if (log_level_str) {
+		if (event_rule_type != LTTNG_EVENT_RULE_TYPE_TRACEPOINT) {
+			ERR("Log levels are only applicable to tracepoint event rules.");
+			goto error;
+		}
+
+		if (domain_type == LTTNG_DOMAIN_KERNEL) {
+			ERR("Log levels are not supported by the kernel tracer.");
+			goto error;
+		}
 	}
 
 	/* Finally, create the event rule object. */
@@ -886,10 +942,10 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 
 		/* Set pattern. */
 		event_rule_status = lttng_event_rule_tracepoint_set_pattern(
-				res.er, tracepoint_name);
+				res.er, name);
 		if (event_rule_status != LTTNG_EVENT_RULE_STATUS_OK) {
 			ERR("Failed to set tracepoint event rule's pattern to '%s'.",
-					tracepoint_name);
+					name);
 			goto error;
 		}
 
@@ -921,26 +977,25 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 			}
 		}
 
-		if (loglevel_str) {
-			int loglevel;
-
-			if (domain_type == LTTNG_DOMAIN_KERNEL) {
-				ERR("Log levels are not supported by the kernel tracer.");
-				goto error;
-			}
-
-			loglevel = parse_loglevel_string(
-					loglevel_str, domain_type);
-			if (loglevel < 0) {
-				ERR("Failed to parse `%s` as a log level.",
-						loglevel_str);
+		/*
+		 * ".." is the same as passing no log level option and
+		 * correspond the the "ANY" case.
+		 */
+		if (log_level_str && strcmp(log_level_str, "..") != 0) {
+			int log_level;
+			bool log_level_only;
+
+			if (!parse_log_level_string(log_level_str, domain_type,
+					    &log_level, &log_level_only)) {
+				ERR("Failed to parse log level string `%s`.",
+						log_level_str);
 				goto error;
 			}
 
-			if (loglevel_only) {
-				log_level_rule = lttng_log_level_rule_exactly_create(loglevel);
+			if (log_level_only) {
+				log_level_rule = lttng_log_level_rule_exactly_create(log_level);
 			} else {
-				log_level_rule = lttng_log_level_rule_at_least_as_severe_as_create(loglevel);
+				log_level_rule = lttng_log_level_rule_at_least_as_severe_as_create(log_level);
 			}
 
 			if (log_level_rule == NULL) {
@@ -965,8 +1020,8 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 		int ret;
 		enum lttng_event_rule_status event_rule_status;
 
-
-		ret = parse_kernel_probe_opts(source, &kernel_probe_location);
+		ret = parse_kernel_probe_opts(
+				location, &kernel_probe_location);
 		if (ret) {
 			ERR("Failed to parse kernel probe location.");
 			goto error;
@@ -979,9 +1034,12 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 			goto error;
 		}
 
-		event_rule_status = lttng_event_rule_kernel_probe_set_event_name(res.er, tracepoint_name);
+		event_rule_status =
+				lttng_event_rule_kernel_probe_set_event_name(
+						res.er, event_name);
 		if (event_rule_status != LTTNG_EVENT_RULE_STATUS_OK) {
-			ERR("Failed to set kprobe event rule's name to '%s'.", tracepoint_name);
+			ERR("Failed to set kprobe event rule's name to '%s'.",
+					event_name);
 			goto error;
 		}
 
@@ -993,7 +1051,7 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 		enum lttng_event_rule_status event_rule_status;
 
 		ret = parse_userspace_probe_opts(
-				source, &userspace_probe_location);
+				location, &userspace_probe_location);
 		if (ret) {
 			ERR("Failed to parse user space probe location.");
 			goto error;
@@ -1005,11 +1063,12 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 			goto error;
 		}
 
-		event_rule_status = lttng_event_rule_userspace_probe_set_event_name(
-				res.er, tracepoint_name);
+		event_rule_status =
+				lttng_event_rule_userspace_probe_set_event_name(
+						res.er, event_name);
 		if (event_rule_status != LTTNG_EVENT_RULE_STATUS_OK) {
 			ERR("Failed to set user space probe event rule's name to '%s'.",
-					tracepoint_name);
+					event_name);
 			goto error;
 		}
 
@@ -1026,10 +1085,10 @@ struct parse_event_rule_res parse_event_rule(int *argc, const char ***argv)
 		}
 
 		event_rule_status = lttng_event_rule_syscall_set_pattern(
-				res.er, tracepoint_name);
+				res.er, name);
 		if (event_rule_status != LTTNG_EVENT_RULE_STATUS_OK) {
 			ERR("Failed to set syscall event rule's pattern to '%s'.",
-					tracepoint_name);
+					name);
 			goto error;
 		}
 
@@ -1067,9 +1126,12 @@ end:
 	free(error);
 	argpar_state_destroy(state);
 	free(filter);
-	free(exclude);
-	free(loglevel_str);
-	free(source);
+	free(name);
+	free(exclude_names);
+	free(log_level_str);
+	free(location);
+	free(event_name);
+
 	strutils_free_null_terminated_array_of_strings(exclusion_list);
 	lttng_kernel_probe_location_destroy(kernel_probe_location);
 	lttng_userspace_probe_location_destroy(userspace_probe_location);
@@ -2027,7 +2089,7 @@ struct argpar_opt_descr add_trigger_options[] = {
 	{ OPT_CONDITION, '\0', "condition", true },
 	{ OPT_ACTION, '\0', "action", true },
 	{ OPT_NAME, '\0', "name", true },
-	{ OPT_USER_ID, '\0', "user-id", true },
+	{ OPT_OWNER_UID, '\0', "owner-uid", true },
 	ARGPAR_OPT_DESCR_SENTINEL,
 };
 
@@ -2054,7 +2116,7 @@ int cmd_add_trigger(int argc, const char **argv)
 	char *error = NULL;
 	char *name = NULL;
 	int i;
-	char *user_id = NULL;
+	char *owner_uid = NULL;
 
 	lttng_dynamic_pointer_array_init(&actions, lttng_actions_destructor);
 
@@ -2160,10 +2222,10 @@ int cmd_add_trigger(int argc, const char **argv)
 
 			break;
 		}
-		case OPT_USER_ID:
+		case OPT_OWNER_UID:
 		{
-			if (!assign_string(&user_id, item_opt->arg,
-					"--user-id")) {
+			if (!assign_string(&owner_uid, item_opt->arg,
+					"--owner-uid")) {
 				goto error;
 			}
 
@@ -2222,15 +2284,15 @@ int cmd_add_trigger(int argc, const char **argv)
 		}
 	}
 
-	if (user_id) {
+	if (owner_uid) {
 		enum lttng_trigger_status trigger_status;
 		char *end;
 		long long uid;
 
 		errno = 0;
-		uid = strtol(user_id, &end, 10);
-		if (end == user_id || *end != '\0' || errno != 0) {
-			ERR("Failed to parse `%s` as a user id.", user_id);
+		uid = strtol(owner_uid, &end, 10);
+		if (end == owner_uid || *end != '\0' || errno != 0) {
+			ERR("Failed to parse `%s` as a user id.", owner_uid);
 		}
 
 		trigger_status = lttng_trigger_set_owner_uid(trigger, uid);
@@ -2263,6 +2325,6 @@ end:
 	lttng_trigger_destroy(trigger);
 	free(error);
 	free(name);
-	free(user_id);
+	free(owner_uid);
 	return ret;
 }