X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Ftrace-ust.c;h=f64f51c280d670b9b83070abb6e2666d97ce51e2;hp=a6c0c04ad864075d64cbf0c8dba6b66e96ce21cc;hb=55c9e7cac24318259d4f2549c97f7577b7b52db4;hpb=a8c3ad3e850d45026f22ecdc7ea963b7e923bd08

diff --git a/src/bin/lttng-sessiond/trace-ust.c b/src/bin/lttng-sessiond/trace-ust.c
index a6c0c04ad..f64f51c28 100644
--- a/src/bin/lttng-sessiond/trace-ust.c
+++ b/src/bin/lttng-sessiond/trace-ust.c
@@ -281,7 +281,7 @@ struct ltt_ust_session *trace_ust_create_session(uint64_t session_id)
 	lus = zmalloc(sizeof(struct ltt_ust_session));
 	if (lus == NULL) {
 		PERROR("create ust session zmalloc");
-		goto error;
+		goto error_alloc;
 	}
 
 	/* Init data structure */
@@ -313,20 +313,35 @@ struct ltt_ust_session *trace_ust_create_session(uint64_t session_id)
 	/* Alloc agent hash table. */
 	lus->agents = lttng_ht_new(0, LTTNG_HT_TYPE_U64);
 
+	lus->tracker_list_vpid = lttng_tracker_list_create();
+	if (!lus->tracker_list_vpid) {
+		goto error;
+	}
+	lus->tracker_list_vuid = lttng_tracker_list_create();
+	if (!lus->tracker_list_vuid) {
+		goto error;
+	}
+	lus->tracker_list_vgid = lttng_tracker_list_create();
+	if (!lus->tracker_list_vgid) {
+		goto error;
+	}
 	lus->consumer = consumer_create_output(CONSUMER_DST_LOCAL);
 	if (lus->consumer == NULL) {
-		goto error_consumer;
+		goto error;
 	}
 
 	DBG2("UST trace session create successful");
 
 	return lus;
 
-error_consumer:
+error:
+	lttng_tracker_list_destroy(lus->tracker_list_vpid);
+	lttng_tracker_list_destroy(lus->tracker_list_vuid);
+	lttng_tracker_list_destroy(lus->tracker_list_vgid);
 	ht_cleanup_push(lus->domain_global.channels);
 	ht_cleanup_push(lus->agents);
 	free(lus);
-error:
+error_alloc:
 	return NULL;
 }
 
@@ -719,29 +734,25 @@ error:
 	return NULL;
 }
 
-static
-void destroy_pid_tracker_node_rcu(struct rcu_head *head)
+static void destroy_id_tracker_node_rcu(struct rcu_head *head)
 {
-	struct ust_pid_tracker_node *tracker_node =
-		caa_container_of(head, struct ust_pid_tracker_node, node.head);
+	struct ust_id_tracker_node *tracker_node = caa_container_of(
+			head, struct ust_id_tracker_node, node.head);
 	free(tracker_node);
 }
 
-static
-void destroy_pid_tracker_node(struct ust_pid_tracker_node *tracker_node)
+static void destroy_id_tracker_node(struct ust_id_tracker_node *tracker_node)
 {
-
-	call_rcu(&tracker_node->node.head, destroy_pid_tracker_node_rcu);
+	call_rcu(&tracker_node->node.head, destroy_id_tracker_node_rcu);
 }
 
-static
-int init_pid_tracker(struct ust_pid_tracker *pid_tracker)
+static int init_id_tracker(struct ust_id_tracker *id_tracker)
 {
-	int ret = 0;
+	int ret = LTTNG_OK;
 
-	pid_tracker->ht = lttng_ht_new(0, LTTNG_HT_TYPE_ULONG);
-	if (!pid_tracker->ht) {
-		ret = -1;
+	id_tracker->ht = lttng_ht_new(0, LTTNG_HT_TYPE_ULONG);
+	if (!id_tracker->ht) {
+		ret = LTTNG_ERR_NOMEM;
 		goto end;
 	}
 
@@ -750,63 +761,60 @@ end:
 }
 
 /*
- * Teardown pid tracker content, but don't free pid_tracker object.
+ * Teardown id tracker content, but don't free id_tracker object.
  */
-static
-void fini_pid_tracker(struct ust_pid_tracker *pid_tracker)
+static void fini_id_tracker(struct ust_id_tracker *id_tracker)
 {
-	struct ust_pid_tracker_node *tracker_node;
+	struct ust_id_tracker_node *tracker_node;
 	struct lttng_ht_iter iter;
 
-	if (!pid_tracker->ht) {
+	if (!id_tracker->ht) {
 		return;
 	}
 	rcu_read_lock();
-	cds_lfht_for_each_entry(pid_tracker->ht->ht,
-			&iter.iter, tracker_node, node.node) {
-		int ret = lttng_ht_del(pid_tracker->ht, &iter);
+	cds_lfht_for_each_entry (id_tracker->ht->ht, &iter.iter, tracker_node,
+			node.node) {
+		int ret = lttng_ht_del(id_tracker->ht, &iter);
 
 		assert(!ret);
-		destroy_pid_tracker_node(tracker_node);
+		destroy_id_tracker_node(tracker_node);
 	}
 	rcu_read_unlock();
-	ht_cleanup_push(pid_tracker->ht);
-	pid_tracker->ht = NULL;
+	ht_cleanup_push(id_tracker->ht);
+	id_tracker->ht = NULL;
 }
 
-static
-struct ust_pid_tracker_node *pid_tracker_lookup(
-		struct ust_pid_tracker *pid_tracker, int pid,
+static struct ust_id_tracker_node *id_tracker_lookup(
+		struct ust_id_tracker *id_tracker,
+		int id,
 		struct lttng_ht_iter *iter)
 {
-	unsigned long _pid = (unsigned long) pid;
+	unsigned long _id = (unsigned long) id;
 	struct lttng_ht_node_ulong *node;
 
-	lttng_ht_lookup(pid_tracker->ht, (void *) _pid, iter);
+	lttng_ht_lookup(id_tracker->ht, (void *) _id, iter);
 	node = lttng_ht_iter_get_node_ulong(iter);
 	if (node) {
-		return caa_container_of(node, struct ust_pid_tracker_node,
-			node);
+		return caa_container_of(node, struct ust_id_tracker_node, node);
 	} else {
 		return NULL;
 	}
 }
 
-static
-int pid_tracker_add_pid(struct ust_pid_tracker *pid_tracker, int pid)
+static int id_tracker_add_id(struct ust_id_tracker *id_tracker, int id)
 {
 	int retval = LTTNG_OK;
-	struct ust_pid_tracker_node *tracker_node;
+	struct ust_id_tracker_node *tracker_node;
 	struct lttng_ht_iter iter;
 
-	if (pid < 0) {
+	if (id < 0) {
 		retval = LTTNG_ERR_INVALID;
 		goto end;
 	}
-	tracker_node = pid_tracker_lookup(pid_tracker, pid, &iter);
+	tracker_node = id_tracker_lookup(id_tracker, id, &iter);
 	if (tracker_node) {
 		/* Already exists. */
-		retval = LTTNG_ERR_PID_TRACKED;
+		retval = LTTNG_ERR_ID_TRACKED;
 		goto end;
 	}
 	tracker_node = zmalloc(sizeof(*tracker_node));
@@ -814,48 +822,85 @@ int pid_tracker_add_pid(struct ust_pid_tracker *pid_tracker, int pid)
 		retval = LTTNG_ERR_NOMEM;
 		goto end;
 	}
-	lttng_ht_node_init_ulong(&tracker_node->node, (unsigned long) pid);
-	lttng_ht_add_unique_ulong(pid_tracker->ht, &tracker_node->node);
+	lttng_ht_node_init_ulong(&tracker_node->node, (unsigned long) id);
+	lttng_ht_add_unique_ulong(id_tracker->ht, &tracker_node->node);
 end:
 	return retval;
 }
 
-static
-int pid_tracker_del_pid(struct ust_pid_tracker *pid_tracker, int pid)
+static int id_tracker_del_id(struct ust_id_tracker *id_tracker, int id)
 {
 	int retval = LTTNG_OK, ret;
-	struct ust_pid_tracker_node *tracker_node;
+	struct ust_id_tracker_node *tracker_node;
 	struct lttng_ht_iter iter;
 
-	if (pid < 0) {
+	if (id < 0) {
 		retval = LTTNG_ERR_INVALID;
 		goto end;
 	}
-	tracker_node = pid_tracker_lookup(pid_tracker, pid, &iter);
+	tracker_node = id_tracker_lookup(id_tracker, id, &iter);
 	if (!tracker_node) {
 		/* Not found */
-		retval = LTTNG_ERR_PID_NOT_TRACKED;
+		retval = LTTNG_ERR_ID_NOT_TRACKED;
 		goto end;
 	}
-	ret = lttng_ht_del(pid_tracker->ht, &iter);
+	ret = lttng_ht_del(id_tracker->ht, &iter);
 	assert(!ret);
 
-	destroy_pid_tracker_node(tracker_node);
+	destroy_id_tracker_node(tracker_node);
 end:
 	return retval;
 }
 
+static struct ust_id_tracker *get_id_tracker(struct ltt_ust_session *session,
+		enum lttng_tracker_type tracker_type)
+{
+	switch (tracker_type) {
+	case LTTNG_TRACKER_VPID:
+		return &session->vpid_tracker;
+	case LTTNG_TRACKER_VUID:
+		return &session->vuid_tracker;
+	case LTTNG_TRACKER_VGID:
+		return &session->vgid_tracker;
+	default:
+		return NULL;
+	}
+}
+
+static struct lttng_tracker_list *get_id_tracker_list(
+		struct ltt_ust_session *session,
+		enum lttng_tracker_type tracker_type)
+{
+	switch (tracker_type) {
+	case LTTNG_TRACKER_VPID:
+		return session->tracker_list_vpid;
+	case LTTNG_TRACKER_VUID:
+		return session->tracker_list_vuid;
+	case LTTNG_TRACKER_VGID:
+		return session->tracker_list_vgid;
+	default:
+		return NULL;
+	}
+}
+
 /*
  * The session lock is held when calling this function.
  */
-int trace_ust_pid_tracker_lookup(struct ltt_ust_session *session, int pid)
+int trace_ust_id_tracker_lookup(enum lttng_tracker_type tracker_type,
+		struct ltt_ust_session *session,
+		int id)
 {
 	struct lttng_ht_iter iter;
+	struct ust_id_tracker *id_tracker;
 
-	if (!session->pid_tracker.ht) {
+	id_tracker = get_id_tracker(session, tracker_type);
+	if (!id_tracker) {
+		abort();
+	}
+	if (!id_tracker->ht) {
 		return 1;
 	}
-	if (pid_tracker_lookup(&session->pid_tracker, pid, &iter)) {
+	if (id_tracker_lookup(id_tracker, id, &iter)) {
 		return 1;
 	}
 	return 0;
@@ -864,47 +909,84 @@ int trace_ust_pid_tracker_lookup(struct ltt_ust_session *session, int pid)
 /*
  * Called with the session lock held.
  */
-int trace_ust_track_pid(struct ltt_ust_session *session, int pid)
+int trace_ust_track_id(enum lttng_tracker_type tracker_type,
+		struct ltt_ust_session *session,
+		const struct lttng_tracker_id *id)
 {
 	int retval = LTTNG_OK;
 	bool should_update_apps = false;
+	struct ust_id_tracker *id_tracker;
+	struct lttng_tracker_list *tracker_list;
+	int value;
+	struct lttng_tracker_id *saved_ids;
+	ssize_t saved_ids_count, i;
+
+	if (tracker_type == LTTNG_TRACKER_PID) {
+		DBG("Backward compatible behavior: translate PID tracker to VPID tracker for UST domain.");
+		tracker_type = LTTNG_TRACKER_VPID;
+	}
 
-	if (pid == -1) {
-		/* Track all pids: destroy tracker if exists. */
-		if (session->pid_tracker.ht) {
-			fini_pid_tracker(&session->pid_tracker);
+	retval = lttng_tracker_id_lookup_string(tracker_type, id, &value);
+	if (retval != LTTNG_OK) {
+		return retval;
+	}
+	tracker_list = get_id_tracker_list(session, tracker_type);
+	if (!tracker_list) {
+		return LTTNG_ERR_INVALID;
+	}
+	/* Save list for restore on error. */
+	saved_ids_count = lttng_tracker_id_get_list(tracker_list, &saved_ids);
+	if (saved_ids_count < 0) {
+		return LTTNG_ERR_INVALID;
+	}
+	/* Add to list. */
+	retval = lttng_tracker_list_add(tracker_list, id);
+	if (retval != LTTNG_OK) {
+		goto end;
+	}
+
+	id_tracker = get_id_tracker(session, tracker_type);
+	if (!id_tracker) {
+		abort();
+	}
+	if (value == -1) {
+		/* Track all ids: destroy tracker if exists. */
+		if (id_tracker->ht) {
+			fini_id_tracker(id_tracker);
 			/* Ensure all apps have session. */
 			should_update_apps = true;
 		}
 	} else {
-		int ret;
-
-		if (!session->pid_tracker.ht) {
+		if (!id_tracker->ht) {
 			/* Create tracker. */
-			if (init_pid_tracker(&session->pid_tracker)) {
-				ERR("Error initializing PID tracker");
-				retval = LTTNG_ERR_NOMEM;
-				goto end;
+			retval = init_id_tracker(id_tracker);
+			if (retval != LTTNG_OK) {
+				ERR("Error initializing ID tracker");
+				goto end_restore;
 			}
-			ret = pid_tracker_add_pid(&session->pid_tracker, pid);
-			if (ret != LTTNG_OK) {
-				retval = ret;
-				fini_pid_tracker(&session->pid_tracker);
-				goto end;
+			retval = id_tracker_add_id(id_tracker, value);
+			if (retval != LTTNG_OK) {
+				fini_id_tracker(id_tracker);
+				goto end_restore;
 			}
 			/* Remove all apps from session except pid. */
 			should_update_apps = true;
 		} else {
 			struct ust_app *app;
 
-			ret = pid_tracker_add_pid(&session->pid_tracker, pid);
-			if (ret != LTTNG_OK) {
-				retval = ret;
-				goto end;
+			retval = id_tracker_add_id(id_tracker, value);
+			if (retval != LTTNG_OK) {
+				goto end_restore;
 			}
 			/* Add session to application */
-			app = ust_app_find_by_pid(pid);
-			if (app) {
+			switch (tracker_type) {
+			case LTTNG_TRACKER_VPID:
+				app = ust_app_find_by_pid(value);
+				if (app) {
+					should_update_apps = true;
+				}
+				break;
+			default:
 				should_update_apps = true;
 			}
 		}
@@ -912,104 +994,145 @@ int trace_ust_track_pid(struct ltt_ust_session *session, int pid)
 	if (should_update_apps && session->active) {
 		ust_app_global_update_all(session);
 	}
+	goto end;
+
+end_restore:
+	if (lttng_tracker_id_set_list(tracker_list, saved_ids,
+			    saved_ids_count) != LTTNG_OK) {
+		ERR("Error on tracker add error handling.\n");
+	}
 end:
+	for (i = 0; i < saved_ids_count; i++) {
+		free(saved_ids[i].string);
+	}
+	free(saved_ids);
 	return retval;
 }
 
 /*
  * Called with the session lock held.
  */
-int trace_ust_untrack_pid(struct ltt_ust_session *session, int pid)
+int trace_ust_untrack_id(enum lttng_tracker_type tracker_type,
+		struct ltt_ust_session *session,
+		const struct lttng_tracker_id *id)
 {
 	int retval = LTTNG_OK;
 	bool should_update_apps = false;
+	struct ust_id_tracker *id_tracker;
+	struct lttng_tracker_list *tracker_list;
+	int value;
+	struct lttng_tracker_id *saved_ids;
+	ssize_t saved_ids_count, i;
+
+	if (tracker_type == LTTNG_TRACKER_PID) {
+		DBG("Backward compatible behavior: translate PID tracker to VPID tracker for UST domain.");
+		tracker_type = LTTNG_TRACKER_VPID;
+	}
+
+	retval = lttng_tracker_id_lookup_string(tracker_type, id, &value);
+	if (retval != LTTNG_OK) {
+		return retval;
+	}
+
+	tracker_list = get_id_tracker_list(session, tracker_type);
+	if (!tracker_list) {
+		return LTTNG_ERR_INVALID;
+	}
+	/* Save list for restore on error. */
+	saved_ids_count = lttng_tracker_id_get_list(tracker_list, &saved_ids);
+	if (saved_ids_count < 0) {
+		return LTTNG_ERR_INVALID;
+	}
+	/* Remove from list. */
+	retval = lttng_tracker_list_remove(tracker_list, id);
+	if (retval != LTTNG_OK) {
+		goto end;
+	}
 
-	if (pid == -1) {
+	id_tracker = get_id_tracker(session, tracker_type);
+	if (!id_tracker) {
+		abort();
+	}
+
+	if (value == -1) {
 		/* Create empty tracker, replace old tracker. */
-		struct ust_pid_tracker tmp_tracker;
+		struct ust_id_tracker tmp_tracker;
 
-		tmp_tracker = session->pid_tracker;
-		if (init_pid_tracker(&session->pid_tracker)) {
-			ERR("Error initializing PID tracker");
-			retval = LTTNG_ERR_NOMEM;
+		tmp_tracker = *id_tracker;
+		retval = init_id_tracker(id_tracker);
+		if (retval != LTTNG_OK) {
+			ERR("Error initializing ID tracker");
 			/* Rollback operation. */
-			session->pid_tracker = tmp_tracker;
-			goto end;
+			*id_tracker = tmp_tracker;
+			goto end_restore;
 		}
-		fini_pid_tracker(&tmp_tracker);
+		fini_id_tracker(&tmp_tracker);
 
 		/* Remove session from all applications */
 		should_update_apps = true;
 	} else {
-		int ret;
 		struct ust_app *app;
 
-		if (!session->pid_tracker.ht) {
-			/* No PID being tracked. */
-			retval = LTTNG_ERR_PID_NOT_TRACKED;
-			goto end;
+		if (!id_tracker->ht) {
+			/* No ID being tracked. */
+			retval = LTTNG_ERR_ID_NOT_TRACKED;
+			goto end_restore;
 		}
-		/* Remove PID from tracker */
-		ret = pid_tracker_del_pid(&session->pid_tracker, pid);
-		if (ret != LTTNG_OK) {
-			retval = ret;
-			goto end;
+		/* Remove ID from tracker */
+		retval = id_tracker_del_id(id_tracker, value);
+		if (retval != LTTNG_OK) {
+			goto end_restore;
 		}
-		/* Remove session from application. */
-		app = ust_app_find_by_pid(pid);
-		if (app) {
+		switch (tracker_type) {
+		case LTTNG_TRACKER_VPID:
+			/* Remove session from application. */
+			app = ust_app_find_by_pid(value);
+			if (app) {
+				should_update_apps = true;
+			}
+			break;
+		default:
+			/* Keep only apps matching ID. */
 			should_update_apps = true;
 		}
 	}
 	if (should_update_apps && session->active) {
 		ust_app_global_update_all(session);
 	}
+	goto end;
+
+end_restore:
+	if (lttng_tracker_id_set_list(tracker_list, saved_ids,
+			    saved_ids_count) != LTTNG_OK) {
+		ERR("Error on tracker remove error handling.\n");
+	}
 end:
+	for (i = 0; i < saved_ids_count; i++) {
+		free(saved_ids[i].string);
+	}
+	free(saved_ids);
 	return retval;
 }
 
 /*
  * Called with session lock held.
  */
-ssize_t trace_ust_list_tracker_pids(struct ltt_ust_session *session,
-		int32_t **_pids)
+ssize_t trace_ust_list_tracker_ids(enum lttng_tracker_type tracker_type,
+		struct ltt_ust_session *session,
+		struct lttng_tracker_id **_ids)
 {
-	struct ust_pid_tracker_node *tracker_node;
-	struct lttng_ht_iter iter;
-	unsigned long count, i = 0;
-	long approx[2];
-	int32_t *pids;
-	int ret = 0;
+	struct lttng_tracker_list *tracker_list;
 
-	if (!session->pid_tracker.ht) {
-		/* Tracker disabled. Set first entry to -1. */
-		pids = zmalloc(sizeof(*pids));
-		if (!pids) {
-			ret = -1;
-			goto end;
-		}
-		pids[0] = -1;
-		*_pids = pids;
-		return 1;
+	if (tracker_type == LTTNG_TRACKER_PID) {
+		DBG("Backward compatible behavior: translate PID tracker to VPID tracker for UST domain.");
+		tracker_type = LTTNG_TRACKER_VPID;
 	}
 
-	rcu_read_lock();
-	cds_lfht_count_nodes(session->pid_tracker.ht->ht,
-		&approx[0], &count, &approx[1]);
-	pids = zmalloc(sizeof(*pids) * count);
-	if (!pids) {
-		ret = -1;
-		goto end;
-	}
-	cds_lfht_for_each_entry(session->pid_tracker.ht->ht,
-			&iter.iter, tracker_node, node.node) {
-		pids[i++] = tracker_node->node.key;
+	tracker_list = get_id_tracker_list(session, tracker_type);
+	if (!tracker_list) {
+		return -LTTNG_ERR_INVALID;
 	}
-	*_pids = pids;
-	ret = count;
-end:
-	rcu_read_unlock();
-	return ret;
+	return lttng_tracker_id_get_list(tracker_list, _ids);
 }
 
 /*
@@ -1241,7 +1364,13 @@ void trace_ust_destroy_session(struct ltt_ust_session *session)
 		buffer_reg_uid_destroy(reg, session->consumer);
 	}
 
-	fini_pid_tracker(&session->pid_tracker);
+	lttng_tracker_list_destroy(session->tracker_list_vpid);
+	lttng_tracker_list_destroy(session->tracker_list_vuid);
+	lttng_tracker_list_destroy(session->tracker_list_vgid);
+
+	fini_id_tracker(&session->vpid_tracker);
+	fini_id_tracker(&session->vuid_tracker);
+	fini_id_tracker(&session->vgid_tracker);
 	lttng_trace_chunk_put(session->current_trace_chunk);
 }