X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fkernel-consumer.c;h=ef6dccb538219c86b70615b5323c00697f5a510d;hp=044b1a81f58f19540a527370beadade74a6f297c;hb=2bba9e532ca1910822005ff7f67400a2e871467c;hpb=6dc3064a30b0cc7cfa9fdd22da1963525dfb7388

diff --git a/src/bin/lttng-sessiond/kernel-consumer.c b/src/bin/lttng-sessiond/kernel-consumer.c
index 044b1a81f..ef6dccb53 100644
--- a/src/bin/lttng-sessiond/kernel-consumer.c
+++ b/src/bin/lttng-sessiond/kernel-consumer.c
@@ -29,27 +29,14 @@
 #include "health.h"
 #include "kernel-consumer.h"
 
-/*
- * Sending a single channel to the consumer with command ADD_CHANNEL.
- */
-int kernel_consumer_add_channel(struct consumer_socket *sock,
-		struct ltt_kernel_channel *channel, struct ltt_kernel_session *session)
+static char *create_channel_path(struct consumer_output *consumer,
+		uid_t uid, gid_t gid)
 {
 	int ret;
 	char tmp_path[PATH_MAX];
-	const char *pathname;
-	struct lttcomm_consumer_msg lkm;
-	struct consumer_output *consumer;
+	char *pathname = NULL;
 
-	/* Safety net */
-	assert(channel);
-	assert(session);
-	assert(session->consumer);
-
-	consumer = session->consumer;
-
-	DBG("Kernel consumer adding channel %s to kernel consumer",
-			channel->channel->name);
+	assert(consumer);
 
 	/* Get the right path name destination */
 	if (consumer->type == CONSUMER_DST_LOCAL) {
@@ -57,14 +44,13 @@ int kernel_consumer_add_channel(struct consumer_socket *sock,
 		ret = snprintf(tmp_path, sizeof(tmp_path), "%s%s",
 				consumer->dst.trace_path, consumer->subdir);
 		if (ret < 0) {
-			PERROR("snprintf metadata path");
+			PERROR("snprintf kernel channel path");
 			goto error;
 		}
-		pathname = tmp_path;
+		pathname = strndup(tmp_path, sizeof(tmp_path));
 
 		/* Create directory */
-		ret = run_as_mkdir_recursive(pathname, S_IRWXU | S_IRWXG,
-				session->uid, session->gid);
+		ret = run_as_mkdir_recursive(pathname, S_IRWXU | S_IRWXG, uid, gid);
 		if (ret < 0) {
 			if (ret != -EEXIST) {
 				ERR("Trace directory creation error");
@@ -75,13 +61,53 @@ int kernel_consumer_add_channel(struct consumer_socket *sock,
 	} else {
 		ret = snprintf(tmp_path, sizeof(tmp_path), "%s", consumer->subdir);
 		if (ret < 0) {
-			PERROR("snprintf metadata path");
+			PERROR("snprintf kernel metadata path");
 			goto error;
 		}
-		pathname = tmp_path;
+		pathname = strndup(tmp_path, sizeof(tmp_path));
 		DBG3("Kernel network consumer subdir path: %s", pathname);
 	}
 
+	return pathname;
+
+error:
+	free(pathname);
+	return NULL;
+}
+
+/*
+ * Sending a single channel to the consumer with command ADD_CHANNEL.
+ */
+int kernel_consumer_add_channel(struct consumer_socket *sock,
+		struct ltt_kernel_channel *channel, struct ltt_kernel_session *session,
+		unsigned int monitor)
+{
+	int ret;
+	char *pathname;
+	struct lttcomm_consumer_msg lkm;
+	struct consumer_output *consumer;
+
+	/* Safety net */
+	assert(channel);
+	assert(session);
+	assert(session->consumer);
+
+	consumer = session->consumer;
+
+	DBG("Kernel consumer adding channel %s to kernel consumer",
+			channel->channel->name);
+
+	if (monitor) {
+		pathname = create_channel_path(consumer, session->uid, session->gid);
+		if (!pathname) {
+			ret = -1;
+			goto error;
+		}
+	} else {
+		/* Empty path. */
+		pathname = "";
+	}
+
 	/* Prep channel message structure */
 	consumer_init_channel_comm_msg(&lkm,
 			LTTNG_CONSUMER_ADD_CHANNEL,
@@ -96,7 +122,8 @@ int kernel_consumer_add_channel(struct consumer_socket *sock,
 			channel->channel->attr.output,
 			CONSUMER_CHANNEL_TYPE_DATA,
 			channel->channel->attr.tracefile_size,
-			channel->channel->attr.tracefile_count);
+			channel->channel->attr.tracefile_count,
+			monitor);
 
 	health_code_update();
 
@@ -115,11 +142,10 @@ error:
  * Sending metadata to the consumer with command ADD_CHANNEL and ADD_STREAM.
  */
 int kernel_consumer_add_metadata(struct consumer_socket *sock,
-		struct ltt_kernel_session *session, int no_monitor)
+		struct ltt_kernel_session *session, unsigned int monitor)
 {
 	int ret;
-	char tmp_path[PATH_MAX];
-	const char *pathname;
+	char *pathname;
 	struct lttcomm_consumer_msg lkm;
 	struct consumer_output *consumer;
 
@@ -133,35 +159,15 @@ int kernel_consumer_add_metadata(struct consumer_socket *sock,
 	/* Get consumer output pointer */
 	consumer = session->consumer;
 
-	/* Get the right path name destination */
-	if (consumer->type == CONSUMER_DST_LOCAL) {
-		/* Set application path to the destination path */
-		ret = snprintf(tmp_path, sizeof(tmp_path), "%s%s",
-				consumer->dst.trace_path, consumer->subdir);
-		if (ret < 0) {
-			PERROR("snprintf metadata path");
+	if (monitor) {
+		pathname = create_channel_path(consumer, session->uid, session->gid);
+		if (!pathname) {
+			ret = -1;
 			goto error;
 		}
-		pathname = tmp_path;
-
-		/* Create directory */
-		ret = run_as_mkdir_recursive(pathname, S_IRWXU | S_IRWXG,
-				session->uid, session->gid);
-		if (ret < 0) {
-			if (ret != -EEXIST) {
-				ERR("Trace directory creation error");
-				goto error;
-			}
-		}
-		DBG3("Kernel local consumer tracefile path: %s", pathname);
 	} else {
-		ret = snprintf(tmp_path, sizeof(tmp_path), "%s", consumer->subdir);
-		if (ret < 0) {
-			PERROR("snprintf metadata path");
-			goto error;
-		}
-		pathname = tmp_path;
-		DBG3("Kernel network consumer subdir path: %s", pathname);
+		/* Empty path. */
+		pathname = "";
 	}
 
 	/* Prep channel message structure */
@@ -177,7 +183,8 @@ int kernel_consumer_add_metadata(struct consumer_socket *sock,
 			1,
 			DEFAULT_KERNEL_CHANNEL_OUTPUT,
 			CONSUMER_CHANNEL_TYPE_METADATA,
-			0, 0);
+			0, 0,
+			monitor);
 
 	health_code_update();
 
@@ -223,7 +230,7 @@ error:
  */
 int kernel_consumer_add_stream(struct consumer_socket *sock,
 		struct ltt_kernel_channel *channel, struct ltt_kernel_stream *stream,
-		struct ltt_kernel_session *session)
+		struct ltt_kernel_session *session, unsigned int monitor)
 {
 	int ret;
 	struct lttcomm_consumer_msg lkm;
@@ -266,7 +273,8 @@ error:
  * Send all stream fds of kernel channel to the consumer.
  */
 int kernel_consumer_send_channel_stream(struct consumer_socket *sock,
-		struct ltt_kernel_channel *channel, struct ltt_kernel_session *session)
+		struct ltt_kernel_channel *channel, struct ltt_kernel_session *session,
+		unsigned int monitor)
 {
 	int ret;
 	struct ltt_kernel_stream *stream;
@@ -286,7 +294,7 @@ int kernel_consumer_send_channel_stream(struct consumer_socket *sock,
 	DBG("Sending streams of channel %s to kernel consumer",
 			channel->channel->name);
 
-	ret = kernel_consumer_add_channel(sock, channel, session);
+	ret = kernel_consumer_add_channel(sock, channel, session, monitor);
 	if (ret < 0) {
 		goto error;
 	}
@@ -298,7 +306,8 @@ int kernel_consumer_send_channel_stream(struct consumer_socket *sock,
 		}
 
 		/* Add stream on the kernel consumer side. */
-		ret = kernel_consumer_add_stream(sock, channel, stream, session);
+		ret = kernel_consumer_add_stream(sock, channel, stream, session,
+				monitor);
 		if (ret < 0) {
 			goto error;
 		}
@@ -314,7 +323,7 @@ error:
 int kernel_consumer_send_session(struct consumer_socket *sock,
 		struct ltt_kernel_session *session)
 {
-	int ret;
+	int ret, monitor = 0;
 	struct ltt_kernel_channel *chan;
 
 	/* Safety net */
@@ -328,10 +337,15 @@ int kernel_consumer_send_session(struct consumer_socket *sock,
 		goto error;
 	}
 
+	/* Don't monitor the streams on the consumer if in flight recorder. */
+	if (session->output_traces) {
+		monitor = 1;
+	}
+
 	DBG("Sending session stream to kernel consumer");
 
 	if (session->metadata_stream_fd >= 0) {
-		ret = kernel_consumer_add_metadata(sock, session, 0);
+		ret = kernel_consumer_add_metadata(sock, session, monitor);
 		if (ret < 0) {
 			goto error;
 		}
@@ -342,7 +356,8 @@ int kernel_consumer_send_session(struct consumer_socket *sock,
 
 	/* Send channel and streams of it */
 	cds_list_for_each_entry(chan, &session->channel_list.head, list) {
-		ret = kernel_consumer_send_channel_stream(sock, chan, session);
+		ret = kernel_consumer_send_channel_stream(sock, chan, session,
+				monitor);
 		if (ret < 0) {
 			goto error;
 		}