X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fjul.c;h=3c251998ef560d13d965337515746d9ada832cf1;hp=a16e9b34b6ce34314bc90150b3e0a9ae61685bb0;hb=8c93562f396a3e785c5193ca32b40f1f16599a6a;hpb=477812d122932d5cdf474bce479327a82f748e30 diff --git a/src/bin/lttng-sessiond/jul.c b/src/bin/lttng-sessiond/jul.c index a16e9b34b..3c251998e 100644 --- a/src/bin/lttng-sessiond/jul.c +++ b/src/bin/lttng-sessiond/jul.c @@ -27,7 +27,7 @@ #include "utils.h" /* - * URCU intermediate call to complete destroy a JUL event. + * URCU delayed JUL event reclaim. */ static void destroy_event_jul_rcu(struct rcu_head *head) { @@ -40,7 +40,7 @@ static void destroy_event_jul_rcu(struct rcu_head *head) } /* - * URCU intermediate call to complete destroy a JUL event. + * URCU delayed JUL app reclaim. */ static void destroy_app_jul_rcu(struct rcu_head *head) { @@ -53,8 +53,8 @@ static void destroy_app_jul_rcu(struct rcu_head *head) } /* - * Communication with Java agent call. Send the message header to the given - * socket all in big endian. + * Communication with Java agent. Send the message header to the given + * socket in big endian. * * Return 0 on success or else a negative errno message of sendmsg() op. */ @@ -67,6 +67,7 @@ static int send_header(struct lttcomm_sock *sock, uint64_t data_size, assert(sock); + memset(&msg, 0, sizeof(msg)); msg.data_size = htobe64(data_size); msg.cmd = htobe32(cmd); msg.cmd_version = htobe32(cmd_version); @@ -135,9 +136,11 @@ error: /* - * Internal call to list events on a given app. Populate events. + * Internal event listing for a given app. Populate events. * * Return number of element in the list or else a negative LTTNG_ERR* code. + * On success, the caller is responsible for freeing the memory + * allocated for "events". */ static ssize_t list_events(struct jul_app *app, struct lttng_event **events) { @@ -220,7 +223,7 @@ error: } /* - * Internal enable JUL event call on a JUL application. This function + * Internal enable JUL event on a JUL application. This function * communicates with the Java agent to enable a given event (Logger name). * * Return LTTNG_OK on success or else a LTTNG_ERR* code. @@ -246,6 +249,9 @@ static int enable_event(struct jul_app *app, struct jul_event *event) goto error_io; } + memset(&msg, 0, sizeof(msg)); + msg.loglevel = event->loglevel; + msg.loglevel_type = event->loglevel_type; strncpy(msg.name, event->name, sizeof(msg.name)); ret = send_payload(app->sock, &msg, sizeof(msg)); if (ret < 0) { @@ -305,6 +311,7 @@ static int disable_event(struct jul_app *app, struct jul_event *event) goto error_io; } + memset(&msg, 0, sizeof(msg)); strncpy(msg.name, event->name, sizeof(msg.name)); ret = send_payload(app->sock, &msg, sizeof(msg)); if (ret < 0) { @@ -436,28 +443,33 @@ int jul_list_events(struct lttng_event **events) nb_ev = list_events(app, &jul_events); if (nb_ev < 0) { ret = nb_ev; - rcu_read_unlock(); - goto error; + goto error_unlock; } - if (count >= nbmem) { + if (count + nb_ev > nbmem) { /* In case the realloc fails, we free the memory */ - void *ptr; - - DBG2("Reallocating JUL event list from %zu to %zu entries", nbmem, - 2 * nbmem); - nbmem *= 2; - ptr = realloc(tmp_events, nbmem * sizeof(*tmp_events)); - if (!ptr) { + struct lttng_event *new_tmp_events; + size_t new_nbmem; + + new_nbmem = max_t(size_t, count + nb_ev, nbmem << 1); + DBG2("Reallocating JUL event list from %zu to %zu entries", + nbmem, new_nbmem); + new_tmp_events = realloc(tmp_events, + new_nbmem * sizeof(*new_tmp_events)); + if (!new_tmp_events) { PERROR("realloc JUL events"); ret = -ENOMEM; - rcu_read_unlock(); - goto error; + free(jul_events); + goto error_unlock; } - tmp_events = ptr; + /* Zero the new memory */ + memset(new_tmp_events + nbmem, 0, + (new_nbmem - nbmem) * sizeof(*new_tmp_events)); + nbmem = new_nbmem; + tmp_events = new_tmp_events; } - memcpy(tmp_events + (count * sizeof(*tmp_events)), jul_events, - nb_ev * sizeof(*tmp_events)); + memcpy(tmp_events + count, jul_events, + nb_ev * sizeof(*tmp_events)); free(jul_events); count += nb_ev; } @@ -467,6 +479,8 @@ int jul_list_events(struct lttng_event **events) *events = tmp_events; return ret; +error_unlock: + rcu_read_unlock(); error: free(tmp_events); return ret; @@ -491,8 +505,6 @@ struct jul_app *jul_create_app(pid_t pid, struct lttcomm_sock *sock) app->pid = pid; app->sock = sock; - /* Flag it invalid until assignation. */ - app->ust_app_sock = -1; lttng_ht_node_init_ulong(&app->node, (unsigned long) app->sock->fd); error: @@ -543,59 +555,6 @@ void jul_add_app(struct jul_app *app) rcu_read_unlock(); } -/* - * Attach a given JUL application to an UST app object. This is done by copying - * the socket fd value into the ust app obj. atomically. - */ -void jul_attach_app(struct jul_app *japp) -{ - struct ust_app *uapp; - - assert(japp); - - rcu_read_lock(); - uapp = ust_app_find_by_pid(japp->pid); - if (!uapp) { - goto end; - } - - uatomic_set(&uapp->jul_app_sock, japp->sock->fd); - - DBG3("JUL app pid: %d, sock: %d attached to UST app.", japp->pid, - japp->sock->fd); - -end: - rcu_read_unlock(); - return; -} - -/* - * Remove JUL app. reference from an UST app object and set it to NULL. - */ -void jul_detach_app(struct jul_app *japp) -{ - struct ust_app *uapp; - - assert(japp); - - rcu_read_lock(); - - if (japp->ust_app_sock < 0) { - goto end; - } - - uapp = ust_app_find_by_sock(japp->ust_app_sock); - if (!uapp) { - goto end; - } - - uapp->jul_app_sock = -1; - -end: - rcu_read_unlock(); - return; -} - /* * Delete JUL application from the global hash table. */ @@ -617,7 +576,8 @@ void jul_delete_app(struct jul_app *app) /* * Destroy a JUL application object by detaching it from its corresponding UST - * app if one, closing the socket and freeing the memory. + * app if one is connected by closing the socket. Finally, perform a + * delayed memory reclaim. */ void jul_destroy_app(struct jul_app *app) { @@ -729,28 +689,9 @@ error: } /* - * Delete JUL event from given domain. Events hash table MUST be initialized. - */ -void jul_delete_event(struct jul_event *event, struct jul_domain *dom) -{ - int ret; - struct lttng_ht_iter iter; - - assert(event); - assert(dom); - assert(dom->events); - - DBG3("JUL deleting event %s from domain", event->name); - - iter.iter.node = &event->node.node; - rcu_read_lock(); - ret = lttng_ht_del(dom->events, &iter); - rcu_read_unlock(); - assert(!ret); -} - -/* - * Free given JUl event. After this call, the pointer is not usable anymore. + * Free given JUL event. This event must not be globally visible at this + * point (only expected to be used on failure just after event + * creation). After this call, the pointer is not usable anymore. */ void jul_destroy_event(struct jul_event *event) { @@ -761,7 +702,7 @@ void jul_destroy_event(struct jul_event *event) /* * Destroy a JUL domain completely. Note that the given pointer is NOT freed - * thus a reference can be passed to this function. + * thus a reference to static or stack data can be passed to this function. */ void jul_destroy_domain(struct jul_domain *dom) {