X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fjul-thread.c;h=c1df1d86282485c4166d17fa7191eaa14b1e2343;hp=972186059dd3f08fa7ab5350fb804936ee16bb12;hb=6c50984057fcbc4559573e99b2eed2ee8f5694a6;hpb=3ecd6f6bc0fa12904879438fd319541bda4cfbd7 diff --git a/src/bin/lttng-sessiond/jul-thread.c b/src/bin/lttng-sessiond/jul-thread.c index 972186059..c1df1d862 100644 --- a/src/bin/lttng-sessiond/jul-thread.c +++ b/src/bin/lttng-sessiond/jul-thread.c @@ -223,13 +223,10 @@ static int handle_registration(struct lttcomm_sock *reg_sock) jul_add_app(app); /* - * Attach JUL application to a UST app object if one exists. - * - * FIXME: This implies that the UST app object exists and created before - * JUL registration. Must confirm or else JUL app will leak until socket is - * closed by the application. + * We don't need to attach the JUL app to the app. If we ever do + * so, we should consider both registration order of JUL before + * app and app before JUL. */ - jul_attach_app(app); return new_sock->fd; @@ -317,10 +314,6 @@ restart: goto error; } - /* - * FIXME: Should we try to invalidate the JUL socket in the - * associated ust app. - */ destroy_jul_app(pollfd); } else if (revents & (LPOLLIN)) { int new_fd;