X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fcmd.c;h=ac489fa2fa7f946a7c65a8b81d8f4572323ea16d;hp=ffff05809d2f072cd6c40ea00f83dec07fad5f56;hb=8404118c67ee01844e0bcee69d05c684689506b0;hpb=fe4b07c71bc832789c96ce0de4ddb8e58cda24df

diff --git a/src/bin/lttng-sessiond/cmd.c b/src/bin/lttng-sessiond/cmd.c
index ffff05809..ac489fa2f 100644
--- a/src/bin/lttng-sessiond/cmd.c
+++ b/src/bin/lttng-sessiond/cmd.c
@@ -1769,6 +1769,7 @@ static int _cmd_enable_event(struct ltt_session *session,
 
 		{
 			struct lttng_filter_bytecode *filter_copy = NULL;
+			char *filter_expression_copy = NULL;
 
 			if (filter) {
 				filter_copy = zmalloc(
@@ -1779,16 +1780,28 @@ static int _cmd_enable_event(struct ltt_session *session,
 				}
 
 				memcpy(filter_copy, filter,
-					sizeof(struct lttng_filter_bytecode)
-					+ filter->len);
+				       sizeof(struct lttng_filter_bytecode)
+				       + filter->len);
+			}
+
+			if (filter_expression) {
+				filter_expression_copy =
+						strdup(filter_expression);
+				if (!filter_expression) {
+					ret = LTTNG_ERR_NOMEM;
+					goto error_free_copy;
+				}
 			}
 
 			ret = cmd_enable_event_internal(session, &tmp_dom,
 					(char *) default_chan_name,
-					&uevent, filter_expression, filter_copy,
-					NULL, wpipe);
-			/* We have passed ownership */
-			filter_expression = NULL;
+					&uevent, filter_expression_copy,
+					filter_copy, NULL, wpipe);
+			filter_copy = NULL;
+			filter_expression_copy = NULL;
+error_free_copy:
+			free(filter_copy);
+			free(filter_expression_copy);
 		}
 
 		if (ret != LTTNG_OK && ret != LTTNG_ERR_UST_EVENT_ENABLED) {
@@ -1797,10 +1810,12 @@ static int _cmd_enable_event(struct ltt_session *session,
 
 		/* The wild card * means that everything should be enabled. */
 		if (strncmp(event->name, "*", 1) == 0 && strlen(event->name) == 1) {
-			ret = event_agent_enable_all(usess, agt, event, filter);
+			ret = event_agent_enable_all(usess, agt, event, filter,
+					filter_expression);
 			filter = NULL;
 		} else {
-			ret = event_agent_enable(usess, agt, event, filter);
+			ret = event_agent_enable(usess, agt, event, filter,
+					filter_expression);
 			filter = NULL;
 		}
 		if (ret != LTTNG_OK) {