X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fclient.c;h=8a2ef85b7345c33d89cd2914134bd075a71b4e9e;hp=74bbbe9b2e05e3be7f94a1cba1330aae6d7658ba;hb=d7b377ed1acd4043bde353d99122e0e56fa4e975;hpb=e368fb4396b9bdb22de16f0c93512c9f6d7ab0b4

diff --git a/src/bin/lttng-sessiond/client.c b/src/bin/lttng-sessiond/client.c
index 74bbbe9b2..8a2ef85b7 100644
--- a/src/bin/lttng-sessiond/client.c
+++ b/src/bin/lttng-sessiond/client.c
@@ -13,6 +13,7 @@
 #include "common/dynamic-array.h"
 #include "common/payload.h"
 #include "common/payload-view.h"
+#include "common/fd-handle.h"
 #include "common/sessiond-comm/sessiond-comm.h"
 #include "common/payload.h"
 #include "common/payload-view.h"
@@ -91,8 +92,12 @@ static int setup_lttng_msg(struct command_ctx *cmd_ctx,
 		.data_size = payload_len,
 	};
 
-	lttng_dynamic_buffer_set_size(&cmd_ctx->reply_payload.buffer, 0);
-	lttng_dynamic_array_clear(&cmd_ctx->reply_payload._fds);
+	ret = lttng_dynamic_buffer_set_size(&cmd_ctx->reply_payload.buffer, 0);
+	if (ret) {
+		goto end;
+	}
+
+	lttng_dynamic_pointer_array_clear(&cmd_ctx->reply_payload._fd_handles);
 
 	cmd_ctx->lttng_msg_size = total_msg_size;
 
@@ -132,7 +137,10 @@ static int setup_empty_lttng_msg(struct command_ctx *cmd_ctx)
 	int ret;
 	const struct lttcomm_lttng_msg llm = {};
 
-	lttng_dynamic_buffer_set_size(&cmd_ctx->reply_payload.buffer, 0);
+	ret = lttng_dynamic_buffer_set_size(&cmd_ctx->reply_payload.buffer, 0);
+	if (ret) {
+		goto end;
+	}
 
 	/* Append place-holder reply header. */
 	ret = lttng_dynamic_buffer_append(
@@ -571,15 +579,14 @@ static unsigned int lttng_sessions_count(uid_t uid, gid_t gid)
 	struct ltt_session *session;
 	const struct ltt_session_list *session_list = session_get_list();
 
-	DBG("Counting number of available session for UID %d GID %d",
-			uid, gid);
+	DBG("Counting number of available session for UID %d", uid);
 	cds_list_for_each_entry(session, &session_list->head, list) {
 		if (!session_get(session)) {
 			continue;
 		}
 		session_lock(session);
 		/* Only count the sessions the user can control. */
-		if (session_access_ok(session, uid, gid) &&
+		if (session_access_ok(session, uid) &&
 				!session->destroyed) {
 			i++;
 		}
@@ -592,9 +599,10 @@ static unsigned int lttng_sessions_count(uid_t uid, gid_t gid)
 static int receive_userspace_probe(struct command_ctx *cmd_ctx, int sock,
 		int *sock_error, struct lttng_event *event)
 {
-	int fd, ret;
+	int fd = -1, ret;
 	struct lttng_userspace_probe_location *probe_location;
 	struct lttng_payload probe_location_payload;
+	struct fd_handle *handle = NULL;
 
 	/*
 	 * Create a payload to store the serialized version of the probe
@@ -633,13 +641,25 @@ static int receive_userspace_probe(struct command_ctx *cmd_ctx, int sock,
 		goto error;
 	}
 
-	ret = lttng_payload_push_fd(&probe_location_payload, fd);
+	handle = fd_handle_create(fd);
+	if (!handle) {
+		ret = LTTNG_ERR_NOMEM;
+		goto error;
+	}
+
+	/* Transferred to the handle. */
+	fd = -1;
+
+	ret = lttng_payload_push_fd_handle(&probe_location_payload, handle);
 	if (ret) {
 		ERR("Failed to add userspace probe file descriptor to payload");
 		ret = LTTNG_ERR_NOMEM;
 		goto error;
 	}
 
+	fd_handle_put(handle);
+	handle = NULL;
+
 	{
 		struct lttng_payload_view view = lttng_payload_view_from_payload(
 			&probe_location_payload, 0, -1);
@@ -662,6 +682,13 @@ static int receive_userspace_probe(struct command_ctx *cmd_ctx, int sock,
 	}
 
 error:
+	if (fd >= 0) {
+		if (close(fd)) {
+			PERROR("Failed to close userspace probe location binary fd");
+		}
+	}
+
+	fd_handle_put(handle);
 	lttng_payload_reset(&probe_location_payload);
 	return ret;
 }
@@ -699,6 +726,7 @@ static int check_rotate_compatible(void)
 static int send_unix_sock(int sock, struct lttng_payload_view *view)
 {
 	int ret;
+	const int fd_count = lttng_payload_view_get_fd_handle_count(view);
 
 	/* Check valid length */
 	if (view->buffer.size == 0) {
@@ -712,10 +740,11 @@ static int send_unix_sock(int sock, struct lttng_payload_view *view)
 		goto end;
 	}
 
-	if (lttng_dynamic_array_get_count(&view->_fds) > 0) {
-		ret = lttcomm_send_fds_unix_sock(sock,
-				(const int *) view->_fds.buffer.data,
-				lttng_dynamic_array_get_count(&view->_fds));
+	if (fd_count > 0) {
+		ret = lttcomm_send_payload_view_fds_unix_sock(sock, view);
+		if (ret < 0) {
+			goto end;
+		}
 	}
 
 end:
@@ -1076,13 +1105,12 @@ skip_domain:
 	}
 
 	/*
-	 * Check that the UID or GID match that of the tracing session.
+	 * Check that the UID matches that of the tracing session.
 	 * The root user can interact with all sessions.
 	 */
 	if (need_tracing_session) {
 		if (!session_access_ok(cmd_ctx->session,
-				LTTNG_SOCK_GET_UID_CRED(&cmd_ctx->creds),
-				LTTNG_SOCK_GET_GID_CRED(&cmd_ctx->creds)) ||
+				LTTNG_SOCK_GET_UID_CRED(&cmd_ctx->creds)) ||
 				cmd_ctx->session->destroyed) {
 			ret = LTTNG_ERR_EPERM;
 			goto error;
@@ -2266,8 +2294,7 @@ static void *thread_manage_clients(void *data)
 			.gid = UINT32_MAX,
 		};
 		cmd_ctx.session = NULL;
-		lttng_dynamic_buffer_set_size(&cmd_ctx.reply_payload.buffer, 0);
-		lttng_dynamic_array_clear(&cmd_ctx.reply_payload._fds);
+		lttng_payload_clear(&cmd_ctx.reply_payload);
 		cmd_ctx.lttng_msg_size = 0;
 
 		DBG("Accepting client command ...");
@@ -2410,7 +2437,7 @@ static void *thread_manage_clients(void *data)
 			       sizeof(llm));
 			assert(cmd_ctx.lttng_msg_size == cmd_ctx.reply_payload.buffer.size);
 
-			llm->fd_count = lttng_payload_view_get_fd_count(&view);
+			llm->fd_count = lttng_payload_view_get_fd_handle_count(&view);
 
 			DBG("Sending response (size: %d, retcode: %s (%d))",
 					cmd_ctx.lttng_msg_size,