X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fagent.c;h=1eb64c25e32b937282bd5f1b45c7442d3909b188;hp=b267503fcbcec3e58890fda360c507496645afe6;hb=d558f2363a2daf3e456a28a6089f7464837ed542;hpb=f60140a188c6c0cd1acf948c37e338e96a74be8d

diff --git a/src/bin/lttng-sessiond/agent.c b/src/bin/lttng-sessiond/agent.c
index b267503fc..1eb64c25e 100644
--- a/src/bin/lttng-sessiond/agent.c
+++ b/src/bin/lttng-sessiond/agent.c
@@ -16,6 +16,7 @@
  */
 
 #define _GNU_SOURCE
+#define _LGPL_SOURCE
 #include <assert.h>
 #include <urcu/uatomic.h>
 
@@ -539,6 +540,8 @@ int agent_list_events(struct lttng_event **events,
 
 	assert(events);
 
+	DBG2("Agent listing events for domain %d", domain);
+
 	nbmem = UST_APP_EVENT_LIST_SIZE;
 	tmp_events = zmalloc(nbmem * sizeof(*tmp_events));
 	if (!tmp_events) {
@@ -677,6 +680,8 @@ void agent_add_app(struct agent_app *app)
 
 /*
  * Delete agent application from the global hash table.
+ *
+ * rcu_read_lock() must be held by the caller.
  */
 void agent_delete_app(struct agent_app *app)
 {
@@ -688,9 +693,7 @@ void agent_delete_app(struct agent_app *app)
 	DBG3("Agent deleting app pid: %d and sock: %d", app->pid, app->sock->fd);
 
 	iter.iter.node = &app->node.node;
-	rcu_read_lock();
 	ret = lttng_ht_del(agent_apps_ht_by_sock, &iter);
-	rcu_read_unlock();
 	assert(!ret);
 }
 
@@ -769,6 +772,7 @@ struct agent *agent_create(enum lttng_domain_type domain)
 	ret = agent_init(agt);
 	if (ret < 0) {
 		free(agt);
+		agt = NULL;
 		goto error;
 	}
 
@@ -896,7 +900,7 @@ struct agent_event *agent_find_event(const char *name, int loglevel,
 	return caa_container_of(node, struct agent_event, node);
 
 error:
-	DBG3("Agent NOT found %s.", name);
+	DBG3("Agent event NOT found %s.", name);
 	return NULL;
 }
 
@@ -909,6 +913,7 @@ void agent_destroy_event(struct agent_event *event)
 {
 	assert(event);
 
+	free(event->filter);
 	free(event);
 }
 
@@ -952,7 +957,7 @@ void agent_destroy(struct agent *agt)
 	}
 	rcu_read_unlock();
 
-	lttng_ht_destroy(agt->events);
+	ht_cleanup_push(agt->events);
 }
 
 /*