X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-relayd%2Fviewer-stream.c;h=8e3a1949288dfddf250b0f5cd6edfb3690318218;hp=21294d1f32dfc700c33c1075b1343e36b84c2833;hb=4c2717fcf7b66d23540fd0b52d3efa885680619e;hpb=ebb29c10d382c55529138ae70eb5a05bf3ccb9a6 diff --git a/src/bin/lttng-relayd/viewer-stream.c b/src/bin/lttng-relayd/viewer-stream.c index 21294d1f3..8e3a19492 100644 --- a/src/bin/lttng-relayd/viewer-stream.c +++ b/src/bin/lttng-relayd/viewer-stream.c @@ -41,11 +41,12 @@ static void viewer_stream_destroy_rcu(struct rcu_head *head) } struct relay_viewer_stream *viewer_stream_create(struct relay_stream *stream, + struct lttng_trace_chunk *viewer_trace_chunk, enum lttng_viewer_seek seek_t) { struct relay_viewer_stream *vstream = NULL; const bool acquired_reference = lttng_trace_chunk_get( - stream->trace_chunk); + viewer_trace_chunk); if (!acquired_reference) { goto error; @@ -57,7 +58,8 @@ struct relay_viewer_stream *viewer_stream_create(struct relay_stream *stream, goto error; } - vstream->stream_file.trace_chunk = stream->trace_chunk; + vstream->stream_file.trace_chunk = viewer_trace_chunk; + viewer_trace_chunk = NULL; vstream->path_name = lttng_strndup(stream->path_name, LTTNG_VIEWER_PATH_MAX); if (vstream->path_name == NULL) { PERROR("relay viewer path_name alloc"); @@ -103,7 +105,7 @@ struct relay_viewer_stream *viewer_stream_create(struct relay_stream *stream, } case LTTNG_VIEWER_SEEK_LAST: vstream->current_tracefile_id = - tracefile_array_get_file_index_head(stream->tfa); + tracefile_array_get_read_file_index_head(stream->tfa); /* * We seek at the very end of each stream, awaiting for * a future packet to eventually come in. @@ -129,7 +131,8 @@ struct relay_viewer_stream *viewer_stream_create(struct relay_stream *stream, const uint32_t connection_minor = stream->trace->session->minor; vstream->index_file = lttng_index_file_create_from_trace_chunk_read_only( - stream->trace_chunk, stream->path_name, + vstream->stream_file.trace_chunk, + stream->path_name, stream->channel_name, stream->tracefile_size, vstream->current_tracefile_id, lttng_to_index_major(connection_major, @@ -169,6 +172,9 @@ error: if (vstream) { viewer_stream_destroy(vstream); } + if (viewer_trace_chunk && acquired_reference) { + lttng_trace_chunk_put(viewer_trace_chunk); + } return NULL; } @@ -206,6 +212,7 @@ static void viewer_stream_release(struct urcu_ref *ref) vstream->stream = NULL; } lttng_trace_chunk_put(vstream->stream_file.trace_chunk); + vstream->stream_file.trace_chunk = NULL; call_rcu(&vstream->rcu_node, viewer_stream_destroy_rcu); } @@ -312,7 +319,8 @@ int viewer_stream_rotate(struct relay_viewer_stream *vstream) } vstream->index_file = lttng_index_file_create_from_trace_chunk_read_only( - stream->trace_chunk, stream->path_name, + vstream->stream_file.trace_chunk, + stream->path_name, stream->channel_name, stream->tracefile_size, vstream->current_tracefile_id,