X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=src%2Fbin%2Flttng-relayd%2Fviewer-session.c;h=a4b859726a6ea9b9bc7ef86ac5a019f43e29bdc2;hp=6d74b351717dc695103127b178c2074dd142a54b;hb=d62023be5fccac24ad404aff2915c1888c22755c;hpb=1ae5e83e58569f50b38fde0afe3f2aa08010f354

diff --git a/src/bin/lttng-relayd/viewer-session.c b/src/bin/lttng-relayd/viewer-session.c
index 6d74b3517..a4b859726 100644
--- a/src/bin/lttng-relayd/viewer-session.c
+++ b/src/bin/lttng-relayd/viewer-session.c
@@ -105,6 +105,41 @@ void viewer_session_destroy(struct relay_viewer_session *vsession)
 	free(vsession);
 }
 
+/*
+ * Release ownership of all the streams of one session and detach the viewer.
+ */
+void viewer_session_close_one_session(struct relay_viewer_session *vsession,
+		struct relay_session *session)
+{
+	struct lttng_ht_iter iter;
+	struct relay_viewer_stream *vstream;
+
+	/*
+	 * TODO: improvement: create more efficient list of
+	 * vstream per session.
+	 */
+	cds_lfht_for_each_entry(viewer_streams_ht->ht, &iter.iter,
+			vstream, stream_n.node) {
+		if (!viewer_stream_get(vstream)) {
+			continue;
+		}
+		if (vstream->stream->trace->session != session) {
+			viewer_stream_put(vstream);
+			continue;
+		}
+		/* Put local reference. */
+		viewer_stream_put(vstream);
+		/*
+		 * We have reached one of the viewer stream's lifetime
+		 * end condition. This "put" will cause the proper
+		 * teardown of the viewer stream.
+		 */
+		viewer_stream_put(vstream);
+	}
+
+	viewer_session_detach(vsession, session);
+}
+
 void viewer_session_close(struct relay_viewer_session *vsession)
 {
 	struct relay_session *session;
@@ -112,32 +147,7 @@ void viewer_session_close(struct relay_viewer_session *vsession)
 	rcu_read_lock();
 	cds_list_for_each_entry_rcu(session,
 			&vsession->session_list, viewer_session_node) {
-		struct lttng_ht_iter iter;
-		struct relay_viewer_stream *vstream;
-
-		/*
-		 * TODO: improvement: create more efficient list of
-		 * vstream per session.
-		 */
-		cds_lfht_for_each_entry(viewer_streams_ht->ht, &iter.iter,
-				vstream, stream_n.node) {
-			if (!viewer_stream_get(vstream)) {
-				continue;
-			}
-			if (vstream->stream->trace->session != session) {
-				viewer_stream_put(vstream);
-				continue;
-			}
-			/* Put local reference. */
-			viewer_stream_put(vstream);
-			/*
-			 * We have reached one of the viewer stream's lifetime
-			 * end condition.
-			 */
-			viewer_stream_put(vstream);
-		}
-
-		viewer_session_detach(vsession, session);
+		viewer_session_close_one_session(vsession, session);
 	}
 	rcu_read_unlock();
 }