X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=lttng%2Fcommands%2Flist.c;h=abbdea1ba8bb904c86508c3ef965100073dd225c;hp=e2d5b6643d5df24f15d5a2bb658ae6460604c22e;hb=5edd7e09e892604b00ca937c0f1bc887bb5a842c;hpb=eeac7d463a09ac924c3c98f1fa5fa6c19748b4de

diff --git a/lttng/commands/list.c b/lttng/commands/list.c
index e2d5b6643..abbdea1ba 100644
--- a/lttng/commands/list.c
+++ b/lttng/commands/list.c
@@ -48,7 +48,7 @@ static struct poptOption long_options[] = {
 	/* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
 	{"help",      'h', POPT_ARG_NONE, 0, OPT_HELP, 0, 0},
 	{"kernel",    'k', POPT_ARG_VAL, &opt_kernel, 1, 0, 0},
-	{"userspace", 'u', POPT_ARG_STRING | POPT_ARGFLAG_OPTIONAL, 0, OPT_USERSPACE, 0, 0},
+	{"userspace", 'u', POPT_ARG_STRING | POPT_ARGFLAG_OPTIONAL, &opt_cmd_name, OPT_USERSPACE, 0, 0},
 	{"pid",       'p', POPT_ARG_INT, &opt_pid, 0, 0, 0},
 	{"channel",   'c', POPT_ARG_STRING, &opt_channel, 0, 0, 0},
 	{"domain",    'd', POPT_ARG_VAL, &opt_domain, 1, 0, 0},
@@ -109,6 +109,28 @@ end:
 	return cmdline;
 }
 
+static
+const char *active_string(int value)
+{
+	switch (value) {
+	case 0:	return " [inactive]";
+	case 1: return " [active]";
+	case -1: return "";
+	default: return NULL;
+	}
+}
+
+static
+const char *enabled_string(int value)
+{
+	switch (value) {
+	case 0:	return " [disabled]";
+	case 1: return " [enabled]";
+	case -1: return "";
+	default: return NULL;
+	}
+}
+
 /*
  * Pretty print single event.
  */
@@ -116,12 +138,12 @@ static void print_events(struct lttng_event *event)
 {
 	switch (event->type) {
 	case LTTNG_EVENT_TRACEPOINT:
-		MSG("%s%s (type: tracepoint) [enabled: %d]", indent6,
-				event->name, event->enabled);
+		MSG("%s%s (type: tracepoint)%s", indent6,
+				event->name, enabled_string(event->enabled));
 		break;
 	case LTTNG_EVENT_PROBE:
-		MSG("%s%s (type: probe) [enabled: %d]", indent6,
-				event->name, event->enabled);
+		MSG("%s%s (type: probe)%s", indent6,
+				event->name, enabled_string(event->enabled));
 		if (event->attr.probe.addr != 0) {
 			MSG("%saddr: 0x%" PRIx64, indent8, event->attr.probe.addr);
 		} else {
@@ -131,17 +153,17 @@ static void print_events(struct lttng_event *event)
 		break;
 	case LTTNG_EVENT_FUNCTION:
 	case LTTNG_EVENT_FUNCTION_ENTRY:
-		MSG("%s%s (type: function) [enabled: %d]", indent6,
-				event->name, event->enabled);
+		MSG("%s%s (type: function)%s", indent6,
+				event->name, enabled_string(event->enabled));
 		MSG("%ssymbol: \"%s\"", indent8, event->attr.ftrace.symbol_name);
 		break;
 	case LTTNG_EVENT_SYSCALL:
-		MSG("%s (type: syscall) [enabled: %d]", indent6,
-				event->enabled);
+		MSG("%s (type: syscall)%s", indent6,
+				enabled_string(event->enabled));
 		break;
 	case LTTNG_EVENT_NOOP:
-		MSG("%s (type: noop) [enabled: %d]", indent6,
-				event->enabled);
+		MSG("%s (type: noop)%s", indent6,
+				enabled_string(event->enabled));
 		break;
 	case LTTNG_EVENT_ALL:
 		/* We should never have "all" events in list. */
@@ -257,7 +279,7 @@ static int list_events(const char *channel_name)
 
 	MSG("\n%sEvents:", indent4);
 	if (count == 0) {
-		MSG("%sNone", indent6);
+		MSG("%sNone\n", indent6);
 		goto end;
 	}
 
@@ -282,7 +304,7 @@ error:
  */
 static void print_channel(struct lttng_channel *channel)
 {
-	MSG("- %s (enabled: %d):\n", channel->name, channel->enabled);
+	MSG("- %s:%s\n", channel->name, enabled_string(channel->enabled));
 
 	MSG("%sAttributes:", indent4);
 	MSG("%soverwrite mode: %d", indent6, channel->attr.overwrite);
@@ -311,7 +333,7 @@ static int list_channels(const char *channel_name)
 	unsigned int chan_found = 0;
 	struct lttng_channel *channels = NULL;
 
-	DBG("Listing channel(s) (%s)", channel_name);
+	DBG("Listing channel(s) (%s)", channel_name ? : "<all>");
 
 	count = lttng_list_channels(handle, &channels);
 	if (count < 0) {
@@ -385,14 +407,14 @@ static int list_sessions(const char *session_name)
 		if (session_name != NULL) {
 			if (strncmp(sessions[i].name, session_name, NAME_MAX) == 0) {
 				session_found = 1;
-				MSG("Tracing session %s:", session_name);
+				MSG("Tracing session %s:%s", session_name, active_string(sessions[i].enabled));
 				MSG("%sTrace path: %s\n", indent4, sessions[i].path);
 				break;
 			}
 			continue;
 		}
 
-		MSG("  %d) %s (%s)", i + 1, sessions[i].name, sessions[i].path);
+		MSG("  %d) %s (%s)%s", i + 1, sessions[i].name, sessions[i].path, active_string(sessions[i].enabled));
 
 		if (session_found) {
 			break;
@@ -460,7 +482,7 @@ error:
 int cmd_list(int argc, const char **argv)
 {
 	int opt, i, ret = CMD_SUCCESS;
-	unsigned int nb_domain;
+	int nb_domain;
 	const char *session_name;
 	static poptContext pc;
 	struct lttng_domain domain;
@@ -481,7 +503,6 @@ int cmd_list(int argc, const char **argv)
 			goto end;
 		case OPT_USERSPACE:
 			opt_userspace = 1;
-			opt_cmd_name = poptGetOptArg(pc);
 			break;
 		default:
 			usage(stderr);