X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=lttng%2Fcommands%2Fenable_channels.c;h=c5887d07bf17ac10688e3dbb3b74bc6d57564ddc;hp=bd732f22f20d4e4979323c1c75a32f1e0c77dee9;hb=0b0dd29a48f5855eeb7cda99efaa079d8353eb6b;hpb=b389abbe14d653f704fcf8f952539cc5ce775c53

diff --git a/lttng/commands/enable_channels.c b/lttng/commands/enable_channels.c
index bd732f22f..c5887d07b 100644
--- a/lttng/commands/enable_channels.c
+++ b/lttng/commands/enable_channels.c
@@ -84,19 +84,27 @@ static void usage(FILE *ofp)
 	fprintf(ofp, "  -p, --pid PID            If -u, apply on a specific PID\n");
 	fprintf(ofp, "\n");
 	fprintf(ofp, "Channel options:\n");
-	fprintf(ofp, "      --discard            Discard event when buffers are full (default)\n");
-	fprintf(ofp, "      --overwrite          Flight recorder mode\n");
-	fprintf(ofp, "      --subbuf-size        Subbuffer size in bytes (default: 4096)\n");
-	fprintf(ofp, "      --num-subbuf         Number of subbufers (default: 2)\n");
-	fprintf(ofp, "      --switch-timer       Switch timer interval in usec (default: 0)\n");
-	fprintf(ofp, "      --read-timer         Read timer interval in usec (default: 200)\n");
+	fprintf(ofp, "      --discard            Discard event when buffers are full%s\n",
+		DEFAULT_CHANNEL_OVERWRITE ? "" : " (default)");
+	fprintf(ofp, "      --overwrite          Flight recorder mode%s\n",
+		DEFAULT_CHANNEL_OVERWRITE ? " (default)" : "");
+	fprintf(ofp, "      --subbuf-size        Subbuffer size in bytes\n");
+	fprintf(ofp, "                               (default: %u, kernel default: %u)\n",
+		DEFAULT_CHANNEL_SUBBUF_SIZE,
+		DEFAULT_KERNEL_CHANNEL_SUBBUF_SIZE);
+	fprintf(ofp, "      --num-subbuf         Number of subbufers\n");
+	fprintf(ofp, "                               (default: %u, kernel default: %u)\n",
+		DEFAULT_CHANNEL_SUBBUF_NUM,
+		DEFAULT_KERNEL_CHANNEL_SUBBUF_NUM);
+	fprintf(ofp, "      --switch-timer       Switch timer interval in usec (default: %u)\n",
+		DEFAULT_CHANNEL_SWITCH_TIMER);
+	fprintf(ofp, "      --read-timer         Read timer interval in usec (default: %u)\n",
+		DEFAULT_CHANNEL_READ_TIMER);
 	fprintf(ofp, "\n");
 }
 
 /*
- *  enable_channel
- *
- *  Adding channel using the lttng API.
+ * Adding channel using the lttng API.
  */
 static int enable_channel(char *session_name)
 {
@@ -106,6 +114,14 @@ static int enable_channel(char *session_name)
 
 	if (opt_kernel) {
 		dom.type = LTTNG_DOMAIN_KERNEL;
+	} else if (opt_pid != 0) {
+		dom.type = LTTNG_DOMAIN_UST_PID;
+		dom.attr.pid = opt_pid;
+		DBG("PID %d set to lttng handle", opt_pid);
+	} else {
+		ERR("Please specify a tracer (--kernel or --userspace)");
+		ret = CMD_NOT_IMPLEMENTED;
+		goto error;
 	}
 
 	handle = lttng_create_handle(session_name, &dom);
@@ -114,35 +130,21 @@ static int enable_channel(char *session_name)
 		goto error;
 	}
 
-	/* Strip event list */
+	/* Strip channel list (format: chan1,chan2,...) */
 	channel_name = strtok(opt_channels, ",");
 	while (channel_name != NULL) {
-		/* Kernel tracer action */
-		if (opt_kernel) {
-			DBG("Enabling kernel channel %s", channel_name);
+		/* Copy channel name and normalize it */
+		strncpy(chan.name, channel_name, NAME_MAX);
+		chan.name[NAME_MAX - 1] = '\0';
 
-			/* Copy channel name and normalize it */
-			strncpy(chan.name, channel_name, NAME_MAX);
-			chan.name[NAME_MAX - 1] = '\0';
+		DBG("Enabling channel %s", channel_name);
 
-			ret = lttng_enable_channel(handle, &chan);
-			if (ret < 0) {
-				goto error;
-			} else {
-				MSG("Kernel channel enabled %s", channel_name);
-			}
-		} else if (opt_userspace) {		/* User-space tracer action */
-			/*
-			 * TODO: Waiting on lttng UST 2.0
-			 */
-			if (opt_pid_all) {
-			} else if (opt_pid != 0) {
-			}
-			ret = CMD_NOT_IMPLEMENTED;
+		ret = lttng_enable_channel(handle, &chan);
+		if (ret < 0) {
 			goto error;
 		} else {
-			ERR("Please specify a tracer (--kernel or --userspace)");
-			goto error;
+			MSG("Channel enabled %s for session %s",
+					channel_name, session_name);
 		}
 
 		/* Next event */
@@ -156,9 +158,7 @@ error:
 }
 
 /*
- *  init_channel_config
- *
- *  Default value for channel configuration.
+ * Default value for channel configuration.
  */
 static void init_channel_config(void)
 {
@@ -177,14 +177,14 @@ static void init_channel_config(void)
 		chan.attr.switch_timer_interval = DEFAULT_CHANNEL_SWITCH_TIMER;
 		chan.attr.read_timer_interval = DEFAULT_CHANNEL_READ_TIMER;
 
-		chan.attr.subbuf_size = DEFAULT_CHANNEL_SUBBUF_SIZE;
-		chan.attr.num_subbuf = DEFAULT_CHANNEL_SUBBUF_NUM;
+		chan.attr.subbuf_size = DEFAULT_UST_CHANNEL_SUBBUF_SIZE;
+		chan.attr.num_subbuf = DEFAULT_UST_CHANNEL_SUBBUF_NUM;
 		chan.attr.output = DEFAULT_CHANNEL_OUTPUT;
 	}
 }
 
 /*
- *  Add channel to trace session
+ * Add channel to trace session
  */
 int cmd_enable_channels(int argc, const char **argv)
 {