X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=lttng-sessiond%2Fust-consumer.c;h=c02cbf96588c2c4701c7c9e9667c590582c1723e;hp=866d7bd56bc199e8bed90b2e3abc1ec88f48a070;hb=fc34caaa25f9780eb8509f243f910c3f2aaa5a69;hpb=84cd17c63cde7ea5d7a0ad037dd41e8297658812 diff --git a/lttng-sessiond/ust-consumer.c b/lttng-sessiond/ust-consumer.c index 866d7bd56..c02cbf965 100644 --- a/lttng-sessiond/ust-consumer.c +++ b/lttng-sessiond/ust-consumer.c @@ -23,18 +23,19 @@ #include #include +#include #include #include #include -#include "hashtable.h" #include "ust-consumer.h" /* * Send all stream fds of UST channel to the consumer. */ static int send_channel_streams(int sock, - struct ust_app_channel *uchan) + struct ust_app_channel *uchan, + uid_t uid, gid_t gid) { int ret, fd; struct lttcomm_consumer_msg lum; @@ -84,6 +85,8 @@ static int send_channel_streams(int sock, */ lum.u.stream.output = DEFAULT_UST_CHANNEL_OUTPUT; lum.u.stream.mmap_len = stream->obj->memory_map_size; + lum.u.stream.uid = uid; + lum.u.stream.gid = gid; strncpy(lum.u.stream.path_name, stream->pathname, PATH_MAX - 1); lum.u.stream.path_name[PATH_MAX - 1] = '\0'; DBG("Sending stream %d to consumer", lum.u.stream.stream_key); @@ -117,13 +120,17 @@ int ust_consumer_send_session(int consumer_fd, struct ust_app_session *usess) { int ret = 0; int sock = consumer_fd; - struct cds_lfht_iter iter; - struct cds_lfht_node *node; + struct lttng_ht_iter iter; struct lttcomm_consumer_msg lum; - struct ust_app_channel *uchan; + struct ust_app_channel *ua_chan; DBG("Sending metadata stream fd"); + if (consumer_fd < 0) { + ERR("Consumer has negative file descriptor"); + return -EINVAL; + } + if (usess->metadata->obj->shm_fd != 0) { int fd; int fds[2]; @@ -153,6 +160,8 @@ int ust_consumer_send_session(int consumer_fd, struct ust_app_session *usess) lum.u.stream.state = LTTNG_CONSUMER_ACTIVE_STREAM; lum.u.stream.output = DEFAULT_UST_CHANNEL_OUTPUT; lum.u.stream.mmap_len = usess->metadata->stream_obj->memory_map_size; + lum.u.stream.uid = usess->uid; + lum.u.stream.gid = usess->gid; strncpy(lum.u.stream.path_name, usess->metadata->pathname, PATH_MAX - 1); lum.u.stream.path_name[PATH_MAX - 1] = '\0'; DBG("Sending metadata stream %d to consumer", lum.u.stream.stream_key); @@ -172,16 +181,13 @@ int ust_consumer_send_session(int consumer_fd, struct ust_app_session *usess) /* Send each channel fd streams of session */ rcu_read_lock(); - hashtable_get_first(usess->channels, &iter); - while ((node = hashtable_iter_get_node(&iter)) != NULL) { - uchan = caa_container_of(node, struct ust_app_channel, node); - - ret = send_channel_streams(sock, uchan); + cds_lfht_for_each_entry(usess->channels->ht, &iter.iter, ua_chan, + node.node) { + ret = send_channel_streams(sock, ua_chan, usess->uid, usess->gid); if (ret < 0) { rcu_read_unlock(); goto error; } - hashtable_get_next(usess->channels, &iter); } rcu_read_unlock();