X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=ltt-sessiond%2Fsession.c;h=9ca6a69ad2ce4aa902773546653851c69751a6db;hp=ff79bf2a969bde74e1045f7c0c126e6eea46df16;hb=1e307fab325060d9db4e989c0fdc3cddf46f50f6;hpb=af9737e9006817895374706246dcf3d9efbeb58f diff --git a/ltt-sessiond/session.c b/ltt-sessiond/session.c index ff79bf2a9..9ca6a69ad 100644 --- a/ltt-sessiond/session.c +++ b/ltt-sessiond/session.c @@ -8,7 +8,7 @@ * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License @@ -22,10 +22,10 @@ #include #include #include -#include #include -#include "lttngerr.h" +#include + #include "session.h" /* @@ -49,11 +49,9 @@ static struct ltt_session_list ltt_session_list = { }; /* - * add_session_list - * - * Add a ltt_session structure to the global list. + * Add a ltt_session structure to the global list. * - * The caller MUST acquire the session list lock before. + * The caller MUST acquire the session list lock before. */ static void add_session_list(struct ltt_session *ls) { @@ -62,11 +60,9 @@ static void add_session_list(struct ltt_session *ls) } /* - * del_session_list - * - * Delete a ltt_session structure to the global list. + * Delete a ltt_session structure to the global list. * - * The caller MUST acquire the session list lock before. + * The caller MUST acquire the session list lock before. */ static void del_session_list(struct ltt_session *ls) { @@ -78,9 +74,7 @@ static void del_session_list(struct ltt_session *ls) } /* - * get_session_list - * - * Return a pointer to the session list. + * Return a pointer to the session list. */ struct ltt_session_list *get_session_list(void) { @@ -120,10 +114,8 @@ void unlock_session(struct ltt_session *session) } /* - * find_session_by_name - * - * Return a ltt_session structure ptr that matches name. - * If no session found, NULL is returned. + * Return a ltt_session structure ptr that matches name. + * If no session found, NULL is returned. */ struct ltt_session *find_session_by_name(char *name) { @@ -132,7 +124,7 @@ struct ltt_session *find_session_by_name(char *name) lock_session_list(); cds_list_for_each_entry(iter, <t_session_list.head, list) { - if (strncmp(iter->name, name, strlen(name)) == 0) { + if (strncmp(iter->name, name, NAME_MAX) == 0) { found = 1; break; } @@ -147,11 +139,9 @@ struct ltt_session *find_session_by_name(char *name) } /* - * destroy_session + * Delete session from the session list and free the memory. * - * Delete session from the session list and free the memory. - * - * Return -1 if no session is found. On success, return 1; + * Return -1 if no session is found. On success, return 1; */ int destroy_session(char *name) { @@ -177,17 +167,12 @@ int destroy_session(char *name) } /* - * create_session - * - * Create a brand new session and add it to the session list. + * Create a brand new session and add it to the session list. */ int create_session(char *name, char *path) { int ret; - char date_time[NAME_MAX]; struct ltt_session *new_session; - time_t rawtime; - struct tm *timeinfo; new_session = find_session_by_name(name); if (new_session != NULL) { @@ -217,15 +202,7 @@ int create_session(char *name, char *path) /* Define session system path */ if (path != NULL) { - if (strstr(name, "auto-") == NULL) { - time(&rawtime); - timeinfo = localtime(&rawtime); - strftime(date_time, sizeof(date_time), "-%Y%m%d-%H%M%S", timeinfo); - } else { - date_time[0] = '\0'; - } - - if (asprintf(&new_session->path, "%s/%s%s", path, name, date_time) < 0) { + if (asprintf(&new_session->path, "%s", path) < 0) { ret = -ENOMEM; goto error_asprintf; }