X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=ltt-sessiond%2Fmain.c;h=5db41869f5b1e8c5176cbe07ca42b79e302e52a8;hp=567742ebb783bc1a4bfdf9f6ff89ddc8193f1604;hb=e8b608574c1ece1984f094388f8da2a0b4b3b83b;hpb=274e143ba43aefcd257a53048b7972dc89e94316

diff --git a/ltt-sessiond/main.c b/ltt-sessiond/main.c
index 567742ebb..5db41869f 100644
--- a/ltt-sessiond/main.c
+++ b/ltt-sessiond/main.c
@@ -41,9 +41,9 @@
 
 #include <urcu/list.h>		/* URCU list library (-lurcu) */
 #include <lttng/lttng.h>
+#include <lttng-sessiond-comm.h>
 
 #include "context.h"
-#include "liblttsessiondcomm.h"
 #include "ltt-sessiond.h"
 #include "lttngerr.h"
 #include "kernel-ctl.h"
@@ -158,6 +158,15 @@ static void teardown_kernel_session(struct ltt_session *session)
 {
 	if (session->kernel_session != NULL) {
 		DBG("Tearing down kernel session");
+
+		/*
+		 * If a custom kernel consumer was registered, close the socket before
+		 * tearing down the complete kernel session structure
+		 */
+		if (session->kernel_session->consumer_fd != kconsumerd_cmd_sock) {
+			lttcomm_close_unix_sock(session->kernel_session->consumer_fd);
+		}
+
 		trace_destroy_kernel_session(session->kernel_session);
 		/* Extra precaution */
 		session->kernel_session = NULL;
@@ -288,7 +297,9 @@ static int send_kconsumerd_channel_fds(int sock, struct ltt_kernel_channel *chan
 			lkm.fd = stream->fd;
 			lkm.state = stream->state;
 			lkm.max_sb_size = channel->channel->attr.subbuf_size;
+			lkm.output = channel->channel->attr.output;
 			strncpy(lkm.path_name, stream->pathname, PATH_MAX);
+			lkm.path_name[PATH_MAX - 1] = '\0';
 
 			DBG("Sending fd %d to kconsumerd", lkm.fd);
 
@@ -311,7 +322,7 @@ error:
 /*
  * Send all stream fds of the kernel session to the consumer.
  */
-static int send_kconsumerd_fds(int sock, struct ltt_kernel_session *session)
+static int send_kconsumerd_fds(struct ltt_kernel_session *session)
 {
 	int ret;
 	struct ltt_kernel_channel *chan;
@@ -324,7 +335,7 @@ static int send_kconsumerd_fds(int sock, struct ltt_kernel_session *session)
 
 	DBG("Sending kconsumerd header for metadata");
 
-	ret = lttcomm_send_unix_sock(sock, &lkh, sizeof(struct lttcomm_kconsumerd_header));
+	ret = lttcomm_send_unix_sock(session->consumer_fd, &lkh, sizeof(struct lttcomm_kconsumerd_header));
 	if (ret < 0) {
 		perror("send kconsumerd header");
 		goto error;
@@ -332,14 +343,21 @@ static int send_kconsumerd_fds(int sock, struct ltt_kernel_session *session)
 
 	DBG("Sending metadata stream fd");
 
+	/* Extra protection. It's NOT suppose to be set to 0 at this point */
+	if (session->consumer_fd == 0) {
+		session->consumer_fd = kconsumerd_cmd_sock;
+	}
+
 	if (session->metadata_stream_fd != 0) {
 		/* Send metadata stream fd first */
 		lkm.fd = session->metadata_stream_fd;
 		lkm.state = ACTIVE_FD;
 		lkm.max_sb_size = session->metadata->conf->attr.subbuf_size;
+		lkm.output = DEFAULT_KERNEL_CHANNEL_OUTPUT;
 		strncpy(lkm.path_name, session->metadata->pathname, PATH_MAX);
+		lkm.path_name[PATH_MAX - 1] = '\0';
 
-		ret = lttcomm_send_fds_unix_sock(sock, &lkm, &lkm.fd, 1, sizeof(lkm));
+		ret = lttcomm_send_fds_unix_sock(session->consumer_fd, &lkm, &lkm.fd, 1, sizeof(lkm));
 		if (ret < 0) {
 			perror("send kconsumerd fd");
 			goto error;
@@ -347,7 +365,7 @@ static int send_kconsumerd_fds(int sock, struct ltt_kernel_session *session)
 	}
 
 	cds_list_for_each_entry(chan, &session->channel_list.head, list) {
-		ret = send_kconsumerd_channel_fds(sock, chan);
+		ret = send_kconsumerd_channel_fds(session->consumer_fd, chan);
 		if (ret < 0) {
 			goto error;
 		}
@@ -546,6 +564,12 @@ static int update_kernel_stream(int fd)
 			unlock_session(session);
 			continue;
 		}
+
+		/* This is not suppose to be 0 but this is an extra security check */
+		if (session->kernel_session->consumer_fd == 0) {
+			session->kernel_session->consumer_fd = kconsumerd_cmd_sock;
+		}
+
 		cds_list_for_each_entry(channel, &session->kernel_session->channel_list.head, list) {
 			if (channel->fd == fd) {
 				DBG("Channel found, updating kernel streams");
@@ -553,12 +577,14 @@ static int update_kernel_stream(int fd)
 				if (ret < 0) {
 					goto end;
 				}
+
 				/*
 				 * Have we already sent fds to the consumer? If yes, it means that
 				 * tracing is started so it is safe to send our updated stream fds.
 				 */
 				if (session->kernel_session->kconsumer_fds_sent == 1) {
-					ret = send_kconsumerd_channel_fds(kconsumerd_cmd_sock, channel);
+					ret = send_kconsumerd_channel_fds(session->kernel_session->consumer_fd,
+							channel);
 					if (ret < 0) {
 						goto end;
 					}
@@ -883,6 +909,9 @@ error:
 	return ret;
 }
 
+/*
+ * Join kernel consumer thread
+ */
 static int join_kconsumerd_thread(void)
 {
 	void *status;
@@ -1005,7 +1034,7 @@ static int modprobe_kernel_modules(void)
 			ERR("Unable to launch modprobe for module %s",
 				kernel_modules_list[i].name);
 		} else if (kernel_modules_list[i].required
-			   && WEXITSTATUS(ret) != 0) {
+				&& WEXITSTATUS(ret) != 0) {
 			ERR("Unable to load module %s",
 				kernel_modules_list[i].name);
 		} else {
@@ -1041,7 +1070,7 @@ static int modprobe_remove_kernel_modules(void)
 			ERR("Unable to launch modprobe --remove for module %s",
 				kernel_modules_list[i].name);
 		} else if (kernel_modules_list[i].required
-			   && WEXITSTATUS(ret) != 0) {
+				&& WEXITSTATUS(ret) != 0) {
 			ERR("Unable to remove module %s",
 				kernel_modules_list[i].name);
 		} else {
@@ -1169,7 +1198,16 @@ static int start_kernel_trace(struct ltt_kernel_session *session)
 	int ret = 0;
 
 	if (session->kconsumer_fds_sent == 0) {
-		ret = send_kconsumerd_fds(kconsumerd_cmd_sock, session);
+		/*
+		 * Assign default kernel consumer if no consumer assigned to the kernel
+		 * session. At this point, it's NOT suppose to be 0 but this is an extra
+		 * security check.
+		 */
+		if (session->consumer_fd == 0) {
+			session->consumer_fd = kconsumerd_cmd_sock;
+		}
+
+		ret = send_kconsumerd_fds(session);
 		if (ret < 0) {
 			ERR("Send kconsumerd fds failed");
 			ret = LTTCOMM_KERN_CONSUMER_FAIL;
@@ -1243,8 +1281,20 @@ static int create_kernel_session(struct ltt_session *session)
 		goto error;
 	}
 
-	ret = mkdir_recursive(session->path, S_IRWXU | S_IRWXG,
-			      geteuid(), allowed_group()); 
+	/* Set kernel consumer socket fd */
+	if (kconsumerd_cmd_sock) {
+		session->kernel_session->consumer_fd = kconsumerd_cmd_sock;
+	}
+
+	ret = asprintf(&session->kernel_session->trace_path, "%s/kernel",
+			session->path);
+	if (ret < 0) {
+		perror("asprintf kernel traces path");
+		goto error;
+	}
+
+	ret = mkdir_recursive(session->kernel_session->trace_path,
+			S_IRWXU | S_IRWXG, geteuid(), allowed_group());
 	if (ret < 0) {
 		if (ret != -EEXIST) {
 			ERR("Trace directory creation error");
@@ -1275,7 +1325,9 @@ static void list_lttng_sessions(struct lttng_session *sessions)
 	 */
 	cds_list_for_each_entry(session, &session_list_ptr->head, list) {
 		strncpy(sessions[i].path, session->path, PATH_MAX);
+		sessions[i].path[PATH_MAX - 1] = '\0';
 		strncpy(sessions[i].name, session->name, NAME_MAX);
+		sessions[i].name[NAME_MAX - 1] = '\0';
 		i++;
 	}
 }
@@ -1321,6 +1373,7 @@ static void list_lttng_events(struct ltt_kernel_channel *kchan,
 	/* Kernel channels */
 	cds_list_for_each_entry(event, &kchan->events_list.head , list) {
 		strncpy(events[i].name, event->event->name, LTTNG_SYMBOL_NAME_LEN);
+		events[i].name[LTTNG_SYMBOL_NAME_LEN - 1] = '\0';
 		events[i].enabled = event->enabled;
 		switch (event->event->instrumentation) {
 			case LTTNG_KERNEL_TRACEPOINT:
@@ -1355,7 +1408,9 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 
 	DBG("Processing client command %d", cmd_ctx->lsm->cmd_type);
 
-	/* Listing commands don't need a session */
+	/*
+	 * Commands that DO NOT need a session.
+	 */
 	switch (cmd_ctx->lsm->cmd_type) {
 	case LTTNG_CREATE_SESSION:
 	case LTTNG_LIST_SESSIONS:
@@ -1396,10 +1451,10 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 
 		/* Need a session for kernel command */
 		switch (cmd_ctx->lsm->cmd_type) {
+		case LTTNG_CALIBRATE:
 		case LTTNG_CREATE_SESSION:
 		case LTTNG_LIST_SESSIONS:
 		case LTTNG_LIST_TRACEPOINTS:
-		case LTTNG_CALIBRATE:
 			break;
 		default:
 			if (cmd_ctx->session->kernel_session == NULL) {
@@ -1410,7 +1465,9 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 				}
 
 				/* Start the kernel consumer daemon */
-				if (kconsumerd_pid == 0) {
+
+				if (kconsumerd_pid == 0 &&
+						cmd_ctx->lsm->cmd_type != LTTNG_REGISTER_CONSUMER) {
 					ret = start_kconsumerd();
 					if (ret < 0) {
 						goto error;
@@ -1444,6 +1501,7 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 			strncpy(kctx.u.perf_counter.name,
 					cmd_ctx->lsm->u.context.ctx.u.perf_counter.name,
 					LTTNG_SYMBOL_NAME_LEN);
+			kctx.u.perf_counter.name[LTTNG_SYMBOL_NAME_LEN - 1] = '\0';
 
 			/* Add kernel context to kernel tracer. See context.c */
 			ret = add_kernel_context(cmd_ctx->session->kernel_session, &kctx,
@@ -1603,7 +1661,8 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 				DBG("Creating kernel channel");
 
 				ret = kernel_create_channel(cmd_ctx->session->kernel_session,
-						&cmd_ctx->lsm->u.channel.chan, cmd_ctx->session->path);
+						&cmd_ctx->lsm->u.channel.chan,
+						cmd_ctx->session->kernel_session->trace_path);
 				if (ret < 0) {
 					ret = LTTCOMM_KERN_CHAN_FAIL;
 					goto error;
@@ -1666,7 +1725,7 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 					}
 
 					ret = kernel_create_channel(cmd_ctx->session->kernel_session,
-							chan, cmd_ctx->session->path);
+							chan, cmd_ctx->session->kernel_session->trace_path);
 					if (ret < 0) {
 						ret = LTTCOMM_KERN_CHAN_FAIL;
 						goto error;
@@ -1738,7 +1797,7 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 					}
 
 					ret = kernel_create_channel(cmd_ctx->session->kernel_session,
-							chan, cmd_ctx->session->path);
+							chan, cmd_ctx->session->kernel_session->trace_path);
 					if (ret < 0) {
 						ret = LTTCOMM_KERN_CHAN_FAIL;
 						goto error;
@@ -1843,7 +1902,7 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 			if (cmd_ctx->session->kernel_session->metadata == NULL) {
 				DBG("Open kernel metadata");
 				ret = kernel_open_metadata(cmd_ctx->session->kernel_session,
-						cmd_ctx->session->path);
+						cmd_ctx->session->kernel_session->trace_path);
 				if (ret < 0) {
 					ret = LTTCOMM_KERN_META_FAIL;
 					goto error;
@@ -2062,7 +2121,7 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 			goto setup_error;
 		}
 
-		DBG("Listing events (%ld events)", nb_event);
+		DBG("Listing events (%zu events)", nb_event);
 
 		list_lttng_events(kchan,
 				(struct lttng_event *)(cmd_ctx->llm->payload));
@@ -2095,7 +2154,6 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 		ret = LTTCOMM_OK;
 		break;
 	}
-
 	case LTTNG_CALIBRATE:
 	{
 		/* Setup lttng message with no payload */
@@ -2125,6 +2183,43 @@ static int process_client_msg(struct command_ctx *cmd_ctx)
 		ret = LTTCOMM_OK;
 		break;
 	}
+	case LTTNG_REGISTER_CONSUMER:
+	{
+		int sock;
+
+		/* Setup lttng message with no payload */
+		ret = setup_lttng_msg(cmd_ctx, 0);
+		if (ret < 0) {
+			goto setup_error;
+		}
+
+		switch (cmd_ctx->lsm->domain.type) {
+		case LTTNG_DOMAIN_KERNEL:
+			{
+				/* Can't register a consumer if there is already one */
+				if (cmd_ctx->session->kernel_session->consumer_fd != 0) {
+					ret = LTTCOMM_CONNECT_FAIL;
+					goto error;
+				}
+
+				sock = lttcomm_connect_unix_sock(cmd_ctx->lsm->u.reg.path);
+				if (sock < 0) {
+					ret = LTTCOMM_CONNECT_FAIL;
+					goto error;
+				}
+
+				cmd_ctx->session->kernel_session->consumer_fd = sock;
+				break;
+			}
+		default:
+			/* TODO: Userspace tracing */
+			ret = LTTCOMM_NOT_IMPLEMENTED;
+			goto error;
+		}
+
+		ret = LTTCOMM_OK;
+		break;
+	}
 
 	default:
 		/* Undefined command */