X-Git-Url: https://git.lttng.org/?p=lttng-tools.git;a=blobdiff_plain;f=ltt-sessiond%2Fmain.c;h=5a8119f917b40b6d4b4aaa92759a8f124de9f62c;hp=05114e1f2cbed563814c4f4babd80d963eddd1f6;hb=19e708528b7ebd740485ca05056e56e6835d43a7;hpb=7b3958902a08e7d96d388614f2726ad8a6fc9df2 diff --git a/ltt-sessiond/main.c b/ltt-sessiond/main.c index 05114e1f2..5a8119f91 100644 --- a/ltt-sessiond/main.c +++ b/ltt-sessiond/main.c @@ -1,7 +1,4 @@ /* - DBG("Creating kernel event %s for channel %s.", - cmd_ctx->lsm->u.enable.event.name, cmd_ctx->lsm->u.enable.channel_name); - * Copyright (C) 2011 - David Goulet * * This program is free software; you can redistribute it and/or @@ -876,10 +873,10 @@ static int process_client_msg(struct command_ctx *cmd_ctx) ret = LTTCOMM_OK; break; } - case LTTNG_KERNEL_ENABLE_EVENT: + case LTTNG_KERNEL_DISABLE_EVENT: { - int found = 0; struct ltt_kernel_channel *chan; + struct ltt_kernel_event *ev; /* Setup lttng message with no payload */ ret = setup_lttng_msg(cmd_ctx, 0); @@ -887,28 +884,64 @@ static int process_client_msg(struct command_ctx *cmd_ctx) goto setup_error; } - /* Get channel by name and create event for that channel */ - cds_list_for_each_entry(chan, &cmd_ctx->session->kernel_session->channel_list.head, list) { - if (strcmp(cmd_ctx->lsm->u.enable.channel_name, chan->channel->name) == 0) { - DBG("Creating kernel event %s for channel %s.", - cmd_ctx->lsm->u.enable.event.name, cmd_ctx->lsm->u.enable.channel_name); + chan = get_kernel_channel_by_name(cmd_ctx->lsm->u.disable.channel_name, + cmd_ctx->session->kernel_session); + if (chan == NULL) { + ret = LTTCOMM_KERN_CHAN_NOT_FOUND; + goto error; + } - ret = kernel_create_event(chan, &cmd_ctx->lsm->u.enable.event); - if (ret < 0) { - ret = LTTCOMM_KERN_ENABLE_FAIL; - goto error; - } - found = 1; - break; + ev = get_kernel_event_by_name(cmd_ctx->lsm->u.disable.name, chan); + if (ev != NULL) { + DBG("Disabling kernel event %s for channel %s.", + cmd_ctx->lsm->u.disable.name, cmd_ctx->lsm->u.disable.channel_name); + ret = kernel_disable_event(ev); + if (ret < 0) { + ret = LTTCOMM_KERN_ENABLE_FAIL; + goto error; } } - if (!found) { + kernel_wait_quiescent(kernel_tracer_fd); + ret = LTTCOMM_OK; + break; + } + case LTTNG_KERNEL_ENABLE_EVENT: + { + struct ltt_kernel_channel *chan; + struct ltt_kernel_event *ev; + + /* Setup lttng message with no payload */ + ret = setup_lttng_msg(cmd_ctx, 0); + if (ret < 0) { + goto setup_error; + } + + chan = get_kernel_channel_by_name(cmd_ctx->lsm->u.enable.channel_name, + cmd_ctx->session->kernel_session); + if (chan == NULL) { ret = LTTCOMM_KERN_CHAN_NOT_FOUND; + goto error; + } + + ev = get_kernel_event_by_name(cmd_ctx->lsm->u.enable.event.name, chan); + if (ev == NULL) { + DBG("Creating kernel event %s for channel %s.", + cmd_ctx->lsm->u.enable.event.name, cmd_ctx->lsm->u.enable.channel_name); + ret = kernel_create_event(&cmd_ctx->lsm->u.enable.event, chan); } else { - kernel_wait_quiescent(kernel_tracer_fd); - ret = LTTCOMM_OK; + DBG("Enabling kernel event %s for channel %s.", + cmd_ctx->lsm->u.enable.event.name, cmd_ctx->lsm->u.enable.channel_name); + ret = kernel_enable_event(ev); + } + + if (ret < 0) { + ret = LTTCOMM_KERN_ENABLE_FAIL; + goto error; } + + kernel_wait_quiescent(kernel_tracer_fd); + ret = LTTCOMM_OK; break; } case LTTNG_KERNEL_ENABLE_ALL_EVENT: @@ -951,7 +984,7 @@ static int process_client_msg(struct command_ctx *cmd_ctx) /* Default event type for enable all */ ev.type = LTTNG_EVENT_TRACEPOINTS; /* Enable each single tracepoint event */ - ret = kernel_create_event(chan, &ev); + ret = kernel_create_event(&ev, chan); if (ret < 0) { ret = LTTCOMM_KERN_ENABLE_FAIL; goto error;