Fix: Double free in utils_partial_realpath error path

[lttng-tools.git] / src / common / utils.c

diff --git a/src/common/utils.c b/src/common/utils.c
index df55dc9fb65880db9dc75373c390634849e0fd34..901ddb036771d77ff7ab1c2f723c98db7f895bbb 100644 (file)
--- a/src/common/utils.c
+++ b/src/common/utils.c
@@ -189,6 +189,10 @@ char *utils_partial_realpath(const char *path, char *resolved_path, size_t size)
 error:
        free(resolved_path);
        free(cut_path);
+       free(try_path);
+       if (try_path_prev != try_path) {
+               free(try_path_prev);
+       }
        return NULL;
 }
 
@@ -1347,7 +1351,7 @@ end:
 
 static const char *get_man_bin_path(void)
 {
-       char *env_man_path = getenv(DEFAULT_MAN_BIN_PATH_ENV);
+       char *env_man_path = lttng_secure_getenv(DEFAULT_MAN_BIN_PATH_ENV);
 
        if (env_man_path) {
                return env_man_path;