Fix: unchecked buffer size for communication header

[lttng-tools.git] / src / common / evaluation.c

diff --git a/src/common/evaluation.c b/src/common/evaluation.c
index 91d5c0b1d8de7edbe397449784a264c873f9b923..b76d349fa40526225d9b7199a0d919955a1d8bfb 100644 (file)
--- a/src/common/evaluation.c
+++ b/src/common/evaluation.c
@@ -1,18 +1,8 @@
 /*
- * Copyright (C) 2017 - Jérémie Galarneau <jeremie.galarneau@efficios.com>
+ * Copyright (C) 2017 Jérémie Galarneau <jeremie.galarneau@efficios.com>
  *
- * This library is free software; you can redistribute it and/or modify it
- * under the terms of the GNU Lesser General Public License, version 2.1 only,
- * as published by the Free Software Foundation.
+ * SPDX-License-Identifier: LGPL-2.1-only
  *
- * This library is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
- * for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this library; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
 #include <lttng/condition/evaluation-internal.h>
@@ -32,22 +22,22 @@ void lttng_evaluation_init(struct lttng_evaluation *evaluation,
 }
 
 LTTNG_HIDDEN
-int lttng_evaluation_serialize(struct lttng_evaluation *evaluation,
-               struct lttng_dynamic_buffer *buf)
+int lttng_evaluation_serialize(const struct lttng_evaluation *evaluation,
+               struct lttng_payload *payload)
 {
        int ret;
        struct lttng_evaluation_comm evaluation_comm = {
                .type = (int8_t) evaluation->type
        };
 
-       ret = lttng_dynamic_buffer_append(buf, &evaluation_comm,
+       ret = lttng_dynamic_buffer_append(&payload->buffer, &evaluation_comm,
                        sizeof(evaluation_comm));
        if (ret) {
                goto end;
        }
 
        if (evaluation->serialize) {
-               ret = evaluation->serialize(evaluation, buf);
+               ret = evaluation->serialize(evaluation, payload);
                if (ret) {
                        goto end;
                }
@@ -57,27 +47,35 @@ end:
 }
 
 LTTNG_HIDDEN
-ssize_t lttng_evaluation_create_from_buffer(
-               const struct lttng_buffer_view *src_view,
+ssize_t lttng_evaluation_create_from_payload(
+               struct lttng_payload_view *src_view,
                struct lttng_evaluation **evaluation)
 {
        ssize_t ret, evaluation_size = 0;
        const struct lttng_evaluation_comm *evaluation_comm;
-       const struct lttng_buffer_view evaluation_view =
-                       lttng_buffer_view_from_view(src_view,
-                       sizeof(*evaluation_comm), -1);
+       struct lttng_payload_view evaluation_comm_view =
+                       lttng_payload_view_from_view(
+                                       src_view, 0, sizeof(*evaluation_comm));
+       struct lttng_payload_view evaluation_view =
+                       lttng_payload_view_from_view(src_view,
+                                       sizeof(*evaluation_comm), -1);
 
        if (!src_view || !evaluation) {
                ret = -1;
                goto end;
        }
 
-       evaluation_comm = (const struct lttng_evaluation_comm *) src_view->data;
+       if (!lttng_payload_view_is_valid(&evaluation_comm_view)) {
+               ret = -1;
+               goto end;
+       }
+
+       evaluation_comm = (typeof(evaluation_comm)) evaluation_comm_view.buffer.data;
        evaluation_size += sizeof(*evaluation_comm);
 
        switch ((enum lttng_condition_type) evaluation_comm->type) {
        case LTTNG_CONDITION_TYPE_BUFFER_USAGE_LOW:
-               ret = lttng_evaluation_buffer_usage_low_create_from_buffer(
+               ret = lttng_evaluation_buffer_usage_low_create_from_payload(
                                &evaluation_view, evaluation);
                if (ret < 0) {
                        goto end;
@@ -85,7 +83,7 @@ ssize_t lttng_evaluation_create_from_buffer(
                evaluation_size += ret;
                break;
        case LTTNG_CONDITION_TYPE_BUFFER_USAGE_HIGH:
-               ret = lttng_evaluation_buffer_usage_high_create_from_buffer(
+               ret = lttng_evaluation_buffer_usage_high_create_from_payload(
                                &evaluation_view, evaluation);
                if (ret < 0) {
                        goto end;
@@ -93,7 +91,7 @@ ssize_t lttng_evaluation_create_from_buffer(
                evaluation_size += ret;
                break;
        case LTTNG_CONDITION_TYPE_SESSION_CONSUMED_SIZE:
-               ret = lttng_evaluation_session_consumed_size_create_from_buffer(
+               ret = lttng_evaluation_session_consumed_size_create_from_payload(
                                &evaluation_view, evaluation);
                if (ret < 0) {
                        goto end;
@@ -101,7 +99,7 @@ ssize_t lttng_evaluation_create_from_buffer(
                evaluation_size += ret;
                break;
        case LTTNG_CONDITION_TYPE_SESSION_ROTATION_ONGOING:
-               ret = lttng_evaluation_session_rotation_ongoing_create_from_buffer(
+               ret = lttng_evaluation_session_rotation_ongoing_create_from_payload(
                                &evaluation_view, evaluation);
                if (ret < 0) {
                        goto end;
@@ -109,7 +107,7 @@ ssize_t lttng_evaluation_create_from_buffer(
                evaluation_size += ret;
                break;
        case LTTNG_CONDITION_TYPE_SESSION_ROTATION_COMPLETED:
-               ret = lttng_evaluation_session_rotation_completed_create_from_buffer(
+               ret = lttng_evaluation_session_rotation_completed_create_from_payload(
                                &evaluation_view, evaluation);
                if (ret < 0) {
                        goto end;
@@ -122,6 +120,7 @@ ssize_t lttng_evaluation_create_from_buffer(
                ret = -1;
                goto end;
        }
+
        ret = evaluation_size;
 end:
        return ret;