Fix: sessions with agent channels fail to load
[lttng-tools.git] / src / common / config / session-config.c
index 69b62d7523b6cd286df13f6bddb918bba5f726ce..0d75a088d402e17076b53994fb6f6915b0d8f13c 100644 (file)
@@ -40,6 +40,7 @@
 #include <libxml/tree.h>
 #include <lttng/lttng.h>
 #include <lttng/snapshot.h>
+#include <lttng/rotation.h>
 
 #include "session-config.h"
 #include "config-internal.h"
@@ -91,7 +92,8 @@ const char * const config_element_subbuf_size = "subbuffer_size";
 const char * const config_element_num_subbuf = "subbuffer_count";
 const char * const config_element_switch_timer_interval = "switch_timer_interval";
 const char * const config_element_read_timer_interval = "read_timer_interval";
-const char * const config_element_monitor_timer_interval = "monitor_timer_interval";
+LTTNG_HIDDEN const char * const config_element_monitor_timer_interval = "monitor_timer_interval";
+LTTNG_HIDDEN const char * const config_element_blocking_timeout = "blocking_timeout";
 const char * const config_element_output = "output";
 const char * const config_element_output_type = "output_type";
 const char * const config_element_tracefile_size = "tracefile_size";
@@ -130,6 +132,10 @@ const char * const config_element_trackers = "trackers";
 const char * const config_element_targets = "targets";
 const char * const config_element_target_pid = "pid_target";
 
+LTTNG_HIDDEN const char * const config_element_rotation_timer_interval = "rotation_schedule_timer_period";
+LTTNG_HIDDEN const char * const config_element_rotation_size = "rotation_schedule_size";
+LTTNG_HIDDEN const char * const config_element_rotation_schedule = "rotation_schedule";
+
 const char * const config_domain_type_kernel = "KERNEL";
 const char * const config_domain_type_ust = "UST";
 const char * const config_domain_type_jul = "JUL";
@@ -2079,6 +2085,56 @@ int process_channel_attr_node(xmlNodePtr attr_node,
 
                channel->attr.live_timer_interval =
                        live_timer_interval;
+       } else if (!strcmp((const char *) attr_node->name,
+                       config_element_monitor_timer_interval)) {
+               xmlChar *content;
+               uint64_t monitor_timer_interval = 0;
+
+               /* monitor_timer_interval */
+               content = xmlNodeGetContent(attr_node);
+               if (!content) {
+                       ret = -LTTNG_ERR_NOMEM;
+                       goto end;
+               }
+
+               ret = parse_uint(content, &monitor_timer_interval);
+               free(content);
+               if (ret) {
+                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                       goto end;
+               }
+
+               ret = lttng_channel_set_monitor_timer_interval(channel,
+                       monitor_timer_interval);
+               if (ret) {
+                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                       goto end;
+               }
+       } else if (!strcmp((const char *) attr_node->name,
+                       config_element_blocking_timeout)) {
+               xmlChar *content;
+               int64_t blocking_timeout = 0;
+
+               /* blocking_timeout */
+               content = xmlNodeGetContent(attr_node);
+               if (!content) {
+                       ret = -LTTNG_ERR_NOMEM;
+                       goto end;
+               }
+
+               ret = parse_int(content, &blocking_timeout);
+               free(content);
+               if (ret) {
+                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                       goto end;
+               }
+
+               ret = lttng_channel_set_blocking_timeout(channel,
+                       blocking_timeout);
+               if (ret) {
+                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                       goto end;
+               }
        } else if (!strcmp((const char *) attr_node->name,
                        config_element_events)) {
                /* events */
@@ -2339,13 +2395,13 @@ end:
        return ret;
 }
 
-
 static
 int process_domain_node(xmlNodePtr domain_node, const char *session_name)
 {
        int ret;
        struct lttng_domain domain = { 0 };
        struct lttng_handle *handle = NULL;
+       struct lttng_channel *channel = NULL;
        xmlNodePtr channels_node = NULL;
        xmlNodePtr trackers_node = NULL;
        xmlNodePtr pid_tracker_node = NULL;
@@ -2381,40 +2437,69 @@ int process_domain_node(xmlNodePtr domain_node, const char *session_name)
        /* create all channels */
        for (node = xmlFirstElementChild(channels_node); node;
                node = xmlNextElementSibling(node)) {
-               struct lttng_channel channel;
+               const enum lttng_domain_type original_domain = domain.type;
                xmlNodePtr contexts_node = NULL;
                xmlNodePtr events_node = NULL;
                xmlNodePtr channel_attr_node;
 
-               memset(&channel, 0, sizeof(channel));
-               lttng_channel_set_default_attr(&domain, &channel.attr);
+               /*
+                * Channels of the "agent" types cannot be created directly.
+                * They are meant to be created implicitly through the
+                * activation of events in their domain. However, a user
+                * can override the default channel configuration attributes
+                * by creating the underlying UST channel _before_ enabling
+                * an agent domain event.
+                *
+                * Hence, the channel's type is substituted before the creation
+                * and restored by the time the events are created.
+                */
+               switch (domain.type) {
+               case LTTNG_DOMAIN_JUL:
+               case LTTNG_DOMAIN_LOG4J:
+               case LTTNG_DOMAIN_PYTHON:
+                       domain.type = LTTNG_DOMAIN_UST;
+               default:
+                       break;
+               }
+
+               channel = lttng_channel_create(&domain);
+               if (!channel) {
+                       ret = -1;
+                       goto end;
+               }
 
                for (channel_attr_node = xmlFirstElementChild(node);
                        channel_attr_node; channel_attr_node =
                        xmlNextElementSibling(channel_attr_node)) {
                        ret = process_channel_attr_node(channel_attr_node,
-                               &channel, &contexts_node, &events_node);
+                               channel, &contexts_node, &events_node);
                        if (ret) {
                                goto end;
                        }
                }
 
-               ret = lttng_enable_channel(handle, &channel);
+               ret = lttng_enable_channel(handle, channel);
                if (ret < 0) {
                        goto end;
                }
 
-               ret = process_events_node(events_node, handle, channel.name);
+               /* Restore the original channel domain. */
+               domain.type = original_domain;
+
+               ret = process_events_node(events_node, handle, channel->name);
                if (ret) {
                        goto end;
                }
 
                ret = process_contexts_node(contexts_node, handle,
-                       channel.name);
+                       channel->name);
                if (ret) {
                        goto end;
                }
+
+               lttng_channel_destroy(channel);
        }
+       channel = NULL;
 
        /* get the trackers node */
        for (node = xmlFirstElementChild(domain_node); node;
@@ -2446,6 +2531,7 @@ int process_domain_node(xmlNodePtr domain_node, const char *session_name)
        }
 
 end:
+       lttng_channel_destroy(channel);
        lttng_destroy_handle(handle);
        return ret;
 }
@@ -2456,12 +2542,15 @@ int process_session_node(xmlNodePtr session_node, const char *session_name,
                const struct config_load_session_override_attr *overrides)
 {
        int ret, started = -1, snapshot_mode = -1;
-       uint64_t live_timer_interval = UINT64_MAX;
+       uint64_t live_timer_interval = UINT64_MAX,
+                        rotation_timer_interval = 0,
+                        rotation_size = 0;
        xmlChar *name = NULL;
        xmlChar *shm_path = NULL;
        xmlNodePtr domains_node = NULL;
        xmlNodePtr output_node = NULL;
        xmlNodePtr node;
+       xmlNodePtr attributes_child;
        struct lttng_domain *kernel_domain = NULL;
        struct lttng_domain *ust_domain = NULL;
        struct lttng_domain *jul_domain = NULL;
@@ -2514,40 +2603,78 @@ int process_session_node(xmlNodePtr session_node, const char *session_name,
 
                        shm_path = node_content;
                } else {
-                       /* attributes, snapshot_mode or live_timer_interval */
-                       xmlNodePtr attributes_child =
-                               xmlFirstElementChild(node);
-
-                       if (!strcmp((const char *) attributes_child->name,
-                               config_element_snapshot_mode)) {
-                               /* snapshot_mode */
-                               xmlChar *snapshot_mode_content =
-                                       xmlNodeGetContent(attributes_child);
-                               if (!snapshot_mode_content) {
-                                       ret = -LTTNG_ERR_NOMEM;
-                                       goto error;
-                               }
+                       /*
+                        * attributes, snapshot_mode, live_timer_interval, rotation_size,
+                        * rotation_timer_interval.
+                        */
+                       for (attributes_child = xmlFirstElementChild(node); attributes_child;
+                                       attributes_child = xmlNextElementSibling(attributes_child)) {
+                               if (!strcmp((const char *) attributes_child->name,
+                                                       config_element_snapshot_mode)) {
+                                       /* snapshot_mode */
+                                       xmlChar *snapshot_mode_content =
+                                               xmlNodeGetContent(attributes_child);
+                                       if (!snapshot_mode_content) {
+                                               ret = -LTTNG_ERR_NOMEM;
+                                               goto error;
+                                       }
 
-                               ret = parse_bool(snapshot_mode_content, &snapshot_mode);
-                               free(snapshot_mode_content);
-                               if (ret) {
-                                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
-                                       goto error;
+                                       ret = parse_bool(snapshot_mode_content, &snapshot_mode);
+                                       free(snapshot_mode_content);
+                                       if (ret) {
+                                               ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                                               goto error;
+                                       }
+                               } else if (!strcmp((const char *) attributes_child->name,
+                                                       config_element_live_timer_interval)) {
+                                       /* live_timer_interval */
+                                       xmlChar *timer_interval_content =
+                                               xmlNodeGetContent(attributes_child);
+                                       if (!timer_interval_content) {
+                                               ret = -LTTNG_ERR_NOMEM;
+                                               goto error;
+                                       }
+
+                                       ret = parse_uint(timer_interval_content, &live_timer_interval);
+                                       free(timer_interval_content);
+                                       if (ret) {
+                                               ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                                               goto error;
+                                       }
                                }
-                       } else {
-                               /* live_timer_interval */
-                               xmlChar *timer_interval_content =
-                                       xmlNodeGetContent(attributes_child);
-                               if (!timer_interval_content) {
-                                       ret = -LTTNG_ERR_NOMEM;
-                                       goto error;
+                               if (!strcmp((const char *) attributes_child->name,
+                                                       config_element_rotation_timer_interval)) {
+                                       /* rotation_timer_interval */
+                                       xmlChar *timer_interval_content =
+                                               xmlNodeGetContent(attributes_child);
+                                       if (!timer_interval_content) {
+                                               ret = -LTTNG_ERR_NOMEM;
+                                               goto error;
+                                       }
+
+                                       ret = parse_uint(timer_interval_content, &rotation_timer_interval);
+                                       free(timer_interval_content);
+                                       if (ret) {
+                                               ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                                               goto error;
+                                       }
                                }
+                               if (!strcmp((const char *) attributes_child->name,
+                                                       config_element_rotation_size)) {
+                                       /* rotation_size */
+                                       xmlChar *rotation_size_content =
+                                               xmlNodeGetContent(attributes_child);
+                                       if (!rotation_size_content) {
+                                               ret = -LTTNG_ERR_NOMEM;
+                                               goto error;
+                                       }
 
-                               ret = parse_uint(timer_interval_content, &live_timer_interval);
-                               free(timer_interval_content);
-                               if (ret) {
-                                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
-                                       goto error;
+                                       ret = parse_uint(rotation_size_content, &rotation_size);
+                                       free(rotation_size_content);
+                                       if (ret) {
+                                               ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                                               goto error;
+                                       }
                                }
                        }
                }
@@ -2687,6 +2814,27 @@ domain_init_error:
                }
        }
 
+       if (rotation_timer_interval || rotation_size) {
+               struct lttng_rotation_schedule_attr *rotation_attr = lttng_rotation_schedule_attr_create();
+
+               if (!rotation_attr) {
+                       goto error;
+               }
+               ret = lttng_rotation_schedule_attr_set_session_name(rotation_attr, (const char *) name);
+               if (ret) {
+                       lttng_rotation_schedule_attr_destroy(rotation_attr);
+                       goto error;
+               }
+               lttng_rotation_schedule_attr_set_timer_period(rotation_attr,
+                               rotation_timer_interval);
+               lttng_rotation_schedule_attr_set_size(rotation_attr, rotation_size);
+               ret = lttng_rotation_set_schedule(rotation_attr);
+               lttng_rotation_schedule_attr_destroy(rotation_attr);
+               if (ret) {
+                       goto error;
+               }
+       }
+
        if (started) {
                ret = lttng_start_tracing((const char *) name);
                if (ret) {
@@ -2945,7 +3093,6 @@ static int validate_path_creds(const char *path)
                if (errno != ENOENT) {
                        PERROR("stat");
                }
-               ret = -LTTNG_ERR_INVALID;
                goto valid;
        }
 
This page took 0.027208 seconds and 4 git commands to generate.