Fix: sessions with agent channels fail to load
[lttng-tools.git] / src / common / config / session-config.c
index 01b6d9c0e65066ae3fcfba47697fad748d88a3f0..0d75a088d402e17076b53994fb6f6915b0d8f13c 100644 (file)
@@ -40,6 +40,7 @@
 #include <libxml/tree.h>
 #include <lttng/lttng.h>
 #include <lttng/snapshot.h>
+#include <lttng/rotation.h>
 
 #include "session-config.h"
 #include "config-internal.h"
@@ -91,6 +92,8 @@ const char * const config_element_subbuf_size = "subbuffer_size";
 const char * const config_element_num_subbuf = "subbuffer_count";
 const char * const config_element_switch_timer_interval = "switch_timer_interval";
 const char * const config_element_read_timer_interval = "read_timer_interval";
+LTTNG_HIDDEN const char * const config_element_monitor_timer_interval = "monitor_timer_interval";
+LTTNG_HIDDEN const char * const config_element_blocking_timeout = "blocking_timeout";
 const char * const config_element_output = "output";
 const char * const config_element_output_type = "output_type";
 const char * const config_element_tracefile_size = "tracefile_size";
@@ -129,6 +132,10 @@ const char * const config_element_trackers = "trackers";
 const char * const config_element_targets = "targets";
 const char * const config_element_target_pid = "pid_target";
 
+LTTNG_HIDDEN const char * const config_element_rotation_timer_interval = "rotation_schedule_timer_period";
+LTTNG_HIDDEN const char * const config_element_rotation_size = "rotation_schedule_size";
+LTTNG_HIDDEN const char * const config_element_rotation_schedule = "rotation_schedule";
+
 const char * const config_domain_type_kernel = "KERNEL";
 const char * const config_domain_type_ust = "UST";
 const char * const config_domain_type_jul = "JUL";
@@ -178,6 +185,9 @@ LTTNG_HIDDEN const char * const config_event_context_preemptible = "PREEMPTIBLE"
 LTTNG_HIDDEN const char * const config_event_context_need_reschedule = "NEED_RESCHEDULE";
 LTTNG_HIDDEN const char * const config_event_context_migratable = "MIGRATABLE";
 
+/* Deprecated symbols */
+const char * const config_element_perf;
+
 enum process_event_node_phase {
        CREATION = 0,
        ENABLE = 1,
@@ -1185,7 +1195,8 @@ end:
 }
 
 static
-int create_snapshot_session(const char *session_name, xmlNodePtr output_node)
+int create_snapshot_session(const char *session_name, xmlNodePtr output_node,
+               const struct config_load_session_override_attr *overrides)
 {
        int ret;
        xmlNodePtr node = NULL;
@@ -1215,6 +1226,9 @@ int create_snapshot_session(const char *session_name, xmlNodePtr output_node)
                uint64_t max_size = UINT64_MAX;
                struct consumer_output output = { 0 };
                struct lttng_snapshot_output *snapshot_output = NULL;
+               const char *control_uri = NULL;
+               const char *data_uri = NULL;
+               const char *path = NULL;
 
                for (node = xmlFirstElementChild(snapshot_output_node); node;
                                node = xmlNextElementSibling(node)) {
@@ -1250,6 +1264,30 @@ int create_snapshot_session(const char *session_name, xmlNodePtr output_node)
                        }
                }
 
+               control_uri = output.control_uri;
+               data_uri = output.data_uri;
+               path = output.path;
+
+               if (overrides) {
+                       if (overrides->path_url) {
+                               path = overrides->path_url;
+                               /* Control/data_uri are null */
+                               control_uri = NULL;
+                               data_uri = NULL;
+                       } else {
+                               if (overrides->ctrl_url) {
+                                       control_uri = overrides->ctrl_url;
+                                       /* path is null */
+                                       path = NULL;
+                               }
+                               if (overrides->data_url) {
+                                       data_uri = overrides->data_url;
+                                       /* path is null */
+                                       path = NULL;
+                               }
+                       }
+               }
+
                snapshot_output = lttng_snapshot_output_create();
                if (!snapshot_output) {
                        ret = -LTTNG_ERR_NOMEM;
@@ -1266,23 +1304,23 @@ int create_snapshot_session(const char *session_name, xmlNodePtr output_node)
                        goto error_snapshot_output;
                }
 
-               if (output.path) {
-                       ret = lttng_snapshot_output_set_ctrl_url(output.path,
+               if (path) {
+                       ret = lttng_snapshot_output_set_ctrl_url(path,
                                        snapshot_output);
                        if (ret) {
                                goto error_snapshot_output;
                        }
                } else {
-                       if (output.control_uri) {
-                               ret = lttng_snapshot_output_set_ctrl_url(output.control_uri,
+                       if (control_uri) {
+                               ret = lttng_snapshot_output_set_ctrl_url(control_uri,
                                                snapshot_output);
                                if (ret) {
                                        goto error_snapshot_output;
                                }
                        }
 
-                       if (output.data_uri) {
-                               ret = lttng_snapshot_output_set_data_url(output.data_uri,
+                       if (data_uri) {
+                               ret = lttng_snapshot_output_set_data_url(data_uri,
                                                snapshot_output);
                                if (ret) {
                                        goto error_snapshot_output;
@@ -1312,11 +1350,15 @@ int create_session(const char *name,
        struct lttng_domain *jul_domain,
        struct lttng_domain *log4j_domain,
        xmlNodePtr output_node,
-       uint64_t live_timer_interval)
+       uint64_t live_timer_interval,
+       const struct config_load_session_override_attr *overrides)
 {
        int ret;
        struct consumer_output output = { 0 };
        xmlNodePtr consumer_output_node;
+       const char *control_uri = NULL;
+       const char *data_uri = NULL;
+       const char *path = NULL;
 
        assert(name);
 
@@ -1341,13 +1383,38 @@ int create_session(const char *name,
                }
        }
 
-       if (live_timer_interval != UINT64_MAX &&
-               !output.control_uri && !output.data_uri) {
+       control_uri = output.control_uri;
+       data_uri = output.data_uri;
+       path = output.path;
+
+       /* Check for override and apply them */
+       if (overrides) {
+               if (overrides->path_url) {
+                       path = overrides->path_url;
+                       /* control/data_uri are null */;
+                       control_uri = NULL;
+                       data_uri = NULL;
+               } else {
+                       if (overrides->ctrl_url) {
+                               control_uri = overrides->ctrl_url;
+                               /* path is null */
+                               path = NULL;
+                       }
+                       if (overrides->data_url) {
+                               data_uri = overrides->data_url;
+                               /* path is null */
+                               path = NULL;
+                       }
+               }
+       }
+
+
+       if (live_timer_interval != UINT64_MAX && !control_uri && !data_uri) {
                ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
                goto end;
        }
 
-       if (output.control_uri || output.data_uri) {
+       if (control_uri || data_uri) {
                /* network destination */
                if (live_timer_interval && live_timer_interval != UINT64_MAX) {
                        /*
@@ -1363,15 +1430,14 @@ int create_session(const char *name,
                        goto end;
                }
 
-               ret = create_session_net_output(name, output.control_uri,
-                               output.data_uri);
+               ret = create_session_net_output(name, control_uri, data_uri);
                if (ret) {
                        goto end;
                }
 
        } else {
                /* either local output or no output */
-               ret = lttng_create_session(name, output.path);
+               ret = lttng_create_session(name, path);
                if (ret) {
                        goto end;
                }
@@ -1608,6 +1674,7 @@ int process_event_node(xmlNodePtr event_node, struct lttng_handle *handle,
                                goto end;
                        }
 
+                       free(filter_expression);
                        filter_expression = strdup((char *) content);
                        free(content);
                        if (!filter_expression) {
@@ -2018,6 +2085,56 @@ int process_channel_attr_node(xmlNodePtr attr_node,
 
                channel->attr.live_timer_interval =
                        live_timer_interval;
+       } else if (!strcmp((const char *) attr_node->name,
+                       config_element_monitor_timer_interval)) {
+               xmlChar *content;
+               uint64_t monitor_timer_interval = 0;
+
+               /* monitor_timer_interval */
+               content = xmlNodeGetContent(attr_node);
+               if (!content) {
+                       ret = -LTTNG_ERR_NOMEM;
+                       goto end;
+               }
+
+               ret = parse_uint(content, &monitor_timer_interval);
+               free(content);
+               if (ret) {
+                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                       goto end;
+               }
+
+               ret = lttng_channel_set_monitor_timer_interval(channel,
+                       monitor_timer_interval);
+               if (ret) {
+                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                       goto end;
+               }
+       } else if (!strcmp((const char *) attr_node->name,
+                       config_element_blocking_timeout)) {
+               xmlChar *content;
+               int64_t blocking_timeout = 0;
+
+               /* blocking_timeout */
+               content = xmlNodeGetContent(attr_node);
+               if (!content) {
+                       ret = -LTTNG_ERR_NOMEM;
+                       goto end;
+               }
+
+               ret = parse_int(content, &blocking_timeout);
+               free(content);
+               if (ret) {
+                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                       goto end;
+               }
+
+               ret = lttng_channel_set_blocking_timeout(channel,
+                       blocking_timeout);
+               if (ret) {
+                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                       goto end;
+               }
        } else if (!strcmp((const char *) attr_node->name,
                        config_element_events)) {
                /* events */
@@ -2278,13 +2395,13 @@ end:
        return ret;
 }
 
-
 static
 int process_domain_node(xmlNodePtr domain_node, const char *session_name)
 {
        int ret;
        struct lttng_domain domain = { 0 };
        struct lttng_handle *handle = NULL;
+       struct lttng_channel *channel = NULL;
        xmlNodePtr channels_node = NULL;
        xmlNodePtr trackers_node = NULL;
        xmlNodePtr pid_tracker_node = NULL;
@@ -2320,40 +2437,69 @@ int process_domain_node(xmlNodePtr domain_node, const char *session_name)
        /* create all channels */
        for (node = xmlFirstElementChild(channels_node); node;
                node = xmlNextElementSibling(node)) {
-               struct lttng_channel channel;
+               const enum lttng_domain_type original_domain = domain.type;
                xmlNodePtr contexts_node = NULL;
                xmlNodePtr events_node = NULL;
                xmlNodePtr channel_attr_node;
 
-               memset(&channel, 0, sizeof(channel));
-               lttng_channel_set_default_attr(&domain, &channel.attr);
+               /*
+                * Channels of the "agent" types cannot be created directly.
+                * They are meant to be created implicitly through the
+                * activation of events in their domain. However, a user
+                * can override the default channel configuration attributes
+                * by creating the underlying UST channel _before_ enabling
+                * an agent domain event.
+                *
+                * Hence, the channel's type is substituted before the creation
+                * and restored by the time the events are created.
+                */
+               switch (domain.type) {
+               case LTTNG_DOMAIN_JUL:
+               case LTTNG_DOMAIN_LOG4J:
+               case LTTNG_DOMAIN_PYTHON:
+                       domain.type = LTTNG_DOMAIN_UST;
+               default:
+                       break;
+               }
+
+               channel = lttng_channel_create(&domain);
+               if (!channel) {
+                       ret = -1;
+                       goto end;
+               }
 
                for (channel_attr_node = xmlFirstElementChild(node);
                        channel_attr_node; channel_attr_node =
                        xmlNextElementSibling(channel_attr_node)) {
                        ret = process_channel_attr_node(channel_attr_node,
-                               &channel, &contexts_node, &events_node);
+                               channel, &contexts_node, &events_node);
                        if (ret) {
                                goto end;
                        }
                }
 
-               ret = lttng_enable_channel(handle, &channel);
+               ret = lttng_enable_channel(handle, channel);
                if (ret < 0) {
                        goto end;
                }
 
-               ret = process_events_node(events_node, handle, channel.name);
+               /* Restore the original channel domain. */
+               domain.type = original_domain;
+
+               ret = process_events_node(events_node, handle, channel->name);
                if (ret) {
                        goto end;
                }
 
                ret = process_contexts_node(contexts_node, handle,
-                       channel.name);
+                       channel->name);
                if (ret) {
                        goto end;
                }
+
+               lttng_channel_destroy(channel);
        }
+       channel = NULL;
 
        /* get the trackers node */
        for (node = xmlFirstElementChild(domain_node); node;
@@ -2385,21 +2531,26 @@ int process_domain_node(xmlNodePtr domain_node, const char *session_name)
        }
 
 end:
+       lttng_channel_destroy(channel);
        lttng_destroy_handle(handle);
        return ret;
 }
 
 static
 int process_session_node(xmlNodePtr session_node, const char *session_name,
-               int override)
+               int overwrite,
+               const struct config_load_session_override_attr *overrides)
 {
        int ret, started = -1, snapshot_mode = -1;
-       uint64_t live_timer_interval = UINT64_MAX;
+       uint64_t live_timer_interval = UINT64_MAX,
+                        rotation_timer_interval = 0,
+                        rotation_size = 0;
        xmlChar *name = NULL;
        xmlChar *shm_path = NULL;
        xmlNodePtr domains_node = NULL;
        xmlNodePtr output_node = NULL;
        xmlNodePtr node;
+       xmlNodePtr attributes_child;
        struct lttng_domain *kernel_domain = NULL;
        struct lttng_domain *ust_domain = NULL;
        struct lttng_domain *jul_domain = NULL;
@@ -2452,40 +2603,78 @@ int process_session_node(xmlNodePtr session_node, const char *session_name,
 
                        shm_path = node_content;
                } else {
-                       /* attributes, snapshot_mode or live_timer_interval */
-                       xmlNodePtr attributes_child =
-                               xmlFirstElementChild(node);
-
-                       if (!strcmp((const char *) attributes_child->name,
-                               config_element_snapshot_mode)) {
-                               /* snapshot_mode */
-                               xmlChar *snapshot_mode_content =
-                                       xmlNodeGetContent(attributes_child);
-                               if (!snapshot_mode_content) {
-                                       ret = -LTTNG_ERR_NOMEM;
-                                       goto error;
-                               }
+                       /*
+                        * attributes, snapshot_mode, live_timer_interval, rotation_size,
+                        * rotation_timer_interval.
+                        */
+                       for (attributes_child = xmlFirstElementChild(node); attributes_child;
+                                       attributes_child = xmlNextElementSibling(attributes_child)) {
+                               if (!strcmp((const char *) attributes_child->name,
+                                                       config_element_snapshot_mode)) {
+                                       /* snapshot_mode */
+                                       xmlChar *snapshot_mode_content =
+                                               xmlNodeGetContent(attributes_child);
+                                       if (!snapshot_mode_content) {
+                                               ret = -LTTNG_ERR_NOMEM;
+                                               goto error;
+                                       }
 
-                               ret = parse_bool(snapshot_mode_content, &snapshot_mode);
-                               free(snapshot_mode_content);
-                               if (ret) {
-                                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
-                                       goto error;
+                                       ret = parse_bool(snapshot_mode_content, &snapshot_mode);
+                                       free(snapshot_mode_content);
+                                       if (ret) {
+                                               ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                                               goto error;
+                                       }
+                               } else if (!strcmp((const char *) attributes_child->name,
+                                                       config_element_live_timer_interval)) {
+                                       /* live_timer_interval */
+                                       xmlChar *timer_interval_content =
+                                               xmlNodeGetContent(attributes_child);
+                                       if (!timer_interval_content) {
+                                               ret = -LTTNG_ERR_NOMEM;
+                                               goto error;
+                                       }
+
+                                       ret = parse_uint(timer_interval_content, &live_timer_interval);
+                                       free(timer_interval_content);
+                                       if (ret) {
+                                               ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                                               goto error;
+                                       }
                                }
-                       } else {
-                               /* live_timer_interval */
-                               xmlChar *timer_interval_content =
-                                       xmlNodeGetContent(attributes_child);
-                               if (!timer_interval_content) {
-                                       ret = -LTTNG_ERR_NOMEM;
-                                       goto error;
+                               if (!strcmp((const char *) attributes_child->name,
+                                                       config_element_rotation_timer_interval)) {
+                                       /* rotation_timer_interval */
+                                       xmlChar *timer_interval_content =
+                                               xmlNodeGetContent(attributes_child);
+                                       if (!timer_interval_content) {
+                                               ret = -LTTNG_ERR_NOMEM;
+                                               goto error;
+                                       }
+
+                                       ret = parse_uint(timer_interval_content, &rotation_timer_interval);
+                                       free(timer_interval_content);
+                                       if (ret) {
+                                               ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                                               goto error;
+                                       }
                                }
+                               if (!strcmp((const char *) attributes_child->name,
+                                                       config_element_rotation_size)) {
+                                       /* rotation_size */
+                                       xmlChar *rotation_size_content =
+                                               xmlNodeGetContent(attributes_child);
+                                       if (!rotation_size_content) {
+                                               ret = -LTTNG_ERR_NOMEM;
+                                               goto error;
+                                       }
 
-                               ret = parse_uint(timer_interval_content, &live_timer_interval);
-                               free(timer_interval_content);
-                               if (ret) {
-                                       ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
-                                       goto error;
+                                       ret = parse_uint(rotation_size_content, &rotation_size);
+                                       free(rotation_size_content);
+                                       if (ret) {
+                                               ret = -LTTNG_ERR_LOAD_INVALID_CONFIG;
+                                               goto error;
+                                       }
                                }
                        }
                }
@@ -2566,7 +2755,22 @@ domain_init_error:
                goto error;
        }
 
-       if (override) {
+       /* Apply overrides */
+       if (overrides) {
+               if (overrides->session_name) {
+                       xmlChar *name_override = xmlStrdup(BAD_CAST(overrides->session_name));
+                       if (!name_override) {
+                               ret = -LTTNG_ERR_NOMEM;
+                               goto error;
+                       }
+
+                       /* Overrides the session name to the provided name */
+                       xmlFree(name);
+                       name = name_override;
+               }
+       }
+
+       if (overwrite) {
                /* Destroy session if it exists */
                ret = lttng_destroy_session((const char *) name);
                if (ret && ret != -LTTNG_ERR_SESS_NOT_FOUND) {
@@ -2577,17 +2781,18 @@ domain_init_error:
 
        /* Create session type depending on output type */
        if (snapshot_mode && snapshot_mode != -1) {
-               ret = create_snapshot_session((const char *) name, output_node);
+               ret = create_snapshot_session((const char *) name, output_node,
+                               overrides);
        } else if (live_timer_interval &&
                live_timer_interval != UINT64_MAX) {
                ret = create_session((const char *) name, kernel_domain,
                                ust_domain, jul_domain, log4j_domain,
-                               output_node, live_timer_interval);
+                               output_node, live_timer_interval, overrides);
        } else {
                /* regular session */
                ret = create_session((const char *) name, kernel_domain,
                                ust_domain, jul_domain, log4j_domain,
-                               output_node, UINT64_MAX);
+                               output_node, UINT64_MAX, overrides);
        }
        if (ret) {
                goto error;
@@ -2609,6 +2814,27 @@ domain_init_error:
                }
        }
 
+       if (rotation_timer_interval || rotation_size) {
+               struct lttng_rotation_schedule_attr *rotation_attr = lttng_rotation_schedule_attr_create();
+
+               if (!rotation_attr) {
+                       goto error;
+               }
+               ret = lttng_rotation_schedule_attr_set_session_name(rotation_attr, (const char *) name);
+               if (ret) {
+                       lttng_rotation_schedule_attr_destroy(rotation_attr);
+                       goto error;
+               }
+               lttng_rotation_schedule_attr_set_timer_period(rotation_attr,
+                               rotation_timer_interval);
+               lttng_rotation_schedule_attr_set_size(rotation_attr, rotation_size);
+               ret = lttng_rotation_set_schedule(rotation_attr);
+               lttng_rotation_schedule_attr_destroy(rotation_attr);
+               if (ret) {
+                       goto error;
+               }
+       }
+
        if (started) {
                ret = lttng_start_tracing((const char *) name);
                if (ret) {
@@ -2661,7 +2887,8 @@ valid:
 
 static
 int load_session_from_file(const char *path, const char *session_name,
-       struct session_config_validation_ctx *validation_ctx, int override)
+       struct session_config_validation_ctx *validation_ctx, int overwrite,
+       const struct config_load_session_override_attr *overrides)
 {
        int ret, session_found = !session_name;
        xmlDocPtr doc = NULL;
@@ -2703,7 +2930,7 @@ int load_session_from_file(const char *path, const char *session_name,
                session_node; session_node =
                        xmlNextElementSibling(session_node)) {
                ret = process_session_node(session_node,
-                       session_name, override);
+                       session_name, overwrite, overrides);
                if (session_name && ret == 0) {
                        /* Target session found and loaded */
                        session_found = 1;
@@ -2737,7 +2964,8 @@ struct dirent *alloc_dirent(const char *path)
 
 static
 int load_session_from_path(const char *path, const char *session_name,
-       struct session_config_validation_ctx *validation_ctx, int override)
+       struct session_config_validation_ctx *validation_ctx, int overwrite,
+       const struct config_load_session_override_attr *overrides)
 {
        int ret, session_found = !session_name;
        DIR *directory = NULL;
@@ -2812,7 +3040,7 @@ int load_session_from_path(const char *path, const char *session_name,
                        file_path[path_len + file_name_len] = '\0';
 
                        ret = load_session_from_file(file_path, session_name,
-                               validation_ctx, override);
+                               validation_ctx, overwrite, overrides);
                        if (session_name && !ret) {
                                session_found = 1;
                                break;
@@ -2823,7 +3051,7 @@ int load_session_from_path(const char *path, const char *session_name,
                free(file_path);
        } else {
                ret = load_session_from_file(path, session_name,
-                       validation_ctx, override);
+                       validation_ctx, overwrite, overrides);
                if (ret) {
                        goto end;
                } else {
@@ -2838,7 +3066,7 @@ end:
                }
        }
 
-       if (session_found) {
+       if (session_found && !ret) {
                ret = 0;
        }
 
@@ -2865,7 +3093,6 @@ static int validate_path_creds(const char *path)
                if (errno != ENOENT) {
                        PERROR("stat");
                }
-               ret = -LTTNG_ERR_INVALID;
                goto valid;
        }
 
@@ -2881,7 +3108,8 @@ invalid:
 
 LTTNG_HIDDEN
 int config_load_session(const char *path, const char *session_name,
-               int override, unsigned int autoload)
+               int overwrite, unsigned int autoload,
+               const struct config_load_session_override_attr *overrides)
 {
        int ret;
        bool session_loaded = false;
@@ -2935,7 +3163,7 @@ int config_load_session(const char *path, const char *session_name,
                        }
                        if (path_ptr) {
                                ret = load_session_from_path(path_ptr, session_name,
-                                               &validation_ctx, override);
+                                               &validation_ctx, overwrite, overrides);
                                if (ret && ret != -LTTNG_ERR_LOAD_SESSION_NOENT) {
                                        goto end;
                                }
@@ -2965,7 +3193,7 @@ int config_load_session(const char *path, const char *session_name,
 
                if (path_ptr) {
                        ret = load_session_from_path(path_ptr, session_name,
-                                       &validation_ctx, override);
+                                       &validation_ctx, overwrite, overrides);
                        if (!ret) {
                                session_loaded = true;
                        }
@@ -2990,7 +3218,7 @@ int config_load_session(const char *path, const char *session_name,
                }
 
                ret = load_session_from_path(path, session_name,
-                       &validation_ctx, override);
+                       &validation_ctx, overwrite, overrides);
        }
 end:
        fini_session_config_validation_ctx(&validation_ctx);
@@ -3008,3 +3236,9 @@ end:
        }
        return ret;
 }
+
+static
+void __attribute__((destructor)) session_config_exit(void)
+{
+       xmlCleanupParser();
+}
This page took 0.032316 seconds and 4 git commands to generate.