buffer-view: improve logging on creation failure

[lttng-tools.git] / src / common / buffer-view.c

diff --git a/src/common/buffer-view.c b/src/common/buffer-view.c
index 6f674f4a9828f857ada1a5e2fc3038d00ba343ba..04bd1ca354f5555b4b78063ba523684cd93b52c2 100644 (file)
--- a/src/common/buffer-view.c
+++ b/src/common/buffer-view.c
@@ -18,6 +18,12 @@ struct lttng_buffer_view lttng_buffer_view_init(
        return view;
 }
 
        return view;
 }
 

+LTTNG_HIDDEN
+bool lttng_buffer_view_is_valid(const struct lttng_buffer_view *view)
+{
+       return view && view->data && view->size > 0;
+}
+

 LTTNG_HIDDEN
 struct lttng_buffer_view lttng_buffer_view_from_view(
                const struct lttng_buffer_view *src, size_t offset,
 LTTNG_HIDDEN
 struct lttng_buffer_view lttng_buffer_view_from_view(
                const struct lttng_buffer_view *src, size_t offset,


@@ -28,12 +34,14 @@ struct lttng_buffer_view lttng_buffer_view_from_view(
        assert(src);
 
        if (offset > src->size) {
        assert(src);
 
        if (offset > src->size) {

-               ERR("Attempt to create buffer view with invalid offset");
+               ERR("Attempt to create buffer view from another view with invalid offset (offset > source size): source size = %zu, offset in source = %zu, length = %zd",
+                               src->size, offset, len);

                goto end;
        }
 
        if (len != -1 && len > (src->size - offset)) {
                goto end;
        }
 
        if (len != -1 && len > (src->size - offset)) {

-               ERR("Attempt to create buffer view with invalid length");
+               ERR("Attempt to create buffer view from another view with invalid length (length > space left after offset in source): source size = %zu, offset in source = %zu, length = %zd",
+                               src->size, offset, len);

                goto end;
        }
 
                goto end;
        }
 


@@ -53,12 +61,14 @@ struct lttng_buffer_view lttng_buffer_view_from_dynamic_buffer(
        assert(src);
 
        if (offset > src->size) {
        assert(src);
 
        if (offset > src->size) {

-               ERR("Attempt to create buffer view with invalid offset");
+               ERR("Attempt to create buffer view from a dynamic buffer with invalid offset (offset > source size): source size = %zu, offset in source = %zu, length = %zd",
+                               src->size, offset, len);

                goto end;
        }
 
        if (len != -1 && len > (src->size - offset)) {
                goto end;
        }
 
        if (len != -1 && len > (src->size - offset)) {

-               ERR("Attempt to create buffer view with invalid length");
+               ERR("Attempt to create buffer view from a dynamic buffer with invalid length (length > space left after offset in source): source size = %zu, offset in source = %zu, length = %zd",
+                               src->size, offset, len);

                goto end;
        }
 
                goto end;
        }