Fix: Ensure a valid command error code is returned by track/untrack

[lttng-tools.git] / src / bin / lttng / commands / track-untrack.c

diff --git a/src/bin/lttng/commands/track-untrack.c b/src/bin/lttng/commands/track-untrack.c
index 52442cc1361b2e8d1d0574a35f3812996bb735a8..9ce850468d96db65fbe228e78e682b19bcd20cef 100644 (file)
--- a/src/bin/lttng/commands/track-untrack.c
+++ b/src/bin/lttng/commands/track-untrack.c
@@ -96,6 +96,7 @@ int parse_pid_string(const char *_pid_string,
        int count = 0;
        int *pid_list = NULL;
        char *pid_string = NULL;
+       char *endptr;
 
        if (all && _pid_string) {
                ERR("An empty PID string is expected with --all");
@@ -132,13 +133,16 @@ int parse_pid_string(const char *_pid_string,
        while (one_pid_str != NULL) {
                unsigned long v;
 
-               v = strtoul(one_pid_str, NULL, 10);
+               errno = 0;
+               v = strtoul(one_pid_str, &endptr, 10);
                if ((v == 0 && errno == EINVAL)
-                               || (v == ULONG_MAX && errno == ERANGE)) {
+                               || (v == ULONG_MAX && errno == ERANGE)
+                               || (*one_pid_str != '\0' && *endptr != '\0')){
                        ERR("Error parsing PID %s", one_pid_str);
                        retval = CMD_ERROR;
                        goto error;
                }
+
                if ((long) v > INT_MAX || (int) v < 0) {
                        ERR("Invalid PID value %ld", (long) v);
                        retval = CMD_ERROR;
@@ -194,11 +198,12 @@ end:
 }
 
 static
-int track_untrack_pid(enum cmd_type cmd_type, const char *cmd_str,
+enum cmd_error_code track_untrack_pid(enum cmd_type cmd_type, const char *cmd_str,
                const char *session_name, const char *pid_string,
                int all, struct mi_writer *writer)
 {
-       int ret, retval = CMD_SUCCESS, i;
+       int ret, success = 1 , i;
+       enum cmd_error_code retval = CMD_SUCCESS;
        int *pid_list = NULL;
        int nr_pids;
        struct lttng_domain dom;
@@ -244,26 +249,49 @@ int track_untrack_pid(enum cmd_type cmd_type, const char *cmd_str,
        }
 
        if (writer) {
-               /* Open pids element */
-               ret = mi_lttng_writer_open_element(writer, config_element_pids);
+               /* Open process element */
+               ret = mi_lttng_targets_open(writer);
                if (ret) {
                        retval = CMD_ERROR;
                        goto end;
                }
        }
 
-       /* TODO: MI */
        for (i = 0; i < nr_pids; i++) {
                DBG("%s PID %d", cmd_str, pid_list[i]);
                ret = lib_func(handle, pid_list[i]);
                if (ret) {
+                       success = 0;
                        retval = CMD_ERROR;
-                       goto end;
+               } else {
+                       success = 1;
+               }
+
+               /* Mi */
+               if (writer) {
+                       ret = mi_lttng_pid_target(writer, pid_list[i], 1);
+                       if (ret) {
+                               retval = CMD_ERROR;
+                               goto end;
+                       }
+
+                       ret = mi_lttng_writer_write_element_bool(writer,
+                                       mi_lttng_element_success, success);
+                       if (ret) {
+                               retval = CMD_ERROR;
+                               goto end;
+                       }
+
+                       ret = mi_lttng_writer_close_element(writer);
+                       if (ret) {
+                               retval = CMD_ERROR;
+                               goto end;
+                       }
                }
        }
 
        if (writer) {
-               /* Close pids element */
+               /* Close targets element */
                ret = mi_lttng_writer_close_element(writer);
                if (ret) {
                        retval = CMD_ERROR;
@@ -271,7 +299,6 @@ int track_untrack_pid(enum cmd_type cmd_type, const char *cmd_str,
                }
        }
 
-       /* SUCCESS */
 end:
        if (handle) {
                lttng_destroy_handle(handle);
@@ -300,7 +327,8 @@ static
 int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
                int argc, const char **argv)
 {
-       int opt, ret = CMD_SUCCESS, command_ret = CMD_SUCCESS;
+       int opt, ret = 0;
+       enum cmd_error_code command_ret = CMD_SUCCESS;
        int success = 1;
        static poptContext pc;
        char *session_name = NULL;
@@ -308,7 +336,7 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
 
        if (argc < 1) {
                usage(stderr, cmd_str);
-               ret = CMD_ERROR;
+               command_ret = CMD_ERROR;
                goto end;
        }
 
@@ -329,7 +357,7 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
                        break;
                default:
                        usage(stderr, cmd_str);
-                       ret = CMD_UNDEFINED;
+                       command_ret = CMD_UNDEFINED;
                        goto end;
                }
        }
@@ -337,14 +365,14 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
        if (!(opt_userspace ^ opt_kernel)) {
                ERR("Exactly one of -u or -k needs to be specified.");
                usage(stderr, cmd_str);
-               ret = CMD_ERROR;
+               command_ret = CMD_ERROR;
                goto end;
        }
 
        if (!opt_session_name) {
                session_name = get_session_name();
                if (session_name == NULL) {
-                       ret = CMD_ERROR;
+                       command_ret = CMD_ERROR;
                        goto end;
                }
        } else {
@@ -355,7 +383,7 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
        if (!opt_pid) {
                ERR("Please specify at least one tracker with its expected arguments");
                usage(stderr, cmd_str);
-               ret = CMD_ERROR;
+               command_ret = CMD_ERROR;
                goto end;
        }
 
@@ -363,7 +391,7 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
        if (lttng_opt_mi) {
                writer = mi_lttng_writer_create(fileno(stdout), lttng_opt_mi);
                if (!writer) {
-                       ret = CMD_ERROR;
+                       command_ret = CMD_ERROR;
                        goto end;
                }
        }
@@ -373,7 +401,7 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
                ret = mi_lttng_writer_command_open(writer,
                                get_mi_element_command(cmd_type));
                if (ret) {
-                       ret = CMD_ERROR;
+                       command_ret = CMD_ERROR;
                        goto end;
                }
 
@@ -381,7 +409,7 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
                ret = mi_lttng_writer_open_element(writer,
                                mi_lttng_element_command_output);
                if (ret) {
-                       ret = CMD_ERROR;
+                       command_ret = CMD_ERROR;
                        goto end;
                }
        }
@@ -389,7 +417,7 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
        command_ret = track_untrack_pid(cmd_type,
                        cmd_str, session_name, opt_pid_string,
                        opt_all, writer);
-       if (command_ret) {
+       if (command_ret != CMD_SUCCESS) {
                success = 0;
        }
 
@@ -398,7 +426,7 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
                /* Close  output element */
                ret = mi_lttng_writer_close_element(writer);
                if (ret) {
-                       ret = CMD_ERROR;
+                       command_ret = CMD_ERROR;
                        goto end;
                }
 
@@ -406,14 +434,14 @@ int cmd_track_untrack(enum cmd_type cmd_type, const char *cmd_str,
                ret = mi_lttng_writer_write_element_bool(writer,
                                mi_lttng_element_command_success, success);
                if (ret) {
-                       ret = CMD_ERROR;
+                       command_ret = CMD_ERROR;
                        goto end;
                }
 
                /* Command element close */
                ret = mi_lttng_writer_command_close(writer);
                if (ret) {
-                       ret = CMD_ERROR;
+                       command_ret = CMD_ERROR;
                        goto end;
                }
        }
@@ -426,14 +454,11 @@ end:
        /* Mi clean-up */
        if (writer && mi_lttng_writer_destroy(writer)) {
                /* Preserve original error code */
-               ret = ret ? ret : LTTNG_ERR_MI_IO_FAIL;
+               command_ret = CMD_ERROR;
        }
 
-       /* Overwrite ret if an error occurred during track() */
-       ret = command_ret ? command_ret : ret;
-
        poptFreeContext(pc);
-       return ret;
+       return (int) command_ret;
 }
 
 int cmd_track(int argc, const char **argv)