Detect and report exclusion option errors
[lttng-tools.git] / src / bin / lttng / commands / enable_events.c
index a7b70c3f9dada482aa76cdd3113ccfa61535d4e0..af6abbe6e6b4e93bc5950dfd000a9d0236e9cfb7 100644 (file)
@@ -43,6 +43,7 @@ static char *opt_function;
 static char *opt_function_entry_symbol;
 static char *opt_channel_name;
 static char *opt_filter;
+static char *opt_exclude;
 #if 0
 /* Not implemented yet */
 static char *opt_cmd_name;
@@ -61,6 +62,7 @@ enum {
        OPT_LOGLEVEL_ONLY,
        OPT_LIST_OPTIONS,
        OPT_FILTER,
+       OPT_EXCLUDE,
 };
 
 static struct lttng_handle *handle;
@@ -89,6 +91,7 @@ static struct poptOption long_options[] = {
        {"loglevel-only",  0,     POPT_ARG_STRING, 0, OPT_LOGLEVEL_ONLY, 0, 0},
        {"list-options", 0, POPT_ARG_NONE, NULL, OPT_LIST_OPTIONS, NULL, NULL},
        {"filter",         'f', POPT_ARG_STRING, &opt_filter, OPT_FILTER, 0, 0},
+       {"exclude",        'x', POPT_ARG_STRING, &opt_exclude, OPT_EXCLUDE, 0, 0},
        {0, 0, 0, 0, 0, 0, 0}
 };
 
@@ -192,6 +195,12 @@ static void usage(FILE *ofp)
        fprintf(ofp, "                           '$ctx.procname == \"demo*\"'\n");
        fprintf(ofp, "                           '$ctx.vpid >= 4433 && $ctx.vpid < 4455'\n");
        fprintf(ofp, "                           '$ctx.vtid == 1234'\n");
+       fprintf(ofp, "  -x, --exclude LIST\n");
+       fprintf(ofp, "                           Add exclusions to UST tracepoints:\n");
+       fprintf(ofp, "                           Events that match any of the items\n");
+       fprintf(ofp, "                           in the comma-separated LIST are not\n");
+       fprintf(ofp, "                           enabled, even if they match a wildcard\n");
+       fprintf(ofp, "                           definition of the event.\n");
        fprintf(ofp, "\n");
 }
 
@@ -327,6 +336,94 @@ const char *print_raw_channel_name(const char *name)
        return name ? : "<default>";
 }
 
+/*
+ * Compare list of exclusions against an event name.
+ * Return a list of legal exclusion names.
+ * Produce an error or a warning about others (depending on the situation)
+ */
+static
+int check_exclusion_subsets(const char *event_name,
+               const char *exclusions,
+               int *exclusion_count_ptr,
+               char ***exclusion_list_ptr)
+{
+       const char *excluder_ptr;
+       const char *event_ptr;
+       const char *next_excluder;
+       int excluder_length;
+       int exclusion_count = 0;
+       char **exclusion_list = NULL;
+       int ret = CMD_SUCCESS;
+
+       if (event_name[strlen(event_name) - 1] != '*') {
+               ERR("Event %s: Excluders can only be used with wildcarded events", event_name);
+               goto error;
+       }
+
+       next_excluder = exclusions;
+       while (*next_excluder != 0) {
+               event_ptr = event_name;
+               excluder_ptr = next_excluder;
+               excluder_length = strcspn(next_excluder, ",");
+
+               /* Scan both the excluder and the event letter by letter */
+               while (1) {
+                       char e, x;
+
+                       e = *event_ptr;
+                       x = *excluder_ptr;
+
+                       if (x == '*') {
+                               /* Event is a subset of the excluder */
+                               ERR("Event %s: %.*s excludes all events from %s",
+                                               event_name,
+                                               excluder_length,
+                                               next_excluder,
+                                               event_name);
+                               goto error;
+                       }
+                       if (e == '*') {
+                               /* Excluder is a proper subset of event */
+                               exclusion_count++;
+                               exclusion_list = realloc(exclusion_list, sizeof(char **) * exclusion_count);
+                               exclusion_list[exclusion_count - 1] = strndup(next_excluder, excluder_length);
+
+                               break;
+                       }
+                       if (x != e) {
+                               /* Excluder and event sets have no common elements */
+                               WARN("Event %s: %.*s does not exclude any events from %s",
+                                               event_name,
+                                               excluder_length,
+                                               next_excluder,
+                                               event_name);
+                               break;
+                       }
+                       excluder_ptr++;
+                       event_ptr++;
+               }
+               /* next excluder */
+               next_excluder += excluder_length;
+               if (*next_excluder == ',') {
+                       next_excluder++;
+               }
+       }
+       goto end;
+error:
+       while (exclusion_count--) {
+               free(exclusion_list[exclusion_count]);
+       }
+       if (exclusion_list != NULL) {
+               free(exclusion_list);
+       }
+       exclusion_list = NULL;
+       exclusion_count = 0;
+       ret = CMD_ERROR;
+end:
+       *exclusion_count_ptr = exclusion_count;
+       *exclusion_list_ptr = exclusion_list;
+       return ret;
+}
 /*
  * Enabling event using the lttng API.
  */
@@ -336,6 +433,8 @@ static int enable_events(char *session_name)
        char *event_name, *channel_name = NULL;
        struct lttng_event ev;
        struct lttng_domain dom;
+       int exclusion_count = 0;
+       char **exclusion_list = NULL;
 
        memset(&ev, 0, sizeof(ev));
        memset(&dom, 0, sizeof(dom));
@@ -346,6 +445,9 @@ static int enable_events(char *session_name)
                        ret = CMD_ERROR;
                        goto error;
                }
+               if (opt_loglevel) {
+                       WARN("Kernel loglevels are not supported.");
+               }
        }
 
        /* Create lttng domain */
@@ -366,6 +468,12 @@ static int enable_events(char *session_name)
                goto error;
        }
 
+       if (opt_kernel && opt_exclude) {
+               ERR("Event name exclusions are not yet implemented for kernel events");
+               ret = CMD_ERROR;
+               goto error;
+       }
+
        channel_name = opt_channel_name;
 
        handle = lttng_create_handle(session_name, &dom);
@@ -397,8 +505,18 @@ static int enable_events(char *session_name)
                        }
                }
 
+               if (opt_exclude) {
+                       ret = check_exclusion_subsets("*", opt_exclude,
+                                       &exclusion_count, &exclusion_list);
+                       if (ret == CMD_ERROR) {
+                               goto error;
+                       }
+               }
                if (!opt_filter) {
-                       ret = lttng_enable_event(handle, &ev, channel_name);
+                       ret = lttng_enable_event_with_exclusions(handle,
+                                       &ev, channel_name,
+                                       NULL,
+                                       exclusion_count, exclusion_list);
                        if (ret < 0) {
                                switch (-ret) {
                                case LTTNG_ERR_KERN_EVENT_EXIST:
@@ -419,7 +537,7 @@ static int enable_events(char *session_name)
 
                        switch (opt_event_type) {
                        case LTTNG_EVENT_TRACEPOINT:
-                               if (opt_loglevel) {
+                               if (opt_loglevel && dom.type != LTTNG_DOMAIN_KERNEL) {
                                        MSG("All %s tracepoints are enabled in channel %s for loglevel %s",
                                                        get_domain_str(dom.type),
                                                        print_channel_name(channel_name),
@@ -428,7 +546,6 @@ static int enable_events(char *session_name)
                                        MSG("All %s tracepoints are enabled in channel %s",
                                                        get_domain_str(dom.type),
                                                        print_channel_name(channel_name));
-
                                }
                                break;
                        case LTTNG_EVENT_SYSCALL:
@@ -438,7 +555,7 @@ static int enable_events(char *session_name)
                                }
                                break;
                        case LTTNG_EVENT_ALL:
-                               if (opt_loglevel) {
+                               if (opt_loglevel && dom.type != LTTNG_DOMAIN_KERNEL) {
                                        MSG("All %s events are enabled in channel %s for loglevel %s",
                                                        get_domain_str(dom.type),
                                                        print_channel_name(channel_name),
@@ -458,8 +575,8 @@ static int enable_events(char *session_name)
                        }
                }
                if (opt_filter) {
-                       ret = lttng_enable_event_with_filter(handle, &ev, channel_name,
-                                               opt_filter);
+                       ret = lttng_enable_event_with_exclusions(handle, &ev, channel_name,
+                                               opt_filter, exclusion_count, exclusion_list);
                        if (ret < 0) {
                                switch (-ret) {
                                case LTTNG_ERR_FILTER_EXIST:
@@ -533,12 +650,6 @@ static int enable_events(char *session_name)
                                goto error;
                        }
 
-                       if (opt_loglevel) {
-                               MSG("Kernel loglevels are not supported.");
-                               ret = CMD_UNSUPPORTED;
-                               goto error;
-                       }
-
                        /* kernel loglevels not implemented */
                        ev.loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL;
                } else if (opt_userspace) {             /* User-space tracer action */
@@ -572,6 +683,28 @@ static int enable_events(char *session_name)
                                goto error;
                        }
 
+                       if (opt_exclude) {
+                               if (opt_event_type != LTTNG_EVENT_ALL && opt_event_type != LTTNG_EVENT_TRACEPOINT) {
+                                       ERR("Exclusion option can only be used with tracepoint events");
+                                       ret = CMD_ERROR;
+                                       goto error;
+                               }
+                               /* Free previously allocated items */
+                               if (exclusion_list != NULL) {
+                                       while (exclusion_count--) {
+                                               free(exclusion_list[exclusion_count]);
+                                       }
+                                       free(exclusion_list);
+                                       exclusion_list = NULL;
+                               }
+                               /* Check for proper subsets */
+                               ret = check_exclusion_subsets(event_name, opt_exclude,
+                                               &exclusion_count, &exclusion_list);
+                               if (ret == CMD_ERROR) {
+                                       goto error;
+                               }
+                       }
+
                        ev.loglevel_type = opt_loglevel_type;
                        if (opt_loglevel) {
                                ev.loglevel = loglevel_str_to_value(opt_loglevel);
@@ -600,7 +733,9 @@ static int enable_events(char *session_name)
                }
 
                if (!opt_filter) {
-                       ret = lttng_enable_event(handle, &ev, channel_name);
+                       ret = lttng_enable_event_with_exclusions(handle,
+                                       &ev, channel_name,
+                                       NULL, exclusion_count, exclusion_list);
                        if (ret < 0) {
                                /* Turn ret to positive value to handle the positive error code */
                                switch (-ret) {
@@ -627,8 +762,8 @@ static int enable_events(char *session_name)
                }
 
                if (opt_filter) {
-                       ret = lttng_enable_event_with_filter(handle, &ev, channel_name,
-                                       opt_filter);
+                       ret = lttng_enable_event_with_exclusions(handle, &ev, channel_name,
+                                       opt_filter, exclusion_count, exclusion_list);
                        if (ret < 0) {
                                switch (-ret) {
                                case LTTNG_ERR_FILTER_EXIST:
@@ -663,6 +798,13 @@ error:
        }
        lttng_destroy_handle(handle);
 
+       if (exclusion_list != NULL) {
+               while (exclusion_count--) {
+                       free(exclusion_list[exclusion_count]);
+               }
+               free(exclusion_list);
+       }
+
        return ret;
 }
 
@@ -718,6 +860,8 @@ int cmd_enable_events(int argc, const char **argv)
                        goto end;
                case OPT_FILTER:
                        break;
+               case OPT_EXCLUDE:
+                       break;
                default:
                        usage(stderr);
                        ret = CMD_UNDEFINED;
This page took 0.02724 seconds and 4 git commands to generate.