Save registration time for app
[lttng-tools.git] / src / bin / lttng-sessiond / ust-app.c
index 6b9afe3abf4ce0180cb3957da00cdd8036ac6cf7..8c9277cae225ea80e9df7bf106d304a529e71769 100644 (file)
@@ -250,7 +250,8 @@ static struct ust_registry_session *get_session_registry(
        case LTTNG_BUFFER_PER_UID:
        {
                struct buffer_reg_uid *reg_uid = buffer_reg_uid_find(
-                               ua_sess->tracing_id, ua_sess->bits_per_long, ua_sess->uid);
+                               ua_sess->tracing_id, ua_sess->bits_per_long,
+                               ua_sess->real_credentials.uid);
                if (!reg_uid) {
                        goto error;
                }
@@ -1831,25 +1832,22 @@ static void shadow_copy_channel(struct ust_app_channel *ua_chan,
 static void shadow_copy_session(struct ust_app_session *ua_sess,
                struct ltt_ust_session *usess, struct ust_app *app)
 {
-       time_t rawtime;
        struct tm *timeinfo;
        char datetime[16];
        int ret;
        char tmp_shm_path[PATH_MAX];
 
-       /* Get date and time for unique app path */
-       time(&rawtime);
-       timeinfo = localtime(&rawtime);
+       timeinfo = localtime(&app->registration_time);
        strftime(datetime, sizeof(datetime), "%Y%m%d-%H%M%S", timeinfo);
 
        DBG2("Shadow copy of session handle %d", ua_sess->handle);
 
        ua_sess->tracing_id = usess->id;
        ua_sess->id = get_next_session_id();
-       ua_sess->uid = app->uid;
-       ua_sess->gid = app->gid;
-       ua_sess->euid = usess->uid;
-       ua_sess->egid = usess->gid;
+       ua_sess->real_credentials.uid = app->uid;
+       ua_sess->real_credentials.gid = app->gid;
+       ua_sess->effective_credentials.uid = usess->uid;
+       ua_sess->effective_credentials.gid = usess->gid;
        ua_sess->buffer_type = usess->buffer_type;
        ua_sess->bits_per_long = app->bits_per_long;
 
@@ -1870,7 +1868,9 @@ static void shadow_copy_session(struct ust_app_session *ua_sess,
                break;
        case LTTNG_BUFFER_PER_UID:
                ret = snprintf(ua_sess->path, sizeof(ua_sess->path),
-                               DEFAULT_UST_TRACE_UID_PATH, ua_sess->uid, app->bits_per_long);
+                               DEFAULT_UST_TRACE_UID_PATH,
+                               ua_sess->real_credentials.uid,
+                               app->bits_per_long);
                break;
        default:
                assert(0);
@@ -1923,7 +1923,7 @@ error:
  * Lookup sesison wrapper.
  */
 static
-void __lookup_session_by_app(struct ltt_ust_session *usess,
+void __lookup_session_by_app(const struct ltt_ust_session *usess,
                        struct ust_app *app, struct lttng_ht_iter *iter)
 {
        /* Get right UST app session from app */
@@ -1935,7 +1935,7 @@ void __lookup_session_by_app(struct ltt_ust_session *usess,
  * id.
  */
 static struct ust_app_session *lookup_session_by_app(
-               struct ltt_ust_session *usess, struct ust_app *app)
+               const struct ltt_ust_session *usess, struct ust_app *app)
 {
        struct lttng_ht_iter iter;
        struct lttng_ht_node_u64 *node;
@@ -1990,10 +1990,10 @@ static int setup_buffer_reg_pid(struct ust_app_session *ua_sess,
                        app->bits_per_long, app->uint8_t_alignment,
                        app->uint16_t_alignment, app->uint32_t_alignment,
                        app->uint64_t_alignment, app->long_alignment,
-                       app->byte_order, app->version.major,
-                       app->version.minor, reg_pid->root_shm_path,
-                       reg_pid->shm_path,
-                       ua_sess->euid, ua_sess->egid);
+                       app->byte_order, app->version.major, app->version.minor,
+                       reg_pid->root_shm_path, reg_pid->shm_path,
+                       ua_sess->effective_credentials.uid,
+                       ua_sess->effective_credentials.gid);
        if (ret < 0) {
                /*
                 * reg_pid->registry->reg.ust is NULL upon error, so we need to
@@ -2462,7 +2462,7 @@ static int do_consumer_create_channel(struct ltt_ust_session *usess,
         * stream we have to expect.
         */
        ret = ust_consumer_ask_channel(ua_sess, ua_chan, usess->consumer, socket,
-                       registry, trace_archive_id);
+                       registry, usess->current_trace_chunk);
        if (ret < 0) {
                goto error_ask;
        }
@@ -2845,7 +2845,7 @@ static int create_channel_per_uid(struct ust_app *app,
         */
        ret = do_consumer_create_channel(usess, ua_sess, ua_chan,
                        app->bits_per_long, reg_uid->registry->reg.ust,
-                       session->current_archive_id);
+                       session->most_recent_chunk_id.value);
        if (ret < 0) {
                ERR("Error creating UST channel \"%s\" on the consumer daemon",
                                ua_chan->name);
@@ -2882,10 +2882,9 @@ static int create_channel_per_uid(struct ust_app *app,
 
        notification_ret = notification_thread_command_add_channel(
                        notification_thread_handle, session->name,
-                       ua_sess->euid, ua_sess->egid,
-                       ua_chan->name,
-                       ua_chan->key,
-                       LTTNG_DOMAIN_UST,
+                       ua_sess->effective_credentials.uid,
+                       ua_sess->effective_credentials.gid, ua_chan->name,
+                       ua_chan->key, LTTNG_DOMAIN_UST,
                        ua_chan->attr.subbuf_size * ua_chan->attr.num_subbuf);
        if (notification_ret != LTTNG_OK) {
                ret = - (int) notification_ret;
@@ -2959,7 +2958,7 @@ static int create_channel_per_pid(struct ust_app *app,
        /* Create and get channel on the consumer side. */
        ret = do_consumer_create_channel(usess, ua_sess, ua_chan,
                        app->bits_per_long, registry,
-                       session->current_archive_id);
+                       session->most_recent_chunk_id.value);
        if (ret < 0) {
                ERR("Error creating UST channel \"%s\" on the consumer daemon",
                        ua_chan->name);
@@ -2983,10 +2982,9 @@ static int create_channel_per_pid(struct ust_app *app,
 
        cmd_ret = notification_thread_command_add_channel(
                        notification_thread_handle, session->name,
-                       ua_sess->euid, ua_sess->egid,
-                       ua_chan->name,
-                       ua_chan->key,
-                       LTTNG_DOMAIN_UST,
+                       ua_sess->effective_credentials.uid,
+                       ua_sess->effective_credentials.gid, ua_chan->name,
+                       ua_chan->key, LTTNG_DOMAIN_UST,
                        ua_chan->attr.subbuf_size * ua_chan->attr.num_subbuf);
        if (cmd_ret != LTTNG_OK) {
                ret = - (int) cmd_ret;
@@ -3236,7 +3234,7 @@ static int create_ust_app_metadata(struct ust_app_session *ua_sess,
         * consumer.
         */
        ret = ust_consumer_ask_channel(ua_sess, metadata, consumer, socket,
-                       registry, session->current_archive_id);
+                       registry, session->current_trace_chunk);
        if (ret < 0) {
                /* Nullify the metadata key so we don't try to close it later on. */
                registry->metadata_key = 0;
@@ -3376,6 +3374,8 @@ void ust_app_add(struct ust_app *app)
        assert(app);
        assert(app->notify_sock >= 0);
 
+       app->registration_time = time(NULL);
+
        rcu_read_lock();
 
        /*
@@ -5874,8 +5874,9 @@ void ust_app_destroy(struct ust_app *app)
  *
  * Returns LTTNG_OK on success or a LTTNG_ERR error code.
  */
-enum lttng_error_code ust_app_snapshot_record(struct ltt_ust_session *usess,
-               struct snapshot_output *output, int wait,
+enum lttng_error_code ust_app_snapshot_record(
+               const struct ltt_ust_session *usess,
+               const struct consumer_output *output, int wait,
                uint64_t nb_packets_per_stream)
 {
        int ret = 0;
@@ -5883,20 +5884,12 @@ enum lttng_error_code ust_app_snapshot_record(struct ltt_ust_session *usess,
        struct lttng_ht_iter iter;
        struct ust_app *app;
        char pathname[PATH_MAX];
-       struct ltt_session *session = NULL;
-       uint64_t trace_archive_id;
 
        assert(usess);
        assert(output);
 
        rcu_read_lock();
 
-       session = session_find_by_id(usess->id);
-       assert(session);
-       assert(pthread_mutex_trylock(&session->lock));
-       assert(session_trylock_list());
-       trace_archive_id = session->current_archive_id;
-
        switch (usess->buffer_type) {
        case LTTNG_BUFFER_PER_UID:
        {
@@ -5920,8 +5913,12 @@ enum lttng_error_code ust_app_snapshot_record(struct ltt_ust_session *usess,
                        }
 
                        memset(pathname, 0, sizeof(pathname));
+                       /*
+                        * DEFAULT_UST_TRACE_UID_PATH already contains a path
+                        * separator.
+                        */
                        ret = snprintf(pathname, sizeof(pathname),
-                                       DEFAULT_UST_TRACE_DIR "/" DEFAULT_UST_TRACE_UID_PATH,
+                                       DEFAULT_UST_TRACE_DIR DEFAULT_UST_TRACE_UID_PATH,
                                        reg->uid, reg->bits_per_long);
                        if (ret < 0) {
                                PERROR("snprintf snapshot path");
@@ -5929,23 +5926,21 @@ enum lttng_error_code ust_app_snapshot_record(struct ltt_ust_session *usess,
                                goto error;
                        }
 
-                       /* Add the UST default trace dir to path. */
+                        /* Add the UST default trace dir to path. */
                        cds_lfht_for_each_entry(reg->registry->channels->ht, &iter.iter,
                                        reg_chan, node.node) {
                                status = consumer_snapshot_channel(socket,
                                                reg_chan->consumer_key,
                                                output, 0, usess->uid,
                                                usess->gid, pathname, wait,
-                                               nb_packets_per_stream,
-                                               trace_archive_id);
+                                               nb_packets_per_stream);
                                if (status != LTTNG_OK) {
                                        goto error;
                                }
                        }
                        status = consumer_snapshot_channel(socket,
                                        reg->registry->reg.ust->metadata_key, output, 1,
-                                       usess->uid, usess->gid, pathname, wait, 0,
-                                       trace_archive_id);
+                                       usess->uid, usess->gid, pathname, wait, 0);
                        if (status != LTTNG_OK) {
                                goto error;
                        }
@@ -5969,7 +5964,7 @@ enum lttng_error_code ust_app_snapshot_record(struct ltt_ust_session *usess,
 
                        /* Get the right consumer socket for the application. */
                        socket = consumer_find_socket_by_bitness(app->bits_per_long,
-                                       output->consumer);
+                                       output);
                        if (!socket) {
                                status = LTTNG_ERR_INVALID;
                                goto error;
@@ -5977,7 +5972,7 @@ enum lttng_error_code ust_app_snapshot_record(struct ltt_ust_session *usess,
 
                        /* Add the UST default trace dir to path. */
                        memset(pathname, 0, sizeof(pathname));
-                       ret = snprintf(pathname, sizeof(pathname), DEFAULT_UST_TRACE_DIR "/%s",
+                       ret = snprintf(pathname, sizeof(pathname), DEFAULT_UST_TRACE_DIR "%s",
                                        ua_sess->path);
                        if (ret < 0) {
                                status = LTTNG_ERR_INVALID;
@@ -5985,14 +5980,16 @@ enum lttng_error_code ust_app_snapshot_record(struct ltt_ust_session *usess,
                                goto error;
                        }
 
-                       cds_lfht_for_each_entry(ua_sess->channels->ht, &chan_iter.iter,
+                        cds_lfht_for_each_entry(ua_sess->channels->ht, &chan_iter.iter,
                                        ua_chan, node.node) {
                                status = consumer_snapshot_channel(socket,
-                                               ua_chan->key, output,
-                                               0, ua_sess->euid, ua_sess->egid,
+                                               ua_chan->key, output, 0,
+                                               ua_sess->effective_credentials
+                                                               .uid,
+                                               ua_sess->effective_credentials
+                                                               .gid,
                                                pathname, wait,
-                                               nb_packets_per_stream,
-                                               trace_archive_id);
+                                               nb_packets_per_stream);
                                switch (status) {
                                case LTTNG_OK:
                                        break;
@@ -6009,10 +6006,10 @@ enum lttng_error_code ust_app_snapshot_record(struct ltt_ust_session *usess,
                                continue;
                        }
                        status = consumer_snapshot_channel(socket,
-                                       registry->metadata_key, output,
-                                       1, ua_sess->euid, ua_sess->egid,
-                                       pathname, wait, 0,
-                                       trace_archive_id);
+                                       registry->metadata_key, output, 1,
+                                       ua_sess->effective_credentials.uid,
+                                       ua_sess->effective_credentials.gid,
+                                       pathname, wait, 0);
                        switch (status) {
                        case LTTNG_OK:
                                break;
@@ -6031,17 +6028,14 @@ enum lttng_error_code ust_app_snapshot_record(struct ltt_ust_session *usess,
 
 error:
        rcu_read_unlock();
-       if (session) {
-               session_put(session);
-       }
        return status;
 }
 
 /*
  * Return the size taken by one more packet per stream.
  */
-uint64_t ust_app_get_size_one_more_packet_per_stream(struct ltt_ust_session *usess,
-               uint64_t cur_nr_packets)
+uint64_t ust_app_get_size_one_more_packet_per_stream(
+               const struct ltt_ust_session *usess, uint64_t cur_nr_packets)
 {
        uint64_t tot_size = 0;
        struct ust_app *app;
@@ -6280,7 +6274,6 @@ enum lttng_error_code ust_app_rotate_session(struct ltt_session *session)
        struct lttng_ht_iter iter;
        struct ust_app *app;
        struct ltt_ust_session *usess = session->ust_session;
-       char pathname[LTTNG_PATH_MAX];
 
        assert(usess);
 
@@ -6303,24 +6296,14 @@ enum lttng_error_code ust_app_rotate_session(struct ltt_session *session)
                                goto error;
                        }
 
-                       ret = snprintf(pathname, sizeof(pathname),
-                                       DEFAULT_UST_TRACE_DIR "/" DEFAULT_UST_TRACE_UID_PATH,
-                                       reg->uid, reg->bits_per_long);
-                       if (ret < 0 || ret >= sizeof(pathname)) {
-                               PERROR("Failed to format rotation path");
-                               cmd_ret = LTTNG_ERR_INVALID;
-                               goto error;
-                       }
-
                        /* Rotate the data channels. */
                        cds_lfht_for_each_entry(reg->registry->channels->ht, &iter.iter,
                                        reg_chan, node.node) {
                                ret = consumer_rotate_channel(socket,
                                                reg_chan->consumer_key,
                                                usess->uid, usess->gid,
-                                               usess->consumer, pathname,
-                                               /* is_metadata_channel */ false,
-                                               session->current_archive_id);
+                                               usess->consumer,
+                                               /* is_metadata_channel */ false);
                                if (ret < 0) {
                                        cmd_ret = LTTNG_ERR_ROTATION_FAIL_CONSUMER;
                                        goto error;
@@ -6332,9 +6315,8 @@ enum lttng_error_code ust_app_rotate_session(struct ltt_session *session)
                        ret = consumer_rotate_channel(socket,
                                        reg->registry->reg.ust->metadata_key,
                                        usess->uid, usess->gid,
-                                       usess->consumer, pathname,
-                                       /* is_metadata_channel */ true,
-                                       session->current_archive_id);
+                                       usess->consumer,
+                                       /* is_metadata_channel */ true);
                        if (ret < 0) {
                                cmd_ret = LTTNG_ERR_ROTATION_FAIL_CONSUMER;
                                goto error;
@@ -6356,14 +6338,6 @@ enum lttng_error_code ust_app_rotate_session(struct ltt_session *session)
                                /* Session not associated with this app. */
                                continue;
                        }
-                       ret = snprintf(pathname, sizeof(pathname),
-                                       DEFAULT_UST_TRACE_DIR "/%s",
-                                       ua_sess->path);
-                       if (ret < 0 || ret >= sizeof(pathname)) {
-                               PERROR("Failed to format rotation path");
-                               cmd_ret = LTTNG_ERR_INVALID;
-                               goto error;
-                       }
 
                        /* Get the right consumer socket for the application. */
                        socket = consumer_find_socket_by_bitness(app->bits_per_long,
@@ -6379,15 +6353,17 @@ enum lttng_error_code ust_app_rotate_session(struct ltt_session *session)
                                continue;
                        }
 
-
                        /* Rotate the data channels. */
                        cds_lfht_for_each_entry(ua_sess->channels->ht, &chan_iter.iter,
                                        ua_chan, node.node) {
-                               ret = consumer_rotate_channel(socket, ua_chan->key,
-                                               ua_sess->euid, ua_sess->egid,
-                                               ua_sess->consumer, pathname,
-                                               /* is_metadata_channel */ false,
-                                               session->current_archive_id);
+                               ret = consumer_rotate_channel(socket,
+                                               ua_chan->key,
+                                               ua_sess->effective_credentials
+                                                               .uid,
+                                               ua_sess->effective_credentials
+                                                               .gid,
+                                               ua_sess->consumer,
+                                               /* is_metadata_channel */ false);
                                if (ret < 0) {
                                        /* Per-PID buffer and application going away. */
                                        if (ret == -LTTNG_ERR_CHAN_NOT_FOUND)
@@ -6399,11 +6375,12 @@ enum lttng_error_code ust_app_rotate_session(struct ltt_session *session)
 
                        /* Rotate the metadata channel. */
                        (void) push_metadata(registry, usess->consumer);
-                       ret = consumer_rotate_channel(socket, registry->metadata_key,
-                                       ua_sess->euid, ua_sess->egid,
-                                       ua_sess->consumer, pathname,
-                                       /* is_metadata_channel */ true,
-                                       session->current_archive_id);
+                       ret = consumer_rotate_channel(socket,
+                                       registry->metadata_key,
+                                       ua_sess->effective_credentials.uid,
+                                       ua_sess->effective_credentials.gid,
+                                       ua_sess->consumer,
+                                       /* is_metadata_channel */ true);
                        if (ret < 0) {
                                /* Per-PID buffer and application going away. */
                                if (ret == -LTTNG_ERR_CHAN_NOT_FOUND)
@@ -6425,3 +6402,99 @@ error:
        rcu_read_unlock();
        return cmd_ret;
 }
+
+enum lttng_error_code ust_app_create_channel_subdirectories(
+               const struct ltt_ust_session *usess)
+{
+       enum lttng_error_code ret = LTTNG_OK;
+       struct lttng_ht_iter iter;
+       enum lttng_trace_chunk_status chunk_status;
+       char *pathname_index;
+       int fmt_ret;
+
+       assert(usess->current_trace_chunk);
+       rcu_read_lock();
+
+       switch (usess->buffer_type) {
+       case LTTNG_BUFFER_PER_UID:
+       {
+               struct buffer_reg_uid *reg;
+
+               cds_list_for_each_entry(reg, &usess->buffer_reg_uid_list, lnode) {
+                       fmt_ret = asprintf(&pathname_index,
+                                      DEFAULT_UST_TRACE_DIR DEFAULT_UST_TRACE_UID_PATH "/" DEFAULT_INDEX_DIR,
+                                      reg->uid, reg->bits_per_long);
+                       if (fmt_ret < 0) {
+                               ERR("Failed to format channel index directory");
+                               ret = LTTNG_ERR_CREATE_DIR_FAIL;
+                               goto error;
+                       }
+
+                       /*
+                        * Create the index subdirectory which will take care
+                        * of implicitly creating the channel's path.
+                        */
+                       chunk_status = lttng_trace_chunk_create_subdirectory(
+                                       usess->current_trace_chunk,
+                                       pathname_index);
+                       free(pathname_index);
+                       if (chunk_status != LTTNG_TRACE_CHUNK_STATUS_OK) {
+                               ret = LTTNG_ERR_CREATE_DIR_FAIL;
+                               goto error;
+                       }
+               }
+               break;
+       }
+       case LTTNG_BUFFER_PER_PID:
+       {
+               struct ust_app *app;
+
+               cds_lfht_for_each_entry(ust_app_ht->ht, &iter.iter, app,
+                               pid_n.node) {
+                       struct ust_app_session *ua_sess;
+                       struct ust_registry_session *registry;
+
+                       ua_sess = lookup_session_by_app(usess, app);
+                       if (!ua_sess) {
+                               /* Session not associated with this app. */
+                               continue;
+                       }
+
+                       registry = get_session_registry(ua_sess);
+                       if (!registry) {
+                               DBG("Application session is being torn down. Skip application.");
+                               continue;
+                       }
+
+                       fmt_ret = asprintf(&pathname_index,
+                                       DEFAULT_UST_TRACE_DIR "%s/" DEFAULT_INDEX_DIR,
+                                       ua_sess->path);
+                       if (fmt_ret < 0) {
+                               ERR("Failed to format channel index directory");
+                               ret = LTTNG_ERR_CREATE_DIR_FAIL;
+                               goto error;
+                       }
+                       /*
+                        * Create the index subdirectory which will take care
+                        * of implicitly creating the channel's path.
+                        */
+                       chunk_status = lttng_trace_chunk_create_subdirectory(
+                                       usess->current_trace_chunk,
+                                       pathname_index);
+                       free(pathname_index);
+                       if (chunk_status != LTTNG_TRACE_CHUNK_STATUS_OK) {
+                               ret = LTTNG_ERR_CREATE_DIR_FAIL;
+                               goto error;
+                       }
+               }
+               break;
+       }
+       default:
+               abort();
+       }
+
+       ret = LTTNG_OK;
+error:
+       rcu_read_unlock();
+       return ret;
+}
This page took 0.030439 seconds and 4 git commands to generate.