Fix: consumer output memory leak on creation

[lttng-tools.git] / src / bin / lttng-sessiond / trace-ust.c

diff --git a/src/bin/lttng-sessiond/trace-ust.c b/src/bin/lttng-sessiond/trace-ust.c
index d1e8b8dae117a4369d35681a0e6d7462b0f136c3..864a4b0d1bb0dcd25c2e2de54b16999f8d3d22cc 100644 (file)
--- a/src/bin/lttng-sessiond/trace-ust.c
+++ b/src/bin/lttng-sessiond/trace-ust.c
@@ -111,7 +111,7 @@ struct ltt_ust_session *trace_ust_create_session(char *path,
 
        lus->consumer = consumer_create_output(CONSUMER_DST_LOCAL);
        if (lus->consumer == NULL) {
-               goto error_free_session;
+               goto error_consumer;
        }
 
        /*
@@ -128,7 +128,7 @@ struct ltt_ust_session *trace_ust_create_session(char *path,
                                "%s" DEFAULT_UST_TRACE_DIR, path);
                if (ret < 0) {
                        PERROR("snprintf UST consumer trace path");
-                       goto error;
+                       goto error_path;
                }
 
                /* Set session path */
@@ -136,7 +136,7 @@ struct ltt_ust_session *trace_ust_create_session(char *path,
                                path);
                if (ret < 0) {
                        PERROR("snprintf kernel traces path");
-                       goto error_free_session;
+                       goto error_path;
                }
        }
 
@@ -144,7 +144,9 @@ struct ltt_ust_session *trace_ust_create_session(char *path,
 
        return lus;
 
-error_free_session:
+error_path:
+       consumer_destroy_output(lus->consumer);
+error_consumer:
        lttng_ht_destroy(lus->domain_global.channels);
        lttng_ht_destroy(lus->domain_exec);
        lttng_ht_destroy(lus->domain_pid);
@@ -578,6 +580,9 @@ void trace_ust_destroy_session(struct ltt_ust_session *session)
        destroy_domain_pid(session->domain_pid);
        destroy_domain_exec(session->domain_exec);
 
+       consumer_destroy_output(session->consumer);
+       consumer_destroy_output(session->tmp_consumer);
+
        free(session);
 
        rcu_read_unlock();