Fix: sessiond: triggers: failure to insert trigger is fatal

[lttng-tools.git] / src / bin / lttng-sessiond / notification-thread-events.c

diff --git a/src/bin/lttng-sessiond/notification-thread-events.c b/src/bin/lttng-sessiond/notification-thread-events.c
index 178b80fa2b59bbcc715ad23245924b7b0d48657a..c9c21bc7225df72ee21ad8a74d33f101dd878aca 100644 (file)
--- a/src/bin/lttng-sessiond/notification-thread-events.c
+++ b/src/bin/lttng-sessiond/notification-thread-events.c
@@ -2305,7 +2305,7 @@ static int handle_notification_thread_command_get_trigger(
 
        /* Not a fatal error if the trigger is not found. */
        get_trigger_info_for_log(trigger, &trigger_name, &trigger_owner_uid);
-       ERR("Failed to retrieve registered version of trigger: trigger name = '%s', trigger owner uid = %d",
+       DBG("Failed to retrieve registered version of trigger: trigger name = '%s', trigger owner uid = %d",
                        trigger_name, (int) trigger_owner_uid);
 
        ret = 0;
@@ -2729,9 +2729,8 @@ int handle_notification_thread_command_register_trigger(
                        trigger,
                        &trigger_ht_element->node_by_name_uid);
        if (node != &trigger_ht_element->node_by_name_uid) {
-               /* Not a fatal error, simply report it to the client. */
-               cds_lfht_del(state->triggers_ht, &trigger_ht_element->node);
-               *cmd_result = LTTNG_ERR_TRIGGER_EXISTS;
+               /* Internal error: add to triggers_ht should have failed. */
+               ret = -1;
                goto error_free_ht_element;
        }