Fix: double RCU unlock on event_agent_disable_all
[lttng-tools.git] / src / bin / lttng-sessiond / event.c
index 5a6825e6ef8a7412ec679bbb9f0c67cb95b12e7b..8cca21391d43dd9b20b877bc920e14d10c1a348e 100644 (file)
@@ -16,6 +16,7 @@
  */
 
 #define _GNU_SOURCE
+#define _LGPL_SOURCE
 #include <errno.h>
 #include <urcu/list.h>
 #include <string.h>
 #include "channel.h"
 #include "event.h"
 #include "kernel.h"
+#include "lttng-sessiond.h"
 #include "ust-ctl.h"
 #include "ust-app.h"
 #include "trace-kernel.h"
 #include "trace-ust.h"
+#include "agent.h"
 
 /*
- * Setup a lttng_event used to enable *all* syscall tracing.
+ * Add unique UST event based on the event name, filter bytecode and loglevel.
  */
-static void init_syscalls_kernel_event(struct lttng_event *event)
+static void add_unique_ust_event(struct lttng_ht *ht,
+               struct ltt_ust_event *event)
 {
-       event->name[0] = '\0';
-       /*
-        * We use LTTNG_EVENT* here since the trace kernel creation will make the
-        * right changes for the kernel.
-        */
-       event->type = LTTNG_EVENT_SYSCALL;
+       struct cds_lfht_node *node_ptr;
+       struct ltt_ust_ht_key key;
+
+       assert(ht);
+       assert(ht->ht);
+       assert(event);
+
+       key.name = event->attr.name;
+       key.filter = (struct lttng_filter_bytecode *) event->filter;
+       key.loglevel_type = event->attr.loglevel_type;
+       key.loglevel_value = event->attr.loglevel;
+       key.exclusion = event->exclusion;
+
+       node_ptr = cds_lfht_add_unique(ht->ht,
+                       ht->hash_fct(event->node.key, lttng_ht_seed),
+                       trace_ust_ht_match_event, &key, &event->node.node);
+       assert(node_ptr == &event->node.node);
 }
 
 /*
  * Disable kernel tracepoint event for a channel from the kernel session.
  */
-int event_kernel_disable_tracepoint(struct ltt_kernel_session *ksession,
-               struct ltt_kernel_channel *kchan, char *event_name)
+int event_kernel_disable_event(struct ltt_kernel_channel *kchan,
+               char *event_name)
 {
        int ret;
        struct ltt_kernel_event *kevent;
 
-       kevent = trace_kernel_get_event_by_name(event_name, kchan);
+       assert(kchan);
+
+       kevent = trace_kernel_get_event_by_name(event_name, kchan,
+                       LTTNG_EVENT_ALL);
        if (kevent == NULL) {
-               ret = LTTCOMM_NO_EVENT;
+               ret = LTTNG_ERR_NO_EVENT;
                goto error;
        }
 
        ret = kernel_disable_event(kevent);
        if (ret < 0) {
-               ret = LTTCOMM_KERN_DISABLE_FAIL;
+               ret = LTTNG_ERR_KERN_DISABLE_FAIL;
                goto error;
        }
 
        DBG("Kernel event %s disable for channel %s.",
                        kevent->event->name, kchan->channel->name);
 
-       ret = LTTCOMM_OK;
+       ret = LTTNG_OK;
 
 error:
        return ret;
@@ -78,71 +96,68 @@ error:
 /*
  * Disable kernel tracepoint events for a channel from the kernel session.
  */
-int event_kernel_disable_all_tracepoints(struct ltt_kernel_session *ksession,
-               struct ltt_kernel_channel *kchan)
+int event_kernel_disable_event_type(struct ltt_kernel_channel *kchan,
+               enum lttng_event_type type)
 {
        int ret;
        struct ltt_kernel_event *kevent;
 
+       assert(kchan);
+
        /* For each event in the kernel session */
        cds_list_for_each_entry(kevent, &kchan->events_list.head, list) {
+               if (type != LTTNG_EVENT_ALL && kevent->type != type)
+                       continue;
                ret = kernel_disable_event(kevent);
                if (ret < 0) {
                        /* We continue disabling the rest */
                        continue;
                }
        }
-       ret = LTTCOMM_OK;
+       ret = LTTNG_OK;
        return ret;
 }
 
-/*
- * Disable kernel syscall events for a channel from the kernel session.
- */
-int event_kernel_disable_all_syscalls(struct ltt_kernel_session *ksession,
-               struct ltt_kernel_channel *kchan)
-{
-       ERR("Cannot disable syscall tracing for existing session. Please destroy session instead.");
-       return LTTCOMM_OK;      /* Return OK so disable all succeeds */
-}
-
 /*
  * Disable all kernel event for a channel from the kernel session.
  */
-int event_kernel_disable_all(struct ltt_kernel_session *ksession,
-               struct ltt_kernel_channel *kchan)
+int event_kernel_disable_event_all(struct ltt_kernel_channel *kchan)
 {
-       int ret;
-
-       ret = event_kernel_disable_all_tracepoints(ksession, kchan);
-       if (ret != LTTCOMM_OK)
-               return ret;
-       ret = event_kernel_disable_all_syscalls(ksession, kchan);
-       return ret;
+       return event_kernel_disable_event_type(kchan, LTTNG_EVENT_ALL);
 }
 
 /*
  * Enable kernel tracepoint event for a channel from the kernel session.
+ * We own filter_expression and filter.
  */
-int event_kernel_enable_tracepoint(struct ltt_kernel_session *ksession,
-               struct ltt_kernel_channel *kchan, struct lttng_event *event)
+int event_kernel_enable_event(struct ltt_kernel_channel *kchan,
+               struct lttng_event *event, char *filter_expression,
+               struct lttng_filter_bytecode *filter)
 {
        int ret;
        struct ltt_kernel_event *kevent;
 
-       kevent = trace_kernel_get_event_by_name(event->name, kchan);
+       assert(kchan);
+       assert(event);
+
+       kevent = trace_kernel_find_event(event->name, kchan,
+                       event->type, filter);
        if (kevent == NULL) {
-               ret = kernel_create_event(event, kchan);
+               ret = kernel_create_event(event, kchan,
+                       filter_expression, filter);
+               /* We have passed ownership */
+               filter_expression = NULL;
+               filter = NULL;
                if (ret < 0) {
                        switch (-ret) {
                        case EEXIST:
-                               ret = LTTCOMM_KERN_EVENT_EXIST;
+                               ret = LTTNG_ERR_KERN_EVENT_EXIST;
                                break;
                        case ENOSYS:
-                               ret = LTTCOMM_KERN_EVENT_ENOSYS;
+                               ret = LTTNG_ERR_KERN_EVENT_ENOSYS;
                                break;
                        default:
-                               ret = LTTCOMM_KERN_ENABLE_FAIL;
+                               ret = LTTNG_ERR_KERN_ENABLE_FAIL;
                                break;
                        }
                        goto end;
@@ -150,436 +165,492 @@ int event_kernel_enable_tracepoint(struct ltt_kernel_session *ksession,
        } else if (kevent->enabled == 0) {
                ret = kernel_enable_event(kevent);
                if (ret < 0) {
-                       ret = LTTCOMM_KERN_ENABLE_FAIL;
+                       ret = LTTNG_ERR_KERN_ENABLE_FAIL;
                        goto end;
                }
        } else {
                /* At this point, the event is considered enabled */
-               ret = LTTCOMM_KERN_EVENT_EXIST;
+               ret = LTTNG_ERR_KERN_EVENT_EXIST;
                goto end;
        }
 
-       ret = LTTCOMM_OK;
+       ret = LTTNG_OK;
 end:
+       free(filter_expression);
+       free(filter);
        return ret;
 }
 
 /*
- * Enable all kernel tracepoint events of a channel of the kernel session.
+ * ============================
+ * UST : The Ultimate Frontier!
+ * ============================
+ */
+
+/*
+ * Enable UST tracepoint event for a channel from a UST session.
+ * We own filter_expression, filter, and exclusion.
  */
-int event_kernel_enable_all_tracepoints(struct ltt_kernel_session *ksession,
-               struct ltt_kernel_channel *kchan, int kernel_tracer_fd)
+int event_ust_enable_tracepoint(struct ltt_ust_session *usess,
+               struct ltt_ust_channel *uchan, struct lttng_event *event,
+               char *filter_expression,
+               struct lttng_filter_bytecode *filter,
+               struct lttng_event_exclusion *exclusion,
+               bool internal_event)
 {
-       int size, i, ret;
-       struct ltt_kernel_event *kevent;
-       struct lttng_event *event_list = NULL;
+       int ret = LTTNG_OK, to_create = 0;
+       struct ltt_ust_event *uevent;
 
-       /* For each event in the kernel session */
-       cds_list_for_each_entry(kevent, &kchan->events_list.head, list) {
-               if (kevent->enabled == 0) {
-                       ret = kernel_enable_event(kevent);
-                       if (ret < 0) {
-                               /* Enable failed but still continue */
-                               continue;
-                       }
+       assert(usess);
+       assert(uchan);
+       assert(event);
+
+       rcu_read_lock();
+
+       uevent = trace_ust_find_event(uchan->events, event->name, filter,
+                       event->loglevel_type, event->loglevel, exclusion);
+       if (!uevent) {
+               uevent = trace_ust_create_event(event, filter_expression,
+                               filter, exclusion, internal_event);
+               /* We have passed ownership */
+               filter_expression = NULL;
+               filter = NULL;
+               exclusion = NULL;
+               if (uevent == NULL) {
+                       ret = LTTNG_ERR_UST_ENABLE_FAIL;
+                       goto error;
                }
+
+               /* Valid to set it after the goto error since uevent is still NULL */
+               to_create = 1;
        }
 
-       size = kernel_list_events(kernel_tracer_fd, &event_list);
-       if (size < 0) {
-               ret = LTTCOMM_KERN_LIST_FAIL;
+       if (uevent->enabled) {
+               /* It's already enabled so everything is OK */
+               ret = LTTNG_ERR_UST_EVENT_ENABLED;
                goto end;
        }
 
-       for (i = 0; i < size; i++) {
-               kevent = trace_kernel_get_event_by_name(event_list[i].name, kchan);
-               if (kevent == NULL) {
-                       /* Default event type for enable all */
-                       event_list[i].type = LTTNG_EVENT_TRACEPOINT;
-                       /* Enable each single tracepoint event */
-                       ret = kernel_create_event(&event_list[i], kchan);
-                       if (ret < 0) {
-                               /* Ignore error here and continue */
-                       }
+       uevent->enabled = 1;
+
+       if (to_create) {
+               /* Create event on all UST registered apps for session */
+               ret = ust_app_create_event_glb(usess, uchan, uevent);
+       } else {
+               /* Enable event on all UST registered apps for session */
+               ret = ust_app_enable_event_glb(usess, uchan, uevent);
+       }
+
+       if (ret < 0) {
+               if (ret == -LTTNG_UST_ERR_EXIST) {
+                       ret = LTTNG_ERR_UST_EVENT_EXIST;
+                       goto end;
+               } else {
+                       ret = LTTNG_ERR_UST_ENABLE_FAIL;
+                       goto error;
                }
        }
-       free(event_list);
 
-       ret = LTTCOMM_OK;
+       if (to_create) {
+               /* Add ltt ust event to channel */
+               add_unique_ust_event(uchan->events, uevent);
+       }
+
+       DBG("Event UST %s %s in channel %s", uevent->attr.name,
+                       to_create ? "created" : "enabled", uchan->name);
+
+       ret = LTTNG_OK;
+
 end:
+       rcu_read_unlock();
+       free(filter_expression);
+       free(filter);
+       free(exclusion);
        return ret;
 
+error:
+       /*
+        * Only destroy event on creation time (not enabling time) because if the
+        * event is found in the channel (to_create == 0), it means that at some
+        * point the enable_event worked and it's thus valid to keep it alive.
+        * Destroying it also implies that we also destroy it's shadow copy to sync
+        * everyone up.
+        */
+       if (to_create) {
+               /* In this code path, the uevent was not added to the hash table */
+               trace_ust_destroy_event(uevent);
+       }
+       rcu_read_unlock();
+       free(filter_expression);
+       free(filter);
+       free(exclusion);
+       return ret;
 }
 
 /*
- * Enable all kernel tracepoint events of a channel of the kernel session.
+ * Disable UST tracepoint of a channel from a UST session.
  */
-int event_kernel_enable_all_syscalls(struct ltt_kernel_session *ksession,
-               struct ltt_kernel_channel *kchan, int kernel_tracer_fd)
+int event_ust_disable_tracepoint(struct ltt_ust_session *usess,
+               struct ltt_ust_channel *uchan, char *event_name)
 {
        int ret;
-       struct lttng_event event;
+       struct ltt_ust_event *uevent;
+       struct lttng_ht_node_str *node;
+       struct lttng_ht_iter iter;
+       struct lttng_ht *ht;
 
-       init_syscalls_kernel_event(&event);
+       assert(usess);
+       assert(uchan);
+       assert(event_name);
 
-       DBG("Enabling all syscall tracing");
+       ht = uchan->events;
 
-       ret = kernel_create_event(&event, kchan);
-       if (ret < 0) {
-               if (ret == -EEXIST) {
-                       ret = LTTCOMM_KERN_EVENT_EXIST;
-               } else {
-                       ret = LTTCOMM_KERN_ENABLE_FAIL;
-               }
-               goto end;
+       rcu_read_lock();
+
+       /*
+        * We use a custom lookup since we need the iterator for the next_duplicate
+        * call in the do while loop below.
+        */
+       cds_lfht_lookup(ht->ht, ht->hash_fct((void *) event_name, lttng_ht_seed),
+                       trace_ust_ht_match_event_by_name, event_name, &iter.iter);
+       node = lttng_ht_iter_get_node_str(&iter);
+       if (node == NULL) {
+               DBG2("Trace UST event NOT found by name %s", event_name);
+               ret = LTTNG_ERR_UST_EVENT_NOT_FOUND;
+               goto error;
        }
 
-       ret = LTTCOMM_OK;
-end:
-       return ret;
-}
+       do {
+               uevent = caa_container_of(node, struct ltt_ust_event, node);
+               assert(uevent);
 
-/*
- * Enable all kernel events of a channel of the kernel session.
- */
-int event_kernel_enable_all(struct ltt_kernel_session *ksession,
-               struct ltt_kernel_channel *kchan, int kernel_tracer_fd)
-{
-       int tp_ret;
+               if (uevent->enabled == 0) {
+                       /* It's already disabled so everything is OK */
+                       goto next;
+               }
 
-       tp_ret = event_kernel_enable_all_tracepoints(ksession, kchan, kernel_tracer_fd);
-       if (tp_ret != LTTCOMM_OK) {
-               goto end;
-       }
+               ret = ust_app_disable_event_glb(usess, uchan, uevent);
+               if (ret < 0 && ret != -LTTNG_UST_ERR_EXIST) {
+                       ret = LTTNG_ERR_UST_DISABLE_FAIL;
+                       goto error;
+               }
+               uevent->enabled = 0;
 
-       /*
-        * Reaching this code path means that all tracepoints were enabled without
-        * errors so we ignore the error value of syscalls.
-        *
-        * At the moment, failing to enable syscalls on "lttng enable-event -a -k"
-        * is not considered an error that need to be returned to the client since
-        * tracepoints did not fail. Future work will allow us to send back
-        * multiple errors to the client in one API call.
-        */
-       (void) event_kernel_enable_all_syscalls(ksession, kchan, kernel_tracer_fd);
+               DBG2("Event UST %s disabled in channel %s", uevent->attr.name,
+                               uchan->name);
 
-end:
-       return tp_ret;
-}
+next:
+               /* Get next duplicate event by name. */
+               cds_lfht_next_duplicate(ht->ht, trace_ust_ht_match_event_by_name,
+                               event_name, &iter.iter);
+               node = lttng_ht_iter_get_node_str(&iter);
+       } while (node);
 
-/*
- * ============================
- * UST : The Ultimate Frontier!
- * ============================
- */
+       ret = LTTNG_OK;
+
+error:
+       rcu_read_unlock();
+       return ret;
+}
 
 /*
- * Enable all UST tracepoints for a channel from a UST session.
+ * Enable all agent event for a given UST session.
+ *
+ * Return LTTNG_OK on success or else a LTTNG_ERR* code.
  */
-int event_ust_enable_all_tracepoints(struct ltt_ust_session *usess, int domain,
-               struct ltt_ust_channel *uchan)
+int event_agent_enable_all(struct ltt_ust_session *usess,
+               struct agent *agt, struct lttng_event *event,
+               struct lttng_filter_bytecode *filter ,char *filter_expression)
 {
-       int ret, i;
-       size_t size;
+       int ret;
+       struct agent_event *aevent;
        struct lttng_ht_iter iter;
-       struct ltt_ust_event *uevent = NULL;
-       struct lttng_event *events = NULL;
-
-       switch (domain) {
-       case LTTNG_DOMAIN_UST:
-       {
-               /* Enable existing events */
-               cds_lfht_for_each_entry(uchan->events->ht, &iter.iter, uevent,
-                               node.node) {
-                       if (uevent->enabled == 0) {
-                               ret = ust_app_enable_event_glb(usess, uchan, uevent);
-                               if (ret < 0) {
-                                       continue;
-                               }
-                               uevent->enabled = 1;
-                       }
-               }
-
-               /* Get all UST available events */
-               size = ust_app_list_events(&events);
-               if (size < 0) {
-                       ret = LTTCOMM_UST_LIST_FAIL;
-                       goto error;
-               }
 
-               for (i = 0; i < size; i++) {
-                       /*
-                        * Check if event exist and if so, continue since it was enable
-                        * previously.
-                        */
-                       uevent = trace_ust_find_event_by_name(uchan->events,
-                                       events[i].name);
-                       if (uevent != NULL) {
-                               ret = ust_app_enable_event_pid(usess, uchan, uevent,
-                                               events[i].pid);
-                               if (ret < 0) {
-                                       if (ret != -EEXIST) {
-                                               ret = LTTCOMM_UST_ENABLE_FAIL;
-                                               goto error;
-                                       }
-                               }
-                               continue;
-                       }
+       assert(usess);
 
-                       /* Create ust event */
-                       uevent = trace_ust_create_event(&events[i]);
-                       if (uevent == NULL) {
-                               ret = LTTCOMM_FATAL;
-                               goto error_destroy;
-                       }
+       DBG("Event agent enabling ALL events for session %" PRIu64, usess->id);
 
-                       /* Create event for the specific PID */
-                       ret = ust_app_enable_event_pid(usess, uchan, uevent,
-                                       events[i].pid);
-                       if (ret < 0) {
-                               if (ret == -EEXIST) {
-                                       ret = LTTCOMM_UST_EVENT_EXIST;
-                                       goto error;
-                               } else {
-                                       ret = LTTCOMM_UST_ENABLE_FAIL;
-                                       goto error_destroy;
-                               }
-                       }
-
-                       uevent->enabled = 1;
-                       /* Add ltt ust event to channel */
-                       rcu_read_lock();
-                       lttng_ht_add_unique_str(uchan->events, &uevent->node);
-                       rcu_read_unlock();
-               }
-
-               free(events);
-               break;
-       }
-#if 0
-       case LTTNG_DOMAIN_UST_EXEC_NAME:
-       case LTTNG_DOMAIN_UST_PID:
-       case LTTNG_DOMAIN_UST_PID_FOLLOW_CHILDREN:
-#endif
-       default:
-               ret = LTTCOMM_UND;
+       /* Enable event on agent application through TCP socket. */
+       ret = event_agent_enable(usess, agt, event, filter, filter_expression);
+       if (ret != LTTNG_OK) {
                goto error;
        }
 
-       return LTTCOMM_OK;
+       /* Flag every event that they are now enabled. */
+       rcu_read_lock();
+       cds_lfht_for_each_entry(agt->events->ht, &iter.iter, aevent,
+                       node.node) {
+               aevent->enabled = 1;
+       }
+       rcu_read_unlock();
 
-error_destroy:
-       trace_ust_destroy_event(uevent);
+       ret = LTTNG_OK;
 
 error:
-       free(events);
        return ret;
 }
 
 /*
- * Enable UST tracepoint event for a channel from a UST session.
+ * Enable a single agent event for a given UST session.
+ *
+ * Return LTTNG_OK on success or else a LTTNG_ERR* code.
  */
-int event_ust_enable_tracepoint(struct ltt_ust_session *usess, int domain,
-               struct ltt_ust_channel *uchan, struct lttng_event *event)
+int event_agent_enable(struct ltt_ust_session *usess,
+               struct agent *agt, struct lttng_event *event,
+               struct lttng_filter_bytecode *filter,
+               char *filter_expression)
 {
-       int ret = LTTCOMM_OK, to_create = 0;
-       struct ltt_ust_event *uevent;
-
-       uevent = trace_ust_find_event_by_name(uchan->events, event->name);
-       if (uevent == NULL) {
-               uevent = trace_ust_create_event(event);
-               if (uevent == NULL) {
-                       ret = LTTCOMM_FATAL;
+       int ret, created = 0;
+       struct agent_event *aevent;
+
+       assert(usess);
+       assert(event);
+       assert(agt);
+
+       DBG("Event agent enabling %s for session %" PRIu64 " with loglevel type %d "
+                       ", loglevel %d and filter \"%s\"", event->name,
+                       usess->id, event->loglevel_type, event->loglevel,
+                       filter_expression ? filter_expression : "NULL");
+
+       aevent = agent_find_event(event->name, event->loglevel_type,
+               event->loglevel, agt);
+       if (!aevent) {
+               aevent = agent_create_event(event->name, event->loglevel_type,
+                               event->loglevel, filter,
+                               filter_expression);
+               if (!aevent) {
+                       ret = LTTNG_ERR_NOMEM;
                        goto error;
                }
-               /* Valid to set it after the goto error since uevent is still NULL */
-               to_create = 1;
+               created = 1;
        }
 
-       if (uevent->enabled) {
-               /* It's already enabled so everything is OK */
+       /* Already enabled? */
+       if (aevent->enabled) {
                goto end;
        }
 
-       uevent->enabled = 1;
-
-       switch (domain) {
-       case LTTNG_DOMAIN_UST:
-       {
-               if (to_create) {
-                       /* Create event on all UST registered apps for session */
-                       ret = ust_app_create_event_glb(usess, uchan, uevent);
-               } else {
-                       /* Enable event on all UST registered apps for session */
-                       ret = ust_app_enable_event_glb(usess, uchan, uevent);
-               }
-
-               if (ret < 0) {
-                       if (ret == -EEXIST) {
-                               ret = LTTCOMM_UST_EVENT_EXIST;
-                               goto end;
-                       } else {
-                               ret = LTTCOMM_UST_ENABLE_FAIL;
-                               goto error;
-                       }
-               }
-               break;
-       }
-#if 0
-       case LTTNG_DOMAIN_UST_EXEC_NAME:
-       case LTTNG_DOMAIN_UST_PID:
-       case LTTNG_DOMAIN_UST_PID_FOLLOW_CHILDREN:
-#endif
-       default:
-               ret = LTTCOMM_UND;
-               goto end;
+       ret = agent_enable_event(aevent, agt->domain);
+       if (ret != LTTNG_OK) {
+               goto error;
        }
 
-       if (to_create) {
-               rcu_read_lock();
-               /* Add ltt ust event to channel */
-               lttng_ht_add_unique_str(uchan->events, &uevent->node);
-               rcu_read_unlock();
+       /* If the event was created prior to the enable, add it to the domain. */
+       if (created) {
+               agent_add_event(aevent, agt);
        }
 
-       DBG("Event UST %s %s in channel %s", uevent->attr.name,
-                       to_create ? "created" : "enabled", uchan->name);
-
-       ret = LTTCOMM_OK;
-
 end:
-       return ret;
+       return LTTNG_OK;
 
 error:
-       /*
-        * Only destroy event on creation time (not enabling time) because if the
-        * event is found in the channel (to_create == 0), it means that at some
-        * point the enable_event worked and it's thus valid to keep it alive.
-        * Destroying it also implies that we also destroy it's shadow copy to sync
-        * everyone up.
-        */
-       if (to_create) {
-               /* In this code path, the uevent was not added to the hash table */
-               trace_ust_destroy_event(uevent);
+       if (created) {
+               agent_destroy_event(aevent);
        }
        return ret;
 }
 
 /*
- * Disable UST tracepoint of a channel from a UST session.
+ * Return the default event name associated with the provided UST domain. Return
+ * NULL on error.
  */
-int event_ust_disable_tracepoint(struct ltt_ust_session *usess, int domain,
-               struct ltt_ust_channel *uchan, char *event_name)
+const char *event_get_default_agent_ust_name(enum lttng_domain_type domain)
+{
+       const char *default_event_name = NULL;
+
+       switch (domain) {
+       case LTTNG_DOMAIN_LOG4J:
+               default_event_name = DEFAULT_LOG4J_EVENT_NAME;
+               break;
+       case LTTNG_DOMAIN_JUL:
+               default_event_name = DEFAULT_JUL_EVENT_NAME;
+               break;
+       case LTTNG_DOMAIN_PYTHON:
+               default_event_name = DEFAULT_PYTHON_EVENT_NAME;
+               break;
+       default:
+               assert(0);
+       }
+
+       return default_event_name;
+}
+
+/*
+ * Disable a given agent event for a given UST session.
+ *
+ * Must be called with the RCU read lock held.
+ * Return LTTNG_OK on success or else a LTTNG_ERR* code.
+ */
+static int event_agent_disable_one(struct ltt_ust_session *usess,
+               struct agent *agt, struct agent_event *aevent)
 {
        int ret;
-       struct ltt_ust_event *uevent;
+       struct ltt_ust_event *uevent = NULL;
+       struct ltt_ust_channel *uchan = NULL;
+       const char *ust_event_name, *ust_channel_name;
+
+       assert(agt);
+       assert(usess);
+       assert(aevent);
+
+       DBG("Event agent disabling %s (loglevel type %d, loglevel value %d) for session %" PRIu64,
+               aevent->name, aevent->loglevel_type, aevent->loglevel_value,
+               usess->id);
 
-       uevent = trace_ust_find_event_by_name(uchan->events, event_name);
-       if (uevent == NULL) {
-               ret = LTTCOMM_UST_EVENT_NOT_FOUND;
+       /* Already disabled? */
+       if (!aevent->enabled) {
+               goto end;
+       }
+
+       if (agt->domain == LTTNG_DOMAIN_JUL) {
+               ust_channel_name = DEFAULT_JUL_CHANNEL_NAME;
+       } else if (agt->domain == LTTNG_DOMAIN_LOG4J) {
+               ust_channel_name = DEFAULT_LOG4J_CHANNEL_NAME;
+       } else if (agt->domain == LTTNG_DOMAIN_PYTHON) {
+               ust_channel_name = DEFAULT_PYTHON_CHANNEL_NAME;
+       } else {
+               ret = LTTNG_ERR_INVALID;
                goto error;
        }
 
-       if (uevent->enabled == 0) {
-               /* It's already enabled so everything is OK */
-               ret = LTTCOMM_OK;
-               goto end;
+       /*
+        * Disable it on the UST side. First get the channel reference then find
+        * the event and finally disable it.
+        */
+       uchan = trace_ust_find_channel_by_name(usess->domain_global.channels,
+                       (char *) ust_channel_name);
+       if (!uchan) {
+               ret = LTTNG_ERR_UST_CHAN_NOT_FOUND;
+               goto error;
        }
 
-       switch (domain) {
-       case LTTNG_DOMAIN_UST:
-               ret = ust_app_disable_event_glb(usess, uchan, uevent);
-               if (ret < 0 && ret != -EEXIST) {
-                       ret = LTTCOMM_UST_DISABLE_FAIL;
-                       goto error;
-               }
-               break;
-#if 0
-       case LTTNG_DOMAIN_UST_EXEC_NAME:
-       case LTTNG_DOMAIN_UST_PID:
-       case LTTNG_DOMAIN_UST_PID_FOLLOW_CHILDREN:
-#endif
-       default:
-               ret = LTTCOMM_UND;
+       ust_event_name = event_get_default_agent_ust_name(agt->domain);
+       if (!ust_event_name) {
+               ret = LTTNG_ERR_FATAL;
                goto error;
        }
 
+       /*
+        * Agent UST event has its loglevel type forced to
+        * LTTNG_UST_LOGLEVEL_ALL. The actual loglevel type/value filtering
+        * happens thanks to an UST filter. The following -1 is actually
+        * ignored since the type is LTTNG_UST_LOGLEVEL_ALL.
+        */
+       uevent = trace_ust_find_event(uchan->events, (char *) ust_event_name,
+                       aevent->filter, LTTNG_UST_LOGLEVEL_ALL, -1, NULL);
+       /* If the agent event exists, it must be available on the UST side. */
+       assert(uevent);
+
+       ret = ust_app_disable_event_glb(usess, uchan, uevent);
+       if (ret < 0 && ret != -LTTNG_UST_ERR_EXIST) {
+               ret = LTTNG_ERR_UST_DISABLE_FAIL;
+               goto error;
+       }
+
+       /*
+        * Flag event that it's disabled so the shadow copy on the ust app side
+        * will disable it if an application shows up.
+        */
        uevent->enabled = 0;
-       ret = LTTCOMM_OK;
+
+       ret = agent_disable_event(aevent, agt->domain);
+       if (ret != LTTNG_OK) {
+               goto error;
+       }
 
 end:
-       DBG2("Event UST %s disabled in channel %s", uevent->attr.name,
-                       uchan->name);
+       return LTTNG_OK;
 
 error:
        return ret;
 }
 
 /*
- * Disable all UST tracepoints for a channel from a UST session.
+ * Disable all agent events matching a given name for a given UST session.
+ *
+ * Return LTTNG_OK on success or else a LTTNG_ERR* code.
  */
-int event_ust_disable_all_tracepoints(struct ltt_ust_session *usess, int domain,
-               struct ltt_ust_channel *uchan)
+int event_agent_disable(struct ltt_ust_session *usess, struct agent *agt,
+               char *event_name)
 {
-       int ret, i;
-       size_t size;
+       int ret = LTTNG_OK;
+       struct agent_event *aevent;
        struct lttng_ht_iter iter;
-       struct ltt_ust_event *uevent = NULL;
-       struct lttng_event *events = NULL;
+       struct lttng_ht_node_str *node;
 
-       switch (domain) {
-       case LTTNG_DOMAIN_UST:
-       {
-               /* Disabling existing events */
-               cds_lfht_for_each_entry(uchan->events->ht, &iter.iter, uevent,
-                               node.node) {
-                       if (uevent->enabled == 1) {
-                               ret = ust_app_disable_event_glb(usess, uchan, uevent);
-                               if (ret < 0) {
-                                       continue;
-                               }
-                               uevent->enabled = 0;
-                       }
-               }
+       assert(agt);
+       assert(usess);
+       assert(event_name);
 
-               /* Get all UST available events */
-               size = ust_app_list_events(&events);
-               if (size < 0) {
-                       ret = LTTCOMM_UST_LIST_FAIL;
-                       goto error;
-               }
+       DBG("Event agent disabling %s (all loglevels) for session %" PRIu64, event_name, usess->id);
 
-               for (i = 0; i < size; i++) {
-                       uevent = trace_ust_find_event_by_name(uchan->events,
-                                       events[i].name);
-                       if (uevent != NULL && uevent->enabled == 1) {
-                               ret = ust_app_disable_event_pid(usess, uchan, uevent,
-                                               events[i].pid);
-                               if (ret < 0 && ret != -EEXIST) {
-                                       ret = LTTCOMM_UST_DISABLE_FAIL;
-                                       goto error;
-                               }
-                               uevent->enabled = 0;
-                               continue;
-                       }
-               }
+       rcu_read_lock();
+       agent_find_events_by_name(event_name, agt, &iter);
+       node = lttng_ht_iter_get_node_str(&iter);
 
-               free(events);
-               break;
+       if (node == NULL) {
+               DBG2("Event agent NOT found by name %s", event_name);
+               ret = LTTNG_ERR_UST_EVENT_NOT_FOUND;
+               goto end;
        }
-#if 0
-       case LTTNG_DOMAIN_UST_EXEC_NAME:
-       case LTTNG_DOMAIN_UST_PID:
-       case LTTNG_DOMAIN_UST_PID_FOLLOW_CHILDREN:
-#endif
-       default:
-               ret = LTTCOMM_UND;
+
+       do {
+               aevent = caa_container_of(node, struct agent_event, node);
+               ret = event_agent_disable_one(usess, agt, aevent);
+
+               if (ret != LTTNG_OK) {
+                       goto end;
+               }
+
+               /* Get next duplicate agent event by name. */
+               agent_event_next_duplicate(event_name, agt, &iter);
+               node = lttng_ht_iter_get_node_str(&iter);
+       } while (node);
+end:
+       rcu_read_unlock();
+       return ret;
+}
+/*
+ * Disable all agent event for a given UST session.
+ *
+ * Return LTTNG_OK on success or else a LTTNG_ERR* code.
+ */
+int event_agent_disable_all(struct ltt_ust_session *usess,
+               struct agent *agt)
+{
+       int ret;
+       struct agent_event *aevent;
+       struct lttng_ht_iter iter;
+
+       assert(agt);
+       assert(usess);
+
+       /*
+        * Disable event on agent application. Continue to disable all other events
+        * if the * event is not found.
+        */
+       ret = event_agent_disable(usess, agt, "*");
+       if (ret != LTTNG_OK && ret != LTTNG_ERR_UST_EVENT_NOT_FOUND) {
                goto error;
        }
 
-       return LTTCOMM_OK;
+       /* Disable every event. */
+       rcu_read_lock();
+       cds_lfht_for_each_entry(agt->events->ht, &iter.iter, aevent,
+                       node.node) {
+               if (!aevent->enabled) {
+                       continue;
+               }
+
+               ret = event_agent_disable(usess, agt, aevent->name);
+               if (ret != LTTNG_OK) {
+                       goto error_unlock;
+               }
+       }
+       ret = LTTNG_OK;
 
+error_unlock:
+       rcu_read_unlock();
 error:
-       free(events);
        return ret;
 }
This page took 0.033964 seconds and 4 git commands to generate.