#include "notification-thread-commands.h"
#include "rotate.h"
#include "rotation-thread.h"
-#include "sessiond-timer.h"
+#include "timer.h"
#include "agent-thread.h"
#include "cmd.h"
* Create a socket to the relayd using the URI.
*
* On success, the relayd_sock pointer is set to the created socket.
- * Else, it's stays untouched and a lttcomm error code is returned.
+ * Else, it remains untouched and an LTTng error code is returned.
*/
-static int create_connect_relayd(struct lttng_uri *uri,
+static enum lttng_error_code create_connect_relayd(struct lttng_uri *uri,
struct lttcomm_relayd_sock **relayd_sock,
struct consumer_output *consumer)
{
int ret;
+ enum lttng_error_code status = LTTNG_OK;
struct lttcomm_relayd_sock *rsock;
rsock = lttcomm_alloc_relayd_sock(uri, RELAYD_VERSION_COMM_MAJOR,
RELAYD_VERSION_COMM_MINOR);
if (!rsock) {
- ret = LTTNG_ERR_FATAL;
+ status = LTTNG_ERR_FATAL;
goto error;
}
health_poll_exit();
if (ret < 0) {
ERR("Unable to reach lttng-relayd");
- ret = LTTNG_ERR_RELAYD_CONNECT_FAIL;
+ status = LTTNG_ERR_RELAYD_CONNECT_FAIL;
goto free_sock;
}
/* Check relayd version */
ret = relayd_version_check(rsock);
if (ret == LTTNG_ERR_RELAYD_VERSION_FAIL) {
+ status = LTTNG_ERR_RELAYD_VERSION_FAIL;
goto close_sock;
} else if (ret < 0) {
ERR("Unable to reach lttng-relayd");
- ret = LTTNG_ERR_RELAYD_CONNECT_FAIL;
+ status = LTTNG_ERR_RELAYD_CONNECT_FAIL;
goto close_sock;
}
consumer->relay_major_version = rsock->major;
} else {
/* Command is not valid */
ERR("Relayd invalid stream type: %d", uri->stype);
- ret = LTTNG_ERR_INVALID;
+ status = LTTNG_ERR_INVALID;
goto close_sock;
}
*relayd_sock = rsock;
- return LTTNG_OK;
+ return status;
close_sock:
/* The returned value is not useful since we are on an error path. */
free_sock:
free(rsock);
error:
- return ret;
+ return status;
}
/*
* Connect to the relayd using URI and send the socket to the right consumer.
*
* The consumer socket lock must be held by the caller.
+ *
+ * Returns LTTNG_OK on success or an LTTng error code on failure.
*/
-static int send_consumer_relayd_socket(unsigned int session_id,
+static enum lttng_error_code send_consumer_relayd_socket(
+ unsigned int session_id,
struct lttng_uri *relayd_uri,
struct consumer_output *consumer,
struct consumer_socket *consumer_sock,
{
int ret;
struct lttcomm_relayd_sock *rsock = NULL;
+ enum lttng_error_code status;
/* Connect to relayd and make version check if uri is the control. */
- ret = create_connect_relayd(relayd_uri, &rsock, consumer);
- if (ret != LTTNG_OK) {
+ status = create_connect_relayd(relayd_uri, &rsock, consumer);
+ if (status != LTTNG_OK) {
goto relayd_comm_error;
}
assert(rsock);
relayd_uri->stype, session_id,
session_name, hostname, session_live_timer);
if (ret < 0) {
- ret = LTTNG_ERR_ENABLE_CONSUMER_FAIL;
+ status = LTTNG_ERR_ENABLE_CONSUMER_FAIL;
goto close_sock;
}
consumer_sock->data_sock_sent = 1;
}
- ret = LTTNG_OK;
-
/*
* Close socket which was dup on the consumer side. The session daemon does
* NOT keep track of the relayd socket(s) once transfer to the consumer.
*/
close_sock:
- if (ret != LTTNG_OK) {
+ if (status != LTTNG_OK) {
/*
* The consumer output for this session should not be used anymore
* since the relayd connection failed thus making any tracing or/and
free(rsock);
relayd_comm_error:
- return ret;
+ return status;
}
/*
* session.
*
* The consumer socket lock must be held by the caller.
+ *
+ * Returns LTTNG_OK, or an LTTng error code on failure.
*/
-static int send_consumer_relayd_sockets(enum lttng_domain_type domain,
+static enum lttng_error_code send_consumer_relayd_sockets(
+ enum lttng_domain_type domain,
unsigned int session_id, struct consumer_output *consumer,
struct consumer_socket *sock, char *session_name,
char *hostname, int session_live_timer)
{
- int ret = LTTNG_OK;
+ enum lttng_error_code status = LTTNG_OK;
assert(consumer);
assert(sock);
/* Sending control relayd socket. */
if (!sock->control_sock_sent) {
- ret = send_consumer_relayd_socket(session_id,
+ status = send_consumer_relayd_socket(session_id,
&consumer->dst.net.control, consumer, sock,
session_name, hostname, session_live_timer);
- if (ret != LTTNG_OK) {
+ if (status != LTTNG_OK) {
goto error;
}
}
/* Sending data relayd socket. */
if (!sock->data_sock_sent) {
- ret = send_consumer_relayd_socket(session_id,
+ status = send_consumer_relayd_socket(session_id,
&consumer->dst.net.data, consumer, sock,
session_name, hostname, session_live_timer);
- if (ret != LTTNG_OK) {
+ if (status != LTTNG_OK) {
goto error;
}
}
error:
- return ret;
+ return status;
}
/*
session->rotated_after_last_stop = false;
if (session->rotate_timer_period) {
- ret = sessiond_rotate_timer_start(session,
+ ret = timer_session_rotation_schedule_timer_start(session,
session->rotate_timer_period);
if (ret < 0) {
ERR("Failed to enable rotate timer");
return ret;
}
-static
-int rename_active_chunk(struct ltt_session *session)
-{
- int ret;
-
- session->current_archive_id++;
-
- /*
- * The currently active tracing path is now the folder we
- * want to rename.
- */
- ret = lttng_strncpy(session->rotation_chunk.current_rotate_path,
- session->rotation_chunk.active_tracing_path,
- sizeof(session->rotation_chunk.current_rotate_path));
- if (ret) {
- ERR("Failed to copy active tracing path");
- goto end;
- }
-
- ret = rename_complete_chunk(session, time(NULL));
- if (ret < 0) {
- ERR("Failed to rename current rotate path");
- goto end;
- }
-
- /*
- * We just renamed, the folder, we didn't do an actual rotation, so
- * the active tracing path is now the renamed folder and we have to
- * restore the rotate count.
- */
- ret = lttng_strncpy(session->rotation_chunk.active_tracing_path,
- session->rotation_chunk.current_rotate_path,
- sizeof(session->rotation_chunk.active_tracing_path));
- if (ret) {
- ERR("Failed to rename active session chunk tracing path");
- goto end;
- }
-end:
- session->current_archive_id--;
- return ret;
-}
-
/*
* Command LTTNG_STOP_TRACE processed by the client thread.
*/
struct ltt_kernel_channel *kchan;
struct ltt_kernel_session *ksession;
struct ltt_ust_session *usess;
- bool error_occured = false;
+ bool error_occurred = false;
assert(session);
goto error;
}
- if (session->rotate_relay_pending_timer_enabled) {
- sessiond_timer_rotate_pending_stop(session);
- }
-
- if (session->rotate_timer_enabled) {
- sessiond_rotate_timer_stop(session);
+ if (session->rotation_schedule_timer_enabled) {
+ if (timer_session_rotation_schedule_timer_stop(
+ session)) {
+ ERR("Failed to stop the \"rotation schedule\" timer of session %s",
+ session->name);
+ }
}
- if (session->current_archive_id > 0 && !session->rotate_pending) {
+ /*
+ * A rotation is still ongoing. The check timer will continue to wait
+ * for the rotation to complete. When the rotation finally completes,
+ * a check will be performed to rename the "active" chunk to the
+ * expected "timestamp_begin-timestamp_end" format.
+ */
+ if (session->current_archive_id > 0 &&
+ session->rotation_state != LTTNG_ROTATION_STATE_ONGOING) {
ret = rename_active_chunk(session);
if (ret) {
/*
* This error should not prevent the user from stopping
* the session. However, it will be reported at the end.
*/
- error_occured = true;
+ error_occurred = true;
}
}
/* Flag inactive after a successful stop. */
session->active = 0;
- ret = !error_occured ? LTTNG_OK : LTTNG_ERR_UNK;
+ ret = !error_occurred ? LTTNG_OK : LTTNG_ERR_UNK;
error:
return ret;
size_t nb_uri, lttng_sock_cred *creds, unsigned int live_timer)
{
int ret;
- struct ltt_session *session;
+ struct ltt_session *session = NULL;
assert(name);
assert(creds);
- /*
- * Verify if the session already exist
- *
- * XXX: There is no need for the session lock list here since the caller
- * (process_client_msg) is holding it. We might want to change that so a
- * single command does not lock the entire session list.
- */
+ /* Check if the session already exists. */
+ session_lock_list();
session = session_find_by_name(name);
+ session_unlock_list();
if (session != NULL) {
ret = LTTNG_ERR_EXIST_SESS;
- goto find_error;
+ goto end;
}
/* Create tracing session in the registry */
ret = session_create(name, LTTNG_SOCK_GET_UID_CRED(creds),
LTTNG_SOCK_GET_GID_CRED(creds));
if (ret != LTTNG_OK) {
- goto session_error;
+ goto end;
}
- /*
- * Get the newly created session pointer back
- *
- * XXX: There is no need for the session lock list here since the caller
- * (process_client_msg) is holding it. We might want to change that so a
- * single command does not lock the entire session list.
- */
+ /* Get the newly created session pointer back. */
+ session_lock_list();
session = session_find_by_name(name);
+ session_unlock_list();
assert(session);
session->live_timer = live_timer;
session->consumer = consumer_create_output(CONSUMER_DST_LOCAL);
if (session->consumer == NULL) {
ret = LTTNG_ERR_FATAL;
- goto consumer_error;
+ goto end;
}
if (uris) {
ret = cmd_set_consumer_uri(session, nb_uri, uris);
if (ret != LTTNG_OK) {
- goto consumer_error;
+ goto end;
}
session->output_traces = 1;
} else {
session->consumer->enabled = 1;
- return LTTNG_OK;
-
-consumer_error:
- session_destroy(session);
-session_error:
-find_error:
+ ret = LTTNG_OK;
+end:
+ if (session) {
+ session_lock_list();
+ session_put(session);
+ session_unlock_list();
+ }
return ret;
}
size_t nb_uri, lttng_sock_cred *creds)
{
int ret;
- struct ltt_session *session;
+ struct ltt_session *session = NULL;
struct snapshot_output *new_output = NULL;
assert(name);
*/
ret = cmd_create_session_uri(name, NULL, 0, creds, 0);
if (ret != LTTNG_OK) {
- goto error;
+ goto end;
}
/* Get the newly created session pointer back. This should NEVER fail. */
+ session_lock_list();
session = session_find_by_name(name);
+ session_unlock_list();
assert(session);
/* Flag session for snapshot mode. */
/* Skip snapshot output creation if no URI is given. */
if (nb_uri == 0) {
+ /* Not an error. */
goto end;
}
snapshot_add_output(&session->snapshot, new_output);
rcu_read_unlock();
-end:
- return LTTNG_OK;
+ ret = LTTNG_OK;
+ goto end;
error_snapshot:
snapshot_output_destroy(new_output);
error_snapshot_alloc:
- session_destroy(session);
-error:
+end:
+ if (session) {
+ session_lock_list();
+ session_put(session);
+ session_unlock_list();
+ }
return ret;
}
*
* Called with session lock held.
*/
-int cmd_destroy_session(struct ltt_session *session, int wpipe,
+int cmd_destroy_session(struct ltt_session *session,
struct notification_thread_handle *notification_thread_handle)
{
int ret;
- struct ltt_ust_session *usess;
- struct ltt_kernel_session *ksess;
/* Safety net */
assert(session);
- usess = session->ust_session;
- ksess = session->kernel_session;
-
DBG("Begin destroy session %s (id %" PRIu64 ")", session->name, session->id);
- if (session->rotate_relay_pending_timer_enabled) {
- sessiond_timer_rotate_pending_stop(session);
+ if (session->rotation_pending_check_timer_enabled) {
+ if (timer_session_rotation_pending_check_stop(session)) {
+ ERR("Failed to stop the \"rotation pending check\" timer of session %s",
+ session->name);
+ }
}
- if (session->rotate_timer_enabled) {
- sessiond_rotate_timer_stop(session);
+ if (session->rotation_schedule_timer_enabled) {
+ if (timer_session_rotation_schedule_timer_stop(
+ session)) {
+ ERR("Failed to stop the \"rotation schedule\" timer of session %s",
+ session->name);
+ }
}
if (session->rotate_size) {
rename_active_chunk(session);
}
- /* Clean kernel session teardown */
- kernel_destroy_session(ksess);
-
- /* UST session teardown */
- if (usess) {
- /* Close any relayd session */
- consumer_output_send_destroy_relayd(usess->consumer);
-
- /* Destroy every UST application related to this session. */
- ret = ust_app_destroy_trace_all(usess);
- if (ret) {
- ERR("Error in ust_app_destroy_trace_all");
- }
-
- /* Clean up the rest. */
- trace_ust_destroy_session(usess);
- }
-
- /*
- * Must notify the kernel thread here to update it's poll set in order to
- * remove the channel(s)' fd just destroyed.
- */
- ret = notify_thread_pipe(wpipe);
- if (ret < 0) {
- PERROR("write kernel poll pipe");
- }
-
if (session->shm_path[0]) {
/*
* When a session is created with an explicit shm_path,
sizeof(destroy_completion_handler.shm_path));
assert(!ret);
}
- ret = session_destroy(session);
+
+ /*
+ * The session is destroyed. However, note that the command context
+ * still holds a reference to the session, thus delaying its destruction
+ * _at least_ up to the point when that reference is released.
+ */
+ session_destroy(session);
+ ret = LTTNG_OK;
return ret;
}
* the buffer.
*/
cds_list_for_each_entry(session, &list->head, list) {
+ if (!session_get(session)) {
+ continue;
+ }
/*
* Only list the sessions the user can control.
*/
- if (!session_access_ok(session, uid, gid)) {
+ if (!session_access_ok(session, uid, gid) ||
+ session->destroyed) {
+ session_put(session);
continue;
}
}
if (ret < 0) {
PERROR("snprintf session path");
+ session_put(session);
continue;
}
sessions[i].snapshot_mode = session->snapshot_mode;
sessions[i].live_timer_interval = session->live_timer;
i++;
+ session_put(session);
}
}
}
}
- /*
- * A rotation is still pending, we have to wait.
- */
- if (session->rotate_pending) {
+ /* A rotation is still pending, we have to wait. */
+ if (session->rotation_state == LTTNG_ROTATION_STATE_ONGOING) {
DBG("Rotate still pending for session %s", session->name);
ret = 1;
goto error;
* Send relayd sockets from snapshot output to consumer. Ignore request if the
* snapshot output is *not* set with a remote destination.
*
- * Return 0 on success or a LTTNG_ERR code.
+ * Return LTTNG_OK on success or a LTTNG_ERR code.
*/
-static int set_relayd_for_snapshot(struct consumer_output *consumer,
- struct snapshot_output *snap_output, struct ltt_session *session)
+static enum lttng_error_code set_relayd_for_snapshot(
+ struct consumer_output *consumer,
+ struct snapshot_output *snap_output,
+ struct ltt_session *session)
{
- int ret = LTTNG_OK;
+ enum lttng_error_code status = LTTNG_OK;
struct lttng_ht_iter iter;
struct consumer_socket *socket;
cds_lfht_for_each_entry(snap_output->consumer->socks->ht, &iter.iter,
socket, node.node) {
pthread_mutex_lock(socket->lock);
- ret = send_consumer_relayd_sockets(0, session->id,
+ status = send_consumer_relayd_sockets(0, session->id,
snap_output->consumer, socket,
session->name, session->hostname,
session->live_timer);
pthread_mutex_unlock(socket->lock);
- if (ret != LTTNG_OK) {
+ if (status != LTTNG_OK) {
rcu_read_unlock();
goto error;
}
rcu_read_unlock();
error:
- return ret;
+ return status;
}
/*
*
* Return LTTNG_OK on success or a LTTNG_ERR code.
*/
-static int record_kernel_snapshot(struct ltt_kernel_session *ksess,
+static enum lttng_error_code record_kernel_snapshot(struct ltt_kernel_session *ksess,
struct snapshot_output *output, struct ltt_session *session,
int wait, uint64_t nb_packets_per_stream)
{
int ret;
+ enum lttng_error_code status;
assert(ksess);
assert(output);
assert(session);
-
/*
* Copy kernel session sockets so we can communicate with the right
* consumer for the snapshot record command.
*/
ret = consumer_copy_sockets(output->consumer, ksess->consumer);
if (ret < 0) {
- ret = LTTNG_ERR_NOMEM;
+ status = LTTNG_ERR_NOMEM;
goto error;
}
- ret = set_relayd_for_snapshot(ksess->consumer, output, session);
- if (ret != LTTNG_OK) {
+ status = set_relayd_for_snapshot(ksess->consumer, output, session);
+ if (status != LTTNG_OK) {
goto error_snapshot;
}
- ret = kernel_snapshot_record(ksess, output, wait, nb_packets_per_stream);
- if (ret != LTTNG_OK) {
+ status = kernel_snapshot_record(ksess, output, wait, nb_packets_per_stream);
+ if (status != LTTNG_OK) {
goto error_snapshot;
}
- ret = LTTNG_OK;
goto end;
error_snapshot:
consumer_destroy_output_sockets(output->consumer);
error:
end:
- return ret;
+ return status;
}
/*
* Record a UST snapshot.
*
- * Return 0 on success or a LTTNG_ERR error code.
+ * Returns LTTNG_OK on success or a LTTNG_ERR error code.
*/
-static int record_ust_snapshot(struct ltt_ust_session *usess,
+static enum lttng_error_code record_ust_snapshot(struct ltt_ust_session *usess,
struct snapshot_output *output, struct ltt_session *session,
int wait, uint64_t nb_packets_per_stream)
{
int ret;
+ enum lttng_error_code status;
assert(usess);
assert(output);
*/
ret = consumer_copy_sockets(output->consumer, usess->consumer);
if (ret < 0) {
- ret = LTTNG_ERR_NOMEM;
+ status = LTTNG_ERR_NOMEM;
goto error;
}
- ret = set_relayd_for_snapshot(usess->consumer, output, session);
- if (ret != LTTNG_OK) {
+ status = set_relayd_for_snapshot(usess->consumer, output, session);
+ if (status != LTTNG_OK) {
goto error_snapshot;
}
- ret = ust_app_snapshot_record(usess, output, wait, nb_packets_per_stream);
- if (ret < 0) {
- switch (-ret) {
- case EINVAL:
- ret = LTTNG_ERR_INVALID;
- break;
- default:
- ret = LTTNG_ERR_SNAPSHOT_FAIL;
- break;
- }
+ status = ust_app_snapshot_record(usess, output, wait, nb_packets_per_stream);
+ if (status != LTTNG_OK) {
goto error_snapshot;
}
- ret = LTTNG_OK;
-
error_snapshot:
/* Clean up copied sockets so this output can use some other later on. */
consumer_destroy_output_sockets(output->consumer);
error:
- return ret;
+ return status;
}
static
int cmd_snapshot_record(struct ltt_session *session,
struct lttng_snapshot_output *output, int wait)
{
- int ret = LTTNG_OK;
+ enum lttng_error_code cmd_ret = LTTNG_OK;
+ int ret;
unsigned int use_tmp_output = 0;
struct snapshot_output tmp_output;
unsigned int snapshot_success = 0;
ret = utils_get_current_time_str("%Y%m%d-%H%M%S", datetime,
sizeof(datetime));
if (!ret) {
- ret = LTTNG_ERR_INVALID;
+ cmd_ret = LTTNG_ERR_INVALID;
goto error;
}
* set in no output mode.
*/
if (session->output_traces) {
- ret = LTTNG_ERR_NOT_SNAPSHOT_SESSION;
+ cmd_ret = LTTNG_ERR_NOT_SNAPSHOT_SESSION;
goto error;
}
/* The session needs to be started at least once. */
if (!session->has_been_started) {
- ret = LTTNG_ERR_START_SESSION_ONCE;
+ cmd_ret = LTTNG_ERR_START_SESSION_ONCE;
goto error;
}
&tmp_output, NULL);
if (ret < 0) {
if (ret == -ENOMEM) {
- ret = LTTNG_ERR_NOMEM;
+ cmd_ret = LTTNG_ERR_NOMEM;
} else {
- ret = LTTNG_ERR_INVALID;
+ cmd_ret = LTTNG_ERR_INVALID;
}
goto error;
}
nb_packets_per_stream = get_session_nb_packets_per_stream(session,
tmp_output.max_size);
if (nb_packets_per_stream < 0) {
- ret = LTTNG_ERR_MAX_SIZE_INVALID;
+ cmd_ret = LTTNG_ERR_MAX_SIZE_INVALID;
goto error;
}
if (session->kernel_session) {
- ret = record_kernel_snapshot(session->kernel_session,
+ cmd_ret = record_kernel_snapshot(session->kernel_session,
&tmp_output, session,
wait, nb_packets_per_stream);
- if (ret != LTTNG_OK) {
+ if (cmd_ret != LTTNG_OK) {
goto error;
}
}
if (session->ust_session) {
- ret = record_ust_snapshot(session->ust_session,
+ cmd_ret = record_ust_snapshot(session->ust_session,
&tmp_output, session,
wait, nb_packets_per_stream);
- if (ret != LTTNG_OK) {
+ if (cmd_ret != LTTNG_OK) {
goto error;
}
}
nb_packets_per_stream = get_session_nb_packets_per_stream(session,
tmp_output.max_size);
if (nb_packets_per_stream < 0) {
- ret = LTTNG_ERR_MAX_SIZE_INVALID;
+ cmd_ret = LTTNG_ERR_MAX_SIZE_INVALID;
rcu_read_unlock();
goto error;
}
if (*output->name != '\0') {
if (lttng_strncpy(tmp_output.name, output->name,
sizeof(tmp_output.name))) {
- ret = LTTNG_ERR_INVALID;
+ cmd_ret = LTTNG_ERR_INVALID;
rcu_read_unlock();
goto error;
}
memcpy(tmp_output.datetime, datetime, sizeof(datetime));
if (session->kernel_session) {
- ret = record_kernel_snapshot(session->kernel_session,
+ cmd_ret = record_kernel_snapshot(session->kernel_session,
&tmp_output, session,
wait, nb_packets_per_stream);
- if (ret != LTTNG_OK) {
+ if (cmd_ret != LTTNG_OK) {
rcu_read_unlock();
goto error;
}
}
if (session->ust_session) {
- ret = record_ust_snapshot(session->ust_session,
+ cmd_ret = record_ust_snapshot(session->ust_session,
&tmp_output, session,
wait, nb_packets_per_stream);
- if (ret != LTTNG_OK) {
+ if (cmd_ret != LTTNG_OK) {
rcu_read_unlock();
goto error;
}
if (snapshot_success) {
session->snapshot.nb_snapshot++;
} else {
- ret = LTTNG_ERR_SNAPSHOT_FAIL;
+ cmd_ret = LTTNG_ERR_SNAPSHOT_FAIL;
}
error:
- return ret;
+ return cmd_ret;
}
/*
* Ask the consumer to rotate the session output directory.
* The session lock must be held.
*
- * Return LTTNG_OK on success or else a LTTNG_ERR code.
+ * Returns LTTNG_OK on success or else a negative LTTng error code.
*/
int cmd_rotate_session(struct ltt_session *session,
struct lttng_rotate_session_return *rotate_return)
{
int ret;
+ enum lttng_error_code cmd_ret = LTTNG_OK;
size_t strf_ret;
struct tm *timeinfo;
char datetime[21];
time_t now;
- bool ust_active = false;
+ /*
+ * Used to roll-back timestamps in case of failure to launch the
+ * rotation.
+ */
+ time_t original_last_chunk_start_ts, original_current_chunk_start_ts;
assert(session);
if (!session->has_been_started) {
- ret = -LTTNG_ERR_START_SESSION_ONCE;
+ cmd_ret = LTTNG_ERR_START_SESSION_ONCE;
goto end;
}
if (session->live_timer || session->snapshot_mode ||
!session->output_traces) {
- ret = -LTTNG_ERR_ROTATION_NOT_AVAILABLE;
+ cmd_ret = LTTNG_ERR_ROTATION_NOT_AVAILABLE;
goto end;
}
if (session->consumer->type == CONSUMER_DST_NET &&
(session->consumer->relay_major_version == 2 &&
session->consumer->relay_minor_version < 11)) {
- ret = -LTTNG_ERR_ROTATION_NOT_AVAILABLE_RELAY;
+ cmd_ret = LTTNG_ERR_ROTATION_NOT_AVAILABLE_RELAY;
goto end;
}
- if (session->rotate_pending || session->rotate_pending_relay) {
- ret = -LTTNG_ERR_ROTATION_PENDING;
- DBG("Rotate already in progress");
+ if (session->rotation_state == LTTNG_ROTATION_STATE_ONGOING) {
+ DBG("Refusing to launch a rotation; a rotation is already in progress for session %s",
+ session->name);
+ cmd_ret = LTTNG_ERR_ROTATION_PENDING;
goto end;
}
if (session->rotated_after_last_stop) {
DBG("Session \"%s\" was already rotated after stop, refusing rotation",
session->name);
- ret = -LTTNG_ERR_ROTATION_MULTIPLE_AFTER_STOP;
+ cmd_ret = LTTNG_ERR_ROTATION_MULTIPLE_AFTER_STOP;
goto end;
}
if (session->current_archive_id == 0) {
const char *base_path = NULL;
+ assert(session->kernel_session || session->ust_session);
/* Either one of the two sessions is enough to get the root path. */
- if (session->kernel_session) {
- base_path = session_get_base_path(session);
- } else if (session->ust_session) {
- base_path = session_get_base_path(session);
- } else {
- assert(0);
- }
+ base_path = session_get_base_path(session);
assert(base_path);
+
ret = lttng_strncpy(session->rotation_chunk.current_rotate_path,
base_path,
sizeof(session->rotation_chunk.current_rotate_path));
if (ret) {
ERR("Failed to copy session base path to current rotation chunk path");
- ret = -LTTNG_ERR_UNK;
+ cmd_ret = LTTNG_ERR_UNK;
goto end;
}
} else {
sizeof(session->rotation_chunk.current_rotate_path));
if (ret) {
ERR("Failed to copy the active tracing path to the current rotate path");
- ret = -LTTNG_ERR_UNK;
+ cmd_ret = LTTNG_ERR_UNK;
goto end;
}
}
DBG("Current rotate path %s", session->rotation_chunk.current_rotate_path);
- session->current_archive_id++;
- session->rotate_pending = true;
- session->rotation_state = LTTNG_ROTATION_STATE_ONGOING;
- ret = notification_thread_command_session_rotation_ongoing(
- notification_thread_handle,
- session->name, session->uid, session->gid,
- session->current_archive_id);
- if (ret != LTTNG_OK) {
- ERR("Failed to notify notification thread that a session rotation is ongoing for session %s",
- session->name);
- }
-
/*
- * Create the path name for the next chunk.
+ * Channels created after this point will belong to the next
+ * archive id.
*/
+ session->current_archive_id++;
+
now = time(NULL);
if (now == (time_t) -1) {
- ret = -LTTNG_ERR_ROTATION_NOT_AVAILABLE;
+ cmd_ret = LTTNG_ERR_UNK;
goto end;
}
+
+ /* Sample chunk bounds for roll-back in case of error. */
+ original_last_chunk_start_ts = session->last_chunk_start_ts;
+ original_current_chunk_start_ts = session->current_chunk_start_ts;
+
session->last_chunk_start_ts = session->current_chunk_start_ts;
session->current_chunk_start_ts = now;
timeinfo = localtime(&now);
if (!timeinfo) {
PERROR("Failed to sample local time in rotate session command");
- ret = -LTTNG_ERR_UNK;
+ cmd_ret = LTTNG_ERR_UNK;
goto end;
}
strf_ret = strftime(datetime, sizeof(datetime), "%Y%m%dT%H%M%S%z",
timeinfo);
if (!strf_ret) {
ERR("Failed to format local time timestamp in rotate session command");
- ret = -LTTNG_ERR_UNK;
+ cmd_ret = LTTNG_ERR_UNK;
goto end;
}
+
+ /*
+ * A rotation has a local step even if the destination is a relay
+ * daemon; the buffers must be consumed by the consumer daemon.
+ */
+ session->rotation_pending_local = true;
+ session->rotation_pending_relay =
+ session_get_consumer_destination_type(session) == CONSUMER_DST_NET;
+ session->rotation_state = LTTNG_ROTATION_STATE_ONGOING;
+
if (session->kernel_session) {
/*
* The active path for the next rotation/destroy.
datetime, session->current_archive_id + 1);
if (ret < 0 || ret == sizeof(session->rotation_chunk.active_tracing_path)) {
ERR("Failed to format active kernel tracing path in rotate session command");
- ret = -LTTNG_ERR_UNK;
- goto end;
+ cmd_ret = LTTNG_ERR_UNK;
+ goto error;
}
/*
* The sub-directory for the consumer
session->current_archive_id + 1);
if (ret < 0 || ret == sizeof(session->kernel_session->consumer->chunk_path)) {
ERR("Failed to format the kernel consumer's sub-directory in rotate session command");
- ret = -LTTNG_ERR_UNK;
- goto end;
+ cmd_ret = LTTNG_ERR_UNK;
+ goto error;
}
/*
* Create the new chunk folder, before the rotation begins so we don't
if (ret) {
ERR("Failed to create kernel session tracing path at %s",
session->kernel_session->consumer->chunk_path);
- ret = -LTTNG_ERR_CREATE_DIR_FAIL;
- goto end;
+ cmd_ret = LTTNG_ERR_CREATE_DIR_FAIL;
+ goto error;
}
- ret = kernel_rotate_session(session);
- if (ret != LTTNG_OK) {
- ret = -ret;
- goto end;
+ cmd_ret = kernel_rotate_session(session);
+ if (cmd_ret != LTTNG_OK) {
+ goto error;
}
}
if (session->ust_session) {
datetime, session->current_archive_id + 1);
if (ret < 0) {
ERR("Failed to format active UST tracing path in rotate session command");
- ret = -LTTNG_ERR_UNK;
- goto end;
+ cmd_ret = LTTNG_ERR_UNK;
+ goto error;
}
ret = snprintf(session->ust_session->consumer->chunk_path,
PATH_MAX, "/%s-%" PRIu64, datetime,
session->current_archive_id + 1);
if (ret < 0) {
ERR("Failed to format the UST consumer's sub-directory in rotate session command");
- ret = -LTTNG_ERR_UNK;
- goto end;
+ cmd_ret = LTTNG_ERR_UNK;
+ goto error;
}
/*
* Create the new chunk folder, before the rotation begins so we don't
session->ust_session->uid,
session->ust_session->gid);
if (ret) {
- ret = -LTTNG_ERR_CREATE_DIR_FAIL;
- goto end;
+ cmd_ret = LTTNG_ERR_CREATE_DIR_FAIL;
+ goto error;
}
- ret = ust_app_rotate_session(session, &ust_active);
- if (ret != LTTNG_OK) {
- goto end;
+ cmd_ret = ust_app_rotate_session(session);
+ if (cmd_ret != LTTNG_OK) {
+ goto error;
}
- /*
- * Handle the case where we did not start a rotation on any channel.
- * The consumer will never wake up the rotation thread to perform the
- * rename, so we have to do it here while we hold the session and
- * session_list locks.
- */
- if (!session->kernel_session && !ust_active) {
- struct lttng_trace_archive_location *location;
-
- session->rotate_pending = false;
- session->rotation_state = LTTNG_ROTATION_STATE_COMPLETED;
- ret = rename_complete_chunk(session, now);
- if (ret < 0) {
- ERR("Failed to rename completed rotation chunk");
- goto end;
- }
+ }
- /* Ownership of location is transferred. */
- location = session_get_trace_archive_location(session);
- ret = notification_thread_command_session_rotation_completed(
- notification_thread_handle,
- session->name,
- session->uid,
- session->gid,
- session->current_archive_id,
- location);
- if (ret != LTTNG_OK) {
- ERR("Failed to notify notification thread that rotation is complete for session %s",
- session->name);
- }
- }
+ ret = timer_session_rotation_pending_check_start(session,
+ DEFAULT_ROTATE_PENDING_TIMER);
+ if (ret) {
+ cmd_ret = LTTNG_ERR_UNK;
+ goto error;
}
if (!session->active) {
rotate_return->rotation_id = session->current_archive_id;
}
- DBG("Cmd rotate session %s, current_archive_id %" PRIu64 " sent",
- session->name, session->current_archive_id);
- ret = LTTNG_OK;
+ ret = notification_thread_command_session_rotation_ongoing(
+ notification_thread_handle,
+ session->name, session->uid, session->gid,
+ session->current_archive_id - 1);
+ if (ret != LTTNG_OK) {
+ ERR("Failed to notify notification thread that a session rotation is ongoing for session %s",
+ session->name);
+ cmd_ret = ret;
+ }
+ DBG("Cmd rotate session %s, archive_id %" PRIu64 " sent",
+ session->name, session->current_archive_id - 1);
end:
+ ret = (cmd_ret == LTTNG_OK) ? cmd_ret : -((int) cmd_ret);
return ret;
+error:
+ session->last_chunk_start_ts = original_last_chunk_start_ts;
+ session->current_archive_id = original_current_chunk_start_ts;
+ if (session_reset_rotation_state(session,
+ LTTNG_ROTATION_STATE_NO_ROTATION)) {
+ ERR("Failed to reset rotation state of session \"%s\"",
+ session->name);
+ }
+ goto end;
}
/*
* Only start the timer if the session is active,
* otherwise it will be started when the session starts.
*/
- ret = sessiond_rotate_timer_start(session, new_value);
+ ret = timer_session_rotation_schedule_timer_start(
+ session, new_value);
if (ret) {
ERR("Failed to enable session rotation timer in ROTATION_SET_SCHEDULE command");
ret = LTTNG_ERR_UNK;
goto end;
}
} else {
- ret = sessiond_rotate_timer_stop(session);
+ ret = timer_session_rotation_schedule_timer_stop(
+ session);
if (ret) {
ERR("Failed to disable session rotation timer in ROTATION_SET_SCHEDULE command");
ret = LTTNG_ERR_UNK;
projects / lttng-tools.git / blobdiff