Fix: cmd_enable_event must return positive error codes

[lttng-tools.git] / src / bin / lttng-sessiond / cmd.c

diff --git a/src/bin/lttng-sessiond/cmd.c b/src/bin/lttng-sessiond/cmd.c
index ac489fa2fa7f946a7c65a8b81d8f4572323ea16d..01969b2b9607579a72877318b27418cf4942502a 100644 (file)
--- a/src/bin/lttng-sessiond/cmd.c
+++ b/src/bin/lttng-sessiond/cmd.c
@@ -1497,6 +1497,9 @@ static int _cmd_enable_event(struct ltt_session *session,
        assert(event);
        assert(channel_name);
 
+       /* If we have a filter, we must have its filter expression */
+       assert(!(!!filter_expression ^ !!filter));
+
        DBG("Enable event command for event \'%s\'", event->name);
 
        ret = validate_event_name(event->name);
@@ -1726,7 +1729,7 @@ static int _cmd_enable_event(struct ltt_session *session,
                if (!agt) {
                        agt = agent_create(domain->type);
                        if (!agt) {
-                               ret = -LTTNG_ERR_NOMEM;
+                               ret = LTTNG_ERR_NOMEM;
                                goto error;
                        }
                        agent_add(agt, usess->agents);
@@ -1738,7 +1741,7 @@ static int _cmd_enable_event(struct ltt_session *session,
                uevent.loglevel_type = LTTNG_EVENT_LOGLEVEL_ALL;
                default_event_name = event_get_default_agent_ust_name(domain->type);
                if (!default_event_name) {
-                       ret = -LTTNG_ERR_FATAL;
+                       ret = LTTNG_ERR_FATAL;
                        goto error;
                }
                strncpy(uevent.name, default_event_name, sizeof(uevent.name));