Fix: no-output sessions do not enforce snapshot constraints

[lttng-tools.git] / src / bin / lttng-sessiond / channel.c

diff --git a/src/bin/lttng-sessiond/channel.c b/src/bin/lttng-sessiond/channel.c
index f19dbec37f51697209c0ae1d678a1af7768e8533..b270a43ca3a29118a1218c6d32308ec1496fdef0 100644 (file)
--- a/src/bin/lttng-sessiond/channel.c
+++ b/src/bin/lttng-sessiond/channel.c
@@ -259,11 +259,6 @@ int channel_kernel_create(struct ltt_kernel_session *ksession,
                attr->attr.overwrite = !!ksession->snapshot_mode;
        }
 
-       /* Enforce mmap output for snapshot sessions. */
-       if (ksession->snapshot_mode) {
-               attr->attr.output = LTTNG_EVENT_MMAP;
-       }
-
        /* Validate common channel properties. */
        if (channel_validate(attr) < 0) {
                ret = LTTNG_ERR_INVALID;
@@ -311,6 +306,18 @@ int channel_ust_enable(struct ltt_ust_session *usess,
                DBG3("Channel %s already enabled. Skipping", uchan->name);
                ret = LTTNG_ERR_UST_CHAN_EXIST;
                goto end;
+       } else {
+               uchan->enabled = 1;
+               DBG2("Channel %s enabled successfully", uchan->name);
+       }
+
+       if (!usess->active) {
+               /*
+                * The channel will be activated against the apps
+                * when the session is started as part of the
+                * application channel "synchronize" operation.
+                */
+               goto end;
        }
 
        DBG2("Channel %s being enabled in UST domain", uchan->name);
@@ -325,8 +332,6 @@ int channel_ust_enable(struct ltt_ust_session *usess,
         */
        (void) ust_app_enable_channel_glb(usess, uchan);
 
-       uchan->enabled = 1;
-       DBG2("Channel %s enabled successfully", uchan->name);
 
 end:
        return ret;
@@ -465,11 +470,13 @@ int channel_ust_create(struct ltt_ust_session *usess,
                goto error_free_chan;
        }
 
-       /* Enable channel for global domain */
-       ret = ust_app_create_channel_glb(usess, uchan);
-       if (ret < 0 && ret != -LTTNG_UST_ERR_EXIST) {
-               ret = LTTNG_ERR_UST_CHAN_FAIL;
-               goto error_free_chan;
+       if (usess->active) {
+               /* Enable channel for global domain */
+               ret = ust_app_create_channel_glb(usess, uchan);
+               if (ret < 0 && ret != -LTTNG_UST_ERR_EXIST) {
+                       ret = LTTNG_ERR_UST_CHAN_FAIL;
+                       goto error_free_chan;
+               }
        }
 
        /* Adding the channel to the channel hash table. */
@@ -533,6 +540,9 @@ int channel_ust_disable(struct ltt_ust_session *usess,
                DBG2("Channel UST %s already disabled", uchan->name);
                goto end;
        }
+       if (!usess->active) {
+               goto end;
+       }
 
        DBG2("Channel %s being disabled in UST global domain", uchan->name);
        /* Disable channel for global domain */