Relayd add_stream command handle tracefile rotation
[lttng-tools.git] / src / bin / lttng-relayd / main.c
index 5f6f9cfd8ed78a613972c5b3ed9b999c63c90ecc..9a2b3bda7c010e9c8da7ad7a7b0345c9e4697d03 100644 (file)
 #include <common/futex.h>
 #include <common/sessiond-comm/sessiond-comm.h>
 #include <common/sessiond-comm/inet.h>
-#include <common/hashtable/hashtable.h>
 #include <common/sessiond-comm/relayd.h>
 #include <common/uri.h>
 #include <common/utils.h>
 
+#include "cmd.h"
+#include "utils.h"
 #include "lttng-relayd.h"
 
 /* command line options */
+char *opt_output_path;
 static int opt_daemon;
-static char *opt_output_path;
 static struct lttng_uri *control_uri;
 static struct lttng_uri *data_uri;
 
@@ -685,82 +686,6 @@ error:
        return NULL;
 }
 
-/*
- *  config_get_default_path
- *
- *  Returns the HOME directory path. Caller MUST NOT free(3) the return pointer.
- */
-static
-char *config_get_default_path(void)
-{
-       return getenv("HOME");
-}
-
-static
-char *create_output_path_auto(char *path_name)
-{
-       int ret;
-       char *traces_path = NULL;
-       char *alloc_path = NULL;
-       char *default_path;
-
-       default_path = config_get_default_path();
-       if (default_path == NULL) {
-               ERR("Home path not found.\n \
-                               Please specify an output path using -o, --output PATH");
-               goto exit;
-       }
-       alloc_path = strdup(default_path);
-       if (alloc_path == NULL) {
-               PERROR("Path allocation");
-               goto exit;
-       }
-       ret = asprintf(&traces_path, "%s/" DEFAULT_TRACE_DIR_NAME
-                       "/%s", alloc_path, path_name);
-       if (ret < 0) {
-               PERROR("asprintf trace dir name");
-               goto exit;
-       }
-exit:
-       free(alloc_path);
-       return traces_path;
-}
-
-static
-char *create_output_path_noauto(char *path_name)
-{
-       int ret;
-       char *traces_path = NULL;
-       char *full_path;
-
-       full_path = utils_expand_path(opt_output_path);
-       if (!full_path) {
-               goto exit;
-       }
-
-       ret = asprintf(&traces_path, "%s/%s", full_path, path_name);
-       if (ret < 0) {
-               PERROR("asprintf trace dir name");
-               goto exit;
-       }
-exit:
-       free(full_path);
-       return traces_path;
-}
-
-/*
- * create_output_path: create the output trace directory
- */
-static
-char *create_output_path(char *path_name)
-{
-       if (opt_output_path == NULL) {
-               return create_output_path_auto(path_name);
-       } else {
-               return create_output_path_noauto(path_name);
-       }
-}
-
 /*
  * Get stream from stream id.
  * Need to be called with RCU read-side lock held.
@@ -794,6 +719,8 @@ void deferred_free_stream(struct rcu_head *head)
 {
        struct relay_stream *stream =
                caa_container_of(head, struct relay_stream, rcu_node);
+       free(stream->path_name);
+       free(stream->channel_name);
        free(stream);
 }
 
@@ -895,10 +822,8 @@ int relay_add_stream(struct lttcomm_relayd_hdr *recv_hdr,
                struct relay_command *cmd, struct lttng_ht *streams_ht)
 {
        struct relay_session *session = cmd->session;
-       struct lttcomm_relayd_add_stream stream_info;
        struct relay_stream *stream = NULL;
        struct lttcomm_relayd_status_stream reply;
-       char *path = NULL, *root_path = NULL;
        int ret, send_ret;
 
        if (!session || cmd->version_check_done == 0) {
@@ -907,18 +832,6 @@ int relay_add_stream(struct lttcomm_relayd_hdr *recv_hdr,
                goto end_no_session;
        }
 
-       ret = cmd->sock->ops->recvmsg(cmd->sock, &stream_info,
-                       sizeof(struct lttcomm_relayd_add_stream), 0);
-       if (ret < sizeof(struct lttcomm_relayd_add_stream)) {
-               if (ret == 0) {
-                       /* Orderly shutdown. Not necessary to print an error. */
-                       DBG("Socket %d did an orderly shutdown", cmd->sock->fd);
-               } else {
-                       ERR("Relay didn't receive valid add_stream struct size : %d", ret);
-               }
-               ret = -1;
-               goto end_no_session;
-       }
        stream = zmalloc(sizeof(struct relay_stream));
        if (stream == NULL) {
                PERROR("relay stream zmalloc");
@@ -926,49 +839,51 @@ int relay_add_stream(struct lttcomm_relayd_hdr *recv_hdr,
                goto end_no_session;
        }
 
+       switch (cmd->minor) {
+       case 1: /* LTTng sessiond 2.1 */
+               ret = cmd_recv_stream_2_1(cmd, stream);
+               break;
+       case 2: /* LTTng sessiond 2.2 */
+       default:
+               ret = cmd_recv_stream_2_2(cmd, stream);
+               break;
+       }
+       if (ret < 0) {
+               goto err_free_stream;
+       }
+
        rcu_read_lock();
        stream->stream_handle = ++last_relay_stream_id;
        stream->prev_seq = -1ULL;
        stream->session = session;
 
-       root_path = create_output_path(stream_info.pathname);
-       if (!root_path) {
-               ret = -1;
-               goto end;
-       }
-       ret = utils_mkdir_recursive(root_path, S_IRWXU | S_IRWXG);
+       ret = utils_mkdir_recursive(stream->path_name, S_IRWXU | S_IRWXG);
        if (ret < 0) {
                ERR("relay creating output directory");
                goto end;
        }
 
-       ret = asprintf(&path, "%s/%s", root_path, stream_info.channel_name);
-       if (ret < 0) {
-               PERROR("asprintf stream path");
-               path = NULL;
-               goto end;
-       }
-
-       ret = open(path, O_WRONLY|O_CREAT|O_TRUNC, S_IRWXU|S_IRWXG|S_IRWXO);
+       ret = utils_create_stream_file(stream->path_name, stream->channel_name,
+                       stream->tracefile_size, 0, getuid(), getgid());
        if (ret < 0) {
-               PERROR("Relay creating trace file");
+               ERR("Create output file");
                goto end;
        }
-
        stream->fd = ret;
-       DBG("Tracefile %s created", path);
+       if (stream->tracefile_size) {
+               DBG("Tracefile %s/%s_0 created", stream->path_name, stream->channel_name);
+       } else {
+               DBG("Tracefile %s/%s created", stream->path_name, stream->channel_name);
+       }
 
        lttng_ht_node_init_ulong(&stream->stream_n,
                        (unsigned long) stream->stream_handle);
        lttng_ht_add_unique_ulong(streams_ht,
                        &stream->stream_n);
 
-       DBG("Relay new stream added %s", stream_info.channel_name);
+       DBG("Relay new stream added %s", stream->channel_name);
 
 end:
-       free(path);
-       free(root_path);
-
        reply.handle = htobe64(stream->stream_handle);
        /* send the session id to the client or a negative return code on error */
        if (ret < 0) {
@@ -989,6 +904,12 @@ end:
 
 end_no_session:
        return ret;
+
+err_free_stream:
+       free(stream->path_name);
+       free(stream->channel_name);
+       free(stream);
+       return ret;
 }
 
 /*
@@ -1278,6 +1199,14 @@ int relay_send_version(struct lttcomm_relayd_hdr *recv_hdr,
                goto end;
        }
 
+       cmd->major = reply.major;
+       /* We adapt to the lowest compatible version */
+       if (reply.minor <= be32toh(msg.minor)) {
+               cmd->minor = reply.minor;
+       } else {
+               cmd->minor = be32toh(msg.minor);
+       }
+
        reply.major = htobe32(reply.major);
        reply.minor = htobe32(reply.minor);
        ret = cmd->sock->ops->sendmsg(cmd->sock, &reply,
@@ -1286,18 +1215,8 @@ int relay_send_version(struct lttcomm_relayd_hdr *recv_hdr,
                ERR("Relay sending version");
        }
 
-#if 0
-       cmd->session->major = reply.major;
-       /* We adapt to the lowest compatible version */
-       if (reply.minor <= be32toh(msg.minor)) {
-               cmd->session->minor = reply.minor;
-       } else {
-               cmd->session->minor = be32toh(msg.minor);
-       }
-
-       DBG("Version check done using protocol %u.%u", cmd->session->major,
-                       cmd->session->minor);
-#endif
+       DBG("Version check done using protocol %u.%u", cmd->major,
+                       cmd->minor);
 
 end:
        return ret;
@@ -1701,6 +1620,20 @@ int relay_process_data(struct relay_command *cmd, struct lttng_ht *streams_ht)
                goto end_unlock;
        }
 
+       if (stream->tracefile_size > 0 &&
+                       (stream->tracefile_size_current + data_size) >
+                       stream->tracefile_size) {
+               ret = utils_rotate_stream_file(stream->path_name,
+                               stream->channel_name, stream->tracefile_size,
+                               stream->tracefile_count, getuid(), getgid(),
+                               stream->fd, &(stream->tracefile_count_current));
+               if (ret < 0) {
+                       ERR("Rotating output file");
+                       goto end;
+               }
+               stream->fd = ret;
+       }
+       stream->tracefile_size_current += data_size;
        do {
                ret = write(stream->fd, data_buffer, data_size);
        } while (ret < 0 && errno == EINTR);
This page took 0.026009 seconds and 4 git commands to generate.