Fix: sample discarded events count before reserve
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Thu, 10 Mar 2022 19:20:47 +0000 (14:20 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Fri, 11 Mar 2022 16:41:54 +0000 (11:41 -0500)
commitb2cf5e0b0edcfe64d158119097fa49321cf9ba97
tree945f5b76d29064ab3e2ededfc2ae2f051fb79312
parent724644d93214395f1a732a86128dc980ba95c3c5
Fix: sample discarded events count before reserve

Sampling the discarded events count in the buffer_end callback is done
out of order, and may therefore include increments performed by following
events (in following packets) if the thread doing the end-of-packet
event write is interrupted for a long time.

Sampling the event discarded counts before reserving space for the last
event in a packet, and keeping this as part of the private ring buffer
context, should fix this race.

In lttng-modules, this scenario would only happen if an interrupt
handler produces many events, when nested over an event between its
reserve and commit. Note that if lttng-modules supports faultable
tracepoints in the future, this may become more easy to trigger due to
preemption.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I696a206b3926fc1abbee35caa9af65461ff56c68
include/ringbuffer/config.h
include/ringbuffer/frontend.h
include/ringbuffer/frontend_api.h
include/ringbuffer/frontend_internal.h
src/lib/ringbuffer/ring_buffer_frontend.c
src/lttng-ring-buffer-client.h
src/lttng-ring-buffer-event-notifier-client.h
src/lttng-ring-buffer-metadata-client.h
This page took 0.026566 seconds and 4 git commands to generate.