Refactoring: uprobes: combine common code between recorder and notifier
[lttng-modules.git] / src / lttng-events.c
index c956db54a194c3bf0493b43edd3055bfb61379a7..d5f8314c5fbbe59ea9834b37809de658971032c0 100644 (file)
@@ -28,6 +28,7 @@
 #include <linux/vmalloc.h>
 #include <linux/dmi.h>
 
+#include <wrapper/compiler_attributes.h>
 #include <wrapper/uuid.h>
 #include <wrapper/vmalloc.h>   /* for wrapper_vmalloc_sync_mappings() */
 #include <wrapper/random.h>
@@ -63,37 +64,37 @@ static struct kmem_cache *event_recorder_private_cache;
 static struct kmem_cache *event_notifier_cache;
 static struct kmem_cache *event_notifier_private_cache;
 
-static void lttng_session_lazy_sync_event_enablers(struct lttng_session *session);
-static void lttng_session_sync_event_enablers(struct lttng_session *session);
-static void lttng_event_enabler_destroy(struct lttng_event_enabler *event_enabler);
-static void lttng_event_notifier_enabler_destroy(struct lttng_event_notifier_enabler *event_notifier_enabler);
+static void lttng_session_lazy_sync_event_enablers(struct lttng_kernel_session *session);
+static void lttng_session_sync_event_enablers(struct lttng_kernel_session *session);
 static void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group *event_notifier_group);
+static void lttng_event_enabler_sync(struct lttng_event_enabler_common *event_enabler);
 
 static void _lttng_event_destroy(struct lttng_kernel_event_common *event);
-static void _lttng_channel_destroy(struct lttng_channel *chan);
-static int _lttng_event_unregister(struct lttng_kernel_event_recorder *event);
+static void _lttng_channel_destroy(struct lttng_kernel_channel_buffer *chan);
+static int _lttng_event_recorder_unregister(struct lttng_kernel_event_recorder *event);
 static int _lttng_event_notifier_unregister(struct lttng_kernel_event_notifier *event_notifier);
 static
-int _lttng_event_metadata_statedump(struct lttng_session *session,
-                                 struct lttng_channel *chan,
+int _lttng_event_metadata_statedump(struct lttng_kernel_session *session,
+                                 struct lttng_kernel_channel_buffer *chan,
                                  struct lttng_kernel_event_recorder *event);
 static
-int _lttng_session_metadata_statedump(struct lttng_session *session);
+int _lttng_session_metadata_statedump(struct lttng_kernel_session *session);
 static
 void _lttng_metadata_channel_hangup(struct lttng_metadata_stream *stream);
 static
-int _lttng_type_statedump(struct lttng_session *session,
+int _lttng_type_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_type_common *type,
                enum lttng_kernel_string_encoding parent_encoding,
                size_t nesting);
 static
-int _lttng_field_statedump(struct lttng_session *session,
+int _lttng_field_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
-               size_t nesting);
+               size_t nesting, const char **prev_field_name_p);
 
 void synchronize_trace(void)
 {
-#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(5,1,0))
+#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(5,1,0) || \
+       LTTNG_RHEL_KERNEL_RANGE(4,18,0,193,0,0, 4,19,0,0,0,0))
        synchronize_rcu();
 #else
        synchronize_sched();
@@ -136,64 +137,83 @@ static struct lttng_transport *lttng_transport_find(const char *name)
  */
 int lttng_session_active(void)
 {
-       struct lttng_session *iter;
+       struct lttng_kernel_session_private *iter;
 
        list_for_each_entry(iter, &sessions, list) {
-               if (iter->active)
+               if (iter->pub->active)
                        return 1;
        }
        return 0;
 }
 
-struct lttng_session *lttng_session_create(void)
+struct lttng_kernel_session *lttng_session_create(void)
 {
-       struct lttng_session *session;
+       struct lttng_kernel_session *session;
+       struct lttng_kernel_session_private *session_priv;
        struct lttng_metadata_cache *metadata_cache;
        int i;
 
        mutex_lock(&sessions_mutex);
-       session = lttng_kvzalloc(sizeof(struct lttng_session), GFP_KERNEL);
+       session = lttng_kvzalloc(sizeof(*session), GFP_KERNEL);
        if (!session)
                goto err;
-       INIT_LIST_HEAD(&session->chan);
-       INIT_LIST_HEAD(&session->events);
-       lttng_guid_gen(&session->uuid);
+       session_priv = lttng_kvzalloc(sizeof(*session_priv), GFP_KERNEL);
+       if (!session_priv)
+               goto err_free_session;
+       session->priv = session_priv;
+       session_priv->pub = session;
+
+       INIT_LIST_HEAD(&session_priv->chan);
+       INIT_LIST_HEAD(&session_priv->events);
+       lttng_guid_gen(&session_priv->uuid);
 
        metadata_cache = kzalloc(sizeof(struct lttng_metadata_cache),
                        GFP_KERNEL);
        if (!metadata_cache)
-               goto err_free_session;
+               goto err_free_session_private;
        metadata_cache->data = vzalloc(METADATA_CACHE_DEFAULT_SIZE);
        if (!metadata_cache->data)
                goto err_free_cache;
        metadata_cache->cache_alloc = METADATA_CACHE_DEFAULT_SIZE;
        kref_init(&metadata_cache->refcount);
        mutex_init(&metadata_cache->lock);
-       session->metadata_cache = metadata_cache;
+       session_priv->metadata_cache = metadata_cache;
        INIT_LIST_HEAD(&metadata_cache->metadata_stream);
-       memcpy(&metadata_cache->uuid, &session->uuid,
+       memcpy(&metadata_cache->uuid, &session_priv->uuid,
                sizeof(metadata_cache->uuid));
-       INIT_LIST_HEAD(&session->enablers_head);
+       INIT_LIST_HEAD(&session_priv->enablers_head);
        for (i = 0; i < LTTNG_EVENT_HT_SIZE; i++)
-               INIT_HLIST_HEAD(&session->events_ht.table[i]);
-       list_add(&session->list, &sessions);
-       session->pid_tracker.session = session;
-       session->pid_tracker.tracker_type = TRACKER_PID;
-       session->vpid_tracker.session = session;
-       session->vpid_tracker.tracker_type = TRACKER_VPID;
-       session->uid_tracker.session = session;
-       session->uid_tracker.tracker_type = TRACKER_UID;
-       session->vuid_tracker.session = session;
-       session->vuid_tracker.tracker_type = TRACKER_VUID;
-       session->gid_tracker.session = session;
-       session->gid_tracker.tracker_type = TRACKER_GID;
-       session->vgid_tracker.session = session;
-       session->vgid_tracker.tracker_type = TRACKER_VGID;
+               INIT_HLIST_HEAD(&session_priv->events_ht.table[i]);
+       list_add(&session_priv->list, &sessions);
+
+       if (lttng_id_tracker_init(&session->pid_tracker, session, TRACKER_PID))
+               goto tracker_alloc_error;
+       if (lttng_id_tracker_init(&session->vpid_tracker, session, TRACKER_VPID))
+               goto tracker_alloc_error;
+       if (lttng_id_tracker_init(&session->uid_tracker, session, TRACKER_UID))
+               goto tracker_alloc_error;
+       if (lttng_id_tracker_init(&session->vuid_tracker, session, TRACKER_VUID))
+               goto tracker_alloc_error;
+       if (lttng_id_tracker_init(&session->gid_tracker, session, TRACKER_GID))
+               goto tracker_alloc_error;
+       if (lttng_id_tracker_init(&session->vgid_tracker, session, TRACKER_VGID))
+               goto tracker_alloc_error;
+
        mutex_unlock(&sessions_mutex);
+
        return session;
 
+tracker_alloc_error:
+       lttng_id_tracker_fini(&session->pid_tracker);
+       lttng_id_tracker_fini(&session->vpid_tracker);
+       lttng_id_tracker_fini(&session->uid_tracker);
+       lttng_id_tracker_fini(&session->vuid_tracker);
+       lttng_id_tracker_fini(&session->gid_tracker);
+       lttng_id_tracker_fini(&session->vgid_tracker);
 err_free_cache:
        kfree(metadata_cache);
+err_free_session_private:
+       lttng_kvfree(session_priv);
 err_free_session:
        lttng_kvfree(session);
 err:
@@ -291,7 +311,7 @@ struct lttng_event_notifier_group *lttng_event_notifier_group_create(void)
         * notifications.
         */
        event_notifier_group->ops = &transport->ops;
-       event_notifier_group->chan = transport->ops.channel_create(
+       event_notifier_group->chan = transport->ops.priv->channel_create(
                        transport_name, event_notifier_group, NULL,
                        subbuf_size, num_subbuf, switch_timer_interval,
                        read_timer_interval);
@@ -329,51 +349,52 @@ void metadata_cache_destroy(struct kref *kref)
        kfree(cache);
 }
 
-void lttng_session_destroy(struct lttng_session *session)
+void lttng_session_destroy(struct lttng_kernel_session *session)
 {
-       struct lttng_channel *chan, *tmpchan;
+       struct lttng_kernel_channel_buffer_private *chan_priv, *tmpchan_priv;
        struct lttng_kernel_event_recorder_private *event_recorder_priv, *tmpevent_recorder_priv;
        struct lttng_metadata_stream *metadata_stream;
-       struct lttng_event_enabler *event_enabler, *tmp_event_enabler;
+       struct lttng_event_recorder_enabler *event_recorder_enabler, *tmp_event_recorder_enabler;
        int ret;
 
        mutex_lock(&sessions_mutex);
        WRITE_ONCE(session->active, 0);
-       list_for_each_entry(chan, &session->chan, list) {
-               ret = lttng_syscalls_unregister_channel(chan);
+       list_for_each_entry(chan_priv, &session->priv->chan, node) {
+               ret = lttng_syscalls_unregister_syscall_table(&chan_priv->parent.syscall_table);
                WARN_ON(ret);
        }
-       list_for_each_entry(event_recorder_priv, &session->events, node) {
-               ret = _lttng_event_unregister(event_recorder_priv->pub);
+       list_for_each_entry(event_recorder_priv, &session->priv->events, node) {
+               ret = _lttng_event_recorder_unregister(event_recorder_priv->pub);
                WARN_ON(ret);
        }
        synchronize_trace();    /* Wait for in-flight events to complete */
-       list_for_each_entry(chan, &session->chan, list) {
-               ret = lttng_syscalls_destroy_event(chan);
+       list_for_each_entry(chan_priv, &session->priv->chan, node) {
+               ret = lttng_syscalls_destroy_syscall_table(&chan_priv->parent.syscall_table);
                WARN_ON(ret);
        }
-       list_for_each_entry_safe(event_enabler, tmp_event_enabler,
-                       &session->enablers_head, node)
-               lttng_event_enabler_destroy(event_enabler);
-       list_for_each_entry_safe(event_recorder_priv, tmpevent_recorder_priv, &session->events, node)
+       list_for_each_entry_safe(event_recorder_enabler, tmp_event_recorder_enabler,
+                       &session->priv->enablers_head, node)
+               lttng_event_enabler_destroy(&event_recorder_enabler->parent);
+       list_for_each_entry_safe(event_recorder_priv, tmpevent_recorder_priv, &session->priv->events, node)
                _lttng_event_destroy(&event_recorder_priv->pub->parent);
-       list_for_each_entry_safe(chan, tmpchan, &session->chan, list) {
-               BUG_ON(chan->channel_type == METADATA_CHANNEL);
-               _lttng_channel_destroy(chan);
+       list_for_each_entry_safe(chan_priv, tmpchan_priv, &session->priv->chan, node) {
+               BUG_ON(chan_priv->channel_type == METADATA_CHANNEL);
+               _lttng_channel_destroy(chan_priv->pub);
        }
-       mutex_lock(&session->metadata_cache->lock);
-       list_for_each_entry(metadata_stream, &session->metadata_cache->metadata_stream, list)
+       mutex_lock(&session->priv->metadata_cache->lock);
+       list_for_each_entry(metadata_stream, &session->priv->metadata_cache->metadata_stream, list)
                _lttng_metadata_channel_hangup(metadata_stream);
-       mutex_unlock(&session->metadata_cache->lock);
-       lttng_id_tracker_destroy(&session->pid_tracker, false);
-       lttng_id_tracker_destroy(&session->vpid_tracker, false);
-       lttng_id_tracker_destroy(&session->uid_tracker, false);
-       lttng_id_tracker_destroy(&session->vuid_tracker, false);
-       lttng_id_tracker_destroy(&session->gid_tracker, false);
-       lttng_id_tracker_destroy(&session->vgid_tracker, false);
-       kref_put(&session->metadata_cache->refcount, metadata_cache_destroy);
-       list_del(&session->list);
+       mutex_unlock(&session->priv->metadata_cache->lock);
+       lttng_id_tracker_fini(&session->pid_tracker);
+       lttng_id_tracker_fini(&session->vpid_tracker);
+       lttng_id_tracker_fini(&session->uid_tracker);
+       lttng_id_tracker_fini(&session->vuid_tracker);
+       lttng_id_tracker_fini(&session->gid_tracker);
+       lttng_id_tracker_fini(&session->vgid_tracker);
+       kref_put(&session->priv->metadata_cache->refcount, metadata_cache_destroy);
+       list_del(&session->priv->list);
        mutex_unlock(&sessions_mutex);
+       lttng_kvfree(session->priv);
        lttng_kvfree(session);
 }
 
@@ -389,7 +410,7 @@ void lttng_event_notifier_group_destroy(
 
        mutex_lock(&sessions_mutex);
 
-       ret = lttng_syscalls_unregister_event_notifier_group(event_notifier_group);
+       ret = lttng_syscalls_unregister_syscall_table(&event_notifier_group->syscall_table);
        WARN_ON(ret);
 
        list_for_each_entry_safe(event_notifier_priv, tmpevent_notifier_priv,
@@ -403,11 +424,12 @@ void lttng_event_notifier_group_destroy(
 
        irq_work_sync(&event_notifier_group->wakeup_pending);
 
-       kfree(event_notifier_group->sc_filter);
+       ret = lttng_syscalls_destroy_syscall_table(&event_notifier_group->syscall_table);
+       WARN_ON(ret);
 
        list_for_each_entry_safe(event_notifier_enabler, tmp_event_notifier_enabler,
                        &event_notifier_group->enablers_head, node)
-               lttng_event_notifier_enabler_destroy(event_notifier_enabler);
+               lttng_event_enabler_destroy(&event_notifier_enabler->parent);
 
        list_for_each_entry_safe(event_notifier_priv, tmpevent_notifier_priv,
                        &event_notifier_group->event_notifiers_head, node)
@@ -422,7 +444,7 @@ void lttng_event_notifier_group_destroy(
                event_notifier_group->error_counter = NULL;
        }
 
-       event_notifier_group->ops->channel_destroy(event_notifier_group->chan);
+       event_notifier_group->ops->priv->channel_destroy(event_notifier_group->chan);
        module_put(event_notifier_group->transport->owner);
        list_del(&event_notifier_group->node);
 
@@ -430,7 +452,7 @@ void lttng_event_notifier_group_destroy(
        lttng_kvfree(event_notifier_group);
 }
 
-int lttng_session_statedump(struct lttng_session *session)
+int lttng_session_statedump(struct lttng_kernel_session *session)
 {
        int ret;
 
@@ -440,10 +462,10 @@ int lttng_session_statedump(struct lttng_session *session)
        return ret;
 }
 
-int lttng_session_enable(struct lttng_session *session)
+int lttng_session_enable(struct lttng_kernel_session *session)
 {
        int ret = 0;
-       struct lttng_channel *chan;
+       struct lttng_kernel_channel_buffer_private *chan_priv;
 
        mutex_lock(&sessions_mutex);
        if (session->active) {
@@ -452,7 +474,7 @@ int lttng_session_enable(struct lttng_session *session)
        }
 
        /* Set transient enabler state to "enabled" */
-       session->tstate = 1;
+       session->priv->tstate = 1;
 
        /* We need to sync enablers with session before activation. */
        lttng_session_sync_event_enablers(session);
@@ -461,23 +483,23 @@ int lttng_session_enable(struct lttng_session *session)
         * Snapshot the number of events per channel to know the type of header
         * we need to use.
         */
-       list_for_each_entry(chan, &session->chan, list) {
-               if (chan->header_type)
-                       continue;               /* don't change it if session stop/restart */
-               if (chan->free_event_id < 31)
-                       chan->header_type = 1;  /* compact */
+       list_for_each_entry(chan_priv, &session->priv->chan, node) {
+               if (chan_priv->header_type)
+                       continue;                       /* don't change it if session stop/restart */
+               if (chan_priv->free_event_id < 31)
+                       chan_priv->header_type = 1;     /* compact */
                else
-                       chan->header_type = 2;  /* large */
+                       chan_priv->header_type = 2;     /* large */
        }
 
        /* Clear each stream's quiescent state. */
-       list_for_each_entry(chan, &session->chan, list) {
-               if (chan->channel_type != METADATA_CHANNEL)
-                       lib_ring_buffer_clear_quiescent_channel(chan->chan);
+       list_for_each_entry(chan_priv, &session->priv->chan, node) {
+               if (chan_priv->channel_type != METADATA_CHANNEL)
+                       lib_ring_buffer_clear_quiescent_channel(chan_priv->rb_chan);
        }
 
        WRITE_ONCE(session->active, 1);
-       WRITE_ONCE(session->been_active, 1);
+       WRITE_ONCE(session->priv->been_active, 1);
        ret = _lttng_session_metadata_statedump(session);
        if (ret) {
                WRITE_ONCE(session->active, 0);
@@ -491,10 +513,10 @@ end:
        return ret;
 }
 
-int lttng_session_disable(struct lttng_session *session)
+int lttng_session_disable(struct lttng_kernel_session *session)
 {
        int ret = 0;
-       struct lttng_channel *chan;
+       struct lttng_kernel_channel_buffer_private *chan_priv;
 
        mutex_lock(&sessions_mutex);
        if (!session->active) {
@@ -504,25 +526,25 @@ int lttng_session_disable(struct lttng_session *session)
        WRITE_ONCE(session->active, 0);
 
        /* Set transient enabler state to "disabled" */
-       session->tstate = 0;
+       session->priv->tstate = 0;
        lttng_session_sync_event_enablers(session);
 
        /* Set each stream's quiescent state. */
-       list_for_each_entry(chan, &session->chan, list) {
-               if (chan->channel_type != METADATA_CHANNEL)
-                       lib_ring_buffer_set_quiescent_channel(chan->chan);
+       list_for_each_entry(chan_priv, &session->priv->chan, node) {
+               if (chan_priv->channel_type != METADATA_CHANNEL)
+                       lib_ring_buffer_set_quiescent_channel(chan_priv->rb_chan);
        }
 end:
        mutex_unlock(&sessions_mutex);
        return ret;
 }
 
-int lttng_session_metadata_regenerate(struct lttng_session *session)
+int lttng_session_metadata_regenerate(struct lttng_kernel_session *session)
 {
        int ret = 0;
-       struct lttng_channel *chan;
+       struct lttng_kernel_channel_buffer_private *chan_priv;
        struct lttng_kernel_event_recorder_private *event_recorder_priv;
-       struct lttng_metadata_cache *cache = session->metadata_cache;
+       struct lttng_metadata_cache *cache = session->priv->metadata_cache;
        struct lttng_metadata_stream *stream;
 
        mutex_lock(&sessions_mutex);
@@ -535,18 +557,18 @@ int lttng_session_metadata_regenerate(struct lttng_session *session)
        memset(cache->data, 0, cache->cache_alloc);
        cache->metadata_written = 0;
        cache->version++;
-       list_for_each_entry(stream, &session->metadata_cache->metadata_stream, list) {
+       list_for_each_entry(stream, &session->priv->metadata_cache->metadata_stream, list) {
                stream->metadata_out = 0;
                stream->metadata_in = 0;
        }
        mutex_unlock(&cache->lock);
 
-       session->metadata_dumped = 0;
-       list_for_each_entry(chan, &session->chan, list) {
-               chan->metadata_dumped = 0;
+       session->priv->metadata_dumped = 0;
+       list_for_each_entry(chan_priv, &session->priv->chan, node) {
+               chan_priv->metadata_dumped = 0;
        }
 
-       list_for_each_entry(event_recorder_priv, &session->events, node) {
+       list_for_each_entry(event_recorder_priv, &session->priv->events, node) {
                event_recorder_priv->metadata_dumped = 0;
        }
 
@@ -557,12 +579,25 @@ end:
        return ret;
 }
 
-int lttng_channel_enable(struct lttng_channel *channel)
+static
+bool is_channel_buffer_metadata(struct lttng_kernel_channel_common *channel)
+{
+       struct lttng_kernel_channel_buffer *chan_buf;
+
+       if (channel->type != LTTNG_KERNEL_CHANNEL_TYPE_BUFFER)
+               return false;
+       chan_buf = container_of(channel, struct lttng_kernel_channel_buffer, parent);
+       if (chan_buf->priv->channel_type == METADATA_CHANNEL)
+               return true;
+       return false;
+}
+
+int lttng_channel_enable(struct lttng_kernel_channel_common *channel)
 {
        int ret = 0;
 
        mutex_lock(&sessions_mutex);
-       if (channel->channel_type == METADATA_CHANNEL) {
+       if (is_channel_buffer_metadata(channel)) {
                ret = -EPERM;
                goto end;
        }
@@ -571,7 +606,7 @@ int lttng_channel_enable(struct lttng_channel *channel)
                goto end;
        }
        /* Set transient enabler state to "enabled" */
-       channel->tstate = 1;
+       channel->priv->tstate = 1;
        lttng_session_sync_event_enablers(channel->session);
        /* Set atomically the state to "enabled" */
        WRITE_ONCE(channel->enabled, 1);
@@ -580,12 +615,12 @@ end:
        return ret;
 }
 
-int lttng_channel_disable(struct lttng_channel *channel)
+int lttng_channel_disable(struct lttng_kernel_channel_common *channel)
 {
        int ret = 0;
 
        mutex_lock(&sessions_mutex);
-       if (channel->channel_type == METADATA_CHANNEL) {
+       if (is_channel_buffer_metadata(channel)) {
                ret = -EPERM;
                goto end;
        }
@@ -596,85 +631,68 @@ int lttng_channel_disable(struct lttng_channel *channel)
        /* Set atomically the state to "disabled" */
        WRITE_ONCE(channel->enabled, 0);
        /* Set transient enabler state to "enabled" */
-       channel->tstate = 0;
+       channel->priv->tstate = 0;
        lttng_session_sync_event_enablers(channel->session);
 end:
        mutex_unlock(&sessions_mutex);
        return ret;
 }
 
-int lttng_event_enable(struct lttng_kernel_event_recorder *event_recorder)
+int lttng_event_enable(struct lttng_kernel_event_common *event)
 {
-       struct lttng_kernel_event_common *event = &event_recorder->parent;
        int ret = 0;
 
        mutex_lock(&sessions_mutex);
-       if (event_recorder->chan->channel_type == METADATA_CHANNEL) {
-               ret = -EPERM;
-               goto end;
-       }
-       if (event->enabled) {
-               ret = -EEXIST;
-               goto end;
-       }
-       switch (event->priv->instrumentation) {
-       case LTTNG_KERNEL_ABI_TRACEPOINT:       /* Fall-through */
-       case LTTNG_KERNEL_ABI_SYSCALL:
-               ret = -EINVAL;
-               break;
+       switch (event->type) {
+       case LTTNG_KERNEL_EVENT_TYPE_RECORDER:
+       {
+               struct lttng_kernel_event_recorder *event_recorder =
+                       container_of(event, struct lttng_kernel_event_recorder, parent);
 
-       case LTTNG_KERNEL_ABI_KPROBE:           /* Fall-through */
-       case LTTNG_KERNEL_ABI_UPROBE:
-               WRITE_ONCE(event->enabled, 1);
+               if (event_recorder->chan->priv->channel_type == METADATA_CHANNEL) {
+                       ret = -EPERM;
+                       goto end;
+               }
                break;
-
-       case LTTNG_KERNEL_ABI_KRETPROBE:
-               ret = lttng_kretprobes_event_enable_state(&event_recorder->parent, 1);
+       }
+       case LTTNG_KERNEL_EVENT_TYPE_NOTIFIER:
+               switch (event->priv->instrumentation) {
+               case LTTNG_KERNEL_ABI_KRETPROBE:
+                       ret = -EINVAL;
+                       goto end;
+               default:
+                       break;
+               }
                break;
-
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
        default:
-               WARN_ON_ONCE(1);
-               ret = -EINVAL;
+               break;
        }
-end:
-       mutex_unlock(&sessions_mutex);
-       return ret;
-}
 
-int lttng_event_disable(struct lttng_kernel_event_recorder *event_recorder)
-{
-       struct lttng_kernel_event_common *event = &event_recorder->parent;
-       int ret = 0;
-
-       mutex_lock(&sessions_mutex);
-       if (event_recorder->chan->channel_type == METADATA_CHANNEL) {
-               ret = -EPERM;
-               goto end;
-       }
-       if (!event->enabled) {
+       if (event->enabled) {
                ret = -EEXIST;
                goto end;
        }
        switch (event->priv->instrumentation) {
-       case LTTNG_KERNEL_ABI_TRACEPOINT:       /* Fall-through */
+       case LTTNG_KERNEL_ABI_TRACEPOINT:
+               lttng_fallthrough;
        case LTTNG_KERNEL_ABI_SYSCALL:
                ret = -EINVAL;
                break;
 
-       case LTTNG_KERNEL_ABI_KPROBE:           /* Fall-through */
+       case LTTNG_KERNEL_ABI_KPROBE:
+               lttng_fallthrough;
        case LTTNG_KERNEL_ABI_UPROBE:
-               WRITE_ONCE(event->enabled, 0);
+               WRITE_ONCE(event->enabled, 1);
                break;
 
        case LTTNG_KERNEL_ABI_KRETPROBE:
-
-               ret = lttng_kretprobes_event_enable_state(&event_recorder->parent, 0);
+               ret = lttng_kretprobes_event_enable_state(event, 1);
                break;
 
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_NOOP:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
                ret = -EINVAL;
@@ -684,63 +702,61 @@ end:
        return ret;
 }
 
-int lttng_event_notifier_enable(struct lttng_kernel_event_notifier *event_notifier)
+int lttng_event_disable(struct lttng_kernel_event_common *event)
 {
-       struct lttng_kernel_event_common *event = &event_notifier->parent;
        int ret = 0;
 
        mutex_lock(&sessions_mutex);
-       if (event->enabled) {
-               ret = -EEXIST;
-               goto end;
-       }
-       switch (event->priv->instrumentation) {
-       case LTTNG_KERNEL_ABI_TRACEPOINT:       /* Fall-through */
-       case LTTNG_KERNEL_ABI_SYSCALL:
-               ret = -EINVAL;
-               break;
+       switch (event->type) {
+       case LTTNG_KERNEL_EVENT_TYPE_RECORDER:
+       {
+               struct lttng_kernel_event_recorder *event_recorder =
+                       container_of(event, struct lttng_kernel_event_recorder, parent);
 
-       case LTTNG_KERNEL_ABI_KPROBE:           /* Fall-through */
-       case LTTNG_KERNEL_ABI_UPROBE:
-               WRITE_ONCE(event->enabled, 1);
+               if (event_recorder->chan->priv->channel_type == METADATA_CHANNEL) {
+                       ret = -EPERM;
+                       goto end;
+               }
+               break;
+       }
+       case LTTNG_KERNEL_EVENT_TYPE_NOTIFIER:
+               switch (event->priv->instrumentation) {
+               case LTTNG_KERNEL_ABI_KRETPROBE:
+                       ret = -EINVAL;
+                       goto end;
+               default:
+                       break;
+               }
                break;
-
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_KRETPROBE:        /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
        default:
-               WARN_ON_ONCE(1);
-               ret = -EINVAL;
+               break;
        }
-end:
-       mutex_unlock(&sessions_mutex);
-       return ret;
-}
 
-int lttng_event_notifier_disable(struct lttng_kernel_event_notifier *event_notifier)
-{
-       struct lttng_kernel_event_common *event = &event_notifier->parent;
-       int ret = 0;
-
-       mutex_lock(&sessions_mutex);
        if (!event->enabled) {
                ret = -EEXIST;
                goto end;
        }
        switch (event->priv->instrumentation) {
-       case LTTNG_KERNEL_ABI_TRACEPOINT:       /* Fall-through */
+       case LTTNG_KERNEL_ABI_TRACEPOINT:
+               lttng_fallthrough;
        case LTTNG_KERNEL_ABI_SYSCALL:
                ret = -EINVAL;
                break;
 
-       case LTTNG_KERNEL_ABI_KPROBE:           /* Fall-through */
+       case LTTNG_KERNEL_ABI_KPROBE:
+               lttng_fallthrough;
        case LTTNG_KERNEL_ABI_UPROBE:
                WRITE_ONCE(event->enabled, 0);
                break;
 
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_KRETPROBE:        /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+       case LTTNG_KERNEL_ABI_KRETPROBE:
+               ret = lttng_kretprobes_event_enable_state(event, 0);
+               break;
+
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_NOOP:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
                ret = -EINVAL;
@@ -750,7 +766,7 @@ end:
        return ret;
 }
 
-struct lttng_channel *lttng_channel_create(struct lttng_session *session,
+struct lttng_kernel_channel_buffer *lttng_channel_buffer_create(struct lttng_kernel_session *session,
                                       const char *transport_name,
                                       void *buf_addr,
                                       size_t subbuf_size, size_t num_subbuf,
@@ -758,11 +774,12 @@ struct lttng_channel *lttng_channel_create(struct lttng_session *session,
                                       unsigned int read_timer_interval,
                                       enum channel_type channel_type)
 {
-       struct lttng_channel *chan;
+       struct lttng_kernel_channel_buffer *chan;
+       struct lttng_kernel_channel_buffer_private *chan_priv;
        struct lttng_transport *transport = NULL;
 
        mutex_lock(&sessions_mutex);
-       if (session->been_active && channel_type != METADATA_CHANNEL)
+       if (session->priv->been_active && channel_type != METADATA_CHANNEL)
                goto active;    /* Refuse to add channel to active session */
        transport = lttng_transport_find(transport_name);
        if (!transport) {
@@ -774,31 +791,39 @@ struct lttng_channel *lttng_channel_create(struct lttng_session *session,
                printk(KERN_WARNING "LTTng: Can't lock transport module.\n");
                goto notransport;
        }
-       chan = kzalloc(sizeof(struct lttng_channel), GFP_KERNEL);
+       chan = kzalloc(sizeof(struct lttng_kernel_channel_buffer), GFP_KERNEL);
        if (!chan)
                goto nomem;
-       chan->session = session;
-       chan->id = session->free_chan_id++;
+       chan_priv = kzalloc(sizeof(struct lttng_kernel_channel_buffer_private), GFP_KERNEL);
+       if (!chan_priv)
+               goto nomem_priv;
+       chan->priv = chan_priv;
+       chan_priv->pub = chan;
+       chan->parent.type = LTTNG_KERNEL_CHANNEL_TYPE_BUFFER;
+       chan->parent.session = session;
+       chan->priv->id = session->priv->free_chan_id++;
        chan->ops = &transport->ops;
        /*
         * Note: the channel creation op already writes into the packet
         * headers. Therefore the "chan" information used as input
         * should be already accessible.
         */
-       chan->chan = transport->ops.channel_create(transport_name,
+       chan->priv->rb_chan = transport->ops.priv->channel_create(transport_name,
                        chan, buf_addr, subbuf_size, num_subbuf,
                        switch_timer_interval, read_timer_interval);
-       if (!chan->chan)
+       if (!chan->priv->rb_chan)
                goto create_error;
-       chan->tstate = 1;
-       chan->enabled = 1;
-       chan->transport = transport;
-       chan->channel_type = channel_type;
-       list_add(&chan->list, &session->chan);
+       chan->priv->parent.tstate = 1;
+       chan->parent.enabled = 1;
+       chan->priv->transport = transport;
+       chan->priv->channel_type = channel_type;
+       list_add(&chan->priv->node, &session->priv->chan);
        mutex_unlock(&sessions_mutex);
        return chan;
 
 create_error:
+       kfree(chan_priv);
+nomem_priv:
        kfree(chan);
 nomem:
        if (transport)
@@ -815,18 +840,19 @@ active:
  * Needs to be called with sessions mutex held.
  */
 static
-void _lttng_channel_destroy(struct lttng_channel *chan)
+void _lttng_channel_destroy(struct lttng_kernel_channel_buffer *chan)
 {
-       chan->ops->channel_destroy(chan->chan);
-       module_put(chan->transport->owner);
-       list_del(&chan->list);
-       lttng_kernel_destroy_context(chan->ctx);
+       chan->ops->priv->channel_destroy(chan->priv->rb_chan);
+       module_put(chan->priv->transport->owner);
+       list_del(&chan->priv->node);
+       lttng_kernel_destroy_context(chan->priv->ctx);
+       kfree(chan->priv);
        kfree(chan);
 }
 
-void lttng_metadata_channel_destroy(struct lttng_channel *chan)
+void lttng_metadata_channel_destroy(struct lttng_kernel_channel_buffer *chan)
 {
-       BUG_ON(chan->channel_type != METADATA_CHANNEL);
+       BUG_ON(chan->priv->channel_type != METADATA_CHANNEL);
 
        /* Protect the metadata cache with the sessions_mutex. */
        mutex_lock(&sessions_mutex);
@@ -847,19 +873,20 @@ void _lttng_metadata_channel_hangup(struct lttng_metadata_stream *stream)
  * Supports event creation while tracing session is active.
  * Needs to be called with sessions mutex held.
  */
-struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct lttng_channel *chan,
-                               struct lttng_kernel_abi_event *event_param,
-                               const struct lttng_kernel_event_desc *event_desc,
-                               enum lttng_kernel_abi_instrumentation itype)
+struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct lttng_event_recorder_enabler *event_enabler,
+                               const struct lttng_kernel_event_desc *event_desc)
 {
-       struct lttng_session *session = chan->session;
+       struct lttng_kernel_channel_buffer *chan = event_enabler->chan;
+       struct lttng_kernel_abi_event *event_param = &event_enabler->parent.event_param;
+       enum lttng_kernel_abi_instrumentation itype = event_param->instrumentation;
+       struct lttng_kernel_session *session = chan->parent.session;
        struct lttng_kernel_event_recorder *event_recorder;
        struct lttng_kernel_event_recorder_private *event_recorder_priv;
        const char *event_name;
        struct hlist_head *head;
        int ret;
 
-       if (chan->free_event_id == -1U) {
+       if (chan->priv->free_event_id == -1U) {
                ret = -EMFILE;
                goto full;
        }
@@ -869,22 +896,27 @@ struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct l
                event_name = event_desc->event_name;
                break;
 
-       case LTTNG_KERNEL_ABI_KPROBE:           /* Fall-through */
-       case LTTNG_KERNEL_ABI_UPROBE:           /* Fall-through */
-       case LTTNG_KERNEL_ABI_KRETPROBE:        /* Fall-through */
+       case LTTNG_KERNEL_ABI_KPROBE:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_UPROBE:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_KRETPROBE:
+               lttng_fallthrough;
        case LTTNG_KERNEL_ABI_SYSCALL:
                event_name = event_param->name;
                break;
 
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_NOOP:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
                ret = -EINVAL;
                goto type_error;
        }
 
-       head = utils_borrow_hash_table_bucket(session->events_ht.table,
+       head = utils_borrow_hash_table_bucket(session->priv->events_ht.table,
                LTTNG_EVENT_HT_SIZE, event_name);
        lttng_hlist_for_each_entry(event_recorder_priv, head, hlist) {
                WARN_ON_ONCE(!event_recorder_priv->parent.desc);
@@ -912,8 +944,9 @@ struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct l
        event_recorder->parent.priv = &event_recorder_priv->parent;
        event_recorder->parent.type = LTTNG_KERNEL_EVENT_TYPE_RECORDER;
 
+       event_recorder->parent.run_filter = lttng_kernel_interpret_event_filter;
        event_recorder->chan = chan;
-       event_recorder->priv->id = chan->free_event_id++;
+       event_recorder->priv->id = chan->priv->free_event_id++;
        event_recorder->priv->parent.instrumentation = itype;
        INIT_LIST_HEAD(&event_recorder->priv->parent.filter_bytecode_runtime_head);
        INIT_LIST_HEAD(&event_recorder->priv->parent.enablers_ref_head);
@@ -987,8 +1020,9 @@ struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct l
                event_recorder_return->parent.priv = &event_recorder_return_priv->parent;
                event_recorder_return->parent.type = LTTNG_KERNEL_EVENT_TYPE_RECORDER;
 
+               event_recorder_return->parent.run_filter = lttng_kernel_interpret_event_filter;
                event_recorder_return->chan = chan;
-               event_recorder_return->priv->id = chan->free_event_id++;
+               event_recorder_return->priv->id = chan->priv->free_event_id++;
                event_recorder_return->priv->parent.instrumentation = itype;
                event_recorder_return->parent.enabled = 0;
                event_recorder_return->priv->parent.registered = 1;
@@ -1014,7 +1048,7 @@ struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct l
                WARN_ON_ONCE(!ret);
                ret = try_module_get(event_recorder_return->priv->parent.desc->owner);
                WARN_ON_ONCE(!ret);
-               ret = _lttng_event_metadata_statedump(chan->session, chan,
+               ret = _lttng_event_metadata_statedump(chan->parent.session, chan,
                                                    event_recorder_return);
                WARN_ON_ONCE(ret > 0);
                if (ret) {
@@ -1024,7 +1058,7 @@ struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct l
                        module_put(event_recorder->priv->parent.desc->owner);
                        goto statedump_error;
                }
-               list_add(&event_recorder_return->priv->node, &chan->session->events);
+               list_add(&event_recorder_return->priv->node, &chan->parent.session->priv->events);
                break;
        }
 
@@ -1080,27 +1114,29 @@ struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct l
 
                ret = lttng_uprobes_register_event(event_param->name,
                                event_param->u.uprobe.fd,
-                               event_recorder);
+                               &event_recorder->parent);
                if (ret)
                        goto register_error;
                ret = try_module_get(event_recorder->priv->parent.desc->owner);
                WARN_ON_ONCE(!ret);
                break;
 
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_NOOP:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
                ret = -EINVAL;
                goto register_error;
        }
-       ret = _lttng_event_metadata_statedump(chan->session, chan, event_recorder);
+       ret = _lttng_event_metadata_statedump(chan->parent.session, chan, event_recorder);
        WARN_ON_ONCE(ret > 0);
        if (ret) {
                goto statedump_error;
        }
        hlist_add_head(&event_recorder->priv->hlist, head);
-       list_add(&event_recorder->priv->node, &chan->session->events);
+       list_add(&event_recorder->priv->node, &chan->parent.session->priv->events);
        return event_recorder;
 
 statedump_error:
@@ -1135,15 +1171,20 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
                event_name = event_desc->event_name;
                break;
 
-       case LTTNG_KERNEL_ABI_KPROBE:           /* Fall-through */
-       case LTTNG_KERNEL_ABI_UPROBE:           /* Fall-through */
+       case LTTNG_KERNEL_ABI_KPROBE:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_UPROBE:
+               lttng_fallthrough;
        case LTTNG_KERNEL_ABI_SYSCALL:
                event_name = event_notifier_param->event.name;
                break;
 
-       case LTTNG_KERNEL_ABI_KRETPROBE:        /* Fall-through */
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+       case LTTNG_KERNEL_ABI_KRETPROBE:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_NOOP:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
                ret = -EINVAL;
@@ -1188,6 +1229,7 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
        INIT_LIST_HEAD(&event_notifier->priv->parent.filter_bytecode_runtime_head);
        INIT_LIST_HEAD(&event_notifier->priv->parent.enablers_ref_head);
        INIT_LIST_HEAD(&event_notifier->priv->capture_bytecode_runtime_head);
+       event_notifier->parent.run_filter = lttng_kernel_interpret_event_filter;
 
        switch (itype) {
        case LTTNG_KERNEL_ABI_TRACEPOINT:
@@ -1279,19 +1321,21 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
                 */
                smp_wmb();
 
-               ret = lttng_uprobes_register_event_notifier(
-                               event_notifier_param->event.name,
+               ret = lttng_uprobes_register_event(event_notifier_param->event.name,
                                event_notifier_param->event.u.uprobe.fd,
-                               event_notifier);
+                               &event_notifier->parent);
                if (ret)
                        goto register_error;
                ret = try_module_get(event_notifier->priv->parent.desc->owner);
                WARN_ON_ONCE(!ret);
                break;
 
-       case LTTNG_KERNEL_ABI_KRETPROBE:        /* Fall-through */
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+       case LTTNG_KERNEL_ABI_KRETPROBE:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_NOOP:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
                ret = -EINVAL;
@@ -1364,15 +1408,13 @@ int lttng_kernel_counter_clear(struct lttng_counter *counter,
        return counter->ops->counter_clear(counter->counter, dim_indexes);
 }
 
-struct lttng_kernel_event_recorder *lttng_kernel_event_recorder_create(struct lttng_channel *chan,
-                               struct lttng_kernel_abi_event *event_param,
-                               const struct lttng_kernel_event_desc *event_desc,
-                               enum lttng_kernel_abi_instrumentation itype)
+struct lttng_kernel_event_recorder *lttng_kernel_event_recorder_create(struct lttng_event_recorder_enabler *event_enabler,
+                               const struct lttng_kernel_event_desc *event_desc)
 {
        struct lttng_kernel_event_recorder *event;
 
        mutex_lock(&sessions_mutex);
-       event = _lttng_kernel_event_recorder_create(chan, event_param, event_desc, itype);
+       event = _lttng_kernel_event_recorder_create(event_enabler, event_desc);
        mutex_unlock(&sessions_mutex);
        return event;
 }
@@ -1396,7 +1438,7 @@ struct lttng_kernel_event_notifier *lttng_event_notifier_create(
 
 /* Only used for tracepoints for now. */
 static
-void register_event(struct lttng_kernel_event_recorder *event_recorder)
+void register_event_recorder(struct lttng_kernel_event_recorder *event_recorder)
 {
        const struct lttng_kernel_event_desc *desc;
        int ret = -EINVAL;
@@ -1408,22 +1450,26 @@ void register_event(struct lttng_kernel_event_recorder *event_recorder)
        switch (event_recorder->priv->parent.instrumentation) {
        case LTTNG_KERNEL_ABI_TRACEPOINT:
                ret = lttng_wrapper_tracepoint_probe_register(desc->event_kname,
-                                                 desc->probe_callback,
-                                                 event_recorder);
+                                                 desc->tp_class->probe_callback,
+                                                 &event_recorder->parent);
                break;
 
        case LTTNG_KERNEL_ABI_SYSCALL:
-               ret = lttng_syscall_filter_enable_event(event_recorder->chan, event_recorder);
+               ret = lttng_syscall_filter_enable_event(&event_recorder->parent);
                break;
 
-       case LTTNG_KERNEL_ABI_KPROBE:           /* Fall-through */
-       case LTTNG_KERNEL_ABI_UPROBE:           /* Fall-through */
+       case LTTNG_KERNEL_ABI_KPROBE:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_UPROBE:
+               lttng_fallthrough;
        case LTTNG_KERNEL_ABI_KRETPROBE:
                ret = 0;
                break;
 
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_NOOP:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
        }
@@ -1434,7 +1480,7 @@ void register_event(struct lttng_kernel_event_recorder *event_recorder)
 /*
  * Only used internally at session destruction.
  */
-int _lttng_event_unregister(struct lttng_kernel_event_recorder *event_recorder)
+int _lttng_event_recorder_unregister(struct lttng_kernel_event_recorder *event_recorder)
 {
        struct lttng_kernel_event_common_private *event_priv = &event_recorder->priv->parent;
        const struct lttng_kernel_event_desc *desc;
@@ -1447,8 +1493,8 @@ int _lttng_event_unregister(struct lttng_kernel_event_recorder *event_recorder)
        switch (event_priv->instrumentation) {
        case LTTNG_KERNEL_ABI_TRACEPOINT:
                ret = lttng_wrapper_tracepoint_probe_unregister(event_priv->desc->event_kname,
-                                                 event_priv->desc->probe_callback,
-                                                 event_recorder);
+                                                 event_priv->desc->tp_class->probe_callback,
+                                                 &event_recorder->parent);
                break;
 
        case LTTNG_KERNEL_ABI_KPROBE:
@@ -1462,7 +1508,7 @@ int _lttng_event_unregister(struct lttng_kernel_event_recorder *event_recorder)
                break;
 
        case LTTNG_KERNEL_ABI_SYSCALL:
-               ret = lttng_syscall_filter_disable_event(event_recorder->chan, event_recorder);
+               ret = lttng_syscall_filter_disable_event(&event_recorder->parent);
                break;
 
        case LTTNG_KERNEL_ABI_NOOP:
@@ -1470,11 +1516,12 @@ int _lttng_event_unregister(struct lttng_kernel_event_recorder *event_recorder)
                break;
 
        case LTTNG_KERNEL_ABI_UPROBE:
-               lttng_uprobes_unregister_event(event_recorder);
+               lttng_uprobes_unregister_event(&event_recorder->parent);
                ret = 0;
                break;
 
-       case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
        }
@@ -1497,22 +1544,26 @@ void register_event_notifier(struct lttng_kernel_event_notifier *event_notifier)
        switch (event_notifier->priv->parent.instrumentation) {
        case LTTNG_KERNEL_ABI_TRACEPOINT:
                ret = lttng_wrapper_tracepoint_probe_register(desc->event_kname,
-                                                 desc->probe_callback,
-                                                 event_notifier);
+                                                 desc->tp_class->probe_callback,
+                                                 &event_notifier->parent);
                break;
 
        case LTTNG_KERNEL_ABI_SYSCALL:
-               ret = lttng_syscall_filter_enable_event_notifier(event_notifier);
+               ret = lttng_syscall_filter_enable_event(&event_notifier->parent);
                break;
 
-       case LTTNG_KERNEL_ABI_KPROBE:           /* Fall-through */
+       case LTTNG_KERNEL_ABI_KPROBE:
+               lttng_fallthrough;
        case LTTNG_KERNEL_ABI_UPROBE:
                ret = 0;
                break;
 
-       case LTTNG_KERNEL_ABI_KRETPROBE:        /* Fall-through */
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+       case LTTNG_KERNEL_ABI_KRETPROBE:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_NOOP:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
        }
@@ -1534,8 +1585,8 @@ int _lttng_event_notifier_unregister(
        switch (event_notifier->priv->parent.instrumentation) {
        case LTTNG_KERNEL_ABI_TRACEPOINT:
                ret = lttng_wrapper_tracepoint_probe_unregister(event_notifier->priv->parent.desc->event_kname,
-                                                 event_notifier->priv->parent.desc->probe_callback,
-                                                 event_notifier);
+                                                 event_notifier->priv->parent.desc->tp_class->probe_callback,
+                                                 &event_notifier->parent);
                break;
 
        case LTTNG_KERNEL_ABI_KPROBE:
@@ -1544,17 +1595,20 @@ int _lttng_event_notifier_unregister(
                break;
 
        case LTTNG_KERNEL_ABI_UPROBE:
-               lttng_uprobes_unregister_event_notifier(event_notifier);
+               lttng_uprobes_unregister_event(&event_notifier->parent);
                ret = 0;
                break;
 
        case LTTNG_KERNEL_ABI_SYSCALL:
-               ret = lttng_syscall_filter_disable_event_notifier(event_notifier);
+               ret = lttng_syscall_filter_disable_event(&event_notifier->parent);
                break;
 
-       case LTTNG_KERNEL_ABI_KRETPROBE:        /* Fall-through */
-       case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-       case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+       case LTTNG_KERNEL_ABI_KRETPROBE:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_FUNCTION:
+               lttng_fallthrough;
+       case LTTNG_KERNEL_ABI_NOOP:
+               lttng_fallthrough;
        default:
                WARN_ON_ONCE(1);
        }
@@ -1604,11 +1658,13 @@ void _lttng_event_destroy(struct lttng_kernel_event_common *event)
 
                case LTTNG_KERNEL_ABI_UPROBE:
                        module_put(event_priv->desc->owner);
-                       lttng_uprobes_destroy_event_private(event_recorder);
+                       lttng_uprobes_destroy_event_private(&event_recorder->parent);
                        break;
 
-               case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-               case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+               case LTTNG_KERNEL_ABI_FUNCTION:
+                       lttng_fallthrough;
+               case LTTNG_KERNEL_ABI_NOOP:
+                       lttng_fallthrough;
                default:
                        WARN_ON_ONCE(1);
                }
@@ -1637,12 +1693,15 @@ void _lttng_event_destroy(struct lttng_kernel_event_common *event)
 
                case LTTNG_KERNEL_ABI_UPROBE:
                        module_put(event_notifier->priv->parent.desc->owner);
-                       lttng_uprobes_destroy_event_notifier_private(event_notifier);
+                       lttng_uprobes_destroy_event_private(&event_notifier->parent);
                        break;
 
-               case LTTNG_KERNEL_ABI_KRETPROBE:        /* Fall-through */
-               case LTTNG_KERNEL_ABI_FUNCTION:         /* Fall-through */
-               case LTTNG_KERNEL_ABI_NOOP:             /* Fall-through */
+               case LTTNG_KERNEL_ABI_KRETPROBE:
+                       lttng_fallthrough;
+               case LTTNG_KERNEL_ABI_FUNCTION:
+                       lttng_fallthrough;
+               case LTTNG_KERNEL_ABI_NOOP:
+                       lttng_fallthrough;
                default:
                        WARN_ON_ONCE(1);
                }
@@ -1656,7 +1715,7 @@ void _lttng_event_destroy(struct lttng_kernel_event_common *event)
        }
 }
 
-struct lttng_id_tracker *get_tracker(struct lttng_session *session,
+struct lttng_kernel_id_tracker *get_tracker(struct lttng_kernel_session *session,
                enum tracker_type tracker_type)
 {
        switch (tracker_type) {
@@ -1678,10 +1737,10 @@ struct lttng_id_tracker *get_tracker(struct lttng_session *session,
        }
 }
 
-int lttng_session_track_id(struct lttng_session *session,
+int lttng_session_track_id(struct lttng_kernel_session *session,
                enum tracker_type tracker_type, int id)
 {
-       struct lttng_id_tracker *tracker;
+       struct lttng_kernel_id_tracker *tracker;
        int ret;
 
        tracker = get_tracker(session, tracker_type);
@@ -1701,10 +1760,10 @@ int lttng_session_track_id(struct lttng_session *session,
        return ret;
 }
 
-int lttng_session_untrack_id(struct lttng_session *session,
+int lttng_session_untrack_id(struct lttng_kernel_session *session,
                enum tracker_type tracker_type, int id)
 {
-       struct lttng_id_tracker *tracker;
+       struct lttng_kernel_id_tracker *tracker;
        int ret;
 
        tracker = get_tracker(session, tracker_type);
@@ -1726,8 +1785,8 @@ int lttng_session_untrack_id(struct lttng_session *session,
 static
 void *id_list_start(struct seq_file *m, loff_t *pos)
 {
-       struct lttng_id_tracker *id_tracker = m->private;
-       struct lttng_id_tracker_rcu *id_tracker_p = id_tracker->p;
+       struct lttng_kernel_id_tracker *id_tracker = m->private;
+       struct lttng_kernel_id_tracker_rcu *id_tracker_p = id_tracker->p;
        struct lttng_id_hash_node *e;
        int iter = 0, i;
 
@@ -1756,8 +1815,8 @@ void *id_list_start(struct seq_file *m, loff_t *pos)
 static
 void *id_list_next(struct seq_file *m, void *p, loff_t *ppos)
 {
-       struct lttng_id_tracker *id_tracker = m->private;
-       struct lttng_id_tracker_rcu *id_tracker_p = id_tracker->p;
+       struct lttng_kernel_id_tracker *id_tracker = m->private;
+       struct lttng_kernel_id_tracker_rcu *id_tracker_p = id_tracker->p;
        struct lttng_id_hash_node *e;
        int iter = 0, i;
 
@@ -1791,8 +1850,8 @@ void id_list_stop(struct seq_file *m, void *p)
 static
 int id_list_show(struct seq_file *m, void *p)
 {
-       struct lttng_id_tracker *id_tracker = m->private;
-       struct lttng_id_tracker_rcu *id_tracker_p = id_tracker->p;
+       struct lttng_kernel_id_tracker *id_tracker = m->private;
+       struct lttng_kernel_id_tracker_rcu *id_tracker_p = id_tracker->p;
        int id;
 
        if (p == id_tracker_p) {
@@ -1803,7 +1862,7 @@ int id_list_show(struct seq_file *m, void *p)
 
                id = lttng_id_tracker_get_node_id(e);
        }
-       switch (id_tracker->tracker_type) {
+       switch (id_tracker->priv->tracker_type) {
        case TRACKER_PID:
                seq_printf(m,   "process { pid = %d; };\n", id);
                break;
@@ -1846,13 +1905,13 @@ static
 int lttng_tracker_ids_list_release(struct inode *inode, struct file *file)
 {
        struct seq_file *m = file->private_data;
-       struct lttng_id_tracker *id_tracker = m->private;
+       struct lttng_kernel_id_tracker *id_tracker = m->private;
        int ret;
 
        WARN_ON_ONCE(!id_tracker);
        ret = seq_release(inode, file);
        if (!ret)
-               fput(id_tracker->session->file);
+               fput(id_tracker->priv->session->priv->file);
        return ret;
 }
 
@@ -1864,7 +1923,7 @@ const struct file_operations lttng_tracker_ids_list_fops = {
        .release = lttng_tracker_ids_list_release,
 };
 
-int lttng_session_list_tracker_ids(struct lttng_session *session,
+int lttng_session_list_tracker_ids(struct lttng_kernel_session *session,
                enum tracker_type tracker_type)
 {
        struct file *tracker_ids_list_file;
@@ -1884,7 +1943,7 @@ int lttng_session_list_tracker_ids(struct lttng_session *session,
                ret = PTR_ERR(tracker_ids_list_file);
                goto file_error;
        }
-       if (!atomic_long_add_unless(&session->file->f_count, 1, LONG_MAX)) {
+       if (!atomic_long_add_unless(&session->priv->file->f_count, 1, LONG_MAX)) {
                ret = -EOVERFLOW;
                goto refcount_error;
        }
@@ -1900,7 +1959,7 @@ int lttng_session_list_tracker_ids(struct lttng_session *session,
        return file_fd;
 
 open_error:
-       atomic_long_dec(&session->file->f_count);
+       atomic_long_dec(&session->priv->file->f_count);
 refcount_error:
        fput(tracker_ids_list_file);
 file_error:
@@ -1932,7 +1991,7 @@ int lttng_match_enabler_name(const char *desc_name,
 }
 
 int lttng_desc_match_enabler(const struct lttng_kernel_event_desc *desc,
-               struct lttng_enabler *enabler)
+               struct lttng_event_enabler_common *enabler)
 {
        const char *desc_name, *enabler_name;
        bool compat = false, entry = false;
@@ -2021,10 +2080,10 @@ int lttng_desc_match_enabler(const struct lttng_kernel_event_desc *desc,
 }
 
 static
-int lttng_event_enabler_match_event(struct lttng_event_enabler *event_enabler,
+int lttng_event_enabler_match_event(struct lttng_event_recorder_enabler *event_enabler,
                struct lttng_kernel_event_recorder *event_recorder)
 {
-       struct lttng_enabler *base_enabler = lttng_event_enabler_as_enabler(
+       struct lttng_event_enabler_common *base_enabler = lttng_event_recorder_enabler_as_enabler(
                event_enabler);
 
        if (base_enabler->event_param.instrumentation != event_recorder->priv->parent.instrumentation)
@@ -2040,14 +2099,14 @@ static
 int lttng_event_notifier_enabler_match_event_notifier(struct lttng_event_notifier_enabler *event_notifier_enabler,
                struct lttng_kernel_event_notifier *event_notifier)
 {
-       struct lttng_enabler *base_enabler = lttng_event_notifier_enabler_as_enabler(
+       struct lttng_event_enabler_common *base_enabler = lttng_event_notifier_enabler_as_enabler(
                event_notifier_enabler);
 
        if (base_enabler->event_param.instrumentation != event_notifier->priv->parent.instrumentation)
                return 0;
        if (lttng_desc_match_enabler(event_notifier->priv->parent.desc, base_enabler)
                        && event_notifier->priv->group == event_notifier_enabler->group
-                       && event_notifier->priv->parent.user_token == event_notifier_enabler->base.user_token)
+                       && event_notifier->priv->parent.user_token == event_notifier_enabler->parent.user_token)
                return 1;
        else
                return 0;
@@ -2056,7 +2115,7 @@ int lttng_event_notifier_enabler_match_event_notifier(struct lttng_event_notifie
 static
 struct lttng_enabler_ref *lttng_enabler_ref(
                struct list_head *enablers_ref_list,
-               struct lttng_enabler *enabler)
+               struct lttng_event_enabler_common *enabler)
 {
        struct lttng_enabler_ref *enabler_ref;
 
@@ -2068,9 +2127,9 @@ struct lttng_enabler_ref *lttng_enabler_ref(
 }
 
 static
-void lttng_create_tracepoint_event_if_missing(struct lttng_event_enabler *event_enabler)
+void lttng_create_tracepoint_event_if_missing(struct lttng_event_recorder_enabler *event_enabler)
 {
-       struct lttng_session *session = event_enabler->chan->session;
+       struct lttng_kernel_session *session = event_enabler->chan->parent.session;
        struct lttng_kernel_probe_desc *probe_desc;
        const struct lttng_kernel_event_desc *desc;
        int i;
@@ -2091,14 +2150,14 @@ void lttng_create_tracepoint_event_if_missing(struct lttng_event_enabler *event_
 
                        desc = probe_desc->event_desc[i];
                        if (!lttng_desc_match_enabler(desc,
-                                       lttng_event_enabler_as_enabler(event_enabler)))
+                                       lttng_event_recorder_enabler_as_enabler(event_enabler)))
                                continue;
 
                        /*
                         * Check if already created.
                         */
                        head = utils_borrow_hash_table_bucket(
-                               session->events_ht.table, LTTNG_EVENT_HT_SIZE,
+                               session->priv->events_ht.table, LTTNG_EVENT_HT_SIZE,
                                desc->event_name);
                        lttng_hlist_for_each_entry(event_recorder_private, head, hlist) {
                                if (event_recorder_private->parent.desc == desc
@@ -2112,8 +2171,7 @@ void lttng_create_tracepoint_event_if_missing(struct lttng_event_enabler *event_
                         * We need to create an event for this
                         * event probe.
                         */
-                       event_recorder = _lttng_kernel_event_recorder_create(event_enabler->chan,
-                                       NULL, desc, LTTNG_KERNEL_ABI_TRACEPOINT);
+                       event_recorder = _lttng_kernel_event_recorder_create(event_enabler, desc);
                        if (!event_recorder) {
                                printk(KERN_INFO "LTTng: Unable to create event %s\n",
                                        probe_desc->event_desc[i]->event_name);
@@ -2157,7 +2215,7 @@ void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifi
                                LTTNG_EVENT_NOTIFIER_HT_SIZE, desc->event_name);
                        lttng_hlist_for_each_entry(event_notifier_priv, head, hlist) {
                                if (event_notifier_priv->parent.desc == desc
-                                               && event_notifier_priv->parent.user_token == event_notifier_enabler->base.user_token)
+                                               && event_notifier_priv->parent.user_token == event_notifier_enabler->parent.user_token)
                                        found = 1;
                        }
                        if (found)
@@ -2167,7 +2225,7 @@ void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifi
                         * We need to create a event_notifier for this event probe.
                         */
                        event_notifier = _lttng_event_notifier_create(desc,
-                               event_notifier_enabler->base.user_token,
+                               event_notifier_enabler->parent.user_token,
                                event_notifier_enabler->error_counter_index,
                                event_notifier_group, NULL,
                                LTTNG_KERNEL_ABI_TRACEPOINT);
@@ -2180,11 +2238,11 @@ void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifi
 }
 
 static
-void lttng_create_syscall_event_if_missing(struct lttng_event_enabler *event_enabler)
+void lttng_create_syscall_event_if_missing(struct lttng_event_recorder_enabler *event_enabler)
 {
        int ret;
 
-       ret = lttng_syscalls_register_event(event_enabler);
+       ret = lttng_syscalls_register_event(&event_enabler->parent);
        WARN_ON_ONCE(ret);
 }
 
@@ -2193,7 +2251,7 @@ void lttng_create_syscall_event_notifier_if_missing(struct lttng_event_notifier_
 {
        int ret;
 
-       ret = lttng_syscalls_register_event_notifier(event_notifier_enabler);
+       ret = lttng_syscalls_register_event(&event_notifier_enabler->parent);
        WARN_ON_ONCE(ret);
        ret = lttng_syscalls_create_matching_event_notifiers(event_notifier_enabler);
        WARN_ON_ONCE(ret);
@@ -2205,9 +2263,9 @@ void lttng_create_syscall_event_notifier_if_missing(struct lttng_event_notifier_
  * Should be called with sessions mutex held.
  */
 static
-void lttng_create_event_if_missing(struct lttng_event_enabler *event_enabler)
+void lttng_create_event_if_missing(struct lttng_event_recorder_enabler *event_enabler)
 {
-       switch (event_enabler->base.event_param.instrumentation) {
+       switch (event_enabler->parent.event_param.instrumentation) {
        case LTTNG_KERNEL_ABI_TRACEPOINT:
                lttng_create_tracepoint_event_if_missing(event_enabler);
                break;
@@ -2228,11 +2286,11 @@ void lttng_create_event_if_missing(struct lttng_event_enabler *event_enabler)
  * Should be called with sessions mutex held.
  */
 static
-int lttng_event_enabler_ref_events(struct lttng_event_enabler *event_enabler)
+int lttng_event_enabler_ref_events(struct lttng_event_recorder_enabler *event_enabler)
 {
-       struct lttng_channel *chan = event_enabler->chan;
-       struct lttng_session *session = event_enabler->chan->session;
-       struct lttng_enabler *base_enabler = lttng_event_enabler_as_enabler(event_enabler);
+       struct lttng_kernel_channel_buffer *chan = event_enabler->chan;
+       struct lttng_kernel_session *session = event_enabler->chan->parent.session;
+       struct lttng_event_enabler_common *base_enabler = lttng_event_recorder_enabler_as_enabler(event_enabler);
        struct lttng_kernel_event_recorder_private *event_recorder_priv;
 
        if (base_enabler->event_param.instrumentation == LTTNG_KERNEL_ABI_SYSCALL &&
@@ -2243,24 +2301,24 @@ int lttng_event_enabler_ref_events(struct lttng_event_enabler *event_enabler)
                enum lttng_kernel_abi_syscall_entryexit entryexit = base_enabler->event_param.u.syscall.entryexit;
 
                if (entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRY || entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT)
-                       WRITE_ONCE(chan->syscall_all_entry, enabled);
+                       WRITE_ONCE(chan->priv->parent.syscall_table.syscall_all_entry, enabled);
 
                if (entryexit == LTTNG_KERNEL_ABI_SYSCALL_EXIT || entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT)
-                       WRITE_ONCE(chan->syscall_all_exit, enabled);
+                       WRITE_ONCE(chan->priv->parent.syscall_table.syscall_all_exit, enabled);
        }
 
        /* First ensure that probe events are created for this enabler. */
        lttng_create_event_if_missing(event_enabler);
 
        /* For each event matching event_enabler in session event list. */
-       list_for_each_entry(event_recorder_priv, &session->events, node) {
+       list_for_each_entry(event_recorder_priv, &session->priv->events, node) {
                struct lttng_kernel_event_recorder *event_recorder = event_recorder_priv->pub;
                struct lttng_enabler_ref *enabler_ref;
 
                if (!lttng_event_enabler_match_event(event_enabler, event_recorder))
                        continue;
                enabler_ref = lttng_enabler_ref(&event_recorder_priv->parent.enablers_ref_head,
-                       lttng_event_enabler_as_enabler(event_enabler));
+                       lttng_event_recorder_enabler_as_enabler(event_enabler));
                if (!enabler_ref) {
                        /*
                         * If no backward ref, create it.
@@ -2269,7 +2327,7 @@ int lttng_event_enabler_ref_events(struct lttng_event_enabler *event_enabler)
                        enabler_ref = kzalloc(sizeof(*enabler_ref), GFP_KERNEL);
                        if (!enabler_ref)
                                return -ENOMEM;
-                       enabler_ref->ref = lttng_event_enabler_as_enabler(event_enabler);
+                       enabler_ref->ref = lttng_event_recorder_enabler_as_enabler(event_enabler);
                        list_add(&enabler_ref->node,
                                &event_recorder_priv->parent.enablers_ref_head);
                }
@@ -2280,7 +2338,7 @@ int lttng_event_enabler_ref_events(struct lttng_event_enabler *event_enabler)
                lttng_enabler_link_bytecode(event_recorder_priv->parent.desc,
                        lttng_static_ctx,
                        &event_recorder_priv->parent.filter_bytecode_runtime_head,
-                       &lttng_event_enabler_as_enabler(event_enabler)->filter_bytecode_head);
+                       &lttng_event_recorder_enabler_as_enabler(event_enabler)->filter_bytecode_head);
        }
        return 0;
 }
@@ -2293,7 +2351,7 @@ int lttng_event_enabler_ref_events(struct lttng_event_enabler *event_enabler)
 static
 void lttng_create_event_notifier_if_missing(struct lttng_event_notifier_enabler *event_notifier_enabler)
 {
-       switch (event_notifier_enabler->base.event_param.instrumentation) {
+       switch (event_notifier_enabler->parent.event_param.instrumentation) {
        case LTTNG_KERNEL_ABI_TRACEPOINT:
                lttng_create_tracepoint_event_notifier_if_missing(event_notifier_enabler);
                break;
@@ -2316,7 +2374,7 @@ int lttng_event_notifier_enabler_ref_event_notifiers(
                struct lttng_event_notifier_enabler *event_notifier_enabler)
 {
        struct lttng_event_notifier_group *event_notifier_group = event_notifier_enabler->group;
-       struct lttng_enabler *base_enabler = lttng_event_notifier_enabler_as_enabler(event_notifier_enabler);
+       struct lttng_event_enabler_common *base_enabler = lttng_event_notifier_enabler_as_enabler(event_notifier_enabler);
        struct lttng_kernel_event_notifier_private *event_notifier_priv;
 
        if (base_enabler->event_param.instrumentation == LTTNG_KERNEL_ABI_SYSCALL &&
@@ -2328,10 +2386,10 @@ int lttng_event_notifier_enabler_ref_event_notifiers(
                enum lttng_kernel_abi_syscall_entryexit entryexit = base_enabler->event_param.u.syscall.entryexit;
 
                if (entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRY || entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT)
-                       WRITE_ONCE(event_notifier_group->syscall_all_entry, enabled);
+                       WRITE_ONCE(event_notifier_group->syscall_table.syscall_all_entry, enabled);
 
                if (entryexit == LTTNG_KERNEL_ABI_SYSCALL_EXIT || entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT)
-                       WRITE_ONCE(event_notifier_group->syscall_all_exit, enabled);
+                       WRITE_ONCE(event_notifier_group->syscall_table.syscall_all_exit, enabled);
 
        }
 
@@ -2387,10 +2445,10 @@ int lttng_event_notifier_enabler_ref_event_notifiers(
  */
 int lttng_fix_pending_events(void)
 {
-       struct lttng_session *session;
+       struct lttng_kernel_session_private *session_priv;
 
-       list_for_each_entry(session, &sessions, list)
-               lttng_session_lazy_sync_event_enablers(session);
+       list_for_each_entry(session_priv, &sessions, list)
+               lttng_session_lazy_sync_event_enablers(session_priv->pub);
        return 0;
 }
 
@@ -2401,7 +2459,7 @@ static bool lttng_event_notifier_group_has_active_event_notifiers(
 
        list_for_each_entry(event_notifier_enabler, &event_notifier_group->enablers_head,
                        node) {
-               if (event_notifier_enabler->base.enabled)
+               if (event_notifier_enabler->parent.enabled)
                        return true;
        }
        return false;
@@ -2427,53 +2485,60 @@ int lttng_fix_pending_event_notifiers(void)
        return 0;
 }
 
-struct lttng_event_enabler *lttng_event_enabler_create(
+struct lttng_event_recorder_enabler *lttng_event_recorder_enabler_create(
                enum lttng_enabler_format_type format_type,
                struct lttng_kernel_abi_event *event_param,
-               struct lttng_channel *chan)
+               struct lttng_kernel_channel_buffer *chan)
 {
-       struct lttng_event_enabler *event_enabler;
+       struct lttng_event_recorder_enabler *event_enabler;
 
        event_enabler = kzalloc(sizeof(*event_enabler), GFP_KERNEL);
        if (!event_enabler)
                return NULL;
-       event_enabler->base.format_type = format_type;
-       INIT_LIST_HEAD(&event_enabler->base.filter_bytecode_head);
-       memcpy(&event_enabler->base.event_param, event_param,
-               sizeof(event_enabler->base.event_param));
+       event_enabler->parent.enabler_type = LTTNG_EVENT_ENABLER_TYPE_RECORDER;
+       event_enabler->parent.format_type = format_type;
+       INIT_LIST_HEAD(&event_enabler->parent.filter_bytecode_head);
+       memcpy(&event_enabler->parent.event_param, event_param,
+               sizeof(event_enabler->parent.event_param));
        event_enabler->chan = chan;
        /* ctx left NULL */
-       event_enabler->base.enabled = 0;
+       event_enabler->parent.enabled = 0;
+       return event_enabler;
+}
+
+void lttng_event_enabler_session_add(struct lttng_kernel_session *session,
+               struct lttng_event_recorder_enabler *event_enabler)
+{
        mutex_lock(&sessions_mutex);
-       list_add(&event_enabler->node, &event_enabler->chan->session->enablers_head);
-       lttng_session_lazy_sync_event_enablers(event_enabler->chan->session);
+       list_add(&event_enabler->node, &session->priv->enablers_head);
+       event_enabler->published = true;
+       lttng_session_lazy_sync_event_enablers(session);
        mutex_unlock(&sessions_mutex);
-       return event_enabler;
 }
 
-int lttng_event_enabler_enable(struct lttng_event_enabler *event_enabler)
+int lttng_event_enabler_enable(struct lttng_event_enabler_common *event_enabler)
 {
        mutex_lock(&sessions_mutex);
-       lttng_event_enabler_as_enabler(event_enabler)->enabled = 1;
-       lttng_session_lazy_sync_event_enablers(event_enabler->chan->session);
+       event_enabler->enabled = 1;
+       lttng_event_enabler_sync(event_enabler);
        mutex_unlock(&sessions_mutex);
        return 0;
 }
 
-int lttng_event_enabler_disable(struct lttng_event_enabler *event_enabler)
+int lttng_event_enabler_disable(struct lttng_event_enabler_common *event_enabler)
 {
        mutex_lock(&sessions_mutex);
-       lttng_event_enabler_as_enabler(event_enabler)->enabled = 0;
-       lttng_session_lazy_sync_event_enablers(event_enabler->chan->session);
+       event_enabler->enabled = 0;
+       lttng_event_enabler_sync(event_enabler);
        mutex_unlock(&sessions_mutex);
        return 0;
 }
 
 static
-int lttng_enabler_attach_filter_bytecode(struct lttng_enabler *enabler,
+int lttng_enabler_attach_filter_bytecode(struct lttng_event_enabler_common *enabler,
                struct lttng_kernel_abi_filter_bytecode __user *bytecode)
 {
-       struct lttng_bytecode_node *bytecode_node;
+       struct lttng_kernel_bytecode_node *bytecode_node;
        uint32_t bytecode_len;
        int ret;
 
@@ -2489,7 +2554,7 @@ int lttng_enabler_attach_filter_bytecode(struct lttng_enabler *enabler,
        if (ret)
                goto error_free;
 
-       bytecode_node->type = LTTNG_BYTECODE_NODE_TYPE_FILTER;
+       bytecode_node->type = LTTNG_KERNEL_BYTECODE_TYPE_FILTER;
        bytecode_node->enabler = enabler;
        /* Enforce length based on allocated size */
        bytecode_node->bc.len = bytecode_len;
@@ -2502,16 +2567,14 @@ error_free:
        return ret;
 }
 
-int lttng_event_enabler_attach_filter_bytecode(struct lttng_event_enabler *event_enabler,
+int lttng_event_enabler_attach_filter_bytecode(struct lttng_event_enabler_common *event_enabler,
                struct lttng_kernel_abi_filter_bytecode __user *bytecode)
 {
        int ret;
-       ret = lttng_enabler_attach_filter_bytecode(
-               lttng_event_enabler_as_enabler(event_enabler), bytecode);
+       ret = lttng_enabler_attach_filter_bytecode(event_enabler, bytecode);
        if (ret)
                goto error;
-
-       lttng_session_lazy_sync_event_enablers(event_enabler->chan->session);
+       lttng_event_enabler_sync(event_enabler);
        return 0;
 
 error:
@@ -2531,9 +2594,9 @@ int lttng_event_add_callsite(struct lttng_kernel_event_common *event,
 }
 
 static
-void lttng_enabler_destroy(struct lttng_enabler *enabler)
+void lttng_enabler_destroy(struct lttng_event_enabler_common *enabler)
 {
-       struct lttng_bytecode_node *filter_node, *tmp_filter_node;
+       struct lttng_kernel_bytecode_node *filter_node, *tmp_filter_node;
 
        /* Destroy filter bytecode */
        list_for_each_entry_safe(filter_node, tmp_filter_node,
@@ -2542,13 +2605,33 @@ void lttng_enabler_destroy(struct lttng_enabler *enabler)
        }
 }
 
-static
-void lttng_event_enabler_destroy(struct lttng_event_enabler *event_enabler)
+void lttng_event_enabler_destroy(struct lttng_event_enabler_common *event_enabler)
 {
-       lttng_enabler_destroy(lttng_event_enabler_as_enabler(event_enabler));
+       switch (event_enabler->enabler_type) {
+       case LTTNG_EVENT_ENABLER_TYPE_RECORDER:
+       {
+               struct lttng_event_recorder_enabler *event_recorder_enabler =
+                       container_of(event_enabler, struct lttng_event_recorder_enabler, parent);
+
+               lttng_enabler_destroy(event_enabler);
+               if (event_recorder_enabler->published)
+                       list_del(&event_recorder_enabler->node);
+               kfree(event_recorder_enabler);
+               break;
+       }
+       case LTTNG_EVENT_ENABLER_TYPE_NOTIFIER:
+       {
+               struct lttng_event_notifier_enabler *event_notifier_enabler =
+                       container_of(event_enabler, struct lttng_event_notifier_enabler, parent);
 
-       list_del(&event_enabler->node);
-       kfree(event_enabler);
+               list_del(&event_notifier_enabler->node);
+               lttng_enabler_destroy(event_enabler);
+               kfree(event_notifier_enabler);
+               break;
+       }
+       default:
+               WARN_ON_ONCE(1);
+       }
 }
 
 struct lttng_event_notifier_enabler *lttng_event_notifier_enabler_create(
@@ -2562,18 +2645,19 @@ struct lttng_event_notifier_enabler *lttng_event_notifier_enabler_create(
        if (!event_notifier_enabler)
                return NULL;
 
-       event_notifier_enabler->base.format_type = format_type;
-       INIT_LIST_HEAD(&event_notifier_enabler->base.filter_bytecode_head);
+       event_notifier_enabler->parent.enabler_type = LTTNG_EVENT_ENABLER_TYPE_NOTIFIER;
+       event_notifier_enabler->parent.format_type = format_type;
+       INIT_LIST_HEAD(&event_notifier_enabler->parent.filter_bytecode_head);
        INIT_LIST_HEAD(&event_notifier_enabler->capture_bytecode_head);
 
        event_notifier_enabler->error_counter_index = event_notifier_param->error_counter_index;
        event_notifier_enabler->num_captures = 0;
 
-       memcpy(&event_notifier_enabler->base.event_param, &event_notifier_param->event,
-               sizeof(event_notifier_enabler->base.event_param));
+       memcpy(&event_notifier_enabler->parent.event_param, &event_notifier_param->event,
+               sizeof(event_notifier_enabler->parent.event_param));
 
-       event_notifier_enabler->base.enabled = 0;
-       event_notifier_enabler->base.user_token = event_notifier_param->event.token;
+       event_notifier_enabler->parent.enabled = 0;
+       event_notifier_enabler->parent.user_token = event_notifier_param->event.token;
        event_notifier_enabler->group = event_notifier_group;
 
        mutex_lock(&sessions_mutex);
@@ -2605,31 +2689,12 @@ int lttng_event_notifier_enabler_disable(
        return 0;
 }
 
-int lttng_event_notifier_enabler_attach_filter_bytecode(
-               struct lttng_event_notifier_enabler *event_notifier_enabler,
-               struct lttng_kernel_abi_filter_bytecode __user *bytecode)
-{
-       int ret;
-
-       ret = lttng_enabler_attach_filter_bytecode(
-               lttng_event_notifier_enabler_as_enabler(event_notifier_enabler),
-               bytecode);
-       if (ret)
-               goto error;
-
-       lttng_event_notifier_group_sync_enablers(event_notifier_enabler->group);
-       return 0;
-
-error:
-       return ret;
-}
-
 int lttng_event_notifier_enabler_attach_capture_bytecode(
                struct lttng_event_notifier_enabler *event_notifier_enabler,
                struct lttng_kernel_abi_capture_bytecode __user *bytecode)
 {
-       struct lttng_bytecode_node *bytecode_node;
-       struct lttng_enabler *enabler =
+       struct lttng_kernel_bytecode_node *bytecode_node;
+       struct lttng_event_enabler_common *enabler =
                        lttng_event_notifier_enabler_as_enabler(event_notifier_enabler);
        uint32_t bytecode_len;
        int ret;
@@ -2648,7 +2713,7 @@ int lttng_event_notifier_enabler_attach_capture_bytecode(
        if (ret)
                goto error_free;
 
-       bytecode_node->type = LTTNG_BYTECODE_NODE_TYPE_CAPTURE;
+       bytecode_node->type = LTTNG_KERNEL_BYTECODE_TYPE_CAPTURE;
        bytecode_node->enabler = enabler;
 
        /* Enforce length based on allocated size */
@@ -2666,47 +2731,34 @@ end:
        return ret;
 }
 
-static
-void lttng_event_notifier_enabler_destroy(
-               struct lttng_event_notifier_enabler *event_notifier_enabler)
-{
-       if (!event_notifier_enabler) {
-               return;
-       }
-
-       list_del(&event_notifier_enabler->node);
-
-       lttng_enabler_destroy(lttng_event_notifier_enabler_as_enabler(event_notifier_enabler));
-       kfree(event_notifier_enabler);
-}
-
 /*
  * lttng_session_sync_event_enablers should be called just before starting a
  * session.
  * Should be called with sessions mutex held.
  */
 static
-void lttng_session_sync_event_enablers(struct lttng_session *session)
+void lttng_session_sync_event_enablers(struct lttng_kernel_session *session)
 {
-       struct lttng_event_enabler *event_enabler;
+       struct lttng_event_recorder_enabler *event_enabler;
        struct lttng_kernel_event_recorder_private *event_recorder_priv;
 
-       list_for_each_entry(event_enabler, &session->enablers_head, node)
+       list_for_each_entry(event_enabler, &session->priv->enablers_head, node)
                lttng_event_enabler_ref_events(event_enabler);
        /*
         * For each event, if at least one of its enablers is enabled,
         * and its channel and session transient states are enabled, we
         * enable the event, else we disable it.
         */
-       list_for_each_entry(event_recorder_priv, &session->events, node) {
+       list_for_each_entry(event_recorder_priv, &session->priv->events, node) {
                struct lttng_kernel_event_recorder *event_recorder = event_recorder_priv->pub;
                struct lttng_enabler_ref *enabler_ref;
-               struct lttng_bytecode_runtime *runtime;
+               struct lttng_kernel_bytecode_runtime *runtime;
                int enabled = 0, has_enablers_without_filter_bytecode = 0;
                int nr_filters = 0;
 
                switch (event_recorder_priv->parent.instrumentation) {
-               case LTTNG_KERNEL_ABI_TRACEPOINT:       /* Fall-through */
+               case LTTNG_KERNEL_ABI_TRACEPOINT:
+                       lttng_fallthrough;
                case LTTNG_KERNEL_ABI_SYSCALL:
                        /* Enable events */
                        list_for_each_entry(enabler_ref,
@@ -2727,7 +2779,7 @@ void lttng_session_sync_event_enablers(struct lttng_session *session)
                 * intesection of session and channel transient enable
                 * states.
                 */
-               enabled = enabled && session->tstate && event_recorder->chan->tstate;
+               enabled = enabled && session->priv->tstate && event_recorder->chan->priv->parent.tstate;
 
                WRITE_ONCE(event_recorder->parent.enabled, enabled);
                /*
@@ -2735,9 +2787,9 @@ void lttng_session_sync_event_enablers(struct lttng_session *session)
                 * state.
                 */
                if (enabled) {
-                       register_event(event_recorder);
+                       register_event_recorder(event_recorder);
                } else {
-                       _lttng_event_unregister(event_recorder);
+                       _lttng_event_recorder_unregister(event_recorder);
                }
 
                /* Check if has enablers without bytecode enabled */
@@ -2755,7 +2807,7 @@ void lttng_session_sync_event_enablers(struct lttng_session *session)
                /* Enable filters */
                list_for_each_entry(runtime,
                                &event_recorder_priv->parent.filter_bytecode_runtime_head, node) {
-                       lttng_bytecode_filter_sync_state(runtime);
+                       lttng_bytecode_sync_state(runtime);
                        nr_filters++;
                }
                WRITE_ONCE(event_recorder_priv->parent.pub->eval_filter,
@@ -2771,7 +2823,7 @@ void lttng_session_sync_event_enablers(struct lttng_session *session)
  * Should be called with sessions mutex held.
  */
 static
-void lttng_session_lazy_sync_event_enablers(struct lttng_session *session)
+void lttng_session_lazy_sync_event_enablers(struct lttng_kernel_session *session)
 {
        /* We can skip if session is not active */
        if (!session->active)
@@ -2795,12 +2847,13 @@ void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group
        list_for_each_entry(event_notifier_priv, &event_notifier_group->event_notifiers_head, node) {
                struct lttng_kernel_event_notifier *event_notifier = event_notifier_priv->pub;
                struct lttng_enabler_ref *enabler_ref;
-               struct lttng_bytecode_runtime *runtime;
+               struct lttng_kernel_bytecode_runtime *runtime;
                int enabled = 0, has_enablers_without_filter_bytecode = 0;
                int nr_filters = 0, nr_captures = 0;
 
                switch (event_notifier_priv->parent.instrumentation) {
-               case LTTNG_KERNEL_ABI_TRACEPOINT:       /* Fall-through */
+               case LTTNG_KERNEL_ABI_TRACEPOINT:
+                       lttng_fallthrough;
                case LTTNG_KERNEL_ABI_SYSCALL:
                        /* Enable event_notifiers */
                        list_for_each_entry(enabler_ref,
@@ -2845,7 +2898,7 @@ void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group
                /* Enable filters */
                list_for_each_entry(runtime,
                                &event_notifier_priv->parent.filter_bytecode_runtime_head, node) {
-                       lttng_bytecode_filter_sync_state(runtime);
+                       lttng_bytecode_sync_state(runtime);
                        nr_filters++;
                }
                WRITE_ONCE(event_notifier_priv->parent.pub->eval_filter,
@@ -2854,13 +2907,36 @@ void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group
                /* Enable captures */
                list_for_each_entry(runtime,
                                &event_notifier_priv->capture_bytecode_runtime_head, node) {
-                       lttng_bytecode_capture_sync_state(runtime);
+                       lttng_bytecode_sync_state(runtime);
                        nr_captures++;
                }
                WRITE_ONCE(event_notifier->eval_capture, !!nr_captures);
        }
 }
 
+static
+void lttng_event_enabler_sync(struct lttng_event_enabler_common *event_enabler)
+{
+       switch (event_enabler->enabler_type) {
+       case LTTNG_EVENT_ENABLER_TYPE_RECORDER:
+       {
+               struct lttng_event_recorder_enabler *event_recorder_enabler =
+                       container_of(event_enabler, struct lttng_event_recorder_enabler, parent);
+               lttng_session_lazy_sync_event_enablers(event_recorder_enabler->chan->parent.session);
+               break;
+       }
+       case LTTNG_EVENT_ENABLER_TYPE_NOTIFIER:
+       {
+               struct lttng_event_notifier_enabler *event_notifier_enabler =
+                       container_of(event_enabler, struct lttng_event_notifier_enabler, parent);
+               lttng_event_notifier_group_sync_enablers(event_notifier_enabler->group);
+               break;
+       }
+       default:
+               WARN_ON_ONCE(1);
+       }
+}
+
 /*
  * Serialize at most one packet worth of metadata into a metadata
  * channel.
@@ -2874,9 +2950,9 @@ void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group
  * was written and a negative value on error.
  */
 int lttng_metadata_output_channel(struct lttng_metadata_stream *stream,
-               struct channel *chan, bool *coherent)
+               struct lttng_kernel_ring_buffer_channel *chan, bool *coherent)
 {
-       struct lib_ring_buffer_ctx ctx;
+       struct lttng_kernel_ring_buffer_ctx ctx;
        int ret = 0;
        size_t len, reserve_len;
 
@@ -2903,14 +2979,14 @@ int lttng_metadata_output_channel(struct lttng_metadata_stream *stream,
        if (!len)
                goto end;
        reserve_len = min_t(size_t,
-                       stream->transport->ops.packet_avail_size(chan),
+                       stream->transport->ops.priv->packet_avail_size(chan),
                        len);
-       lib_ring_buffer_ctx_init(&ctx, chan, NULL, reserve_len,
-                       sizeof(char), -1);
+       lib_ring_buffer_ctx_init(&ctx, chan, reserve_len,
+                       sizeof(char), NULL);
        /*
         * If reservation failed, return an error to the caller.
         */
-       ret = stream->transport->ops.event_reserve(&ctx, 0);
+       ret = stream->transport->ops.event_reserve(&ctx);
        if (ret != 0) {
                printk(KERN_WARNING "LTTng: Metadata event reservation failed\n");
                stream->coherent = false;
@@ -2918,7 +2994,7 @@ int lttng_metadata_output_channel(struct lttng_metadata_stream *stream,
        }
        stream->transport->ops.event_write(&ctx,
                        stream->metadata_cache->data + stream->metadata_in,
-                       reserve_len);
+                       reserve_len, 1);
        stream->transport->ops.event_commit(&ctx);
        stream->metadata_in += reserve_len;
        if (reserve_len < len)
@@ -2935,22 +3011,22 @@ end:
 }
 
 static
-void lttng_metadata_begin(struct lttng_session *session)
+void lttng_metadata_begin(struct lttng_kernel_session *session)
 {
-       if (atomic_inc_return(&session->metadata_cache->producing) == 1)
-               mutex_lock(&session->metadata_cache->lock);
+       if (atomic_inc_return(&session->priv->metadata_cache->producing) == 1)
+               mutex_lock(&session->priv->metadata_cache->lock);
 }
 
 static
-void lttng_metadata_end(struct lttng_session *session)
+void lttng_metadata_end(struct lttng_kernel_session *session)
 {
-       WARN_ON_ONCE(!atomic_read(&session->metadata_cache->producing));
-       if (atomic_dec_return(&session->metadata_cache->producing) == 0) {
+       WARN_ON_ONCE(!atomic_read(&session->priv->metadata_cache->producing));
+       if (atomic_dec_return(&session->priv->metadata_cache->producing) == 0) {
                struct lttng_metadata_stream *stream;
 
-               list_for_each_entry(stream, &session->metadata_cache->metadata_stream, list)
+               list_for_each_entry(stream, &session->priv->metadata_cache->metadata_stream, list)
                        wake_up_interruptible(&stream->read_wait);
-               mutex_unlock(&session->metadata_cache->lock);
+               mutex_unlock(&session->priv->metadata_cache->lock);
        }
 }
 
@@ -2962,7 +3038,7 @@ void lttng_metadata_end(struct lttng_session *session)
  * The content of the printf is printed as a single atomic metadata
  * transaction.
  */
-int lttng_metadata_printf(struct lttng_session *session,
+int lttng_metadata_printf(struct lttng_kernel_session *session,
                          const char *fmt, ...)
 {
        char *str;
@@ -2978,32 +3054,32 @@ int lttng_metadata_printf(struct lttng_session *session,
                return -ENOMEM;
 
        len = strlen(str);
-       WARN_ON_ONCE(!atomic_read(&session->metadata_cache->producing));
-       if (session->metadata_cache->metadata_written + len >
-                       session->metadata_cache->cache_alloc) {
+       WARN_ON_ONCE(!atomic_read(&session->priv->metadata_cache->producing));
+       if (session->priv->metadata_cache->metadata_written + len >
+                       session->priv->metadata_cache->cache_alloc) {
                char *tmp_cache_realloc;
                unsigned int tmp_cache_alloc_size;
 
                tmp_cache_alloc_size = max_t(unsigned int,
-                               session->metadata_cache->cache_alloc + len,
-                               session->metadata_cache->cache_alloc << 1);
+                               session->priv->metadata_cache->cache_alloc + len,
+                               session->priv->metadata_cache->cache_alloc << 1);
                tmp_cache_realloc = vzalloc(tmp_cache_alloc_size);
                if (!tmp_cache_realloc)
                        goto err;
-               if (session->metadata_cache->data) {
+               if (session->priv->metadata_cache->data) {
                        memcpy(tmp_cache_realloc,
-                               session->metadata_cache->data,
-                               session->metadata_cache->cache_alloc);
-                       vfree(session->metadata_cache->data);
+                               session->priv->metadata_cache->data,
+                               session->priv->metadata_cache->cache_alloc);
+                       vfree(session->priv->metadata_cache->data);
                }
 
-               session->metadata_cache->cache_alloc = tmp_cache_alloc_size;
-               session->metadata_cache->data = tmp_cache_realloc;
+               session->priv->metadata_cache->cache_alloc = tmp_cache_alloc_size;
+               session->priv->metadata_cache->data = tmp_cache_realloc;
        }
-       memcpy(session->metadata_cache->data +
-                       session->metadata_cache->metadata_written,
+       memcpy(session->priv->metadata_cache->data +
+                       session->priv->metadata_cache->metadata_written,
                        str, len);
-       session->metadata_cache->metadata_written += len;
+       session->priv->metadata_cache->metadata_written += len;
        kfree(str);
 
        return 0;
@@ -3014,7 +3090,7 @@ err:
 }
 
 static
-int print_tabs(struct lttng_session *session, size_t nesting)
+int print_tabs(struct lttng_kernel_session *session, size_t nesting)
 {
        size_t i;
 
@@ -3030,7 +3106,7 @@ int print_tabs(struct lttng_session *session, size_t nesting)
 }
 
 static
-int lttng_field_name_statedump(struct lttng_session *session,
+int lttng_field_name_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
                size_t nesting)
 {
@@ -3038,7 +3114,7 @@ int lttng_field_name_statedump(struct lttng_session *session,
 }
 
 static
-int _lttng_integer_type_statedump(struct lttng_session *session,
+int _lttng_integer_type_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_type_integer *type,
                enum lttng_kernel_string_encoding parent_encoding,
                size_t nesting)
@@ -3072,10 +3148,11 @@ int _lttng_integer_type_statedump(struct lttng_session *session,
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_struct_type_statedump(struct lttng_session *session,
+int _lttng_struct_type_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_type_struct *type,
                size_t nesting)
 {
+       const char *prev_field_name = NULL;
        int ret;
        uint32_t i, nr_fields;
        unsigned int alignment;
@@ -3092,7 +3169,7 @@ int _lttng_struct_type_statedump(struct lttng_session *session,
                const struct lttng_kernel_event_field *iter_field;
 
                iter_field = type->fields[i];
-               ret = _lttng_field_statedump(session, iter_field, nesting + 1);
+               ret = _lttng_field_statedump(session, iter_field, nesting + 1, &prev_field_name);
                if (ret)
                        return ret;
        }
@@ -3115,7 +3192,7 @@ int _lttng_struct_type_statedump(struct lttng_session *session,
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_struct_field_statedump(struct lttng_session *session,
+int _lttng_struct_field_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
                size_t nesting)
 {
@@ -3132,13 +3209,20 @@ int _lttng_struct_field_statedump(struct lttng_session *session,
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_variant_type_statedump(struct lttng_session *session,
+int _lttng_variant_type_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_type_variant *type,
-               size_t nesting)
+               size_t nesting,
+               const char *prev_field_name)
 {
+       const char *tag_name;
        int ret;
        uint32_t i, nr_choices;
 
+       tag_name = type->tag_name;
+       if (!tag_name)
+               tag_name = prev_field_name;
+       if (!tag_name)
+               return -EINVAL;
        /*
         * CTF 1.8 does not allow expressing nonzero variant alignment in a nestable way.
         */
@@ -3149,7 +3233,7 @@ int _lttng_variant_type_statedump(struct lttng_session *session,
                return ret;
        ret = lttng_metadata_printf(session,
                "variant <_%s> {\n",
-               type->tag_name);
+               tag_name);
        if (ret)
                return ret;
        nr_choices = type->nr_choices;
@@ -3157,7 +3241,7 @@ int _lttng_variant_type_statedump(struct lttng_session *session,
                const struct lttng_kernel_event_field *iter_field;
 
                iter_field = type->choices[i];
-               ret = _lttng_field_statedump(session, iter_field, nesting + 1);
+               ret = _lttng_field_statedump(session, iter_field, nesting + 1, NULL);
                if (ret)
                        return ret;
        }
@@ -3173,14 +3257,16 @@ int _lttng_variant_type_statedump(struct lttng_session *session,
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_variant_field_statedump(struct lttng_session *session,
+int _lttng_variant_field_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
-               size_t nesting)
+               size_t nesting,
+               const char *prev_field_name)
 {
        int ret;
 
        ret = _lttng_variant_type_statedump(session,
-                       lttng_kernel_get_type_variant(field->type), nesting);
+                       lttng_kernel_get_type_variant(field->type), nesting,
+                       prev_field_name);
        if (ret)
                return ret;
        return lttng_field_name_statedump(session, field, nesting);
@@ -3190,7 +3276,7 @@ int _lttng_variant_field_statedump(struct lttng_session *session,
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_array_field_statedump(struct lttng_session *session,
+int _lttng_array_field_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
                size_t nesting)
 {
@@ -3241,9 +3327,10 @@ int _lttng_array_field_statedump(struct lttng_session *session,
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_sequence_field_statedump(struct lttng_session *session,
+int _lttng_sequence_field_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
-               size_t nesting)
+               size_t nesting,
+               const char *prev_field_name)
 {
        int ret;
        const char *length_name;
@@ -3254,6 +3341,10 @@ int _lttng_sequence_field_statedump(struct lttng_session *session,
        WARN_ON_ONCE(!sequence_type);
 
        length_name = sequence_type->length_name;
+       if (!length_name)
+               length_name = prev_field_name;
+       if (!length_name)
+               return -EINVAL;
 
        if (sequence_type->alignment) {
                ret = print_tabs(session, nesting);
@@ -3288,7 +3379,7 @@ int _lttng_sequence_field_statedump(struct lttng_session *session,
        ret = lttng_metadata_printf(session,
                " _%s[ _%s ];\n",
                field->name,
-               sequence_type->length_name);
+               length_name);
        return ret;
 }
 
@@ -3296,7 +3387,7 @@ int _lttng_sequence_field_statedump(struct lttng_session *session,
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_enum_type_statedump(struct lttng_session *session,
+int _lttng_enum_type_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_type_enum *type,
                size_t nesting)
 {
@@ -3413,7 +3504,7 @@ end:
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_enum_field_statedump(struct lttng_session *session,
+int _lttng_enum_field_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
                size_t nesting)
 {
@@ -3429,7 +3520,7 @@ int _lttng_enum_field_statedump(struct lttng_session *session,
 }
 
 static
-int _lttng_integer_field_statedump(struct lttng_session *session,
+int _lttng_integer_field_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
                size_t nesting)
 {
@@ -3443,7 +3534,7 @@ int _lttng_integer_field_statedump(struct lttng_session *session,
 }
 
 static
-int _lttng_string_type_statedump(struct lttng_session *session,
+int _lttng_string_type_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_type_string *type,
                size_t nesting)
 {
@@ -3461,7 +3552,7 @@ int _lttng_string_type_statedump(struct lttng_session *session,
 }
 
 static
-int _lttng_string_field_statedump(struct lttng_session *session,
+int _lttng_string_field_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
                size_t nesting)
 {
@@ -3480,7 +3571,7 @@ int _lttng_string_field_statedump(struct lttng_session *session,
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_type_statedump(struct lttng_session *session,
+int _lttng_type_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_type_common *type,
                enum lttng_kernel_string_encoding parent_encoding,
                size_t nesting)
@@ -3511,7 +3602,7 @@ int _lttng_type_statedump(struct lttng_session *session,
        case lttng_kernel_type_variant:
                ret = _lttng_variant_type_statedump(session,
                                lttng_kernel_get_type_variant(type),
-                               nesting);
+                               nesting, NULL);
                break;
 
        /* Nested arrays and sequences are not supported yet. */
@@ -3528,12 +3619,16 @@ int _lttng_type_statedump(struct lttng_session *session,
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_field_statedump(struct lttng_session *session,
+int _lttng_field_statedump(struct lttng_kernel_session *session,
                const struct lttng_kernel_event_field *field,
-               size_t nesting)
+               size_t nesting,
+               const char **prev_field_name_p)
 {
+       const char *prev_field_name = NULL;
        int ret = 0;
 
+       if (prev_field_name_p)
+               prev_field_name = *prev_field_name_p;
        switch (field->type->type) {
        case lttng_kernel_type_integer:
                ret = _lttng_integer_field_statedump(session, field, nesting);
@@ -3551,23 +3646,26 @@ int _lttng_field_statedump(struct lttng_session *session,
                ret = _lttng_array_field_statedump(session, field, nesting);
                break;
        case lttng_kernel_type_sequence:
-               ret = _lttng_sequence_field_statedump(session, field, nesting);
+               ret = _lttng_sequence_field_statedump(session, field, nesting, prev_field_name);
                break;
        case lttng_kernel_type_variant:
-               ret = _lttng_variant_field_statedump(session, field, nesting);
+               ret = _lttng_variant_field_statedump(session, field, nesting, prev_field_name);
                break;
 
        default:
                WARN_ON_ONCE(1);
                return -EINVAL;
        }
+       if (prev_field_name_p)
+               *prev_field_name_p = field->name;
        return ret;
 }
 
 static
-int _lttng_context_metadata_statedump(struct lttng_session *session,
+int _lttng_context_metadata_statedump(struct lttng_kernel_session *session,
                                    struct lttng_kernel_ctx *ctx)
 {
+       const char *prev_field_name = NULL;
        int ret = 0;
        int i;
 
@@ -3576,7 +3674,7 @@ int _lttng_context_metadata_statedump(struct lttng_session *session,
        for (i = 0; i < ctx->nr_fields; i++) {
                const struct lttng_kernel_ctx_field *field = &ctx->fields[i];
 
-               ret = _lttng_field_statedump(session, field->event_field, 2);
+               ret = _lttng_field_statedump(session, field->event_field, 2, &prev_field_name);
                if (ret)
                        return ret;
        }
@@ -3584,17 +3682,18 @@ int _lttng_context_metadata_statedump(struct lttng_session *session,
 }
 
 static
-int _lttng_fields_metadata_statedump(struct lttng_session *session,
+int _lttng_fields_metadata_statedump(struct lttng_kernel_session *session,
                                   struct lttng_kernel_event_recorder *event_recorder)
 {
+       const char *prev_field_name = NULL;
        const struct lttng_kernel_event_desc *desc = event_recorder->priv->parent.desc;
        int ret = 0;
        int i;
 
-       for (i = 0; i < desc->nr_fields; i++) {
-               const struct lttng_kernel_event_field *field = desc->fields[i];
+       for (i = 0; i < desc->tp_class->nr_fields; i++) {
+               const struct lttng_kernel_event_field *field = desc->tp_class->fields[i];
 
-               ret = _lttng_field_statedump(session, field, 2);
+               ret = _lttng_field_statedump(session, field, 2, &prev_field_name);
                if (ret)
                        return ret;
        }
@@ -3607,15 +3706,15 @@ int _lttng_fields_metadata_statedump(struct lttng_session *session,
  * transaction.
  */
 static
-int _lttng_event_metadata_statedump(struct lttng_session *session,
-                                 struct lttng_channel *chan,
+int _lttng_event_metadata_statedump(struct lttng_kernel_session *session,
+                                 struct lttng_kernel_channel_buffer *chan,
                                  struct lttng_kernel_event_recorder *event_recorder)
 {
        int ret = 0;
 
        if (event_recorder->priv->metadata_dumped || !LTTNG_READ_ONCE(session->active))
                return 0;
-       if (chan->channel_type == METADATA_CHANNEL)
+       if (chan->priv->channel_type == METADATA_CHANNEL)
                return 0;
 
        lttng_metadata_begin(session);
@@ -3627,7 +3726,7 @@ int _lttng_event_metadata_statedump(struct lttng_session *session,
                "       stream_id = %u;\n",
                event_recorder->priv->parent.desc->event_name,
                event_recorder->priv->id,
-               event_recorder->chan->id);
+               event_recorder->chan->priv->id);
        if (ret)
                goto end;
 
@@ -3664,41 +3763,41 @@ end:
  * transaction.
  */
 static
-int _lttng_channel_metadata_statedump(struct lttng_session *session,
-                                   struct lttng_channel *chan)
+int _lttng_channel_metadata_statedump(struct lttng_kernel_session *session,
+                                   struct lttng_kernel_channel_buffer *chan)
 {
        int ret = 0;
 
-       if (chan->metadata_dumped || !LTTNG_READ_ONCE(session->active))
+       if (chan->priv->metadata_dumped || !LTTNG_READ_ONCE(session->active))
                return 0;
 
-       if (chan->channel_type == METADATA_CHANNEL)
+       if (chan->priv->channel_type == METADATA_CHANNEL)
                return 0;
 
        lttng_metadata_begin(session);
 
-       WARN_ON_ONCE(!chan->header_type);
+       WARN_ON_ONCE(!chan->priv->header_type);
        ret = lttng_metadata_printf(session,
                "stream {\n"
                "       id = %u;\n"
                "       event.header := %s;\n"
                "       packet.context := struct packet_context;\n",
-               chan->id,
-               chan->header_type == 1 ? "struct event_header_compact" :
+               chan->priv->id,
+               chan->priv->header_type == 1 ? "struct event_header_compact" :
                        "struct event_header_large");
        if (ret)
                goto end;
 
-       if (chan->ctx) {
+       if (chan->priv->ctx) {
                ret = lttng_metadata_printf(session,
                        "       event.context := struct {\n");
                if (ret)
                        goto end;
        }
-       ret = _lttng_context_metadata_statedump(session, chan->ctx);
+       ret = _lttng_context_metadata_statedump(session, chan->priv->ctx);
        if (ret)
                goto end;
-       if (chan->ctx) {
+       if (chan->priv->ctx) {
                ret = lttng_metadata_printf(session,
                        "       };\n");
                if (ret)
@@ -3708,7 +3807,7 @@ int _lttng_channel_metadata_statedump(struct lttng_session *session,
        ret = lttng_metadata_printf(session,
                "};\n\n");
 
-       chan->metadata_dumped = 1;
+       chan->priv->metadata_dumped = 1;
 end:
        lttng_metadata_end(session);
        return ret;
@@ -3718,7 +3817,7 @@ end:
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_stream_packet_context_declare(struct lttng_session *session)
+int _lttng_stream_packet_context_declare(struct lttng_kernel_session *session)
 {
        return lttng_metadata_printf(session,
                "struct packet_context {\n"
@@ -3745,7 +3844,7 @@ int _lttng_stream_packet_context_declare(struct lttng_session *session)
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_event_header_declare(struct lttng_session *session)
+int _lttng_event_header_declare(struct lttng_kernel_session *session)
 {
        return lttng_metadata_printf(session,
        "struct event_header_compact {\n"
@@ -3828,7 +3927,7 @@ int64_t measure_clock_offset(void)
 }
 
 static
-int print_escaped_ctf_string(struct lttng_session *session, const char *string)
+int print_escaped_ctf_string(struct lttng_kernel_session *session, const char *string)
 {
        int ret = 0;
        size_t i;
@@ -3847,7 +3946,7 @@ int print_escaped_ctf_string(struct lttng_session *session, const char *string)
                        if (ret)
                                goto error;
                        /* We still print the current char */
-                       /* Fallthrough */
+                       lttng_fallthrough;
                default:
                        ret = lttng_metadata_printf(session, "%c", cur);
                        break;
@@ -3863,7 +3962,7 @@ error:
 }
 
 static
-int print_metadata_escaped_field(struct lttng_session *session, const char *field,
+int print_metadata_escaped_field(struct lttng_kernel_session *session, const char *field,
                const char *field_value)
 {
        int ret;
@@ -3887,12 +3986,12 @@ error:
  * Must be called with sessions_mutex held.
  */
 static
-int _lttng_session_metadata_statedump(struct lttng_session *session)
+int _lttng_session_metadata_statedump(struct lttng_kernel_session *session)
 {
-       unsigned char *uuid_c = session->uuid.b;
+       unsigned char *uuid_c = session->priv->uuid.b;
        unsigned char uuid_s[37], clock_uuid_s[BOOT_ID_LEN];
        const char *product_uuid;
-       struct lttng_channel *chan;
+       struct lttng_kernel_channel_buffer_private *chan_priv;
        struct lttng_kernel_event_recorder_private *event_recorder_priv;
        int ret = 0;
 
@@ -3901,7 +4000,7 @@ int _lttng_session_metadata_statedump(struct lttng_session *session)
 
        lttng_metadata_begin(session);
 
-       if (session->metadata_dumped)
+       if (session->priv->metadata_dumped)
                goto skip_session;
 
        snprintf(uuid_s, sizeof(uuid_s),
@@ -3973,11 +4072,11 @@ int _lttng_session_metadata_statedump(struct lttng_session *session)
        if (ret)
                goto end;
 
-       ret = print_metadata_escaped_field(session, "trace_name", session->name);
+       ret = print_metadata_escaped_field(session, "trace_name", session->priv->name);
        if (ret)
                goto end;
        ret = print_metadata_escaped_field(session, "trace_creation_datetime",
-                       session->creation_time);
+                       session->priv->creation_time);
        if (ret)
                goto end;
 
@@ -4060,19 +4159,19 @@ int _lttng_session_metadata_statedump(struct lttng_session *session)
                goto end;
 
 skip_session:
-       list_for_each_entry(chan, &session->chan, list) {
-               ret = _lttng_channel_metadata_statedump(session, chan);
+       list_for_each_entry(chan_priv, &session->priv->chan, node) {
+               ret = _lttng_channel_metadata_statedump(session, chan_priv->pub);
                if (ret)
                        goto end;
        }
 
-       list_for_each_entry(event_recorder_priv, &session->events, node) {
+       list_for_each_entry(event_recorder_priv, &session->priv->events, node) {
                ret = _lttng_event_metadata_statedump(session, event_recorder_priv->pub->chan,
                                event_recorder_priv->pub);
                if (ret)
                        goto end;
        }
-       session->metadata_dumped = 1;
+       session->priv->metadata_dumped = 1;
 end:
        lttng_metadata_end(session);
        return ret;
@@ -4266,7 +4365,6 @@ static void lttng_exit_cpu_hotplug(void)
 }
 #endif /* #else #if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(4,10,0)) */
 
-
 static int __init lttng_events_init(void)
 {
        int ret;
@@ -4334,6 +4432,9 @@ static int __init lttng_events_init(void)
 #else
                "");
 #endif
+#ifdef CONFIG_LTTNG_EXPERIMENTAL_BITWISE_ENUM
+       printk(KERN_NOTICE "LTTng: Experimental bitwise enum enabled.\n");
+#endif /* CONFIG_LTTNG_EXPERIMENTAL_BITWISE_ENUM */
        return 0;
 
 error_hotplug:
@@ -4375,13 +4476,13 @@ module_init(lttng_events_init);
 
 static void __exit lttng_events_exit(void)
 {
-       struct lttng_session *session, *tmpsession;
+       struct lttng_kernel_session_private *session_priv, *tmpsession_priv;
 
        lttng_exit_cpu_hotplug();
        lttng_logger_exit();
        lttng_abi_exit();
-       list_for_each_entry_safe(session, tmpsession, &sessions, list)
-               lttng_session_destroy(session);
+       list_for_each_entry_safe(session_priv, tmpsession_priv, &sessions, list)
+               lttng_session_destroy(session_priv->pub);
        kmem_cache_destroy(event_recorder_cache);
        kmem_cache_destroy(event_recorder_private_cache);
        kmem_cache_destroy(event_notifier_cache);
This page took 0.063501 seconds and 4 git commands to generate.